@rootnode-app/cli 0.1.0 → 0.1.1

package/README.md

@@ -18,7 +18,9 @@ key; nothing else to configure.
 After every successful EAS build it finds that build's dSYMs, mapping, bundle
 and source map and uploads them under the release the SDK reports
 (`bundleId@version+build`). Uses `EXPO_PUBLIC_ROOTNODE_KEY` (or `ROOTNODE_KEY`).
-Never fails the build unless you pass `--strict`.
+Uploads go to the app's target for that build's platform (`ios` / `android`)
+and to its `react-native` target, whichever exist. Never fails the build
+unless you pass `--strict`.
 
 ## Any build
 

package/dist/bin.js

@@ -4,17 +4,25 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const child_process_1 = require("child_process");
 const discover_1 = require("./discover");
 const plan_1 = require("./plan");
-async function resolveTarget(o) {
-    const res = await fetch(`${o.host}/api/0/rootnode/targets/${encodeURIComponent(o.target)}`, {
+async function lookupTarget(o, name) {
+    const res = await fetch(`${o.host}/api/0/rootnode/targets/${encodeURIComponent(name)}`, {
         headers: { Authorization: `Bearer ${o.key}` },
     });
     const body = (await res.json().catch(() => ({})));
     if (res.status === 401)
         throw new Error('the key was rejected — use the app\'s analytics key (rn_…)');
+    if (res.status === 404)
+        return null;
     if (!res.ok || !body.organization || !body.project)
         throw new Error(body.detail ?? `target lookup failed (http ${res.status})`);
     return { organization: body.organization, project: body.project };
 }
+async function resolveTarget(o) {
+    const t = await lookupTarget(o, o.target);
+    if (!t)
+        throw new Error(`the app has no "${o.target}" target — pass --target with one of its targets (see Rootnode → Setup)`);
+    return t;
+}
 function uploaderPath() {
     // eslint-disable-next-line @typescript-eslint/no-require-imports
     return require('@sentry/cli').getPath();
@@ -58,13 +66,33 @@ async function main(argv) {
         for (const out of outs)
             for (const n of out.notes)
                 console.log(`rootnode: ${out.platform}: ${n}`);
-        const runs = outs.flatMap(runsFor);
-        if (!runs.length) {
+        if (!outs.some((out) => runsFor(out).length)) {
             console.log('rootnode: nothing to upload');
             return 0;
         }
         try {
-            const ok = execute(runs, (0, plan_1.uploaderEnv)(o, await resolveTarget(o)));
+            let ok = true;
+            for (const out of outs) {
+                const runs = runsFor(out);
+                if (!runs.length)
+                    continue;
+                const names = (0, plan_1.easTargetCandidates)(out.platform, o);
+                const found = [];
+                for (const name of names) {
+                    const t = await lookupTarget(o, name);
+                    if (t)
+                        found.push({ name, t });
+                }
+                if (!found.length) {
+                    console.error(`rootnode: ${out.platform}: the app has none of these targets: ${names.join(', ')} — add one in Rootnode → Setup or pass --target`);
+                    ok = false;
+                    continue;
+                }
+                for (const { name, t } of found) {
+                    console.log(`rootnode: ${out.platform} → target ${name}`);
+                    ok = execute(runs, (0, plan_1.uploaderEnv)(o, t)) && ok;
+                }
+            }
             return ok || !o.strict ? 0 : 1;
         }
         catch (e) {

package/dist/discover.js

@@ -51,13 +51,15 @@ function discoverIos(root, plist = exports.readPlist, home = (0, os_1.homedir)()
     out.map = first((0, path_1.join)(buildDir, 'main.jsbundle.map'));
     if (out.bundle && !out.map)
         out.notes.push('no ios/build/main.jsbundle.map — add the "@rootnode-app/react-native" plugin to app.json so the build writes it');
-    const info = plist((0, path_1.join)(arch, 'Info.plist'))?.ApplicationProperties;
-    if (info?.CFBundleIdentifier && info?.CFBundleShortVersionString && info?.CFBundleVersion) {
+    // The archive's own Info.plist usually carries ApplicationProperties; the app bundle's always does.
+    const complete = (i) => (i?.CFBundleIdentifier && i?.CFBundleShortVersionString && i?.CFBundleVersion ? i : null);
+    const info = complete(plist((0, path_1.join)(arch, 'Info.plist'))?.ApplicationProperties) ?? (appName ? complete(plist((0, path_1.join)(apps, appName, 'Info.plist'))) : null);
+    if (info) {
         out.release = (0, plan_1.releaseName)(info.CFBundleIdentifier, info.CFBundleShortVersionString, String(info.CFBundleVersion));
         out.dist = String(info.CFBundleVersion);
     }
     else
-        out.notes.push('could not read the version from the archive Info.plist');
+        out.notes.push('could not read the version from the archive or app Info.plist — dSYMs still upload, the JS source map is skipped');
     return out;
 }
 /** Android: R8 mapping, the release bundle + its (Hermes-composed) source map, version from build.gradle. */

package/dist/plan.d.ts

@@ -7,6 +7,8 @@ export interface Options {
     key: string | null;
     host: string;
     target: string;
+    /** --target or ROOTNODE_TARGET was given — no automatic target choice. */
+    targetExplicit: boolean;
     release: string | null;
     dist: string | null;
     bundle: string | null;
@@ -34,6 +36,12 @@ export declare function uploaderEnv(o: Options, t: UploadTarget): Record<string,
 export declare function symbolRuns(paths: string[]): Run[];
 /** A Hermes/JS bundle with its source map, tied to the release the SDK reports. */
 export declare function sourcemapRun(bundle: string, map: string, release: string, dist: string | null): Run;
+/**
+ * Which app targets one EAS build uploads to. A React Native app may report
+ * crashes through its per-platform targets (ios / android DSNs) or one
+ * react-native target — symbols go to every one of these that exists.
+ */
+export declare function easTargetCandidates(platform: 'ios' | 'android', o: Options): string[];
 /** The release name the React Native SDK reports: bundleId@version+build. */
 export declare const releaseName: (id: string, version: string, build: string) => string;
-export declare const HELP = "rootnode \u2014 upload symbols so release crashes show real code lines\n\n  rootnode eas\n      After an EAS build (package.json \"eas-build-on-success\": \"rootnode eas\"):\n      finds this build's dSYMs, ProGuard mapping and JS bundle + source map and\n      uploads them. Never fails the build unless --strict.\n\n  rootnode upload-symbols <path...>\n      dSYM folders, .xcarchive, unstripped .so folders, mapping.txt.\n\n  rootnode upload-sourcemaps --bundle <file> --map <file> --release <name> [--dist <build>]\n\nOptions\n  --key <rn_\u2026>      the app's analytics key (default: ROOTNODE_KEY or EXPO_PUBLIC_ROOTNODE_KEY)\n  --target <name>   which target of the app: react-native (default), ios, android\u2026\n  --host <url>      default https://rootnode.app\n  --strict          exit non-zero when an upload fails";
+export declare const HELP = "rootnode \u2014 upload symbols so release crashes show real code lines\n\n  rootnode eas\n      After an EAS build (package.json \"eas-build-on-success\": \"npx @rootnode-app/cli eas\"):\n      finds this build's dSYMs, ProGuard mapping and JS bundle + source map and\n      uploads them. Never fails the build unless --strict.\n\n  rootnode upload-symbols <path...>\n      dSYM folders, .xcarchive, unstripped .so folders, mapping.txt.\n\n  rootnode upload-sourcemaps --bundle <file> --map <file> --release <name> [--dist <build>]\n\nOptions\n  --key <rn_\u2026>      the app's analytics key (default: ROOTNODE_KEY or EXPO_PUBLIC_ROOTNODE_KEY)\n  --target <name>   which target of the app: react-native (default; eas picks ios/android + react-native), ios, android\u2026\n  --host <url>      default https://rootnode.app\n  --strict          exit non-zero when an upload fails";

package/dist/plan.js

@@ -10,6 +10,7 @@ exports.parseArgs = parseArgs;
 exports.uploaderEnv = uploaderEnv;
 exports.symbolRuns = symbolRuns;
 exports.sourcemapRun = sourcemapRun;
+exports.easTargetCandidates = easTargetCandidates;
 exports.DEFAULT_HOST = 'https://rootnode.app';
 function parseArgs(argv, env) {
     const [name = 'help', ...rest] = argv;
@@ -17,6 +18,7 @@ function parseArgs(argv, env) {
         key: env.ROOTNODE_KEY ?? env.EXPO_PUBLIC_ROOTNODE_KEY ?? null,
         host: (env.ROOTNODE_HOST ?? exports.DEFAULT_HOST).replace(/\/$/, ''),
         target: env.ROOTNODE_TARGET ?? 'react-native',
+        targetExplicit: !!env.ROOTNODE_TARGET,
         release: null,
         dist: null,
         bundle: null,
@@ -27,7 +29,10 @@ function parseArgs(argv, env) {
     const flags = {
         '--key': (v) => (o.key = v),
         '--host': (v) => (o.host = v.replace(/\/$/, '')),
-        '--target': (v) => (o.target = v),
+        '--target': (v) => {
+            o.target = v;
+            o.targetExplicit = true;
+        },
         '--release': (v) => (o.release = v),
         '--dist': (v) => (o.dist = v),
         '--bundle': (v) => (o.bundle = v),
@@ -82,13 +87,21 @@ function sourcemapRun(bundle, map, release, dist) {
         args: ['sourcemaps', 'upload', '--release', release, ...(dist ? ['--dist', dist] : []), '--bundle', bundle, '--bundle-sourcemap', map],
     };
 }
+/**
+ * Which app targets one EAS build uploads to. A React Native app may report
+ * crashes through its per-platform targets (ios / android DSNs) or one
+ * react-native target — symbols go to every one of these that exists.
+ */
+function easTargetCandidates(platform, o) {
+    return o.targetExplicit ? [o.target] : [platform, 'react-native'];
+}
 /** The release name the React Native SDK reports: bundleId@version+build. */
 const releaseName = (id, version, build) => `${id}@${version}+${build}`;
 exports.releaseName = releaseName;
 exports.HELP = `rootnode — upload symbols so release crashes show real code lines
 
   rootnode eas
-      After an EAS build (package.json "eas-build-on-success": "rootnode eas"):
+      After an EAS build (package.json "eas-build-on-success": "npx @rootnode-app/cli eas"):
       finds this build's dSYMs, ProGuard mapping and JS bundle + source map and
       uploads them. Never fails the build unless --strict.
 
@@ -99,6 +112,6 @@ exports.HELP = `rootnode — upload symbols so release crashes show real code li
 
 Options
   --key <rn_…>      the app's analytics key (default: ROOTNODE_KEY or EXPO_PUBLIC_ROOTNODE_KEY)
-  --target <name>   which target of the app: react-native (default), ios, android…
+  --target <name>   which target of the app: react-native (default; eas picks ios/android + react-native), ios, android…
   --host <url>      default ${exports.DEFAULT_HOST}
   --strict          exit non-zero when an upload fails`;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rootnode-app/cli",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Rootnode command line: upload dSYMs, ProGuard mappings, native debug files and source maps so release crashes show real code lines.",
   "license": "MIT",
   "author": "Doğan Aktı",