@ronkovic/aad 0.3.0

package/src/modules/task-queue/__tests__/dependency-resolver.test.ts

@@ -0,0 +1,456 @@
+import { describe, test, expect } from "bun:test";
+import { createTaskId, type Task } from "@aad/shared/types";
+import {
+  checkDependencies,
+  detectCircularDependencies,
+  getReadyTasks,
+  validateTaskPlan,
+} from "../dependency-resolver";
+import { CircularDependencyError } from "@aad/shared/errors";
+
+describe("dependency-resolver", () => {
+  describe("checkDependencies", () => {
+    test("returns ready for task with no dependencies", () => {
+      const task: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([[task.taskId, task]]);
+      const result = checkDependencies(task.taskId, tasks);
+
+      expect(result.status).toBe("ready");
+      expect(result.blockedBy).toHaveLength(0);
+    });
+
+    test("returns waiting for task with incomplete dependencies", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "running",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const result = checkDependencies(task2.taskId, tasks);
+
+      expect(result.status).toBe("waiting");
+      expect(result.blockedBy).toHaveLength(1);
+      expect(result.blockedBy[0] as string).toBe("task-1");
+    });
+
+    test("returns ready when all dependencies completed", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "completed",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const result = checkDependencies(task2.taskId, tasks);
+
+      expect(result.status).toBe("ready");
+      expect(result.blockedBy).toHaveLength(0);
+    });
+
+    test("returns blocked when dependency failed", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "failed",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const result = checkDependencies(task2.taskId, tasks);
+
+      expect(result.status).toBe("blocked");
+      expect(result.reason).toContain("failed");
+    });
+
+    test("returns blocked when task itself not found", () => {
+      const tasks = new Map<any, any>();
+      const result = checkDependencies(createTaskId("nonexistent"), tasks);
+      expect(result.status).toBe("blocked");
+      expect(result.reason).toContain("Task not found");
+    });
+
+    test("returns blocked when dependency not found", () => {
+      const task: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-999")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([[task.taskId, task]]);
+
+      const result = checkDependencies(task.taskId, tasks);
+
+      expect(result.status).toBe("blocked");
+      expect(result.reason).toContain("not found");
+    });
+  });
+
+  describe("detectCircularDependencies", () => {
+    test("returns null when no cycles", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const cycles = detectCircularDependencies(tasks);
+
+      expect(cycles).toBeNull();
+    });
+
+    test("detects simple cycle", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-2")],
+        priority: 1,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const cycles = detectCircularDependencies(tasks);
+
+      expect(cycles).not.toBeNull();
+      expect(cycles?.length).toBeGreaterThan(0);
+    });
+
+    test("handles task with dependency on non-existent task in DFS", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-ghost")],
+        priority: 1,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([[task1.taskId, task1]]);
+      const cycles = detectCircularDependencies(tasks);
+
+      // No cycle, just missing dep - should return null
+      expect(cycles).toBeNull();
+    });
+
+    test("detects complex cycle", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-2")],
+        priority: 1,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-3")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const task3: Task = {
+        taskId: createTaskId("task-3"),
+        title: "Task 3",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 3,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+        [task3.taskId, task3],
+      ]);
+
+      const cycles = detectCircularDependencies(tasks);
+
+      expect(cycles).not.toBeNull();
+      expect(cycles?.length).toBeGreaterThan(0);
+    });
+  });
+
+  describe("getReadyTasks", () => {
+    test("returns tasks with no dependencies", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const ready = getReadyTasks(tasks);
+
+      expect(ready).toHaveLength(2);
+      // Should be sorted by priority (higher first)
+      expect(ready[0]?.priority).toBe(2);
+      expect(ready[1]?.priority).toBe(1);
+    });
+
+    test("excludes tasks with incomplete dependencies", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "running",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [createTaskId("task-1")],
+        priority: 2,
+        status: "pending",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const ready = getReadyTasks(tasks);
+
+      expect(ready).toHaveLength(0);
+    });
+
+    test("excludes non-pending tasks", () => {
+      const task1: Task = {
+        taskId: createTaskId("task-1"),
+        title: "Task 1",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 1,
+        status: "completed",
+        retryCount: 0,
+      };
+
+      const task2: Task = {
+        taskId: createTaskId("task-2"),
+        title: "Task 2",
+        description: "Task",
+        filesToModify: [],
+        dependsOn: [],
+        priority: 2,
+        status: "running",
+        retryCount: 0,
+      };
+
+      const tasks = new Map([
+        [task1.taskId, task1],
+        [task2.taskId, task2],
+      ]);
+
+      const ready = getReadyTasks(tasks);
+
+      expect(ready).toHaveLength(0);
+    });
+  });
+
+  describe("validateTaskPlan", () => {
+    test("passes validation for valid task plan", () => {
+      const tasks: Task[] = [
+        {
+          taskId: createTaskId("task-1"),
+          title: "Task 1",
+          description: "Task",
+          filesToModify: [],
+          dependsOn: [],
+          priority: 1,
+          status: "pending",
+          retryCount: 0,
+        },
+        {
+          taskId: createTaskId("task-2"),
+          title: "Task 2",
+          description: "Task",
+          filesToModify: [],
+          dependsOn: [createTaskId("task-1")],
+          priority: 2,
+          status: "pending",
+          retryCount: 0,
+        },
+      ];
+
+      expect(() => validateTaskPlan(tasks)).not.toThrow();
+    });
+
+    test("throws CircularDependencyError on cycle", () => {
+      const tasks: Task[] = [
+        {
+          taskId: createTaskId("task-1"),
+          title: "Task 1",
+          description: "Task",
+          filesToModify: [],
+          dependsOn: [createTaskId("task-2")],
+          priority: 1,
+          status: "pending",
+          retryCount: 0,
+        },
+        {
+          taskId: createTaskId("task-2"),
+          title: "Task 2",
+          description: "Task",
+          filesToModify: [],
+          dependsOn: [createTaskId("task-1")],
+          priority: 2,
+          status: "pending",
+          retryCount: 0,
+        },
+      ];
+
+      expect(() => validateTaskPlan(tasks)).toThrow(CircularDependencyError);
+    });
+  });
+});