@rollup/plugin-node-resolve 13.2.0 → 13.3.0

package/CHANGELOG.md

@@ -1,5 +1,31 @@
 # @rollup/plugin-node-resolve ChangeLog
 
+## v13.3.0
+
+_2022-05-02_
+
+### Features
+
+- feat: support `node:` protocol (#1124)
+
+## v13.2.2
+
+_2022-05-02_
+
+### Bugfixes
+
+- fix: Respect if other plugins resolve the resolution to a different id (#1181)
+- fix: Revert respect if other plugins resolve the resolution to a different id (ae59ceb)
+- fix: Respect if other plugins resolve the resolution to a different id (f8d4c44)
+
+## v13.2.1
+
+_2022-04-15_
+
+### Bugfixes
+
+- fix: update side effects logic to be deep when glob doesn’t contain `/` (#1148)
+
 ## v13.2.0
 
 _2022-04-11_

package/dist/cjs/index.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, '__esModule', { value: true });
 
 var path = require('path');
-var builtinList = require('builtin-modules');
+var isBuiltinModule = require('is-builtin-module');
 var deepMerge = require('deepmerge');
 var isModule = require('is-module');
 var fs = require('fs');
@@ -15,13 +15,13 @@ var pluginutils = require('@rollup/pluginutils');
 function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'default' in e ? e : { 'default': e }; }
 
 var path__default = /*#__PURE__*/_interopDefaultLegacy(path);
-var builtinList__default = /*#__PURE__*/_interopDefaultLegacy(builtinList);
+var isBuiltinModule__default = /*#__PURE__*/_interopDefaultLegacy(isBuiltinModule);
 var deepMerge__default = /*#__PURE__*/_interopDefaultLegacy(deepMerge);
 var isModule__default = /*#__PURE__*/_interopDefaultLegacy(isModule);
 var fs__default = /*#__PURE__*/_interopDefaultLegacy(fs);
 var resolve__default = /*#__PURE__*/_interopDefaultLegacy(resolve);
 
-var version = "13.2.0";
+var version = "13.3.0";
 
 util.promisify(fs__default["default"].access);
 const readFile$1 = util.promisify(fs__default["default"].readFile);
@@ -282,7 +282,17 @@ function getPackageInfo(options) {
     if (typeof packageSideEffects === 'boolean') {
       internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
     } else if (Array.isArray(packageSideEffects)) {
-      internalPackageInfo.hasModuleSideEffects = pluginutils.createFilter(packageSideEffects, null, {
+      const finalPackageSideEffects = packageSideEffects.map((sideEffect) => {
+        /*
+         * The array accepts simple glob patterns to the relevant files... Patterns like .css, which do not include a /, will be treated like **\/.css.
+         * https://webpack.js.org/guides/tree-shaking/
+         */
+        if (sideEffect.includes('/')) {
+          return sideEffect;
+        }
+        return `**/${sideEffect}`;
+      });
+      internalPackageInfo.hasModuleSideEffects = pluginutils.createFilter(finalPackageSideEffects, null, {
         resolve: pkgRoot
       });
     }
@@ -912,7 +922,6 @@ async function resolveImportSpecifiers({
 
 /* eslint-disable no-param-reassign, no-shadow, no-undefined */
 
-const builtins = new Set(builtinList__default["default"]);
 const ES6_BROWSER_EMPTY = '\0node-resolve:empty.js';
 const deepFreeze = (object) => {
   Object.freeze(object);
@@ -1071,7 +1080,7 @@ function nodeResolve(opts = {}) {
       ignoreSideEffectsForRoot
     });
 
-    const importeeIsBuiltin = builtins.has(importee);
+    const importeeIsBuiltin = isBuiltinModule__default["default"](importee);
     const resolved =
       importeeIsBuiltin && preferBuiltins
         ? {
@@ -1141,14 +1150,14 @@ function nodeResolve(opts = {}) {
 
     version,
 
-    buildStart(options) {
-      rollupOptions = options;
+    buildStart(buildOptions) {
+      rollupOptions = buildOptions;
 
       for (const warning of warnings) {
         this.warn(warning);
       }
 
-      ({ preserveSymlinks } = options);
+      ({ preserveSymlinks } = buildOptions);
     },
 
     generateBundle() {
@@ -1180,6 +1189,11 @@ function nodeResolve(opts = {}) {
           if (resolvedResolved.external) {
             return false;
           }
+          // Allow other plugins to take over resolution. Rollup core will not
+          // change the id if it corresponds to an existing file
+          if (resolvedResolved.id !== resolved.id) {
+            return resolvedResolved;
+          }
           // Pass on meta information added by other plugins
           return { ...resolved, meta: resolvedResolved.meta };
         }

package/dist/es/index.js

@@ -1,5 +1,5 @@
 import path, { dirname, resolve, extname, normalize, sep } from 'path';
-import builtinList from 'builtin-modules';
+import isBuiltinModule from 'is-builtin-module';
 import deepMerge from 'deepmerge';
 import isModule from 'is-module';
 import fs, { realpathSync } from 'fs';
@@ -8,7 +8,7 @@ import { pathToFileURL, fileURLToPath } from 'url';
 import resolve$1 from 'resolve';
 import { createFilter } from '@rollup/pluginutils';
 
-var version = "13.2.0";
+var version = "13.3.0";
 
 promisify(fs.access);
 const readFile$1 = promisify(fs.readFile);
@@ -269,7 +269,17 @@ function getPackageInfo(options) {
     if (typeof packageSideEffects === 'boolean') {
       internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
     } else if (Array.isArray(packageSideEffects)) {
-      internalPackageInfo.hasModuleSideEffects = createFilter(packageSideEffects, null, {
+      const finalPackageSideEffects = packageSideEffects.map((sideEffect) => {
+        /*
+         * The array accepts simple glob patterns to the relevant files... Patterns like .css, which do not include a /, will be treated like **\/.css.
+         * https://webpack.js.org/guides/tree-shaking/
+         */
+        if (sideEffect.includes('/')) {
+          return sideEffect;
+        }
+        return `**/${sideEffect}`;
+      });
+      internalPackageInfo.hasModuleSideEffects = createFilter(finalPackageSideEffects, null, {
         resolve: pkgRoot
       });
     }
@@ -899,7 +909,6 @@ async function resolveImportSpecifiers({
 
 /* eslint-disable no-param-reassign, no-shadow, no-undefined */
 
-const builtins = new Set(builtinList);
 const ES6_BROWSER_EMPTY = '\0node-resolve:empty.js';
 const deepFreeze = (object) => {
   Object.freeze(object);
@@ -1058,7 +1067,7 @@ function nodeResolve(opts = {}) {
       ignoreSideEffectsForRoot
     });
 
-    const importeeIsBuiltin = builtins.has(importee);
+    const importeeIsBuiltin = isBuiltinModule(importee);
     const resolved =
       importeeIsBuiltin && preferBuiltins
         ? {
@@ -1128,14 +1137,14 @@ function nodeResolve(opts = {}) {
 
     version,
 
-    buildStart(options) {
-      rollupOptions = options;
+    buildStart(buildOptions) {
+      rollupOptions = buildOptions;
 
       for (const warning of warnings) {
         this.warn(warning);
       }
 
-      ({ preserveSymlinks } = options);
+      ({ preserveSymlinks } = buildOptions);
     },
 
     generateBundle() {
@@ -1167,6 +1176,11 @@ function nodeResolve(opts = {}) {
           if (resolvedResolved.external) {
             return false;
           }
+          // Allow other plugins to take over resolution. Rollup core will not
+          // change the id if it corresponds to an existing file
+          if (resolvedResolved.id !== resolved.id) {
+            return resolvedResolved;
+          }
           // Pass on meta information added by other plugins
           return { ...resolved, meta: resolvedResolved.meta };
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rollup/plugin-node-resolve",
-  "version": "13.2.0",
+  "version": "13.3.0",
   "publishConfig": {
     "access": "public"
   },
@@ -57,8 +57,8 @@
   "dependencies": {
     "@rollup/pluginutils": "^3.1.0",
     "@types/resolve": "1.17.1",
-    "builtin-modules": "^3.1.0",
     "deepmerge": "^4.2.2",
+    "is-builtin-module": "^3.1.0",
     "is-module": "^1.0.0",
     "resolve": "^1.19.0"
   },