@rollup/plugin-node-resolve 11.1.0 → 13.0.0

package/CHANGELOG.md

@@ -1,5 +1,62 @@
 # @rollup/plugin-node-resolve ChangeLog
 
+## v13.0.0
+
+_2021-05-04_
+
+### Breaking Changes
+
+- fix!: mark module as external if resolved module is external (#799)
+
+### Features
+
+- feat: Follow up to #843, refining exports and browser field interaction (#866)
+
+## v12.0.0
+
+_2021-05-04_
+
+### Breaking Changes
+
+- fix!: mark module as external if resolved module is external (#799)
+
+### Features
+
+- feat: Follow up to #843, refining exports and browser field interaction (#866)
+
+## v11.2.1
+
+_2021-03-26_
+
+### Bugfixes
+
+- fix: fs.exists is incorrectly promisified (#835)
+
+## v11.2.0
+
+_2021-02-14_
+
+### Features
+
+- feat: add `ignoreSideEffectsForRoot` option (#694)
+
+### Updates
+
+- chore: mark `url` as an external and throw on warning (#783)
+- docs: clearer "Resolving Built-Ins" doc (#782)
+
+## v11.1.1
+
+_2021-01-29_
+
+### Bugfixes
+
+- fix: only log last resolve error (#750)
+
+### Updates
+
+- docs: add clarification on the order of package entrypoints (#768)
+
 ## v11.1.0
 
 _2021-01-15_

package/README.md

@@ -44,7 +44,7 @@ Then call `rollup` either via the [CLI](https://www.rollupjs.org/guide/en/#comma
 
 ## Package entrypoints
 
-This plugin supports the package entrypoints feature from node js, specified in the `exports` or `imports` field of a package. Check the [official documentation](https://nodejs.org/api/packages.html#packages_package_entry_points) for more information on how this works.
+This plugin supports the package entrypoints feature from node js, specified in the `exports` or `imports` field of a package. Check the [official documentation](https://nodejs.org/api/packages.html#packages_package_entry_points) for more information on how this works. This is the default behavior. In the abscence of these fields, the fields in `mainFields` will be the ones to be used.
 
 ## Options
 
@@ -64,7 +64,7 @@ Setting this option will add extra conditions on top of the default conditions.
 Type: `Boolean`<br>
 Default: `false`
 
-If `true`, instructs the plugin to use the `"browser"` property in `package.json` files to specify alternative files to load for bundling. This is useful when bundling for a browser environment. Alternatively, a value of `'browser'` can be added to the `mainFields` option. If `false`, any `"browser"` properties in package files will be ignored. This option takes precedence over `mainFields`.
+If `true`, instructs the plugin to use the browser module resolutions in `package.json` and adds `'browser'` to `exportConditions` if it is not present so browser conditionals in `exports` are applied. If `false`, any browser properties in package files will be ignored. Alternatively, a value of `'browser'` can be added to both the `mainFields` and `exportConditions` options, however this option takes precedence over `mainFields`.
 
 > This option does not work when a package is using [package entrypoints](https://nodejs.org/api/packages.html#packages_package_entry_points)
 
@@ -157,6 +157,10 @@ Specifies the root directory from which to resolve modules. Typically used when
 rootDir: path.join(process.cwd(), '..')
 ```
 
+## `ignoreSideEffectsForRoot`
+
+If you use the `sideEffects` property in the package.json, by default this is respected for files in the root package. Set to `true` to ignore the `sideEffects` configuration for the root package.
+
 ## Preserving symlinks
 
 This plugin honours the rollup [`preserveSymlinks`](https://rollupjs.org/guide/en/#preservesymlinks) option.
@@ -187,14 +191,17 @@ By default this plugin will prefer built-ins over local modules, marking them as
 
 See [`preferBuiltins`](#preferbuiltins).
 
-To provide stubbed versions of Node built-ins, use a plugin like [rollup-plugin-node-polyfills](https://github.com/ionic-team/rollup-plugin-node-polyfills) or use [`builtin-modules`](https://github.com/sindresorhus/builtin-modules) with `external`, and set `preferBuiltins` to `false`. e.g.
+To provide stubbed versions of Node built-ins, use a plugin like [rollup-plugin-node-polyfills](https://github.com/ionic-team/rollup-plugin-node-polyfills) and set `preferBuiltins` to `false`. e.g.
 
 ```js
 import { nodeResolve } from '@rollup/plugin-node-resolve';
-import builtins from 'builtin-modules'
+import nodePolyfills from 'rollup-plugin-node-polyfills';
 export default ({
   input: ...,
-  plugins: [nodeResolve()],
+  plugins: [
+    nodePolyfills(),
+    nodeResolve({ preferBuiltins: false })
+  ],
   external: builtins,
   output: ...
 })

package/dist/cjs/index.js

@@ -21,10 +21,18 @@ var isModule__default = /*#__PURE__*/_interopDefaultLegacy(isModule);
 var fs__default = /*#__PURE__*/_interopDefaultLegacy(fs);
 var resolve__default = /*#__PURE__*/_interopDefaultLegacy(resolve);
 
-const exists = util.promisify(fs__default['default'].exists);
-const readFile = util.promisify(fs__default['default'].readFile);
+const access = util.promisify(fs__default['default'].access);
+const readFile$1 = util.promisify(fs__default['default'].readFile);
 const realpath = util.promisify(fs__default['default'].realpath);
 const stat = util.promisify(fs__default['default'].stat);
+async function exists(filePath) {
+  try {
+    await access(filePath);
+    return true;
+  } catch {
+    return false;
+  }
+}
 
 const onError = (error) => {
   if (error.code === 'ENOENT') {
@@ -78,7 +86,7 @@ const isFileCached = makeCache(async (file) => {
   }
 });
 
-const readCachedFile = makeCache(readFile);
+const readCachedFile = makeCache(readFile$1);
 
 // returns the imported package name for bare module imports
 function getPackageName(id) {
@@ -116,7 +124,16 @@ function getMainFields(options) {
 }
 
 function getPackageInfo(options) {
-  const { cache, extensions, pkg, mainFields, preserveSymlinks, useBrowserOverrides } = options;
+  const {
+    cache,
+    extensions,
+    pkg,
+    mainFields,
+    preserveSymlinks,
+    useBrowserOverrides,
+    rootDir,
+    ignoreSideEffectsForRoot
+  } = options;
   let { pkgPath } = options;
 
   if (cache.has(pkgPath)) {
@@ -206,13 +223,15 @@ function getPackageInfo(options) {
     packageInfo.browserMappedMain = false;
   }
 
-  const packageSideEffects = pkg.sideEffects;
-  if (typeof packageSideEffects === 'boolean') {
-    internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
-  } else if (Array.isArray(packageSideEffects)) {
-    internalPackageInfo.hasModuleSideEffects = pluginutils.createFilter(packageSideEffects, null, {
-      resolve: pkgRoot
-    });
+  if (!ignoreSideEffectsForRoot || rootDir !== pkgRoot) {
+    const packageSideEffects = pkg.sideEffects;
+    if (typeof packageSideEffects === 'boolean') {
+      internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
+    } else if (Array.isArray(packageSideEffects)) {
+      internalPackageInfo.hasModuleSideEffects = pluginutils.createFilter(packageSideEffects, null, {
+        resolve: pkgRoot
+      });
+    }
   }
 
   cache.set(pkgPath, internalPackageInfo);
@@ -328,11 +347,11 @@ async function resolvePackageTarget(context, { target, subpath, pattern, interna
             target.replace(/\*/g, subpath),
             context.pkgURL.href
           );
-          return result ? url.pathToFileURL(result.location) : null;
+          return result ? url.pathToFileURL(result.location).href : null;
         }
 
         const result = await context.resolveId(`${target}${subpath}`, context.pkgURL.href);
-        return result ? url.pathToFileURL(result.location) : null;
+        return result ? url.pathToFileURL(result.location).href : null;
       }
       throw new InvalidPackageTargetError(context, `Invalid mapping: "${target}".`);
     }
@@ -533,7 +552,7 @@ async function resolvePackageImports({
 }
 
 const resolveImportPath = util.promisify(resolve__default['default']);
-const readFile$1 = util.promisify(fs__default['default'].readFile);
+const readFile = util.promisify(fs__default['default'].readFile);
 
 async function getPackageJson(importer, pkgName, resolveOptions, moduleDirectories) {
   if (importer) {
@@ -546,7 +565,7 @@ async function getPackageJson(importer, pkgName, resolveOptions, moduleDirectori
 
   try {
     const pkgJsonPath = await resolveImportPath(`${pkgName}/package.json`, resolveOptions);
-    const pkgJson = JSON.parse(await readFile$1(pkgJsonPath, 'utf-8'));
+    const pkgJson = JSON.parse(await readFile(pkgJsonPath, 'utf-8'));
     return { pkgJsonPath, pkgJson };
   } catch (_) {
     return null;
@@ -564,7 +583,9 @@ async function resolveId({
   preserveSymlinks,
   useBrowserOverrides,
   baseDir,
-  moduleDirectories
+  moduleDirectories,
+  rootDir,
+  ignoreSideEffectsForRoot
 }) {
   let hasModuleSideEffects = () => null;
   let hasPackageEntry = true;
@@ -579,7 +600,9 @@ async function resolveId({
       pkgPath,
       mainFields,
       preserveSymlinks,
-      useBrowserOverrides
+      useBrowserOverrides,
+      rootDir,
+      ignoreSideEffectsForRoot
     });
 
     ({ packageInfo, hasModuleSideEffects, hasPackageEntry, packageBrowserField } = info);
@@ -653,11 +676,10 @@ async function resolveId({
         );
         location = url.fileURLToPath(resolvedPackageExport);
       } catch (error) {
-        if (!(error instanceof ResolveError)) {
-          throw error;
+        if (error instanceof ResolveError) {
+          return error;
         }
-        warn(error);
-        return null;
+        throw error;
       }
     }
   }
@@ -702,11 +724,15 @@ async function resolveImportSpecifiers({
   preserveSymlinks,
   useBrowserOverrides,
   baseDir,
-  moduleDirectories
+  moduleDirectories,
+  rootDir,
+  ignoreSideEffectsForRoot
 }) {
+  let lastResolveError;
+
   for (let i = 0; i < importSpecifierList.length; i++) {
     // eslint-disable-next-line no-await-in-loop
-    const resolved = await resolveId({
+    const result = await resolveId({
       importer,
       importSpecifier: importSpecifierList[i],
       exportConditions,
@@ -717,12 +743,22 @@ async function resolveImportSpecifiers({
       preserveSymlinks,
       useBrowserOverrides,
       baseDir,
-      moduleDirectories
+      moduleDirectories,
+      rootDir,
+      ignoreSideEffectsForRoot
     });
-    if (resolved) {
-      return resolved;
+
+    if (result instanceof ResolveError) {
+      lastResolveError = result;
+    } else if (result) {
+      return result;
     }
   }
+
+  if (lastResolveError) {
+    // only log the last failed resolve error
+    warn(lastResolveError);
+  }
   return null;
 }
 
@@ -798,7 +834,8 @@ const defaults = {
   // which deploy both ESM .mjs and CommonJS .js files as ESM.
   extensions: ['.mjs', '.js', '.json', '.node'],
   resolveOnly: [],
-  moduleDirectories: ['node_modules']
+  moduleDirectories: ['node_modules'],
+  ignoreSideEffectsForRoot: false
 };
 const DEFAULTS = deepFreeze(deepMerge__default['default']({}, defaults));
 
@@ -806,7 +843,7 @@ function nodeResolve(opts = {}) {
   const { warnings } = handleDeprecatedOptions(opts);
 
   const options = { ...defaults, ...opts };
-  const { extensions, jail, moduleDirectories } = options;
+  const { extensions, jail, moduleDirectories, ignoreSideEffectsForRoot } = options;
   const conditionsEsm = [...baseConditionsEsm, ...(options.exportConditions || [])];
   const conditionsCjs = [...baseConditionsCjs, ...(options.exportConditions || [])];
   const packageInfoCache = new Map();
@@ -815,7 +852,7 @@ function nodeResolve(opts = {}) {
   const useBrowserOverrides = mainFields.indexOf('browser') !== -1;
   const isPreferBuiltinsSet = options.preferBuiltins === true || options.preferBuiltins === false;
   const preferBuiltins = isPreferBuiltinsSet ? options.preferBuiltins : true;
-  const rootDir = options.rootDir || process.cwd();
+  const rootDir = path.resolve(options.rootDir || process.cwd());
   let { dedupe } = options;
   let rollupOptions;
 
@@ -835,201 +872,218 @@ function nodeResolve(opts = {}) {
   const browserMapCache = new Map();
   let preserveSymlinks;
 
-  return {
-    name: 'node-resolve',
+  const doResolveId = async (context, importee, importer, opts) => {
+    // strip query params from import
+    const [importPath, params] = importee.split('?');
+    const importSuffix = `${params ? `?${params}` : ''}`;
+    importee = importPath;
 
-    buildStart(options) {
-      rollupOptions = options;
+    const baseDir = !importer || dedupe(importee) ? rootDir : path.dirname(importer);
 
-      for (const warning of warnings) {
-        this.warn(warning);
+    // https://github.com/defunctzombie/package-browser-field-spec
+    const browser = browserMapCache.get(importer);
+    if (useBrowserOverrides && browser) {
+      const resolvedImportee = path.resolve(baseDir, importee);
+      if (browser[importee] === false || browser[resolvedImportee] === false) {
+        return { id: ES6_BROWSER_EMPTY };
       }
-
-      ({ preserveSymlinks } = options);
-    },
-
-    generateBundle() {
-      readCachedFile.clear();
-      isFileCached.clear();
-      isDirCached.clear();
-    },
-
-    async resolveId(importee, importer, opts) {
-      if (importee === ES6_BROWSER_EMPTY) {
-        return importee;
+      const browserImportee =
+        browser[importee] ||
+        browser[resolvedImportee] ||
+        browser[`${resolvedImportee}.js`] ||
+        browser[`${resolvedImportee}.json`];
+      if (browserImportee) {
+        importee = browserImportee;
       }
-      // ignore IDs with null character, these belong to other plugins
-      if (/\0/.test(importee)) return null;
+    }
 
-      if (/\0/.test(importer)) {
-        importer = undefined;
+    const parts = importee.split(/[/\\]/);
+    let id = parts.shift();
+    let isRelativeImport = false;
+
+    if (id[0] === '@' && parts.length > 0) {
+      // scoped packages
+      id += `/${parts.shift()}`;
+    } else if (id[0] === '.') {
+      // an import relative to the parent dir of the importer
+      id = path.resolve(baseDir, importee);
+      isRelativeImport = true;
+    }
+
+    if (
+      !isRelativeImport &&
+      resolveOnly.length &&
+      !resolveOnly.some((pattern) => pattern.test(id))
+    ) {
+      if (normalizeInput(rollupOptions.input).includes(importee)) {
+        return null;
       }
+      return false;
+    }
 
-      // strip query params from import
-      const [importPath, params] = importee.split('?');
-      const importSuffix = `${params ? `?${params}` : ''}`;
-      importee = importPath;
+    const importSpecifierList = [];
 
-      const baseDir = !importer || dedupe(importee) ? rootDir : path.dirname(importer);
+    if (importer === undefined && !importee[0].match(/^\.?\.?\//)) {
+      // For module graph roots (i.e. when importer is undefined), we
+      // need to handle 'path fragments` like `foo/bar` that are commonly
+      // found in rollup config files. If importee doesn't look like a
+      // relative or absolute path, we make it relative and attempt to
+      // resolve it. If we don't find anything, we try resolving it as we
+      // got it.
+      importSpecifierList.push(`./${importee}`);
+    }
 
-      // https://github.com/defunctzombie/package-browser-field-spec
-      const browser = browserMapCache.get(importer);
-      if (useBrowserOverrides && browser) {
-        const resolvedImportee = path.resolve(baseDir, importee);
-        if (browser[importee] === false || browser[resolvedImportee] === false) {
-          return ES6_BROWSER_EMPTY;
-        }
-        const browserImportee =
-          browser[importee] ||
-          browser[resolvedImportee] ||
-          browser[`${resolvedImportee}.js`] ||
-          browser[`${resolvedImportee}.json`];
-        if (browserImportee) {
-          importee = browserImportee;
-        }
-      }
+    const importeeIsBuiltin = builtins.has(importee);
 
-      const parts = importee.split(/[/\\]/);
-      let id = parts.shift();
-      let isRelativeImport = false;
-
-      if (id[0] === '@' && parts.length > 0) {
-        // scoped packages
-        id += `/${parts.shift()}`;
-      } else if (id[0] === '.') {
-        // an import relative to the parent dir of the importer
-        id = path.resolve(baseDir, importee);
-        isRelativeImport = true;
-      }
+    if (importeeIsBuiltin) {
+      // The `resolve` library will not resolve packages with the same
+      // name as a node built-in module. If we're resolving something
+      // that's a builtin, and we don't prefer to find built-ins, we
+      // first try to look up a local module with that name. If we don't
+      // find anything, we resolve the builtin which just returns back
+      // the built-in's name.
+      importSpecifierList.push(`${importee}/`);
+    }
 
-      if (
-        !isRelativeImport &&
-        resolveOnly.length &&
-        !resolveOnly.some((pattern) => pattern.test(id))
-      ) {
-        if (normalizeInput(rollupOptions.input).includes(importee)) {
-          return null;
+    // TypeScript files may import '.js' to refer to either '.ts' or '.tsx'
+    if (importer && importee.endsWith('.js')) {
+      for (const ext of ['.ts', '.tsx']) {
+        if (importer.endsWith(ext) && extensions.includes(ext)) {
+          importSpecifierList.push(importee.replace(/.js$/, ext));
         }
-        return false;
       }
+    }
 
-      const importSpecifierList = [];
+    importSpecifierList.push(importee);
 
-      if (importer === undefined && !importee[0].match(/^\.?\.?\//)) {
-        // For module graph roots (i.e. when importer is undefined), we
-        // need to handle 'path fragments` like `foo/bar` that are commonly
-        // found in rollup config files. If importee doesn't look like a
-        // relative or absolute path, we make it relative and attempt to
-        // resolve it. If we don't find anything, we try resolving it as we
-        // got it.
-        importSpecifierList.push(`./${importee}`);
-      }
+    const warn = (...args) => context.warn(...args);
+    const isRequire =
+      opts && opts.custom && opts.custom['node-resolve'] && opts.custom['node-resolve'].isRequire;
+    const exportConditions = isRequire ? conditionsCjs : conditionsEsm;
 
-      const importeeIsBuiltin = builtins.has(importee);
+    if (useBrowserOverrides && !exportConditions.includes('browser'))
+      exportConditions.push('browser');
 
-      if (importeeIsBuiltin) {
-        // The `resolve` library will not resolve packages with the same
-        // name as a node built-in module. If we're resolving something
-        // that's a builtin, and we don't prefer to find built-ins, we
-        // first try to look up a local module with that name. If we don't
-        // find anything, we resolve the builtin which just returns back
-        // the built-in's name.
-        importSpecifierList.push(`${importee}/`);
-      }
+    const resolvedWithoutBuiltins = await resolveImportSpecifiers({
+      importer,
+      importSpecifierList,
+      exportConditions,
+      warn,
+      packageInfoCache,
+      extensions,
+      mainFields,
+      preserveSymlinks,
+      useBrowserOverrides,
+      baseDir,
+      moduleDirectories,
+      rootDir,
+      ignoreSideEffectsForRoot
+    });
 
-      // TypeScript files may import '.js' to refer to either '.ts' or '.tsx'
-      if (importer && importee.endsWith('.js')) {
-        for (const ext of ['.ts', '.tsx']) {
-          if (importer.endsWith(ext) && extensions.includes(ext)) {
-            importSpecifierList.push(importee.replace(/.js$/, ext));
+    const resolved =
+      importeeIsBuiltin && preferBuiltins
+        ? {
+            packageInfo: undefined,
+            hasModuleSideEffects: () => null,
+            hasPackageEntry: true,
+            packageBrowserField: false
           }
+        : resolvedWithoutBuiltins;
+    if (!resolved) {
+      return null;
+    }
+
+    const { packageInfo, hasModuleSideEffects, hasPackageEntry, packageBrowserField } = resolved;
+    let { location } = resolved;
+    if (packageBrowserField) {
+      if (Object.prototype.hasOwnProperty.call(packageBrowserField, location)) {
+        if (!packageBrowserField[location]) {
+          browserMapCache.set(location, packageBrowserField);
+          return { id: ES6_BROWSER_EMPTY };
         }
+        location = packageBrowserField[location];
       }
+      browserMapCache.set(location, packageBrowserField);
+    }
 
-      importSpecifierList.push(importee);
-
-      const warn = (...args) => this.warn(...args);
-      const isRequire =
-        opts && opts.custom && opts.custom['node-resolve'] && opts.custom['node-resolve'].isRequire;
-      const exportConditions = isRequire ? conditionsCjs : conditionsEsm;
-
-      const resolvedWithoutBuiltins = await resolveImportSpecifiers({
-        importer,
-        importSpecifierList,
-        exportConditions,
-        warn,
-        packageInfoCache,
-        extensions,
-        mainFields,
-        preserveSymlinks,
-        useBrowserOverrides,
-        baseDir,
-        moduleDirectories
-      });
+    if (hasPackageEntry && !preserveSymlinks) {
+      const fileExists = await exists(location);
+      if (fileExists) {
+        location = await realpath(location);
+      }
+    }
 
-      const resolved =
-        importeeIsBuiltin && preferBuiltins
-          ? {
-              packageInfo: undefined,
-              hasModuleSideEffects: () => null,
-              hasPackageEntry: true,
-              packageBrowserField: false
-            }
-          : resolvedWithoutBuiltins;
-      if (!resolved) {
+    idToPackageInfo.set(location, packageInfo);
+
+    if (hasPackageEntry) {
+      if (importeeIsBuiltin && preferBuiltins) {
+        if (!isPreferBuiltinsSet && resolvedWithoutBuiltins && resolved !== importee) {
+          context.warn(
+            `preferring built-in module '${importee}' over local alternative at '${resolvedWithoutBuiltins.location}', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning`
+          );
+        }
+        return false;
+      } else if (jail && location.indexOf(path.normalize(jail.trim(path.sep))) !== 0) {
         return null;
       }
+    }
 
-      const { packageInfo, hasModuleSideEffects, hasPackageEntry, packageBrowserField } = resolved;
-      let { location } = resolved;
-      if (packageBrowserField) {
-        if (Object.prototype.hasOwnProperty.call(packageBrowserField, location)) {
-          if (!packageBrowserField[location]) {
-            browserMapCache.set(location, packageBrowserField);
-            return ES6_BROWSER_EMPTY;
-          }
-          location = packageBrowserField[location];
-        }
-        browserMapCache.set(location, packageBrowserField);
+    if (options.modulesOnly && (await exists(location))) {
+      const code = await readFile$1(location, 'utf-8');
+      if (isModule__default['default'](code)) {
+        return {
+          id: `${location}${importSuffix}`,
+          moduleSideEffects: hasModuleSideEffects(location)
+        };
       }
+      return null;
+    }
+    const result = {
+      id: `${location}${importSuffix}`,
+      moduleSideEffects: hasModuleSideEffects(location)
+    };
+    return result;
+  };
 
-      if (hasPackageEntry && !preserveSymlinks) {
-        const fileExists = await exists(location);
-        if (fileExists) {
-          location = await realpath(location);
-        }
+  return {
+    name: 'node-resolve',
+
+    buildStart(options) {
+      rollupOptions = options;
+
+      for (const warning of warnings) {
+        this.warn(warning);
       }
 
-      idToPackageInfo.set(location, packageInfo);
+      ({ preserveSymlinks } = options);
+    },
 
-      if (hasPackageEntry) {
-        if (importeeIsBuiltin && preferBuiltins) {
-          if (!isPreferBuiltinsSet && resolvedWithoutBuiltins && resolved !== importee) {
-            this.warn(
-              `preferring built-in module '${importee}' over local alternative at '${resolvedWithoutBuiltins.location}', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning`
-            );
-          }
-          return false;
-        } else if (jail && location.indexOf(path.normalize(jail.trim(path.sep))) !== 0) {
-          return null;
-        }
+    generateBundle() {
+      readCachedFile.clear();
+      isFileCached.clear();
+      isDirCached.clear();
+    },
+
+    async resolveId(importee, importer, opts) {
+      if (importee === ES6_BROWSER_EMPTY) {
+        return importee;
       }
+      // ignore IDs with null character, these belong to other plugins
+      if (/\0/.test(importee)) return null;
 
-      if (options.modulesOnly && (await exists(location))) {
-        const code = await readFile(location, 'utf-8');
-        if (isModule__default['default'](code)) {
-          return {
-            id: `${location}${importSuffix}`,
-            moduleSideEffects: hasModuleSideEffects(location)
-          };
+      if (/\0/.test(importer)) {
+        importer = undefined;
+      }
+
+      const resolved = await doResolveId(this, importee, importer, opts);
+      if (resolved) {
+        const resolvedResolved = await this.resolve(resolved.id, importer, { skipSelf: true });
+        const isExternal = !!(resolvedResolved && resolvedResolved.external);
+        if (isExternal) {
+          return false;
         }
-        return null;
       }
-      const result = {
-        id: `${location}${importSuffix}`,
-        moduleSideEffects: hasModuleSideEffects(location)
-      };
-      return result;
+      return resolved;
     },
 
     load(importee) {

package/dist/es/index.js

@@ -8,10 +8,18 @@ import { pathToFileURL, fileURLToPath } from 'url';
 import resolve$1 from 'resolve';
 import { createFilter } from '@rollup/pluginutils';
 
-const exists = promisify(fs.exists);
-const readFile = promisify(fs.readFile);
+const access = promisify(fs.access);
+const readFile$1 = promisify(fs.readFile);
 const realpath = promisify(fs.realpath);
 const stat = promisify(fs.stat);
+async function exists(filePath) {
+  try {
+    await access(filePath);
+    return true;
+  } catch {
+    return false;
+  }
+}
 
 const onError = (error) => {
   if (error.code === 'ENOENT') {
@@ -65,7 +73,7 @@ const isFileCached = makeCache(async (file) => {
   }
 });
 
-const readCachedFile = makeCache(readFile);
+const readCachedFile = makeCache(readFile$1);
 
 // returns the imported package name for bare module imports
 function getPackageName(id) {
@@ -103,7 +111,16 @@ function getMainFields(options) {
 }
 
 function getPackageInfo(options) {
-  const { cache, extensions, pkg, mainFields, preserveSymlinks, useBrowserOverrides } = options;
+  const {
+    cache,
+    extensions,
+    pkg,
+    mainFields,
+    preserveSymlinks,
+    useBrowserOverrides,
+    rootDir,
+    ignoreSideEffectsForRoot
+  } = options;
   let { pkgPath } = options;
 
   if (cache.has(pkgPath)) {
@@ -193,13 +210,15 @@ function getPackageInfo(options) {
     packageInfo.browserMappedMain = false;
   }
 
-  const packageSideEffects = pkg.sideEffects;
-  if (typeof packageSideEffects === 'boolean') {
-    internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
-  } else if (Array.isArray(packageSideEffects)) {
-    internalPackageInfo.hasModuleSideEffects = createFilter(packageSideEffects, null, {
-      resolve: pkgRoot
-    });
+  if (!ignoreSideEffectsForRoot || rootDir !== pkgRoot) {
+    const packageSideEffects = pkg.sideEffects;
+    if (typeof packageSideEffects === 'boolean') {
+      internalPackageInfo.hasModuleSideEffects = () => packageSideEffects;
+    } else if (Array.isArray(packageSideEffects)) {
+      internalPackageInfo.hasModuleSideEffects = createFilter(packageSideEffects, null, {
+        resolve: pkgRoot
+      });
+    }
   }
 
   cache.set(pkgPath, internalPackageInfo);
@@ -315,11 +334,11 @@ async function resolvePackageTarget(context, { target, subpath, pattern, interna
             target.replace(/\*/g, subpath),
             context.pkgURL.href
           );
-          return result ? pathToFileURL(result.location) : null;
+          return result ? pathToFileURL(result.location).href : null;
         }
 
         const result = await context.resolveId(`${target}${subpath}`, context.pkgURL.href);
-        return result ? pathToFileURL(result.location) : null;
+        return result ? pathToFileURL(result.location).href : null;
       }
       throw new InvalidPackageTargetError(context, `Invalid mapping: "${target}".`);
     }
@@ -520,7 +539,7 @@ async function resolvePackageImports({
 }
 
 const resolveImportPath = promisify(resolve$1);
-const readFile$1 = promisify(fs.readFile);
+const readFile = promisify(fs.readFile);
 
 async function getPackageJson(importer, pkgName, resolveOptions, moduleDirectories) {
   if (importer) {
@@ -533,7 +552,7 @@ async function getPackageJson(importer, pkgName, resolveOptions, moduleDirectori
 
   try {
     const pkgJsonPath = await resolveImportPath(`${pkgName}/package.json`, resolveOptions);
-    const pkgJson = JSON.parse(await readFile$1(pkgJsonPath, 'utf-8'));
+    const pkgJson = JSON.parse(await readFile(pkgJsonPath, 'utf-8'));
     return { pkgJsonPath, pkgJson };
   } catch (_) {
     return null;
@@ -551,7 +570,9 @@ async function resolveId({
   preserveSymlinks,
   useBrowserOverrides,
   baseDir,
-  moduleDirectories
+  moduleDirectories,
+  rootDir,
+  ignoreSideEffectsForRoot
 }) {
   let hasModuleSideEffects = () => null;
   let hasPackageEntry = true;
@@ -566,7 +587,9 @@ async function resolveId({
       pkgPath,
       mainFields,
       preserveSymlinks,
-      useBrowserOverrides
+      useBrowserOverrides,
+      rootDir,
+      ignoreSideEffectsForRoot
     });
 
     ({ packageInfo, hasModuleSideEffects, hasPackageEntry, packageBrowserField } = info);
@@ -640,11 +663,10 @@ async function resolveId({
         );
         location = fileURLToPath(resolvedPackageExport);
       } catch (error) {
-        if (!(error instanceof ResolveError)) {
-          throw error;
+        if (error instanceof ResolveError) {
+          return error;
         }
-        warn(error);
-        return null;
+        throw error;
       }
     }
   }
@@ -689,11 +711,15 @@ async function resolveImportSpecifiers({
   preserveSymlinks,
   useBrowserOverrides,
   baseDir,
-  moduleDirectories
+  moduleDirectories,
+  rootDir,
+  ignoreSideEffectsForRoot
 }) {
+  let lastResolveError;
+
   for (let i = 0; i < importSpecifierList.length; i++) {
     // eslint-disable-next-line no-await-in-loop
-    const resolved = await resolveId({
+    const result = await resolveId({
       importer,
       importSpecifier: importSpecifierList[i],
       exportConditions,
@@ -704,12 +730,22 @@ async function resolveImportSpecifiers({
       preserveSymlinks,
       useBrowserOverrides,
       baseDir,
-      moduleDirectories
+      moduleDirectories,
+      rootDir,
+      ignoreSideEffectsForRoot
     });
-    if (resolved) {
-      return resolved;
+
+    if (result instanceof ResolveError) {
+      lastResolveError = result;
+    } else if (result) {
+      return result;
     }
   }
+
+  if (lastResolveError) {
+    // only log the last failed resolve error
+    warn(lastResolveError);
+  }
   return null;
 }
 
@@ -785,7 +821,8 @@ const defaults = {
   // which deploy both ESM .mjs and CommonJS .js files as ESM.
   extensions: ['.mjs', '.js', '.json', '.node'],
   resolveOnly: [],
-  moduleDirectories: ['node_modules']
+  moduleDirectories: ['node_modules'],
+  ignoreSideEffectsForRoot: false
 };
 const DEFAULTS = deepFreeze(deepMerge({}, defaults));
 
@@ -793,7 +830,7 @@ function nodeResolve(opts = {}) {
   const { warnings } = handleDeprecatedOptions(opts);
 
   const options = { ...defaults, ...opts };
-  const { extensions, jail, moduleDirectories } = options;
+  const { extensions, jail, moduleDirectories, ignoreSideEffectsForRoot } = options;
   const conditionsEsm = [...baseConditionsEsm, ...(options.exportConditions || [])];
   const conditionsCjs = [...baseConditionsCjs, ...(options.exportConditions || [])];
   const packageInfoCache = new Map();
@@ -802,7 +839,7 @@ function nodeResolve(opts = {}) {
   const useBrowserOverrides = mainFields.indexOf('browser') !== -1;
   const isPreferBuiltinsSet = options.preferBuiltins === true || options.preferBuiltins === false;
   const preferBuiltins = isPreferBuiltinsSet ? options.preferBuiltins : true;
-  const rootDir = options.rootDir || process.cwd();
+  const rootDir = resolve(options.rootDir || process.cwd());
   let { dedupe } = options;
   let rollupOptions;
 
@@ -822,201 +859,218 @@ function nodeResolve(opts = {}) {
   const browserMapCache = new Map();
   let preserveSymlinks;
 
-  return {
-    name: 'node-resolve',
+  const doResolveId = async (context, importee, importer, opts) => {
+    // strip query params from import
+    const [importPath, params] = importee.split('?');
+    const importSuffix = `${params ? `?${params}` : ''}`;
+    importee = importPath;
 
-    buildStart(options) {
-      rollupOptions = options;
+    const baseDir = !importer || dedupe(importee) ? rootDir : dirname(importer);
 
-      for (const warning of warnings) {
-        this.warn(warning);
+    // https://github.com/defunctzombie/package-browser-field-spec
+    const browser = browserMapCache.get(importer);
+    if (useBrowserOverrides && browser) {
+      const resolvedImportee = resolve(baseDir, importee);
+      if (browser[importee] === false || browser[resolvedImportee] === false) {
+        return { id: ES6_BROWSER_EMPTY };
       }
-
-      ({ preserveSymlinks } = options);
-    },
-
-    generateBundle() {
-      readCachedFile.clear();
-      isFileCached.clear();
-      isDirCached.clear();
-    },
-
-    async resolveId(importee, importer, opts) {
-      if (importee === ES6_BROWSER_EMPTY) {
-        return importee;
+      const browserImportee =
+        browser[importee] ||
+        browser[resolvedImportee] ||
+        browser[`${resolvedImportee}.js`] ||
+        browser[`${resolvedImportee}.json`];
+      if (browserImportee) {
+        importee = browserImportee;
       }
-      // ignore IDs with null character, these belong to other plugins
-      if (/\0/.test(importee)) return null;
+    }
 
-      if (/\0/.test(importer)) {
-        importer = undefined;
+    const parts = importee.split(/[/\\]/);
+    let id = parts.shift();
+    let isRelativeImport = false;
+
+    if (id[0] === '@' && parts.length > 0) {
+      // scoped packages
+      id += `/${parts.shift()}`;
+    } else if (id[0] === '.') {
+      // an import relative to the parent dir of the importer
+      id = resolve(baseDir, importee);
+      isRelativeImport = true;
+    }
+
+    if (
+      !isRelativeImport &&
+      resolveOnly.length &&
+      !resolveOnly.some((pattern) => pattern.test(id))
+    ) {
+      if (normalizeInput(rollupOptions.input).includes(importee)) {
+        return null;
       }
+      return false;
+    }
 
-      // strip query params from import
-      const [importPath, params] = importee.split('?');
-      const importSuffix = `${params ? `?${params}` : ''}`;
-      importee = importPath;
+    const importSpecifierList = [];
 
-      const baseDir = !importer || dedupe(importee) ? rootDir : dirname(importer);
+    if (importer === undefined && !importee[0].match(/^\.?\.?\//)) {
+      // For module graph roots (i.e. when importer is undefined), we
+      // need to handle 'path fragments` like `foo/bar` that are commonly
+      // found in rollup config files. If importee doesn't look like a
+      // relative or absolute path, we make it relative and attempt to
+      // resolve it. If we don't find anything, we try resolving it as we
+      // got it.
+      importSpecifierList.push(`./${importee}`);
+    }
 
-      // https://github.com/defunctzombie/package-browser-field-spec
-      const browser = browserMapCache.get(importer);
-      if (useBrowserOverrides && browser) {
-        const resolvedImportee = resolve(baseDir, importee);
-        if (browser[importee] === false || browser[resolvedImportee] === false) {
-          return ES6_BROWSER_EMPTY;
-        }
-        const browserImportee =
-          browser[importee] ||
-          browser[resolvedImportee] ||
-          browser[`${resolvedImportee}.js`] ||
-          browser[`${resolvedImportee}.json`];
-        if (browserImportee) {
-          importee = browserImportee;
-        }
-      }
+    const importeeIsBuiltin = builtins.has(importee);
 
-      const parts = importee.split(/[/\\]/);
-      let id = parts.shift();
-      let isRelativeImport = false;
-
-      if (id[0] === '@' && parts.length > 0) {
-        // scoped packages
-        id += `/${parts.shift()}`;
-      } else if (id[0] === '.') {
-        // an import relative to the parent dir of the importer
-        id = resolve(baseDir, importee);
-        isRelativeImport = true;
-      }
+    if (importeeIsBuiltin) {
+      // The `resolve` library will not resolve packages with the same
+      // name as a node built-in module. If we're resolving something
+      // that's a builtin, and we don't prefer to find built-ins, we
+      // first try to look up a local module with that name. If we don't
+      // find anything, we resolve the builtin which just returns back
+      // the built-in's name.
+      importSpecifierList.push(`${importee}/`);
+    }
 
-      if (
-        !isRelativeImport &&
-        resolveOnly.length &&
-        !resolveOnly.some((pattern) => pattern.test(id))
-      ) {
-        if (normalizeInput(rollupOptions.input).includes(importee)) {
-          return null;
+    // TypeScript files may import '.js' to refer to either '.ts' or '.tsx'
+    if (importer && importee.endsWith('.js')) {
+      for (const ext of ['.ts', '.tsx']) {
+        if (importer.endsWith(ext) && extensions.includes(ext)) {
+          importSpecifierList.push(importee.replace(/.js$/, ext));
         }
-        return false;
       }
+    }
 
-      const importSpecifierList = [];
+    importSpecifierList.push(importee);
 
-      if (importer === undefined && !importee[0].match(/^\.?\.?\//)) {
-        // For module graph roots (i.e. when importer is undefined), we
-        // need to handle 'path fragments` like `foo/bar` that are commonly
-        // found in rollup config files. If importee doesn't look like a
-        // relative or absolute path, we make it relative and attempt to
-        // resolve it. If we don't find anything, we try resolving it as we
-        // got it.
-        importSpecifierList.push(`./${importee}`);
-      }
+    const warn = (...args) => context.warn(...args);
+    const isRequire =
+      opts && opts.custom && opts.custom['node-resolve'] && opts.custom['node-resolve'].isRequire;
+    const exportConditions = isRequire ? conditionsCjs : conditionsEsm;
 
-      const importeeIsBuiltin = builtins.has(importee);
+    if (useBrowserOverrides && !exportConditions.includes('browser'))
+      exportConditions.push('browser');
 
-      if (importeeIsBuiltin) {
-        // The `resolve` library will not resolve packages with the same
-        // name as a node built-in module. If we're resolving something
-        // that's a builtin, and we don't prefer to find built-ins, we
-        // first try to look up a local module with that name. If we don't
-        // find anything, we resolve the builtin which just returns back
-        // the built-in's name.
-        importSpecifierList.push(`${importee}/`);
-      }
+    const resolvedWithoutBuiltins = await resolveImportSpecifiers({
+      importer,
+      importSpecifierList,
+      exportConditions,
+      warn,
+      packageInfoCache,
+      extensions,
+      mainFields,
+      preserveSymlinks,
+      useBrowserOverrides,
+      baseDir,
+      moduleDirectories,
+      rootDir,
+      ignoreSideEffectsForRoot
+    });
 
-      // TypeScript files may import '.js' to refer to either '.ts' or '.tsx'
-      if (importer && importee.endsWith('.js')) {
-        for (const ext of ['.ts', '.tsx']) {
-          if (importer.endsWith(ext) && extensions.includes(ext)) {
-            importSpecifierList.push(importee.replace(/.js$/, ext));
+    const resolved =
+      importeeIsBuiltin && preferBuiltins
+        ? {
+            packageInfo: undefined,
+            hasModuleSideEffects: () => null,
+            hasPackageEntry: true,
+            packageBrowserField: false
           }
+        : resolvedWithoutBuiltins;
+    if (!resolved) {
+      return null;
+    }
+
+    const { packageInfo, hasModuleSideEffects, hasPackageEntry, packageBrowserField } = resolved;
+    let { location } = resolved;
+    if (packageBrowserField) {
+      if (Object.prototype.hasOwnProperty.call(packageBrowserField, location)) {
+        if (!packageBrowserField[location]) {
+          browserMapCache.set(location, packageBrowserField);
+          return { id: ES6_BROWSER_EMPTY };
         }
+        location = packageBrowserField[location];
       }
+      browserMapCache.set(location, packageBrowserField);
+    }
 
-      importSpecifierList.push(importee);
-
-      const warn = (...args) => this.warn(...args);
-      const isRequire =
-        opts && opts.custom && opts.custom['node-resolve'] && opts.custom['node-resolve'].isRequire;
-      const exportConditions = isRequire ? conditionsCjs : conditionsEsm;
-
-      const resolvedWithoutBuiltins = await resolveImportSpecifiers({
-        importer,
-        importSpecifierList,
-        exportConditions,
-        warn,
-        packageInfoCache,
-        extensions,
-        mainFields,
-        preserveSymlinks,
-        useBrowserOverrides,
-        baseDir,
-        moduleDirectories
-      });
+    if (hasPackageEntry && !preserveSymlinks) {
+      const fileExists = await exists(location);
+      if (fileExists) {
+        location = await realpath(location);
+      }
+    }
 
-      const resolved =
-        importeeIsBuiltin && preferBuiltins
-          ? {
-              packageInfo: undefined,
-              hasModuleSideEffects: () => null,
-              hasPackageEntry: true,
-              packageBrowserField: false
-            }
-          : resolvedWithoutBuiltins;
-      if (!resolved) {
+    idToPackageInfo.set(location, packageInfo);
+
+    if (hasPackageEntry) {
+      if (importeeIsBuiltin && preferBuiltins) {
+        if (!isPreferBuiltinsSet && resolvedWithoutBuiltins && resolved !== importee) {
+          context.warn(
+            `preferring built-in module '${importee}' over local alternative at '${resolvedWithoutBuiltins.location}', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning`
+          );
+        }
+        return false;
+      } else if (jail && location.indexOf(normalize(jail.trim(sep))) !== 0) {
         return null;
       }
+    }
 
-      const { packageInfo, hasModuleSideEffects, hasPackageEntry, packageBrowserField } = resolved;
-      let { location } = resolved;
-      if (packageBrowserField) {
-        if (Object.prototype.hasOwnProperty.call(packageBrowserField, location)) {
-          if (!packageBrowserField[location]) {
-            browserMapCache.set(location, packageBrowserField);
-            return ES6_BROWSER_EMPTY;
-          }
-          location = packageBrowserField[location];
-        }
-        browserMapCache.set(location, packageBrowserField);
+    if (options.modulesOnly && (await exists(location))) {
+      const code = await readFile$1(location, 'utf-8');
+      if (isModule(code)) {
+        return {
+          id: `${location}${importSuffix}`,
+          moduleSideEffects: hasModuleSideEffects(location)
+        };
       }
+      return null;
+    }
+    const result = {
+      id: `${location}${importSuffix}`,
+      moduleSideEffects: hasModuleSideEffects(location)
+    };
+    return result;
+  };
 
-      if (hasPackageEntry && !preserveSymlinks) {
-        const fileExists = await exists(location);
-        if (fileExists) {
-          location = await realpath(location);
-        }
+  return {
+    name: 'node-resolve',
+
+    buildStart(options) {
+      rollupOptions = options;
+
+      for (const warning of warnings) {
+        this.warn(warning);
       }
 
-      idToPackageInfo.set(location, packageInfo);
+      ({ preserveSymlinks } = options);
+    },
 
-      if (hasPackageEntry) {
-        if (importeeIsBuiltin && preferBuiltins) {
-          if (!isPreferBuiltinsSet && resolvedWithoutBuiltins && resolved !== importee) {
-            this.warn(
-              `preferring built-in module '${importee}' over local alternative at '${resolvedWithoutBuiltins.location}', pass 'preferBuiltins: false' to disable this behavior or 'preferBuiltins: true' to disable this warning`
-            );
-          }
-          return false;
-        } else if (jail && location.indexOf(normalize(jail.trim(sep))) !== 0) {
-          return null;
-        }
+    generateBundle() {
+      readCachedFile.clear();
+      isFileCached.clear();
+      isDirCached.clear();
+    },
+
+    async resolveId(importee, importer, opts) {
+      if (importee === ES6_BROWSER_EMPTY) {
+        return importee;
       }
+      // ignore IDs with null character, these belong to other plugins
+      if (/\0/.test(importee)) return null;
 
-      if (options.modulesOnly && (await exists(location))) {
-        const code = await readFile(location, 'utf-8');
-        if (isModule(code)) {
-          return {
-            id: `${location}${importSuffix}`,
-            moduleSideEffects: hasModuleSideEffects(location)
-          };
+      if (/\0/.test(importer)) {
+        importer = undefined;
+      }
+
+      const resolved = await doResolveId(this, importee, importer, opts);
+      if (resolved) {
+        const resolvedResolved = await this.resolve(resolved.id, importer, { skipSelf: true });
+        const isExternal = !!(resolvedResolved && resolvedResolved.external);
+        if (isExternal) {
+          return false;
         }
-        return null;
       }
-      const result = {
-        id: `${location}${importSuffix}`,
-        moduleSideEffects: hasModuleSideEffects(location)
-      };
-      return result;
+      return resolved;
     },
 
     load(importee) {

package/package.json

@@ -1,12 +1,15 @@
 {
   "name": "@rollup/plugin-node-resolve",
-  "version": "11.1.0",
+  "version": "13.0.0",
   "publishConfig": {
     "access": "public"
   },
   "description": "Locate and bundle third-party dependencies in node_modules",
   "license": "MIT",
-  "repository": "rollup/plugins",
+  "repository": {
+    "url": "rollup/plugins",
+    "directory": "packages/node-resolve"
+  },
   "author": "Rich Harris <richard.a.harris@gmail.com>",
   "homepage": "https://github.com/rollup/plugins/tree/master/packages/node-resolve/#readme",
   "bugs": "https://github.com/rollup/plugins/issues",
@@ -26,13 +29,9 @@
     "ci:lint": "pnpm run build && pnpm run lint",
     "ci:lint:commits": "commitlint --from=${CIRCLE_BRANCH} --to=${CIRCLE_SHA1}",
     "ci:test": "pnpm run test -- --verbose && pnpm run test:ts",
-    "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
-    "lint:docs": "prettier --single-quote --arrow-parens avoid --trailing-comma none --write README.md",
-    "lint:js": "eslint --fix --cache src test types --ext .js,.ts",
-    "lint:package": "prettier --write package.json --plugin=prettier-plugin-package",
     "prebuild": "del-cli dist",
     "prepare": "pnpm run build",
-    "prepublishOnly": "pnpm run lint && pnpm run test && pnpm run test:ts",
+    "prepublishOnly": "pnpm -w run lint && pnpm run test && pnpm run test:ts",
     "pretest": "pnpm run build",
     "test": "ava",
     "test:ts": "tsc types/index.d.ts test/types.ts --noEmit"
@@ -51,7 +50,7 @@
     "modules"
   ],
   "peerDependencies": {
-    "rollup": "^1.20.0||^2.0.0"
+    "rollup": "^2.42.0"
   },
   "dependencies": {
     "@rollup/pluginutils": "^3.1.0",
@@ -68,7 +67,7 @@
     "@rollup/plugin-commonjs": "^16.0.0",
     "@rollup/plugin-json": "^4.1.0",
     "es5-ext": "^0.10.53",
-    "rollup": "^2.23.0",
+    "rollup": "^2.42.0",
     "source-map": "^0.7.3",
     "string-capitalize": "^1.0.1"
   },