@rollup/plugin-commonjs 28.0.7 → 28.0.8

package/dist/cjs/index.js

@@ -11,7 +11,7 @@ var estreeWalker = require('estree-walker');
 var MagicString = require('magic-string');
 var isReference = require('is-reference');
 
-var version = "28.0.7";
+var version = "28.0.8";
 var peerDependencies = {
 	rollup: "^2.68.0||^3.0.0||^4.0.0"
 };
@@ -840,22 +840,35 @@ function getRequireResolver(extensions, detectCyclesAndConditional, currentlyRes
             getTypeForFullyAnalyzedModule(dependencyId));
           // Special-case external Node built-ins to be handled via a lazy __require
           // helper instead of hoisted ESM imports when strict wrapping is used.
+          const isExternalWrapped = isWrappedId(dependencyId, EXTERNAL_SUFFIX);
           if (
             parentMeta.initialCommonJSType === IS_WRAPPED_COMMONJS &&
             !allowProxy &&
-            isWrappedId(dependencyId, EXTERNAL_SUFFIX)
+            isExternalWrapped
           ) {
-            const actualId = unwrapId(dependencyId, EXTERNAL_SUFFIX);
-            const isNodeBuiltin = actualId.startsWith('node:');
-            if (isNodeBuiltin) {
+            const actualExternalId = unwrapId(dependencyId, EXTERNAL_SUFFIX);
+            if (actualExternalId.startsWith('node:')) {
               isCommonJS = IS_WRAPPED_COMMONJS;
+              parentMeta.isRequiredCommonJS[dependencyId] = isCommonJS;
             }
           }
           const isWrappedCommonJS = isCommonJS === IS_WRAPPED_COMMONJS;
           fullyAnalyzedModules[dependencyId] = true;
+          const moduleInfo =
+            isWrappedCommonJS && !isExternalWrapped
+              ? rollupContext.getModuleInfo(dependencyId)
+              : null;
+          // For wrapped dependencies, annotate the generated require call as pure only
+          // when Rollup has module info and it explicitly reports no side effects.
+          // Note: For external Node built-ins (handled via EXTERNAL_SUFFIX), the module
+          // has not been loaded yet at this point and getModuleInfo returns null.
+          // Default to side effects = true in that case to be safe.
+          // Preserve Rollup's tri-state semantics (true | false | 'no-treeshake') when available.
+          const wrappedModuleSideEffects = !isWrappedCommonJS
+            ? false
+            : moduleInfo?.moduleSideEffects ?? true;
           return {
-            wrappedModuleSideEffects:
-              isWrappedCommonJS && rollupContext.getModuleInfo(dependencyId).moduleSideEffects,
+            wrappedModuleSideEffects,
             source: sources[index].source,
             id: allowProxy
               ? wrapId(dependencyId, isWrappedCommonJS ? WRAPPED_SUFFIX : PROXY_SUFFIX)

package/dist/es/index.js

@@ -7,7 +7,7 @@ import { walk } from 'estree-walker';
 import MagicString from 'magic-string';
 import isReference from 'is-reference';
 
-var version = "28.0.7";
+var version = "28.0.8";
 var peerDependencies = {
 	rollup: "^2.68.0||^3.0.0||^4.0.0"
 };
@@ -836,22 +836,35 @@ function getRequireResolver(extensions, detectCyclesAndConditional, currentlyRes
             getTypeForFullyAnalyzedModule(dependencyId));
           // Special-case external Node built-ins to be handled via a lazy __require
           // helper instead of hoisted ESM imports when strict wrapping is used.
+          const isExternalWrapped = isWrappedId(dependencyId, EXTERNAL_SUFFIX);
           if (
             parentMeta.initialCommonJSType === IS_WRAPPED_COMMONJS &&
             !allowProxy &&
-            isWrappedId(dependencyId, EXTERNAL_SUFFIX)
+            isExternalWrapped
           ) {
-            const actualId = unwrapId(dependencyId, EXTERNAL_SUFFIX);
-            const isNodeBuiltin = actualId.startsWith('node:');
-            if (isNodeBuiltin) {
+            const actualExternalId = unwrapId(dependencyId, EXTERNAL_SUFFIX);
+            if (actualExternalId.startsWith('node:')) {
               isCommonJS = IS_WRAPPED_COMMONJS;
+              parentMeta.isRequiredCommonJS[dependencyId] = isCommonJS;
             }
           }
           const isWrappedCommonJS = isCommonJS === IS_WRAPPED_COMMONJS;
           fullyAnalyzedModules[dependencyId] = true;
+          const moduleInfo =
+            isWrappedCommonJS && !isExternalWrapped
+              ? rollupContext.getModuleInfo(dependencyId)
+              : null;
+          // For wrapped dependencies, annotate the generated require call as pure only
+          // when Rollup has module info and it explicitly reports no side effects.
+          // Note: For external Node built-ins (handled via EXTERNAL_SUFFIX), the module
+          // has not been loaded yet at this point and getModuleInfo returns null.
+          // Default to side effects = true in that case to be safe.
+          // Preserve Rollup's tri-state semantics (true | false | 'no-treeshake') when available.
+          const wrappedModuleSideEffects = !isWrappedCommonJS
+            ? false
+            : moduleInfo?.moduleSideEffects ?? true;
           return {
-            wrappedModuleSideEffects:
-              isWrappedCommonJS && rollupContext.getModuleInfo(dependencyId).moduleSideEffects,
+            wrappedModuleSideEffects,
             source: sources[index].source,
             id: allowProxy
               ? wrapId(dependencyId, isWrappedCommonJS ? WRAPPED_SUFFIX : PROXY_SUFFIX)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rollup/plugin-commonjs",
-  "version": "28.0.7",
+  "version": "28.0.8",
   "publishConfig": {
     "access": "public"
   },