@roj-ai/sdk 0.1.35 → 0.2.1

package/src/plugins/shell/shell.test.ts

@@ -1,314 +0,0 @@
-import { describe, expect, it } from 'bun:test'
-import type { SessionEnvironment } from '~/core/sessions/session-environment.js'
-import { createNodePlatform } from '~/testing/node-platform.js'
-import { buildBwrapArgs, type ShellConfig, ShellExecutor } from './executor.js'
-
-const testPlatform = createNodePlatform()
-const testExecutorDeps = { fs: testPlatform.fs, process: testPlatform.process }
-
-// ============================================================================
-// Test Helpers
-// ============================================================================
-
-const defaultConfig: ShellConfig = {
-	cwd: process.cwd(),
-	timeout: 5000,
-	sandboxed: false,
-	sandbox: { enabled: false },
-}
-
-const createTestEnvironment = (): SessionEnvironment => ({
-	sessionDir: '/tmp/test-session',
-	sandboxed: false,
-})
-
-// ============================================================================
-// buildBwrapArgs Tests
-// ============================================================================
-
-describe('buildBwrapArgs', () => {
-	it('builds basic args with session dir mapping', () => {
-		const args = buildBwrapArgs({
-			command: 'echo hello',
-			cwd: '/home/user/session',
-			sandbox: { enabled: true },
-			sessionDir: '/real/session/path',
-		})
-
-		expect(args).toContain('--ro-bind')
-		expect(args).toContain('--dev')
-		expect(args).toContain('--proc')
-		expect(args).toContain('--tmpfs')
-		expect(args).toContain('--unshare-all')
-		expect(args).toContain('--die-with-parent')
-		// Session dir should be mapped
-		const bindIdx = args.indexOf('--bind')
-		expect(args[bindIdx + 1]).toBe('/real/session/path')
-		expect(args[bindIdx + 2]).toBe('/home/user/session')
-		// No --share-net by default
-		expect(args).not.toContain('--share-net')
-		// --chdir sets working directory inside namespace
-		const chdirIdx = args.indexOf('--chdir')
-		expect(chdirIdx).toBeGreaterThan(0)
-		expect(args[chdirIdx + 1]).toBe('/home/user/session')
-		// Command at the end
-		expect(args.slice(-3)).toEqual(['/bin/sh', '-c', 'echo hello'])
-	})
-
-	it('includes --share-net when network enabled', () => {
-		const args = buildBwrapArgs({
-			command: 'curl example.com',
-			cwd: '/home/user/session',
-			sandbox: { enabled: true, network: true },
-			sessionDir: '/tmp/session',
-		})
-
-		expect(args).toContain('--share-net')
-	})
-
-	it('maps both session and workspace dirs', () => {
-		const args = buildBwrapArgs({
-			command: 'ls',
-			cwd: '/home/user/session',
-			sandbox: { enabled: true },
-			sessionDir: '/real/session',
-			workspaceDir: '/real/workspace',
-		})
-
-		const bindIndices: number[] = []
-		args.forEach((a, i) => {
-			if (a === '--bind') bindIndices.push(i)
-		})
-		expect(bindIndices.length).toBe(2) // session + workspace
-
-		// Verify session mapping
-		expect(args[bindIndices[0] + 1]).toBe('/real/session')
-		expect(args[bindIndices[0] + 2]).toBe('/home/user/session')
-
-		// Verify workspace mapping
-		expect(args[bindIndices[1] + 1]).toBe('/real/workspace')
-		expect(args[bindIndices[1] + 2]).toBe('/home/user/workspace')
-	})
-
-	it('adds extra bind mounts with correct mode', () => {
-		const args = buildBwrapArgs({
-			command: 'git status',
-			cwd: '/home/user/session',
-			sandbox: { enabled: true },
-			sessionDir: '/real/session',
-			extraBinds: [
-				{ path: '/home/user/project', mode: 'rw' },
-				{ path: '/opt/shared', mode: 'ro' },
-			],
-		})
-
-		// rw bind: --bind path path
-		const rwIdx = args.indexOf('/home/user/project')
-		expect(rwIdx).toBeGreaterThan(0)
-		expect(args[rwIdx - 1]).toBe('--bind')
-		expect(args[rwIdx + 1]).toBe('/home/user/project')
-
-		// ro bind: --ro-bind path path
-		const roIdx = args.indexOf('/opt/shared')
-		expect(roIdx).toBeGreaterThan(0)
-		expect(args[roIdx - 1]).toBe('--ro-bind')
-		expect(args[roIdx + 1]).toBe('/opt/shared')
-	})
-
-	it('sets --chdir to workspace cwd', () => {
-		const args = buildBwrapArgs({
-			command: 'git status',
-			cwd: '/home/user/workspace',
-			sandbox: { enabled: true },
-			sessionDir: '/real/session',
-			workspaceDir: '/real/workspace',
-		})
-
-		const chdirIdx = args.indexOf('--chdir')
-		expect(chdirIdx).toBeGreaterThan(0)
-		expect(args[chdirIdx + 1]).toBe('/home/user/workspace')
-	})
-
-	it('falls back to cwd writable when no session/workspace dirs', () => {
-		const args = buildBwrapArgs({
-			command: 'ls',
-			cwd: '/home/user',
-			sandbox: { enabled: true },
-		})
-
-		const bindIndices: number[] = []
-		args.forEach((a, i) => {
-			if (a === '--bind') bindIndices.push(i)
-		})
-		expect(bindIndices.length).toBe(1)
-		expect(args[bindIndices[0] + 1]).toBe('/home/user')
-		expect(args[bindIndices[0] + 2]).toBe('/home/user')
-	})
-})
-
-// ============================================================================
-// ShellExecutor Tests
-// ============================================================================
-
-describe('ShellExecutor', () => {
-	it('executes simple echo command', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute(
-			{ command: "echo 'Hello, World!'" },
-			environment,
-		)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.stdout).toBe('Hello, World!')
-		expect(result.value.stderr).toBe('')
-		expect(result.value.exitCode).toBe(0)
-		expect(result.value.timedOut).toBe(false)
-		expect(result.value.durationMs).toBeGreaterThan(0)
-	})
-
-	it('returns stderr for errors', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute(
-			{ command: 'ls /nonexistent_directory_12345' },
-			environment,
-		)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.exitCode).not.toBe(0)
-		expect(result.value.stderr).toContain('No such file or directory')
-	})
-
-	it('handles command with args array', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute(
-			{ command: 'echo', args: ['arg1', 'arg2', 'arg3'] },
-			environment,
-		)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.stdout).toBe('arg1 arg2 arg3')
-		expect(result.value.exitCode).toBe(0)
-	})
-
-	it('supports stdin input', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute(
-			{ command: 'cat', stdin: 'Hello from stdin' },
-			environment,
-		)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.stdout).toBe('Hello from stdin')
-		expect(result.value.exitCode).toBe(0)
-	})
-
-	it(
-		'times out long-running commands',
-		async () => {
-			const executor = new ShellExecutor({ ...defaultConfig, timeout: 200 }, testExecutorDeps)
-			const environment = createTestEnvironment()
-
-			const result = await executor.execute({ command: 'sleep 10' }, environment)
-
-			expect(result.ok).toBe(true)
-			if (!result.ok) return
-
-			expect(result.value.timedOut).toBe(true)
-			expect(result.value.signal).toBeDefined()
-		},
-		{ timeout: 10000 },
-	)
-
-	it(
-		'allows overriding timeout per-command',
-		async () => {
-			const executor = new ShellExecutor({ ...defaultConfig, timeout: 10000 }, testExecutorDeps)
-			const environment = createTestEnvironment()
-
-			const result = await executor.execute(
-				{ command: 'sleep 10', timeout: 200 },
-				environment,
-			)
-
-			expect(result.ok).toBe(true)
-			if (!result.ok) return
-
-			expect(result.value.timedOut).toBe(true)
-		},
-		{ timeout: 10000 },
-	)
-
-	it('collects large stdout without truncation', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		// Generate large output - shell tool no longer truncates, eviction happens at agent level
-		const result = await executor.execute(
-			{ command: "yes 'test' | head -n 1000" },
-			environment,
-		)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.stdout.split('\n').length).toBe(1000)
-	})
-
-	it('uses custom working directory', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute({ command: 'pwd', cwd: '/tmp' }, environment)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.stdout).toMatch(/^(\/private)?\/tmp$/)
-	})
-
-	it('passes environment variables', async () => {
-		const executor = new ShellExecutor({
-			...defaultConfig,
-			env: { TEST_VAR: 'test_value' },
-		}, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute(
-			{ command: 'echo $TEST_VAR' },
-			environment,
-		)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.stdout).toBe('test_value')
-	})
-
-	it('returns non-zero exit code for failing commands', async () => {
-		const executor = new ShellExecutor(defaultConfig, testExecutorDeps)
-		const environment = createTestEnvironment()
-
-		const result = await executor.execute({ command: 'exit 42' }, environment)
-
-		expect(result.ok).toBe(true)
-		if (!result.ok) return
-
-		expect(result.value.exitCode).toBe(42)
-	})
-})

package/src/plugins/skills/discovery.test.ts

@@ -1,395 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it } from 'bun:test'
-import { mkdir, rm, writeFile } from 'node:fs/promises'
-import * as path from 'node:path'
-import { createNodeFileSystem } from '~/testing/node-platform.js'
-import { discoverSkills, loadSkillContent, parseSkillFile, parseSkillFrontmatter } from './discovery.js'
-
-const testFs = createNodeFileSystem()
-
-// ============================================================================
-// Test Setup
-// ============================================================================
-
-const TEST_DIR = path.join(import.meta.dir, '__test_skills__')
-
-beforeEach(async () => {
-	await mkdir(TEST_DIR, { recursive: true })
-})
-
-afterEach(async () => {
-	await rm(TEST_DIR, { recursive: true, force: true })
-})
-
-// ============================================================================
-// parseSkillFrontmatter tests
-// ============================================================================
-
-describe('parseSkillFrontmatter', () => {
-	it('parses valid frontmatter with name and description', () => {
-		const content = `---
-name: research
-description: Structured research workflow
----
-# Research Skill
-Some content here...`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value.name).toBe('research')
-			expect(result.value.description).toBe('Structured research workflow')
-		}
-	})
-
-	it('parses quoted values', () => {
-		const content = `---
-name: "code-review"
-description: 'Code review workflow'
----
-Content...`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value.name).toBe('code-review')
-			expect(result.value.description).toBe('Code review workflow')
-		}
-	})
-
-	it('fails when frontmatter does not start with ---', () => {
-		const content = `name: research
-description: Test
----
-Content`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('must start with ---')
-		}
-	})
-
-	it('fails when closing --- is missing', () => {
-		const content = `---
-name: research
-description: Test
-Content without closing delimiter`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('Missing closing ---')
-		}
-	})
-
-	it('fails when name is missing', () => {
-		const content = `---
-description: Test description
----
-Content`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('Missing required "name"')
-		}
-	})
-
-	it('fails when description is missing', () => {
-		const content = `---
-name: test-skill
----
-Content`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('Missing required "description"')
-		}
-	})
-
-	it('ignores comments in frontmatter', () => {
-		const content = `---
-# This is a comment
-name: test
-description: Test skill
-# Another comment
----
-Content`
-
-		const result = parseSkillFrontmatter(content)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value.name).toBe('test')
-		}
-	})
-})
-
-// ============================================================================
-// parseSkillFile tests
-// ============================================================================
-
-describe('parseSkillFile', () => {
-	it('extracts frontmatter and content separately', () => {
-		const content = `---
-name: research
-description: Research workflow
----
-
-# Research Skill
-
-## When to Use
-Use when searching for papers.`
-
-		const result = parseSkillFile(content)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value.frontmatter.name).toBe('research')
-			expect(result.value.frontmatter.description).toBe('Research workflow')
-			expect(result.value.content).toContain('# Research Skill')
-			expect(result.value.content).toContain('## When to Use')
-			// Content should not include frontmatter
-			expect(result.value.content).not.toContain('name:')
-		}
-	})
-
-	it('handles minimal content', () => {
-		const content = `---
-name: minimal
-description: Minimal skill
----
-Just one line.`
-
-		const result = parseSkillFile(content)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value.content).toBe('Just one line.')
-		}
-	})
-})
-
-// ============================================================================
-// discoverSkills tests
-// ============================================================================
-
-describe('discoverSkills', () => {
-	it('discovers skills from a directory', async () => {
-		// Create skill directories
-		const skillDir1 = path.join(TEST_DIR, 'research')
-		const skillDir2 = path.join(TEST_DIR, 'code-review')
-		await mkdir(skillDir1, { recursive: true })
-		await mkdir(skillDir2, { recursive: true })
-
-		await writeFile(
-			path.join(skillDir1, 'SKILL.md'),
-			`---
-name: research
-description: Research workflow
----
-# Research content`,
-		)
-
-		await writeFile(
-			path.join(skillDir2, 'SKILL.md'),
-			`---
-name: code-review
-description: Code review process
----
-# Code review content`,
-		)
-
-		const result = await discoverSkills(testFs, [TEST_DIR], '/')
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value).toHaveLength(2)
-			const names = result.value.map((s) => s.name)
-			expect(names).toContain('research')
-			expect(names).toContain('code-review')
-		}
-	})
-
-	it('skips directories without SKILL.md', async () => {
-		const skillDir = path.join(TEST_DIR, 'valid-skill')
-		const otherDir = path.join(TEST_DIR, 'not-a-skill')
-		await mkdir(skillDir, { recursive: true })
-		await mkdir(otherDir, { recursive: true })
-
-		await writeFile(
-			path.join(skillDir, 'SKILL.md'),
-			`---
-name: valid
-description: A valid skill
----
-Content`,
-		)
-
-		await writeFile(path.join(otherDir, 'README.md'), 'Just a readme')
-
-		const result = await discoverSkills(testFs, [TEST_DIR], '/')
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value).toHaveLength(1)
-			expect(result.value[0].name).toBe('valid')
-		}
-	})
-
-	it('skips non-existent source directories', async () => {
-		const result = await discoverSkills(testFs, ['/nonexistent/path'], '/')
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value).toHaveLength(0)
-		}
-	})
-
-	it('resolves relative paths from basePath', async () => {
-		const baseDir = path.join(TEST_DIR, 'base')
-		const skillsDir = path.join(baseDir, 'skills')
-		const skillDir = path.join(skillsDir, 'my-skill')
-		await mkdir(skillDir, { recursive: true })
-
-		await writeFile(
-			path.join(skillDir, 'SKILL.md'),
-			`---
-name: my-skill
-description: A skill with relative path
----
-Content`,
-		)
-
-		const result = await discoverSkills(testFs, ['skills'], baseDir)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value).toHaveLength(1)
-			expect(result.value[0].name).toBe('my-skill')
-		}
-	})
-
-	it('fails on duplicate skill IDs', async () => {
-		const dir1 = path.join(TEST_DIR, 'skill1')
-		const dir2 = path.join(TEST_DIR, 'skill2')
-		await mkdir(dir1, { recursive: true })
-		await mkdir(dir2, { recursive: true })
-
-		// Both skills have the same name
-		await writeFile(
-			path.join(dir1, 'SKILL.md'),
-			`---
-name: duplicate
-description: First skill
----
-Content 1`,
-		)
-
-		await writeFile(
-			path.join(dir2, 'SKILL.md'),
-			`---
-name: duplicate
-description: Second skill
----
-Content 2`,
-		)
-
-		const result = await discoverSkills(testFs, [TEST_DIR], '/')
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('Duplicate skill ID')
-		}
-	})
-
-	it('fails on invalid frontmatter', async () => {
-		const skillDir = path.join(TEST_DIR, 'invalid-skill')
-		await mkdir(skillDir, { recursive: true })
-
-		await writeFile(
-			path.join(skillDir, 'SKILL.md'),
-			`---
-name: invalid
-# Missing description
----
-Content`,
-		)
-
-		const result = await discoverSkills(testFs, [TEST_DIR], '/')
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('Failed to parse')
-		}
-	})
-
-	it('discovers skills from multiple source directories', async () => {
-		const dir1 = path.join(TEST_DIR, 'source1')
-		const dir2 = path.join(TEST_DIR, 'source2')
-		const skill1 = path.join(dir1, 'skill-a')
-		const skill2 = path.join(dir2, 'skill-b')
-		await mkdir(skill1, { recursive: true })
-		await mkdir(skill2, { recursive: true })
-
-		await writeFile(
-			path.join(skill1, 'SKILL.md'),
-			`---
-name: skill-a
-description: First source skill
----
-Content A`,
-		)
-
-		await writeFile(
-			path.join(skill2, 'SKILL.md'),
-			`---
-name: skill-b
-description: Second source skill
----
-Content B`,
-		)
-
-		const result = await discoverSkills(testFs, [dir1, dir2], '/')
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value).toHaveLength(2)
-		}
-	})
-})
-
-// ============================================================================
-// loadSkillContent tests
-// ============================================================================
-
-describe('loadSkillContent', () => {
-	it('loads skill content without frontmatter', async () => {
-		const skillDir = path.join(TEST_DIR, 'load-test')
-		await mkdir(skillDir, { recursive: true })
-
-		const skillPath = path.join(skillDir, 'SKILL.md')
-		await writeFile(
-			skillPath,
-			`---
-name: loadable
-description: A loadable skill
----
-
-# Skill Instructions
-
-## Step 1
-Do something.
-
-## Step 2
-Do something else.`,
-		)
-
-		const result = await loadSkillContent(testFs, skillPath)
-		expect(result.ok).toBe(true)
-		if (result.ok) {
-			expect(result.value).toContain('# Skill Instructions')
-			expect(result.value).toContain('## Step 1')
-			expect(result.value).not.toContain('name: loadable')
-		}
-	})
-
-	it('fails for non-existent file', async () => {
-		const result = await loadSkillContent(testFs, '/nonexistent/SKILL.md')
-		expect(result.ok).toBe(false)
-		if (!result.ok) {
-			expect(result.error.message).toContain('not found')
-		}
-	})
-})