@roj-ai/sdk 0.1.28 → 0.1.30

package/src/plugins/uploads/uploads.integration.test.ts

@@ -1,8 +1,10 @@
 import { describe, expect, it } from 'bun:test'
 import z from 'zod/v4'
+import { agentEvents } from '~/core/agents/state.js'
 import { MockLLMProvider } from '~/core/llm/mock.js'
 import { selectPluginState } from '~/core/sessions/reducer.js'
 import { createTestPreset, TestHarness } from '~/testing/index.js'
+import type { TestSession } from '~/testing/index.js'
 import type { UploadsState } from './state.js'
 import { uploadEvents } from './state.js'
 
@@ -17,6 +19,12 @@ function okValue<T>(result: { ok: boolean; value?: unknown }, schema: z.ZodType<
 	return schema.parse(result.value)
 }
 
+async function pauseEntryAgent(session: TestSession): Promise<void> {
+	const entryAgentId = session.getEntryAgentId()
+	if (!entryAgentId) throw new Error('Expected entry agent')
+	await session.pauseAgent(entryAgentId, 'Keep upload pending for storage test')
+}
+
 const uploadResultSchema = z.object({
 	uploadId: z.string(),
 	status: z.enum(['ready', 'failed']),
@@ -174,7 +182,7 @@ describe('uploads plugin', () => {
 	// =========================================================================
 
 	describe('dequeue', () => {
-		it('pending upload delivered to agent as LLM message with <attachment> XML', async () => {
+		it('upload arriving while agent is idle wakes exactly one inference', async () => {
 			const harness = new TestHarness({
 				presets: [createTestPreset()],
 				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Got it', toolCalls: [] }),
@@ -191,8 +199,8 @@ describe('uploads plugin', () => {
 				fileBuffer: fileContent,
 			})
 
-			// Send a message to trigger inference — the pending upload should be dequeued
-			await session.sendAndWaitForIdle('Process the file')
+			await session.waitForIdle()
+			expect(harness.llmProvider.getCallCount()).toBe(1)
 
 			// Check that the LLM received the attachment in its messages
 			const lastRequest = harness.llmProvider.getLastRequest()
@@ -209,41 +217,48 @@ describe('uploads plugin', () => {
 			expect(attachmentMessage.content).toContain('filename="doc.txt"')
 			expect(attachmentMessage.content).toContain('type="text/plain"')
 
+			const consumedEvents = await session.getEventsByType(agentEvents, 'agent_input_consumed')
+			expect(consumedEvents).toHaveLength(1)
+			expect(consumedEvents[0].sourcePlugins).toContain('uploads')
+
 			await harness.shutdown()
 		})
 
-		it('after delivery, upload consumed (attachments_consumed event, removed from pending)', async () => {
+		it('several quick uploads debounce into one inference and one consumption event', async () => {
 			const harness = new TestHarness({
 				presets: [createTestPreset()],
 				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Got it', toolCalls: [] }),
 			})
 
 			const session = await harness.createSession('test')
-			const fileContent = Buffer.from('Some data')
-
-			await session.callPluginMethod('uploads.upload', {
-				sessionId: String(session.sessionId),
-				filename: 'data.txt',
-				mimeType: 'text/plain',
-				size: fileContent.length,
-				fileBuffer: fileContent,
-			})
+			const filenames = ['one.txt', 'two.txt', 'three.txt']
+			await Promise.all(filenames.map((filename) => {
+				const fileContent = Buffer.from(`Content of ${filename}`)
+				return session.callPluginMethod('uploads.upload', {
+					sessionId: String(session.sessionId),
+					filename,
+					mimeType: 'text/plain',
+					size: fileContent.length,
+					fileBuffer: fileContent,
+				})
+			}))
 
-			// Before inference, should be in pending
-			const uploadsBefore = selectPluginState<UploadsState>(session.state, 'uploads')
-			expect(uploadsBefore).toBeDefined()
-			if (!uploadsBefore) throw new Error('Expected uploads state')
-			expect(uploadsBefore.pending).toHaveLength(1)
+			await session.waitForIdle()
+			expect(harness.llmProvider.getCallCount()).toBe(1)
 
-			// Trigger inference
-			await session.sendAndWaitForIdle('Handle this')
+			const lastRequest = harness.llmProvider.getLastRequest()
+			expect(lastRequest).toBeDefined()
+			const requestText = lastRequest?.messages
+				.map((message) => typeof message.content === 'string' ? message.content : '')
+				.join('\n') ?? ''
+			for (const filename of filenames) {
+				expect(requestText).toContain(`filename="${filename}"`)
+			}
 
-			// After inference, should be consumed
 			const consumedEvents = await session.getEventsByType(uploadEvents, 'attachments_consumed')
 			expect(consumedEvents).toHaveLength(1)
-			expect(consumedEvents[0].uploadIds).toHaveLength(1)
+			expect(consumedEvents[0].uploadIds).toHaveLength(3)
 
-			// Pending should be empty
 			const uploadsAfter = selectPluginState<UploadsState>(session.state, 'uploads')
 			expect(uploadsAfter).toBeDefined()
 			if (!uploadsAfter) throw new Error('Expected uploads state')
@@ -251,6 +266,36 @@ describe('uploads plugin', () => {
 
 			await harness.shutdown()
 		})
+
+		it('upload does not wake a paused agent', async () => {
+			const harness = new TestHarness({
+				presets: [createTestPreset()],
+				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Got it', toolCalls: [] }),
+			})
+
+			const session = await harness.createSession('test')
+			const entryAgentId = session.getEntryAgentId()
+			if (!entryAgentId) throw new Error('Expected entry agent')
+			await session.pauseAgent(entryAgentId, 'Paused by user')
+
+			const fileContent = Buffer.from('Wait until resume')
+			await session.callPluginMethod('uploads.upload', {
+				sessionId: String(session.sessionId),
+				filename: 'paused.txt',
+				mimeType: 'text/plain',
+				size: fileContent.length,
+				fileBuffer: fileContent,
+			})
+
+			await new Promise((resolve) => setTimeout(resolve, 25))
+			expect(harness.llmProvider.getCallCount()).toBe(0)
+			expect(session.state.agents.get(entryAgentId)?.status).toBe('paused')
+
+			const uploads = selectPluginState<UploadsState>(session.state, 'uploads')
+			expect(uploads?.pending).toHaveLength(1)
+
+			await harness.shutdown()
+		})
 	})
 
 	// =========================================================================
@@ -265,6 +310,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			await session.callPluginMethod('uploads.upload', {
 				sessionId: String(session.sessionId),
@@ -304,6 +350,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const uploadData = okValue(
 				await session.callPluginMethod('uploads.upload', {
@@ -340,6 +387,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const uploadData = okValue(
 				await session.callPluginMethod('uploads.upload', {
@@ -381,6 +429,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const uploadData = okValue(
 				await session.callPluginMethod('uploads.upload', {
@@ -417,6 +466,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const uploadData = okValue(
 				await session.callPluginMethod('uploads.upload', {
@@ -482,6 +532,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const uploadData = okValue(
 				await session.callPluginMethod('uploads.upload', {
@@ -617,7 +668,7 @@ describe('uploads plugin', () => {
 		// uploadAsync method
 		// =========================================================================
 
-		it('uploadAsync returns processing immediately, then statusChanged → ready', async () => {
+		it('uploadAsync returns processing, then ready upload wakes the idle agent', async () => {
 			const harness = new TestHarness({
 				presets: [createTestPreset()],
 				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Ok', toolCalls: [] }),
@@ -655,12 +706,13 @@ describe('uploads plugin', () => {
 			expect(own[0].status).toBe('processing')
 			expect(own[1].status).toBe('ready')
 
-			// State only carries ready uploads — processing event is filtered by reducer.
+			await session.waitForIdle()
+			expect(harness.llmProvider.getCallCount()).toBe(1)
+
+			// The ready upload was delivered and consumed by the woken agent.
 			const uploads = selectPluginState<UploadsState>(session.state, 'uploads')
 			if (!uploads) throw new Error('Expected uploads state')
-			expect(uploads.pending).toHaveLength(1)
-			expect(uploads.pending[0]?.uploadId).toBe(data.uploadId)
-			expect(uploads.pending[0]?.status).toBe('ready')
+			expect(uploads.pending).toHaveLength(0)
 
 			// First notification was processing.
 			const all = harness.notifications.getByType('uploads', 'uploadStatusChanged')
@@ -704,6 +756,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const result = await session.callPluginMethod('uploads.uploadAsync', {
 				sessionId: String(session.sessionId),
@@ -743,6 +796,7 @@ describe('uploads plugin', () => {
 			})
 
 			const session = await harness.createSession('test')
+			await pauseEntryAgent(session)
 
 			const uploadData = okValue(
 				await session.callPluginMethod('uploads.upload', {

package/src/testing/test-harness.ts

@@ -275,6 +275,26 @@ export class TestSession {
 		return this.session.getEntryAgentId()
 	}
 
+	/**
+	 * Pause an agent (the manual-pause API).
+	 */
+	async pauseAgent(agentId: AgentId, message?: string): Promise<void> {
+		const result = await this.session.pauseAgent(agentId, message)
+		if (!result.ok) {
+			throw new Error(`pauseAgent failed: ${result.error.type} — ${result.error.message}`)
+		}
+	}
+
+	/**
+	 * Resume a paused (or errored) agent.
+	 */
+	async resumeAgent(agentId: AgentId): Promise<void> {
+		const result = await this.session.resumeAgent(agentId)
+		if (!result.ok) {
+			throw new Error(`resumeAgent failed: ${result.error.type} — ${result.error.message}`)
+		}
+	}
+
 	/**
 	 * Close the session.
 	 */