@roj-ai/sdk 0.1.27 → 0.1.29

package/src/plugins/services/services.integration.test.ts

@@ -1,5 +1,5 @@
 import { afterEach, describe, expect, it } from 'bun:test'
-import { readFile, rm } from 'node:fs/promises'
+import { mkdir, mkdtemp, readFile, rm } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
 import { MemoryEventStore } from '~/core/events/memory.js'
@@ -13,7 +13,8 @@ import { createTestPreset, TestHarness } from '~/testing/index.js'
 import { serviceEvents, servicePlugin } from './plugin.js'
 import type { ServiceAgentConfig, ServicePluginConfig } from './plugin.js'
 import { PortPool } from './port-pool.js'
-import type { ServiceConfig, ServiceEntry, ServiceStatus } from './schema.js'
+import { buildServiceStatusMessage } from './prompt.js'
+import type { ServiceCommandArgs, ServiceConfig, ServiceCwdArgs, ServiceEntry, ServiceStatus } from './schema.js'
 import { ServiceExecutor } from './service.js'
 
 // ============================================================================
@@ -278,6 +279,84 @@ describe('services plugin', () => {
 			const serviceState = selectPluginState<Map<string, ServiceEntry>>(session.state, 'services')?.get('callback-service')
 			expect(serviceState!.port).toBeGreaterThanOrEqual(10000)
 		})
+
+		it('resolves cwd, command, and env callbacks with runtime context', async () => {
+			const workspaceDir = await mkdtemp(join(tmpdir(), 'roj-svc-runtime-'))
+			const webDir = join(workspaceDir, 'packages', 'web')
+			await mkdir(webDir, { recursive: true })
+
+			let cwdArgs: ServiceCwdArgs | undefined
+			let commandArgs: ServiceCommandArgs | undefined
+			let envArgs: ServiceCommandArgs | undefined
+
+			const runtimeService: ServiceConfig = {
+				type: 'runtime',
+				description: 'Service with runtime resolvers',
+				cwd: (args) => {
+					cwdArgs = args
+					return 'packages/web'
+				},
+				command: async (args) => {
+					commandArgs = args
+					return `printf "%s" "$RUNTIME_MARKER" > marker.txt && echo "READY ${args.port}" && sleep 60`
+				},
+				env: (args) => {
+					envArgs = args
+					return {
+						RUNTIME_MARKER: `${args.sessionId}|${args.workspaceDir}|${args.cwd}|${args.port}`,
+					}
+				},
+				readyPattern: 'READY',
+			}
+
+			try {
+				const portPool = new PortPool()
+				const harness = createServicesHarness({
+					presets: [createServicesPreset([runtimeService], ['runtime'], portPool, { workspaceDir })],
+					llmProvider: MockLLMProvider.withFixedResponse({ content: 'Ok', toolCalls: [] }),
+				})
+
+				const session = await harness.createSession('test')
+				const entryAgentId = session.getEntryAgentId()!
+				const startResult = await session.callPluginMethod('services.start', {
+					sessionId: String(session.sessionId),
+					agentId: String(entryAgentId),
+					serviceType: 'runtime',
+				})
+				expect(startResult.ok).toBe(true)
+				await waitForServiceStatus(session, 'runtime', 'ready')
+
+				const serviceState = selectPluginState<Map<string, ServiceEntry>>(session.state, 'services')?.get('runtime')
+				expect(cwdArgs?.workspaceDir).toBe(workspaceDir)
+				expect(cwdArgs?.sessionId).toBe(String(session.sessionId))
+				expect(commandArgs?.cwd).toBe(webDir)
+				expect(commandArgs?.workspaceDir).toBe(workspaceDir)
+				expect(envArgs?.cwd).toBe(webDir)
+				expect(serviceState?.cwd).toBe(webDir)
+				expect(serviceState?.command).toContain('RUNTIME_MARKER')
+
+				const marker = await readFile(join(webDir, 'marker.txt'), 'utf-8')
+				expect(marker).toContain(String(session.sessionId))
+				expect(marker).toContain(workspaceDir)
+				expect(marker).toContain(webDir)
+
+				const statusResult = await session.callPluginMethod('services.status', {
+					sessionId: String(session.sessionId),
+					agentId: String(entryAgentId),
+					serviceType: 'runtime',
+				})
+				expect(statusResult).toMatchObject({
+					ok: true,
+					value: {
+						status: 'ready',
+						cwd: webDir,
+						command: serviceState?.command,
+					},
+				})
+			} finally {
+				await rm(workspaceDir, { recursive: true, force: true })
+			}
+		})
 	})
 
 	// =========================================================================
@@ -379,6 +458,35 @@ describe('services plugin', () => {
 			const autoEvents = events.filter((e) => e.serviceType === 'auto-start')
 			expect(autoEvents.length).toBeGreaterThanOrEqual(1)
 		})
+
+		it('availableWhen false skips auto-start and explicit start returns an error', async () => {
+			const unavailableService: ServiceConfig = {
+				type: 'unavailable',
+				description: 'Unavailable service',
+				command: 'sleep 60',
+				autoStart: true,
+				availableWhen: () => false,
+			}
+			const portPool = new PortPool()
+			const harness = createServicesHarness({
+				presets: [createServicesPreset([unavailableService], ['unavailable'], portPool)],
+				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Ok', toolCalls: [] }),
+			})
+
+			const session = await harness.createSession('test')
+			await new Promise((resolve) => setTimeout(resolve, 100))
+
+			const events = await session.getEventsByType(serviceEvents, 'service_status_changed')
+			expect(events.some((event) => event.serviceType === 'unavailable')).toBe(false)
+
+			const entryAgentId = session.getEntryAgentId()!
+			const result = await session.callPluginMethod('services.start', {
+				sessionId: String(session.sessionId),
+				agentId: String(entryAgentId),
+				serviceType: 'unavailable',
+			})
+			expect(result.ok).toBe(false)
+		})
 	})
 
 	// =========================================================================
@@ -439,6 +547,38 @@ describe('services plugin', () => {
 			const serviceState = selectPluginState<Map<string, ServiceEntry>>(session.state, 'services')?.get('ready-service')
 			expect(serviceState!.status).toBe('ready')
 		})
+
+		it('readyWhen can mark a service ready without output pattern', async () => {
+			let checks = 0
+			const readyWhenService: ServiceConfig = {
+				type: 'ready-when',
+				description: 'Service with callback readiness',
+				command: 'sleep 60',
+				readyWhen: () => {
+					checks += 1
+					return checks > 1
+				},
+				readyCheckIntervalMs: 20,
+				startupTimeoutMs: 1000,
+			}
+			const portPool = new PortPool()
+			const harness = createServicesHarness({
+				presets: [createServicesPreset([readyWhenService], ['ready-when'], portPool)],
+				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Ok', toolCalls: [] }),
+			})
+
+			const session = await harness.createSession('test')
+			const entryAgentId = session.getEntryAgentId()!
+			const result = await session.callPluginMethod('services.start', {
+				sessionId: String(session.sessionId),
+				agentId: String(entryAgentId),
+				serviceType: 'ready-when',
+			})
+			expect(result.ok).toBe(true)
+
+			await waitForServiceStatus(session, 'ready-when', 'ready')
+			expect(checks).toBeGreaterThan(1)
+		})
 	})
 
 	// =========================================================================
@@ -658,8 +798,8 @@ describe('services plugin', () => {
 			}
 
 			const observed: Array<{ status: ServiceStatus; port?: number }> = []
-			executor.onStatusChanged = (_sessionId, _serviceType, status, port) => {
-				observed.push({ status, port })
+			executor.onStatusChanged = (_sessionId, _serviceType, status, details) => {
+				observed.push({ status, port: details.port })
 			}
 
 			try {
@@ -682,4 +822,132 @@ describe('services plugin', () => {
 			}
 		})
 	})
+
+	// =========================================================================
+	// agentVisible: false — infrastructure services hidden from agents
+	// =========================================================================
+
+	describe('agentVisible: false services', () => {
+		const hiddenService: ServiceConfig = {
+			type: 'hidden-svc',
+			description: 'Infra service driven by the platform, not agents',
+			command: 'sleep 60',
+			agentVisible: false,
+		}
+
+		it('auto-wired agent visibility excludes it: no tool mention, no status line, still method-controllable', async () => {
+			const portPool = new PortPool()
+			const base = createTestPreset({
+				plugins: [servicePlugin.configure({ services: [quickService, hiddenService], portPool })],
+			})
+			// Services attached on the agent definition (defineAgent-style auto-wiring),
+			// NOT via explicit configureAgent — exercises the getAgentConfig filter.
+			const preset = { ...base, orchestrator: { ...base.orchestrator, services: [quickService, hiddenService] } }
+			const harness = createServicesHarness({
+				presets: [preset],
+				llmProvider: MockLLMProvider.withFixedResponse({ content: 'Ok', toolCalls: [] }),
+			})
+
+			const session = await harness.createSession('test')
+			await session.sendAndWaitForIdle('Hi')
+
+			// Service tools exist (quick is visible) but never mention the hidden service
+			const lastRequest = harness.llmProvider.getLastRequest()
+			const serviceStart = lastRequest?.tools?.find((t) => t.name === 'service_start')
+			expect(serviceStart).toBeDefined()
+			expect(serviceStart?.description).toContain('quick')
+			expect(serviceStart?.description).not.toContain('hidden-svc')
+
+			// The session-context status block skips it too
+			const serialized = JSON.stringify(lastRequest?.messages ?? [])
+			expect(serialized).not.toContain('hidden-svc')
+
+			// Still fully controllable at the session level via services.* methods
+			const entryAgentId = session.getEntryAgentId()!
+			const startResult = await session.callPluginMethod('services.start', {
+				sessionId: String(session.sessionId),
+				agentId: String(entryAgentId),
+				serviceType: 'hidden-svc',
+			})
+			expect(startResult).toMatchObject({ ok: true })
+			await waitForServiceStatus(session, 'hidden-svc', 'ready')
+
+			const statusResult = await session.callPluginMethod('services.status', {
+				sessionId: String(session.sessionId),
+				agentId: String(entryAgentId),
+				serviceType: 'hidden-svc',
+			})
+			expect(statusResult).toMatchObject({ ok: true, value: { status: 'ready' } })
+		})
+	})
+
+	// =========================================================================
+	// Real host paths must not leak into agent-facing surfaces
+	// =========================================================================
+
+	describe('host path hygiene', () => {
+		it('status block omits cwd even when the entry tracks one', () => {
+			const message = buildServiceStatusMessage(
+				[{
+					serviceType: 'quick',
+					status: 'ready',
+					port: 4321,
+					cwd: '/home/user/sessions/0000-real-host-path/packages/web',
+				}],
+				[quickService],
+			)
+			expect(message).toContain('quick')
+			expect(message).toContain('port 4321')
+			expect(message).not.toContain('real-host-path')
+			expect(message).not.toContain('cwd')
+		})
+
+		it('service_status tool output strips cwd', async () => {
+			const portPool = new PortPool()
+			// Absolute cwd so the tracked entry actually carries a host path to leak.
+			const cwdService: ServiceConfig = {
+				type: 'cwd-svc',
+				description: 'Service with a resolved host cwd',
+				command: 'sleep 60',
+				cwd: tmpdir(),
+			}
+			const harness = createServicesHarness({
+				presets: [createServicesPreset([cwdService], ['cwd-svc'], portPool)],
+				llmProvider: MockLLMProvider.withSequence([
+					{
+						toolCalls: [{
+							id: ToolCallId('tc-start'),
+							name: 'service_start',
+							input: { serviceType: 'cwd-svc' },
+						}],
+					},
+					{
+						toolCalls: [{
+							id: ToolCallId('tc-status'),
+							name: 'service_status',
+							input: { serviceType: 'cwd-svc' },
+						}],
+					},
+					{ content: 'Done', toolCalls: [] },
+				]),
+			})
+
+			const session = await harness.createSession('test')
+			await session.sendAndWaitForIdle('Check the service')
+			await waitForServiceStatus(session, 'cwd-svc', 'ready')
+
+			// The service_status tool result (fed back as a message) must not carry cwd,
+			// while the session-level method keeps returning it for platform callers.
+			const serialized = JSON.stringify(harness.llmProvider.getLastRequest()?.messages ?? [])
+			expect(serialized).not.toContain('"cwd"')
+
+			const entryAgentId = session.getEntryAgentId()!
+			const statusResult = await session.callPluginMethod('services.status', {
+				sessionId: String(session.sessionId),
+				agentId: String(entryAgentId),
+				serviceType: 'cwd-svc',
+			})
+			expect(statusResult).toMatchObject({ ok: true, value: { cwd: expect.any(String) } })
+		})
+	})
 })

package/src/testing/preset-helpers.ts

@@ -12,6 +12,7 @@ export type TestAgentDefinition<TInput = unknown> = Omit<AgentDefinition<TInput>
  */
 export function createTestPreset(overrides?: {
 	id?: string
+	workspaceDir?: string
 	orchestratorSystem?: string
 	agents?: TestAgentDefinition[]
 	plugins?: SessionPluginConfig[]
@@ -22,6 +23,7 @@ export function createTestPreset(overrides?: {
 	return {
 		id: overrides?.id ?? 'test',
 		name: 'Test Preset',
+		workspaceDir: overrides?.workspaceDir,
 		orchestrator: {
 			system: overrides?.orchestratorSystem ?? 'You are a test agent.',
 			model: ModelId('mock'),