@robota-sdk/agent-ui-terminal 3.0.0-beta.100

package/src/__tests__/PluginTUI.test.tsx

@@ -0,0 +1,167 @@
+// packages/agent-cli/src/ui/__tests__/PluginTUI.test.tsx
+import React from 'react';
+import { render } from 'ink-testing-library';
+import { describe, it, expect, vi } from 'vitest';
+import PluginTUI from '../PluginTUI.js';
+import type { ICommandPluginAdapter } from '@robota-sdk/agent-interface-command';
+
+function mockCallbacks(): ICommandPluginAdapter {
+  return {
+    listInstalled: vi.fn().mockResolvedValue([]),
+    listAvailablePlugins: vi.fn().mockResolvedValue([]),
+    install: vi.fn().mockResolvedValue(undefined),
+    uninstall: vi.fn().mockResolvedValue(undefined),
+    enable: vi.fn().mockResolvedValue(undefined),
+    disable: vi.fn().mockResolvedValue(undefined),
+    marketplaceAdd: vi.fn().mockResolvedValue('test-marketplace'),
+    marketplaceRemove: vi.fn().mockResolvedValue(undefined),
+    marketplaceUpdate: vi.fn().mockResolvedValue(undefined),
+    marketplaceList: vi.fn().mockResolvedValue([]),
+    reloadPlugins: vi.fn().mockResolvedValue({ loadedPluginCount: 0 }),
+  };
+}
+
+describe('PluginTUI', () => {
+  it('renders main menu with Marketplace and Installed Plugins', () => {
+    const { lastFrame } = render(<PluginTUI callbacks={mockCallbacks()} onClose={() => {}} />);
+    const frame = lastFrame()!;
+    expect(frame).toContain('Marketplace');
+    expect(frame).toContain('Installed Plugins');
+  });
+
+  it('calls onClose when Escape on main menu', async () => {
+    let closed = false;
+    const { stdin } = render(
+      <PluginTUI
+        callbacks={mockCallbacks()}
+        onClose={() => {
+          closed = true;
+        }}
+      />,
+    );
+    stdin.write('\x1B');
+    await new Promise((r) => setTimeout(r, 50));
+    expect(closed).toBe(true);
+  });
+
+  it('navigates to installed plugins and shows actions', async () => {
+    const cbs = mockCallbacks();
+    cbs.listInstalled = vi
+      .fn()
+      .mockResolvedValue([{ name: 'my-plugin', description: 'A plugin', enabled: true }]);
+    const { stdin, lastFrame } = render(<PluginTUI callbacks={cbs} onClose={() => {}} />);
+    stdin.write('\x1B[B'); // Down to "Installed Plugins"
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 100));
+    expect(lastFrame()!).toContain('my-plugin');
+  });
+
+  it('navigates to marketplace list on Enter', async () => {
+    const cbs = mockCallbacks();
+    cbs.marketplaceList = vi.fn().mockResolvedValue([{ name: 'test-mp', type: 'github' }]);
+    const { stdin, lastFrame } = render(<PluginTUI callbacks={cbs} onClose={() => {}} />);
+    stdin.write('\r'); // Enter on "Marketplace"
+    await new Promise((r) => setTimeout(r, 100));
+    const frame = lastFrame()!;
+    expect(frame).toContain('Add Marketplace');
+  });
+
+  // Regression: arrow keys must work after navigating to a sub-screen (resolvedRef reset via key)
+  it('arrow keys work in marketplace list after navigating from main', async () => {
+    const cbs = mockCallbacks();
+    cbs.marketplaceList = vi.fn().mockResolvedValue([
+      { name: 'mp-a', type: 'github' },
+      { name: 'mp-b', type: 'git' },
+    ]);
+    const { stdin, lastFrame } = render(<PluginTUI callbacks={cbs} onClose={() => {}} />);
+    stdin.write('\r'); // Enter on "Marketplace"
+    await new Promise((r) => setTimeout(r, 100));
+    // Should be on marketplace-list with arrow keys working
+    stdin.write('\x1B[B'); // Down from "Add Marketplace" to "mp-a"
+    stdin.write('\x1B[B'); // Down to "mp-b"
+    await new Promise((r) => setTimeout(r, 50));
+    const frame = lastFrame()!;
+    // "mp-b" should be highlighted (has > prefix)
+    expect(frame).toContain('mp-b');
+    // Select mp-b → should navigate to marketplace-action
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 50));
+    expect(lastFrame()!).toContain('Browse plugins');
+  });
+
+  // Regression: installed plugin browse shows uninstall for already-installed plugins
+  it('selecting installed plugin in browse shows uninstall action', async () => {
+    const cbs = mockCallbacks();
+    cbs.marketplaceList = vi.fn().mockResolvedValue([{ name: 'test-mp', type: 'github' }]);
+    cbs.listAvailablePlugins = vi.fn().mockResolvedValue([
+      { name: 'my-plugin', description: 'A plugin', installed: true },
+      { name: 'new-plugin', description: 'Not installed', installed: false },
+    ]);
+    const { stdin, lastFrame } = render(<PluginTUI callbacks={cbs} onClose={() => {}} />);
+    // Main → Marketplace
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 100));
+    // Marketplace list → select test-mp
+    stdin.write('\x1B[B'); // Down to "test-mp"
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 50));
+    // Marketplace action → Browse plugins
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 100));
+    // Browse → select installed "my-plugin"
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 50));
+    // Should show uninstall action, not install scope
+    expect(lastFrame()!).toContain('Uninstall');
+    expect(lastFrame()!).not.toContain('User scope');
+  });
+
+  // Regression: uninstalled plugin in browse shows install scope selection
+  it('selecting uninstalled plugin in browse shows install scope', async () => {
+    const cbs = mockCallbacks();
+    cbs.marketplaceList = vi.fn().mockResolvedValue([{ name: 'test-mp', type: 'github' }]);
+    cbs.listAvailablePlugins = vi
+      .fn()
+      .mockResolvedValue([{ name: 'new-plugin', description: 'Not installed', installed: false }]);
+    const { stdin, lastFrame } = render(<PluginTUI callbacks={cbs} onClose={() => {}} />);
+    // Main → Marketplace
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 100));
+    // Marketplace list → select test-mp
+    stdin.write('\x1B[B');
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 50));
+    // Marketplace action → Browse plugins
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 100));
+    // Browse → select "new-plugin"
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 50));
+    // Should show install scope, not uninstall
+    expect(lastFrame()!).toContain('User scope');
+    expect(lastFrame()!).toContain('Project scope');
+  });
+
+  // Regression: install passes name@marketplace format to callback
+  it('install callback receives pluginId in name@marketplace format', async () => {
+    const cbs = mockCallbacks();
+    cbs.marketplaceList = vi.fn().mockResolvedValue([{ name: 'test-mp', type: 'github' }]);
+    cbs.listAvailablePlugins = vi
+      .fn()
+      .mockResolvedValue([{ name: 'new-plugin', description: 'A plugin', installed: false }]);
+    const { stdin } = render(<PluginTUI callbacks={cbs} onClose={() => {}} />);
+    // Main → Marketplace → test-mp → Browse → new-plugin → User scope
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 100));
+    stdin.write('\x1B[B');
+    stdin.write('\r');
+    await new Promise((r) => setTimeout(r, 50));
+    stdin.write('\r'); // Browse plugins
+    await new Promise((r) => setTimeout(r, 100));
+    stdin.write('\r'); // new-plugin
+    await new Promise((r) => setTimeout(r, 50));
+    stdin.write('\r'); // User scope
+    await new Promise((r) => setTimeout(r, 100));
+    expect(cbs.install).toHaveBeenCalledWith('new-plugin@test-mp', 'user');
+  }, 15000);
+});

package/src/__tests__/SlashAutocomplete.test.tsx

@@ -0,0 +1,162 @@
+import React from 'react';
+import { render } from 'ink-testing-library';
+import { describe, it, expect } from 'vitest';
+import SlashAutocomplete from '../SlashAutocomplete.js';
+import { formatKeyHints, SELECTION_INDICATOR } from '../key-hint-footer.js';
+import type { ICommand } from '@robota-sdk/agent-interface-command';
+
+// ink-testing-library fixes stdout.columns = 100
+// outer box chrome = 4 → rowWidth = 96 in tests
+const NAME_COL_MAX = 20;
+
+function makeCmd(name: string, description: string): ICommand {
+  return { name, description } as ICommand;
+}
+
+describe('SlashAutocomplete', () => {
+  it('renders nothing when not visible', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd('help', 'Show help')]}
+        selectedIndex={0}
+        visible={false}
+      />,
+    );
+    expect(lastFrame()).toBe('');
+  });
+
+  it('renders nothing when command list is empty', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete commands={[]} selectedIndex={0} visible={true} />,
+    );
+    expect(lastFrame()).toBe('');
+  });
+
+  it('aligns descriptions to the same column across all rows', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[
+          makeCmd('go', 'Short'),
+          makeCmd('session-persistence', 'Manage sessions'),
+          makeCmd('help', 'Show help'),
+        ]}
+        selectedIndex={0}
+        visible={true}
+      />,
+    );
+    const frame = lastFrame()!;
+    const lines = frame
+      .split('\n')
+      .filter((l) => l.includes('Short') || l.includes('Manage') || l.includes('Show help'));
+    // All description texts should start at the same column index
+    const descPositions = lines.map((l) => {
+      // find position after the two-space separator following the name
+      const match = / {2}\S/.exec(l.slice(l.indexOf('/') + 1));
+      return match ? l.indexOf('/') + 1 + match.index + 2 : -1;
+    });
+    expect(new Set(descPositions).size).toBe(1);
+  });
+
+  it('pads short names to match the longest name in visible set', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd('go', 'Run'), makeCmd('help', 'Show help')]}
+        selectedIndex={0}
+        visible={true}
+      />,
+    );
+    const frame = lastFrame()!;
+    // 'go' should be padded to 4 chars (length of 'help')
+    expect(frame).toContain('/go  ');
+  });
+
+  it('caps name column at NAME_COL_MAX and truncates with ellipsis', () => {
+    const longName = 'a'.repeat(NAME_COL_MAX + 5);
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd(longName, 'Description'), makeCmd('go', 'Short')]}
+        selectedIndex={0}
+        visible={true}
+      />,
+    );
+    const frame = lastFrame()!;
+    expect(frame).toContain('…');
+    expect(frame).not.toContain(longName);
+  });
+
+  it('does not truncate name exactly at NAME_COL_MAX', () => {
+    const exactName = 'b'.repeat(NAME_COL_MAX);
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd(exactName, 'Desc'), makeCmd('go', 'Short')]}
+        selectedIndex={0}
+        visible={true}
+      />,
+    );
+    const frame = lastFrame()!;
+    expect(frame).toContain(exactName);
+  });
+
+  it('truncates long row text with ellipsis via Ink wrap', () => {
+    const longDesc = 'X'.repeat(100);
+    const { lastFrame } = render(
+      <SlashAutocomplete commands={[makeCmd('cmd', longDesc)]} selectedIndex={0} visible={true} />,
+    );
+    expect(lastFrame()).toContain('…');
+    expect(lastFrame()).not.toContain(longDesc);
+  });
+
+  it('handles undefined description gracefully', () => {
+    const cmd = { name: 'cmd' } as ICommand;
+    const { lastFrame } = render(
+      <SlashAutocomplete commands={[cmd]} selectedIndex={0} visible={true} />,
+    );
+    expect(lastFrame()).toContain('cmd');
+  });
+
+  it('shows slash prefix in normal mode', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd('help', 'Show help')]}
+        selectedIndex={0}
+        visible={true}
+      />,
+    );
+    expect(lastFrame()).toContain('/help');
+  });
+
+  it('omits slash prefix in subcommand mode', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd('run', 'Run task')]}
+        selectedIndex={0}
+        visible={true}
+        isSubcommandMode={true}
+      />,
+    );
+    const frame = lastFrame()!;
+    expect(frame).not.toContain('/run');
+    expect(frame).toContain('Run task');
+  });
+
+  // SCREEN-005: footer renders through the key-hint SSOT grammar; selected row uses the indicator.
+  it('renders the footer in the shared key-hint grammar', () => {
+    const { lastFrame } = render(
+      <SlashAutocomplete
+        commands={[makeCmd('help', 'Show help')]}
+        selectedIndex={0}
+        visible={true}
+      />,
+    );
+    const frame = lastFrame()!;
+    expect(frame).toContain(
+      formatKeyHints([
+        { keys: '↑↓', label: 'Navigate' },
+        { keys: 'Tab', label: 'Complete' },
+        { keys: 'Enter', label: 'Select' },
+        { keys: 'Esc', label: 'Close' },
+      ]),
+    );
+    expect(frame).toContain(`${SELECTION_INDICATOR}/help`);
+  });
+});

package/src/__tests__/SupervisedSessionView-render.test.tsx

@@ -0,0 +1,52 @@
+import { render } from 'ink';
+import React from 'react';
+import { describe, expect, it, vi } from 'vitest';
+
+import { renderSupervisedSessionView } from '../SupervisedSessionView.js';
+
+vi.mock('ink', async (importOriginal) => ({
+  ...await importOriginal<typeof import('ink')>(),
+  render: vi.fn(() => ({ waitUntilExit: async () => undefined, unmount: () => undefined })),
+}));
+
+describe('production supervised view renderer', () => {
+  it('forwards the PR open action and filter state into the live view', async () => {
+    const onOpenPr = vi.fn(async () => undefined);
+    await renderSupervisedSessionView({
+      loadRows: async () => [], onOpenPr, filteredByPr: true, screenReader: false,
+    });
+    const wrapper = vi.mocked(render).mock.calls[0]?.[0] as React.ReactElement<{
+      children: React.ReactElement<{ onOpenPr?: typeof onOpenPr; filteredByPr?: boolean }>;
+    }>;
+    expect(wrapper.props.children.props.onOpenPr).toBe(onOpenPr);
+    expect(wrapper.props.children.props.filteredByPr).toBe(true);
+  });
+
+  it('returns the attach the user confirmed so the host can run it and come back', async () => {
+    vi.mocked(render).mockClear();
+    let exitView: () => void = () => undefined;
+    vi.mocked(render).mockImplementationOnce(() => ({
+      waitUntilExit: () => new Promise<void>((resolve) => { exitView = resolve; }),
+      unmount: () => undefined,
+    }) as never);
+    const ended = renderSupervisedSessionView({ loadRows: async () => [], screenReader: false });
+    const wrapper = vi.mocked(render).mock.calls[0]?.[0] as React.ReactElement<{
+      children: React.ReactElement<{ onAttach?: (request: unknown) => void }>;
+    }>;
+    wrapper.props.children.props.onAttach?.({ id: 'x', generation: 'g', mode: 'observe', groupByDirectory: true });
+    exitView();
+    expect(await ended).toEqual({ kind: 'attach', id: 'x', generation: 'g', mode: 'observe', groupByDirectory: true });
+  });
+
+  it('prints the screen-reader line only when asked to announce', async () => {
+    const out = vi.spyOn(process.stdout, 'write').mockImplementation(() => true);
+    try {
+      await renderSupervisedSessionView({ loadRows: async () => [], screenReader: true, screenReaderChannel: 'flag', announce: false });
+      expect(out.mock.calls.map(([text]) => String(text)).join('')).not.toContain('Screen reader mode');
+      await renderSupervisedSessionView({ loadRows: async () => [], screenReader: true, screenReaderChannel: 'flag' });
+      expect(out.mock.calls.map(([text]) => String(text)).join('')).toContain('Screen reader mode: on via flag');
+    } finally {
+      out.mockRestore();
+    }
+  });
+});