@robota-sdk/agent-command 3.0.0-beta.90 → 3.0.0-beta.92

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@robota-sdk/agent-command",
-  "version": "3.0.0-beta.90",
+  "version": "3.0.0-beta.92",
   "description": "Slash-command modules for Robota SDK sessions (/help, /permissions, /mcp, /rewind, …)",
   "type": "module",
   "main": "dist/node/index.js",
@@ -40,12 +40,12 @@
     "CHANGELOG.md"
   ],
   "dependencies": {
-    "@robota-sdk/agent-core": "3.0.0-beta.90",
-    "@robota-sdk/agent-framework": "3.0.0-beta.90",
-    "@robota-sdk/agent-interface-command": "3.0.0-beta.90",
-    "@robota-sdk/agent-interface-execution": "3.0.0-beta.90",
-    "@robota-sdk/agent-interface-session": "3.0.0-beta.90",
-    "@robota-sdk/agent-preset": "3.0.0-beta.90"
+    "@robota-sdk/agent-core": "3.0.0-beta.92",
+    "@robota-sdk/agent-framework": "3.0.0-beta.92",
+    "@robota-sdk/agent-interface-command": "3.0.0-beta.92",
+    "@robota-sdk/agent-interface-execution": "3.0.0-beta.92",
+    "@robota-sdk/agent-interface-session": "3.0.0-beta.92",
+    "@robota-sdk/agent-preset": "3.0.0-beta.92"
   },
   "devDependencies": {
     "@types/node": "^22.19.21",

package/src/provider/__tests__/optional-provider-credentials.test.ts

@@ -0,0 +1,130 @@
+import { describe, expect, it } from 'vitest';
+import type { IProviderDefinition } from '@robota-sdk/agent-core';
+import { SystemCommandExecutor } from '@robota-sdk/agent-framework';
+import type { TProviderSettingsDocument } from '@robota-sdk/agent-framework';
+import { createProviderCommandModule } from '../provider-command-module.js';
+import { scriptedContext } from './scripted-interaction.js';
+
+const localDefinition: IProviderDefinition = {
+  type: 'local',
+  defaults: { model: 'installed-model', baseURL: 'http://localhost:1234/v1' },
+  setupSteps: [
+    { key: 'baseURL', title: 'Server URL', defaultValue: 'http://localhost:1234/v1' },
+    { key: 'model', title: 'Installed model', defaultValue: 'installed-model' },
+    { key: 'apiKey', title: 'Server API key (optional)', masked: true, editOnly: true },
+  ],
+  requiresApiKey: false,
+  createProvider: () => {
+    throw new Error('not used');
+  },
+};
+
+function commands(initial: TProviderSettingsDocument = {}) {
+  let settings = initial;
+  const module = createProviderCommandModule({
+    providerDefinitions: [localDefinition],
+    env: { LOCAL_TOKEN: 'synthetic-selected-token' },
+    settings: {
+      readMergedSettings: () => settings,
+      readTargetSettings: () => settings,
+      writeTargetSettings: (next) => {
+        settings = next;
+      },
+    },
+  });
+  return {
+    executor: new SystemCommandExecutor([...(module.systemCommands ?? [])]),
+    read: () => settings,
+    module,
+  };
+}
+
+describe('optional provider credentials', () => {
+  it('adds a keyless profile after only endpoint and model answers', async () => {
+    const { executor, read } = commands();
+    const { context, requests } = scriptedContext([
+      { type: 'answer', values: [], text: '' },
+      { type: 'answer', values: [], text: '' },
+    ]);
+
+    const result = await executor.execute('provider', context, 'add local');
+
+    expect(result?.success).toBe(true);
+    expect(requests.map((request) => request.id)).toEqual([
+      'provider-setup-baseURL',
+      'provider-setup-model',
+    ]);
+    expect(read().providers?.local).toEqual({
+      type: 'local',
+      model: 'installed-model',
+      baseURL: 'http://localhost:1234/v1',
+    });
+  });
+
+  it.each([undefined, '$ENV:LOCAL_TOKEN', 'synthetic-existing-token'])(
+    'allows blank optional key editing and preserves the previous credential %s',
+    async (apiKey) => {
+      const profile = {
+        type: 'local',
+        model: 'installed-model',
+        baseURL: 'http://localhost:1234/v1',
+        ...(apiKey === undefined ? {} : { apiKey }),
+      };
+      const { executor, read } = commands({ providers: { local: profile } });
+      const { context, requests } = scriptedContext([
+        { type: 'answer', values: [], text: '' },
+        { type: 'answer', values: [], text: 'another-installed-model' },
+        { type: 'answer', values: [], text: '' },
+      ]);
+
+      const result = await executor.execute('provider', context, 'edit local');
+
+      expect(result?.success).toBe(true);
+      expect(requests[2]).toMatchObject({
+        id: 'provider-setup-apiKey',
+        masked: true,
+        allowEmpty: true,
+      });
+      expect(JSON.stringify(requests)).not.toContain('synthetic-existing-token');
+      expect(read().providers?.local).toEqual({ ...profile, model: 'another-installed-model' });
+    },
+  );
+
+  it('keeps credential management user-only and advertises the edit recovery action', () => {
+    const { module } = commands();
+    const entry = module.commandSources?.[0]?.getCommands()[0];
+    expect(entry).toMatchObject({ modelInvocable: false });
+    expect(module.systemCommands?.[0]).toMatchObject({
+      modelInvocable: false,
+      userInvocable: true,
+    });
+    expect(entry?.argumentHint).toContain('edit <profile>');
+    expect(entry?.description).toContain('credentials');
+  });
+
+  it.each(['$ENV:MISSING_SERVER_TOKEN', '$ENV:'])(
+    'leaves the working profile untouched when an edit supplies %s',
+    async (apiKey) => {
+      const initial = {
+        providers: {
+          local: {
+            type: 'local',
+            model: 'installed-model',
+            baseURL: 'http://localhost:1234/v1',
+            apiKey: 'synthetic-working-token',
+          },
+        },
+      };
+      const { executor, read } = commands(initial);
+      const { context } = scriptedContext([
+        { type: 'answer', values: [], text: '' },
+        { type: 'answer', values: [], text: '' },
+        { type: 'answer', values: [], text: apiKey },
+      ]);
+      await expect(executor.execute('provider', context, 'edit local')).rejects.toThrow(
+        'missing apiKey',
+      );
+      expect(read()).toEqual(initial);
+    },
+  );
+});

package/src/provider/provider-command-module.ts

@@ -15,6 +15,11 @@ function buildProviderSubcommands(): ICommand[] {
     { name: 'list', description: 'List provider profiles', source: 'provider' },
     { name: 'switch', description: 'Hot-swap to another provider profile', source: 'provider' },
     { name: 'add', description: 'Configure a provider profile', source: 'provider' },
+    {
+      name: 'edit',
+      description: 'Edit a profile, including optional server credentials',
+      source: 'provider',
+    },
     { name: 'test', description: 'Test provider profile', source: 'provider' },
   ];
 }
@@ -23,11 +28,13 @@ export function createProviderCommandEntry(): ICommand {
   return {
     name: 'provider',
     displayName: 'Provider Setup',
-    description: 'Manage provider profiles',
+    description:
+      'Show, configure or switch provider profiles. Suggest editing a profile when its URL, model or credentials need correction; returns profile details or the result of the change.',
     source: 'provider',
     // User-only: provider profiles hold account credentials; a credential action.
     modelInvocable: false,
-    argumentHint: 'current | list | switch <profile> | add [type] | test [profile]',
+    argumentHint:
+      'current | list | switch <profile> | add [type] | edit <profile> | test [profile]',
     subcommands: buildProviderSubcommands(),
     example: '/provider switch production',
   };

package/src/provider/provider-command-profile-operations.ts

@@ -99,6 +99,7 @@ export async function buildProviderEdit(
   let flow;
   try {
     flow = createProviderSetupFlow(profile.type, options.providerDefinitions, {
+      includeEditOnlySteps: true,
       profileName,
       setCurrent: false,
       initialValues: getProviderProfileSetupValues(profile),

package/src/provider/provider-command-setup.ts

@@ -46,7 +46,8 @@ function toProviderSetupStepRequest(
   return textAction(`provider-setup-${step.key}`, step.title, {
     description,
     placeholder,
-    allowEmpty: step.defaultValue !== undefined,
+    allowEmpty:
+      step.defaultValue !== undefined || (step.editOnly === true && step.required !== true),
     masked: step.masked,
   });
 }

package/src/provider/provider-setup-flow.ts

@@ -28,6 +28,7 @@ export interface IProviderSetupFlowState {
 }
 
 export interface IProviderSetupFlowOptions {
+  includeEditOnlySteps?: boolean;
   existingProfileNames?: readonly string[];
   initialValues?: Partial<Record<TProviderSetupField, string>>;
   profileName?: string;
@@ -58,7 +59,9 @@ export function createProviderSetupFlow(
   return {
     type,
     steps: applyProviderSetupInitialValues(
-      getProviderSetupSteps(definition),
+      getProviderSetupSteps(definition).filter(
+        (step) => step.editOnly !== true || options.includeEditOnlySteps === true,
+      ),
       options.initialValues,
     ),
     setupHelpLinks: definition.setupHelpLinks ?? [],