@robmclarty/volley 0.5.1

package/CHANGELOG.md

@@ -0,0 +1,123 @@
+# Changelog
+
+## v0.5.1 — 2026-09-16
+
+### Changed
+- **Published as `@robmclarty/volley`** — the bare `volley` name on npm belongs to an unrelated project. The binary is still `volley`; config files import `VolleyConfig` from the scoped name.
+- **License is Apache-2.0**, with the license file now in the tree, matching fascicle, checkride, plumbbob, and ridgeline; the manifest had said MIT and shipped no license text.
+- **README corrections.** Anthropic paused its programmatic-billing change on 2026-06-15 rather than shipping it, so the cost-cap section no longer claims subscription runs are metered; the trajectory viewer is named by the bin fascicle actually ships; ridgeline is linked.
+
+### Added
+- A README **Status** section saying what this is — a personal research harness at v0.x with pinned substrates and no support commitment — and where the design record lives.
+- **GitHub Actions CI**: the full checkride gate plus a build on every push to `main` and every pull request.
+
+### Internal
+- Public-facing docs, code comments, and test names no longer cite spec decisions by their internal ids. The specs under `research/` and the build logs under `.plumbbob/` remain the decision record, ids included.
+- The `/version` release skill no longer claims volley has no remote. It still marks a release with a bare `vX.Y.Z` commit and leaves pushing to the operator, and its verify note names the current checkride slots.
+
+## v0.5.0 — 2026-09-16
+
+### Changed
+- **`volley matrix` row and run-state shapes.** A row is now a seat aggregated over its attempts (`runs`, `converged`, `mean_iterations`, `mean_wall_clock_ms`, `mean_cost_usd`, `reason`, plus every `attempt`) rather than one run's fields, and per-attempt state moved from `.volley-matrix/<builder>__<critic>/summary.json` to `…/run-NN/summary.json`. Both `--json` consumers and on-disk readers of the v0.4.1 layout need updating.
+
+### Added
+- **volley sees what the builder changed, and says so.** Every iteration now diffs the build root against a baseline captured before the first iteration, and hands the result to the two places that were flying blind. The **critic prompt** carries the changed-path list, so a critic reviews a change instead of re-reading a tree the deterministic check already blessed (paths and statuses only — never diff hunks, so a 32k-context local critic's prompt stays bounded). The **run summary** gains `comparison.gate_edits`, and each iteration archive carries its own change set.
+- **`volley matrix --repeat N`.** Each seat now runs N times (default 1) and the row reports a pass *rate* over those attempts, because one run is the only thing n=1 can honestly report on: local runs are stochastic, so a single sample supports a hard failure and nothing else — not iterations-to-converge, not wall clock. Each aggregate names the population it is over: `iters` averages the converged attempts only, `wall` and `cost` average every attempt that reported one, and salvage is a ratio of totals rather than a mean of ratios. Every attempt's run state is kept (`.volley-matrix/<builder>__<critic>/run-NN/summary.json`), and the whole sweep is written to `.volley-matrix/matrix.json`.
+- **The matrix table says *why* a seat fell off.** `budget_exhausted` is a status, not a diagnosis. A row's new `why` column names the failing check slots, the criteria the critic still judged unmet, a cost cap, a gate edit, or the error that broke the run; `flags` separates what qualifies a pass (`deg` for a degraded critic, `gate` for a builder that edited the gate) from what explains a failure. Mean cost per run joins the table, and every attempt's full detail — status, verdict, failing slots, unmet criteria, gate edits — is in the `--json` aggregate.
+- **`comparison.unmet_criteria` in the run summary**: what the critic still judged unmet when the run stopped, verbatim, so a non-converged run says what it was missing rather than only that it stopped. Archived per iteration too.
+- **Gate-edit detection.** Changed paths matching the *gate* — the tests, fixtures, and check configuration that decide whether the work passes — are called out to the critic, warned about on stderr, and recorded in the summary. This mechanizes the by-hand verification `research/reckon-local-run-finding.md` recommends making routine: a green check plus an empty `gate_edits` is worth more than a green check alone, because a builder can also pass by editing the test. Reported, not refused, by default (plenty of tasks are legitimately about the tests); `--fail-on-gate-edit` halts the run with the new **exit 8** instead, and beats success rather than losing to it. `--gate-paths` / `gate_paths` replaces the built-in pattern list, and `--dry-run` predicts the posture — including a warning that the refusal cannot fire outside a git repository.
+
+### Fixed
+- **`volley --version` reports the real version.** It was a literal in `src/cli.ts`, frozen at `0.2.0` since v0.2 while `pnpm version` bumped only `package.json`; it now reads the manifest at startup, so it cannot drift from a release again. The fixing commit filed this under v0.4.1 below, but it landed after that release; v0.5.0 is the first version that ships it.
+
+### Internal
+- `research/reckon-local-run-finding.md`: the first multi-module, all-local run finding — four modules with a real dependency order and a `node --test` gate — and the by-hand verification that gate-edit detection now automates.
+- Change-detection tests pin the `--worktree` seam (the diff runs against the worktree, not the workspace) and the exact promise the gate-edit warning makes; preflight tests cover the `--dry-run` gate-edit posture line.
+
+## v0.4.1 — 2026-07-24
+
+### Added
+- **`volley matrix`**: sweep builder×critic model combos serially over one otherwise-fixed config and aggregate every run's `comparison` block into a single table (per-combo state under `.volley-matrix/<builder>__<critic>/summary.json`; `--json` for the aggregate). Serial by design — the local providers share one GPU, so parallel combos would thrash the model loader. A combo that runs without converging is a *result* row; the sweep exits nonzero only when a combo yields no summary at all.
+- **Critic-seat canary in `--dry-run`**: for a local critic, one tiny $0 generate through the real critic tool wiring before any builder spend. A degradable death warns and predicts `critic_degraded`; only a would-fail-even-degraded combo exits 5, named model×seat. The `claude_cli` critic path never runs it.
+- **`--discard-worktree`**: throw a `--worktree` run's effects away at teardown instead of keeping them on the run branch — "isolate the effects, I only want the verdicts". `volley matrix` forces it for every seat, so a sweep leaves neither a branch nor a squash commit per combo. Refused without `--worktree`; `--git` still wins, so `--worktree --git` integrates exactly as before.
+- **Two example families for probing a local model's real ceiling**: `examples/essayist` (a non-code task with a custom critic prompt, rubric, and JS check gate) and `examples/ladder` (seven capability rungs from greenfield through brownfield bugfix and cross-file refactor, plus an online-only dependency-wrangling run recipe).
+- An upstream-ready write-up of the Ollama qwen tool-call parser failure that kills `qwen3.6` in the critic seat (`research/ollama-qwen-parser-issue.md`).
+
+### Changed
+- **A local critic now degrades instead of dying.** A provider stream error is retried once (recorded on the critic record as `retries` / `retry_cause_kind`), and a critique that keeps dying with tools attached falls back to a tool-less verdict grounded in the criteria, the raw check artifacts, and a workspace file inventory. A fallback verdict is *always* marked `critic_degraded` — in the iteration summary, the run's `comparison` block, and the matrix table — so a shallower critique never passes silently as a full one.
+
+### Fixed
+- **`volley --version` reports the real version.** It was a literal in `src/cli.ts`, frozen at `0.2.0` since v0.2 while `pnpm version` bumped only `package.json`; it now reads the manifest at startup (from `src/` under tsx and from `dist/` in the published package alike), so it cannot drift from a release again.
+- **`--worktree` without `--git` no longer destroys a successful run's work.** With `worktree: true` and git checkpoints off (the default), a fully green run — check passed, critic approved — ended in `git branch -D` plus a forced worktree removal: the builder's uncommitted work deleted, the workspace untouched, nothing said before or after. Teardown now *salvages* that case instead — it commits the worktree's state onto the run branch (`volley/<run id>`), keeps the branch, removes only the checkout, and reports the branch as `salvaged_branch` in `.volley/summary.json` and `--json` output, so the work is recoverable with `git switch` / `git cherry-pick`. If the salvage commit itself cannot land (no git identity, a stale index lock), the checkout is left standing rather than deleted. Runs that did not converge, and `--worktree --git` runs whose work was squash-merged, still discard wholesale; the documented integrate path is unchanged.
+- **A `--worktree` run's fate is now predicted before any model spend.** `--dry-run` and run start each print one line saying what a successful run will do with its effects — squash-merge onto the workspace branch (`--git`), leave them on the run branch (`--worktree` alone; a warning, since nothing is integrated), or throw them away (`--discard-worktree`) — alongside the existing critic-seat canary and `num_ctx` predictions.
+
+### Internal
+- README refreshed to v0.4.0 truth, and the matrix example's `--config` path corrected.
+
+## v0.4.0 — 2026-07-17
+
+### Added
+- **Sandboxed local builds.** A local-model builder now runs as the whole volley process inside one hardened Docker container that volley *detects* it is inside (the `VOLLEY_CONTAINED=1` marker its image bakes in — volley does not start the container itself) over a per-run git worktree (`--worktree`) — its effects land on a throwaway phase branch and squash-merge onto the workspace only on a successful `--worktree --git` run. Ships a default image and `Dockerfile` (`--sandbox-image` / `VOLLEY_SANDBOX_IMAGE` to override), default-deny network egress with a host-gateway allowlist, and a `--dry-run` preflight that verifies the toolchain, worktree, and host LLM endpoint before any model spend (exit 5 on failure). `claude_cli` builds stay on the host, Docker-free.
+- **v3 comparison examples.** `examples/all-claude` and `examples/all-local` run an identical task, criteria, check gate, and caps so their `.volley/summary.json` `comparison` block (iterations-to-converge, wall-clock, cost, verdict, check trajectory, local salvage rate, transport) isolates model-vs-transport; the finding is written up under `research/`.
+
+### Changed
+- **Upgraded to fascicle 0.9.5 on AI SDK v7** (`ai@^7`, `ai-sdk-ollama@^4`), moving the local-provider peer set forward together on the `ai_sdk` transport (the native Ollama transport is documented as a one-line future flip). Resolves the v0.3.1 local-builder peer-major mismatch by construction.
+- **A require-containment gate for local builders:** a local builder is admitted only when volley detects it is running inside its container (`VOLLEY_CONTAINED=1`) or `--allow-unsandboxed-builder` (`VOLLEY_ALLOW_UNSANDBOXED_BUILDER=1`) is set; `claude_cli` is exempt. A *contained* `claude_cli` role must use API-key auth (`VOLLEY_AUTH_MODE=api_key`) — its subscription/OAuth token does not survive containerization.
+- Upgraded checkride 0.2.1 → 0.4.1 (atomic summary writes, stale-artifact clearing, and a `checks_run` vacuous-green signal).
+
+### Fixed
+- `checkride --json` parsing now tolerates pnpm 11's dep-verify line printed ahead of the JSON, with a `.check/summary.json` fallback — the check no longer dies with "unparseable stdout."
+
+### Internal
+- oxlint-tsgolint bumped to 0.22.1 to satisfy oxlint's peer floor.
+
+## v0.3.1 — 2026-07-10
+
+### Fixed
+- The default Ollama base URL is now the server root (`http://localhost:11434`):
+  the previous `…/api` default made `ai-sdk-ollama` (which appends `/api/…`
+  itself) request `/api/api/chat` and 404 on every call, breaking both local
+  roles out of the box. A trailing `/api` on `VOLLEY_OLLAMA_URL` is stripped
+  for compatibility with the old documented value.
+- Pre-load an Ollama model at builder start (and before a local critic's first
+  verdict): a cold multi-GB model load could exceed the provider's in-request
+  first-byte timeout and kill the run minutes in with an opaque
+  `stream interrupted: fetch failed`.
+- Document that the `ai-sdk-ollama` peer must match fascicle's declared major
+  (`^3` today — a bare `pnpm add ai-sdk-ollama` pulls v4, which targets a newer
+  AI SDK spec and hard-fails at the first call), and ship it as a devDependency
+  so the local live smoke test runs from a fresh checkout.
+
+### Internal
+- Name every checkride slot that actually runs (`types`, `lint`, `struct`,
+  `dead`, `links`) in `checkride.config.json`, not just the three that were
+  previously listed — the config file now matches the pipeline reality
+  instead of relying on silent tool detection.
+
+## v0.3.0 — 2026-07-10
+
+### Added
+- Run the builder on a local model (Ollama or LM Studio) with `--builder-provider ollama|lmstudio`. A local builder brings no built-in tools, so volley supplies its own workspace tool loop — read/search/list, `write_file`, `edit_file` (exact-match-or-fail), a stateless `bash`, a readability-based `fetch` with SSRF protection, and an explicit `finish` — bounded by `--builder-max-steps` (default 50) per iteration. The produced workspace goes to check + critic exactly like a Claude Code CLI build.
+- Refuse a local builder by default: it runs a real host `bash` with no sandbox yet, so volley stops before any model spend unless you opt in with `--allow-unsandboxed-builder` (or `VOLLEY_ALLOW_UNSANDBOXED_BUILDER=1`), which prints a one-time warning.
+- Warn at builder start when an Ollama model's context window is detectably too small (`num_ctx` below ~16k) — the most common cause of a local model silently ignoring its tools.
+- Record local-builder health per iteration: a `max_steps` cutoff is surfaced as a warning rather than an error, and the run summary carries the loop's `finish_reason` and the rate of tool calls salvaged from unstructured model output.
+- README `Local builder` guide and a `VOLLEY_LIVE`-gated live smoke test for the local path.
+
+### Internal
+- Enforce the spec's architecture decisions as ast-grep rules (create-engine confinement, no deep-sibling imports, no classes).
+- Pin dependencies to exact versions; upgrade checkride to 0.2.1 and flesh out its config for the v3-s1 build.
+
+## v0.2.1 — initial release
+
+### Added
+- Builder/critic loop CLI: runs a full agentic Claude Code CLI session as the builder, gates on a deterministic check pipeline (checkride auto-detected, a custom command, or none), then requires a schema-validated critic verdict before converging.
+- Local critic support — point `--critic-provider` at Ollama or LM Studio to run the read-only critic on a free local model (workspace-scoped read/search/list tools, `$0` cost reporting) while the builder stays on Claude.
+- Cost and iteration caps (`--max-cost-usd`, `--max-iterations`), a stable exit-code contract, and `volley resume <run-id>` to continue an interrupted run.
+- Pluggable critic personas (`reviewer`, `optimizer`, `researcher`, or a custom prompt file) and a TypeScript config-file surface (`VolleyConfig`).
+- `--git` flag to commit after each phase; `.volley/` run artifacts (config, summary, trajectory, per-iteration archives) for every run.
+- `--json`, `--verbose`, and `--quiet` output modes for composing volley under other harnesses.
+
+### Internal
+- Built on fascicle (loop primitive, usage/cost accounting, trajectory logging) and checkride (deterministic check pipeline); both pinned to fascicle 0.8.16 / checkride 0.2.0.
+- Config, CLI, and engine plumbing landed for a future local *builder* provider (`ollama`/`lmstudio`); not yet wired into execution.
+- Unit and integration test suite, with opt-in live smoke tests (`VOLLEY_LIVE=1`) against the real Claude CLI and checkride.

package/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for describing the origin of the Work and
+      reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may accept and charge a
+      fee for acceptance of support, warranty, indemnity, or other liability
+      obligations and/or rights consistent with this License. However, in
+      accepting such obligations, You may act only on Your own behalf
+      and on Your sole responsibility, not on behalf of any other
+      Contributor, and only if You agree to indemnify, defend, and hold
+      each Contributor harmless for any liability incurred by, or claims
+      asserted against, such Contributor by reason of your accepting any
+      such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright 2026 Rob McLarty
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+   implied. See the License for the specific language governing
+   permissions and limitations under the License.