@rnmapbox/maps 10.2.7 → 10.2.8

package/ios/RNMBX/RNMBXCustomLocationProvider.swift

@@ -3,15 +3,15 @@ import MapboxMaps
 let TAG = "RNMBXCustomLocationProvider"
 
 @objc
-public class RNMBXCustomLocationProvider: UIView, RNMBXMapComponent {
+public class RNMBXCustomLocationProvider: UIView, RNMBXMapAndMapViewComponent {
   var map: RNMBXMapView? = nil
-  
+
   let changes : PropertyChanges<RNMBXCustomLocationProvider> = PropertyChanges()
-  
+
   enum Property: String {
     case coordinate
     case heading
-    
+
     func apply(locationProvider: RNMBXCustomLocationProvider) {
       switch self {
         case .coordinate: locationProvider.applyCoordinate()
@@ -19,61 +19,55 @@ public class RNMBXCustomLocationProvider: UIView, RNMBXMapComponent {
       }
     }
   }
-  
+
   @objc
   public var coordinate: [Double] = [] {
     didSet { changed(.coordinate) }
   }
-    
+
   @objc
   public var heading: NSNumber = 0.0 {
     didSet { changed(.heading) }
   }
-  
+
   func changed(_ property: Property) {
     changes.add(name: property.rawValue, update: property.apply)
   }
-  
+
   @objc
   override public func didSetProps(_ props: [String]) {
     if customLocationProvider != nil {
       changes.apply(self)
     }
   }
-  
+
   var customLocationProvider: CustomLocationProvider? = nil
   #if RNMBX_11
   #else
   var defaultLocationProvider: LocationProvider?
   #endif
 
-  public func addToMap(_ map: RNMBXMapView, style: Style) {
+  public func addToMap(_ map: RNMBXMapView, mapView: MapView, style: Style) {
     self.map = map
-    if let mapView = map.mapView {
-      installCustomeLocationProviderIfNeeded(mapView: mapView)
-      changes.apply(self)
-    }
+    installCustomeLocationProviderIfNeeded(mapView: mapView)
+    changes.apply(self)
   }
-  
+
   private func applyCoordinate() {
     updateCoordinate(latitude: coordinate[1], longitude: coordinate[0])
   }
-  
+
   private func applyHeading() {
     updateHeading(heading: heading.doubleValue)
   }
-  
-  public func removeFromMap(_ map: RNMBXMapView, reason: RemovalReason) -> Bool {
-    if let mapView = map.mapView {
-      removeCustomLocationProvider(mapView: mapView)
-    }
+
+  public func removeFromMap(_ map: RNMBXMapView, mapView: MapView, reason: RemovalReason) -> Bool {
+    removeCustomLocationProvider(mapView: mapView)
     self.map = nil
     return true
   }
 
-  public func waitForStyleLoad() -> Bool {
-    false
-  }
+  // Uses default implementation from RNMBXMapComponentProtocol extension (returns false)
 }
 
 #if RNMBX_11

package/ios/RNMBX/RNMBXImageModule.h

@@ -1,5 +1,6 @@
 #import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
+#import "RNMBXViewResolver.h"
 
 #ifdef RCT_NEW_ARCH_ENABLED
 #import "rnmapbox_maps_specs.h"
@@ -9,9 +10,9 @@
 
 @interface RNMBXImageModule : NSObject
 #ifdef RCT_NEW_ARCH_ENABLED
-<NativeRNMBXImageModuleSpec>
+<NativeRNMBXImageModuleSpec, RNMBXViewResolverDelegate>
 #else
-<RCTBridgeModule>
+<RCTBridgeModule, RNMBXViewResolverDelegate>
 #endif
 
 @end

package/ios/RNMBX/RNMBXImageModule.mm

@@ -27,22 +27,14 @@ RCT_EXPORT_MODULE();
 
 - (void)withImage:(nonnull NSNumber*)viewRef block:(void (^)(RNMBXImage *))block reject:(RCTPromiseRejectBlock)reject methodName:(NSString *)methodName
 {
-#ifdef RCT_NEW_ARCH_ENABLED
-    [self.viewRegistry_DEPRECATED addUIBlock:^(RCTViewRegistry *viewRegistry) {
-        RNMBXImageComponentView *componentView = [self.viewRegistry_DEPRECATED viewForReactTag:viewRef];
-        RNMBXImage *view = componentView.contentView;
-
-#else
-    [self.bridge.uiManager
-     addUIBlock:^(RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-        RNMBXImage *view = [uiManager viewForReactTag:viewRef];
-#endif // RCT_NEW_ARCH_ENABLED
-        if (view != nil) {
-           block(view);
-        } else {
-            reject(methodName, [NSString stringWithFormat:@"Unknown reactTag: %@", viewRef], nil);
-        }
-    }];
+    [RNMBXViewResolver withViewRef:viewRef
+                          delegate:self
+                     expectedClass:[RNMBXImage class]
+                             block:^(UIView *view) {
+                                 block((RNMBXImage *)view);
+                             }
+                            reject:reject
+                        methodName:methodName];
 }
 
 

package/ios/RNMBX/RNMBXImages.swift

@@ -74,11 +74,8 @@ open class RNMBXImages : UIView, RNMBXMapComponent {
   }
   
   // MARK: - RNMBXMapComponent
+  // Uses default implementation from RNMBXMapComponentProtocol extension (returns false)
 
-  public func waitForStyleLoad() -> Bool {
-    return false
-  }
-  
   public func addToMap(_ map: RNMBXMapView, style: Style) {
     self.style = style
     imageManager = map.imageManager

package/ios/RNMBX/RNMBXInteractiveElement.swift

@@ -1,38 +1,43 @@
 import MapboxMaps
 
 @objc
-public class RNMBXInteractiveElement : UIView, RNMBXMapComponent {
+public class RNMBXInteractiveElement : UIView, RNMBXMapAndMapViewComponent {
   weak var map : RNMBXMapView? = nil
+  weak var mapView : MapView? = nil
 
   static let hitboxDefault = 44.0
 
   @objc public var draggable: Bool = false
-  
+
   @objc public var hasPressListener: Bool = false
-  
+
   @objc public var hitbox : [String:NSNumber] = [
     "width": NSNumber(value: hitboxDefault),
     "height": NSNumber(value: hitboxDefault)
   ]
-  
+
   @objc public var id: String! = nil {
     willSet {
       if id != nil && newValue != id {
         Logger.log(level:.warn, message: "Changing id from: \(optional: id) to \(optional: newValue), changing of id is not supported")
-        if let map = map { removeFromMap(map, reason: .ComponentChange) }
+        if let map = map, let mapView = mapView {
+          removeFromMap(map, mapView: mapView, reason: .ComponentChange)
+        }
       }
     }
     didSet {
       if oldValue != nil && oldValue != id {
-        if let map = map { addToMap(map, style: map.mapboxMap.style) }
+        if let map = map, let mapView = mapView {
+          addToMap(map, mapView: mapView, style: mapView.mapboxMap.style)
+        }
       }
     }
   }
-  
+
   @objc public var onDragStart: RCTBubblingEventBlock? = nil
-  
+
   @objc public var onPress: RCTBubblingEventBlock? = nil
-  
+
   func getLayerIDs() -> [String] {
     return []
   }
@@ -40,24 +45,26 @@ public class RNMBXInteractiveElement : UIView, RNMBXMapComponent {
   func isDraggable() -> Bool {
     return draggable
   }
-  
+
   func isTouchable() -> Bool {
     return hasPressListener
   }
-  
-  // MARK: - RNMBXMapComponent
-  public func addToMap(_ map: RNMBXMapView, style: Style) {
+
+  // MARK: - RNMBXMapAndMapViewComponent
+  public func addToMap(_ map: RNMBXMapView, mapView: MapView, style: Style) {
     if (self.id == nil) {
       Logger.log(level: .error, message: "id is required on \(self) but not specified")
     }
     self.map = map
+    self.mapView = mapView
   }
 
-  public func removeFromMap(_ map: RNMBXMapView, reason: RemovalReason) -> Bool {
+  public func removeFromMap(_ map: RNMBXMapView, mapView: MapView, reason: RemovalReason) -> Bool {
     self.map = nil
+    self.mapView = nil
     return true
   }
-  
+
   public func waitForStyleLoad() -> Bool {
     return true
   }

package/ios/RNMBX/RNMBXMapView.swift

@@ -60,11 +60,11 @@ public class RNMBXMapViewFactory {
 }
 
 class FeatureEntry {
-  let feature: RNMBXMapComponent
+  let feature: AnyObject  // Can be RNMBXMapComponent or RNMBXMapAndMapViewComponent
   let view: UIView
   var addedToMap: Bool = false
 
-  init(feature:RNMBXMapComponent, view: UIView, addedToMap: Bool = false) {
+  init(feature: AnyObject, view: UIView, addedToMap: Bool = false) {
     self.feature = feature
     self.view = view
     self.addedToMap = addedToMap
@@ -269,7 +269,27 @@ open class RNMBXMapView: UIView, RCTInvalidating {
 
   @objc public func addToMap(_ subview: UIView) {
     withMapView { mapView in
-      if let mapComponent = subview as? RNMBXMapComponent {
+      // Check for RNMBXMapAndMapViewComponent first (requires MapView)
+      if let mapAndMapViewComponent = subview as? RNMBXMapAndMapViewComponent {
+        let style = mapView.mapboxMap.style
+        var addToMap = false
+        if mapAndMapViewComponent.waitForStyleLoad() {
+          if (self.styleLoadWaiters.hasInited()) {
+            addToMap = true
+          }
+        } else {
+          addToMap = true
+        }
+
+        let entry = FeatureEntry(feature: mapAndMapViewComponent, view: subview, addedToMap: false)
+        if (addToMap) {
+          mapAndMapViewComponent.addToMap(self, mapView: mapView, style: style)
+          entry.addedToMap = true
+        }
+        self.features.append(entry)
+      }
+      // Fallback to RNMBXMapComponent (doesn't require MapView)
+      else if let mapComponent = subview as? RNMBXMapComponent {
         let style = mapView.mapboxMap.style
         var addToMap = false
         if mapComponent.waitForStyleLoad() {
@@ -296,7 +316,26 @@ open class RNMBXMapView: UIView, RCTInvalidating {
   }
 
   @objc public func removeFromMap(_ subview: UIView) {
-    if let mapComponent = subview as? RNMBXMapComponent {
+    // Check for RNMBXMapAndMapViewComponent first (requires MapView)
+    if let mapAndMapViewComponent = subview as? RNMBXMapAndMapViewComponent {
+      var entryIndex = features.firstIndex { $0.view == subview }
+      if let entryIndex = entryIndex {
+        var entry = features[entryIndex]
+        if (entry.addedToMap) {
+          // mapView should always be non-nil here if our invariants hold
+          guard let mapView = _mapView else {
+            Logger.error("RNMBXMapView.removeFromMap: CRITICAL - mapView is nil for component that requires it: \(type(of: subview))")
+            features.remove(at: entryIndex)
+            return
+          }
+          mapAndMapViewComponent.removeFromMap(self, mapView: mapView, reason: .OnDestroy)
+          entry.addedToMap = false
+        }
+        features.remove(at: entryIndex)
+      }
+    }
+    // Fallback to RNMBXMapComponent (doesn't require MapView)
+    else if let mapComponent = subview as? RNMBXMapComponent {
       var entryIndex = features.firstIndex { $0.view == subview }
       if let entryIndex = entryIndex {
         var entry = features[entryIndex]
@@ -842,16 +881,39 @@ open class RNMBXMapView: UIView, RCTInvalidating {
   private func removeAllFeaturesFromMap(reason: RemovalReason) {
     features.forEach { entry in
       if (entry.addedToMap) {
-        entry.feature.removeFromMap(self, reason: reason)
+        // Handle RNMBXMapAndMapViewComponent
+        if let mapAndMapViewComponent = entry.feature as? RNMBXMapAndMapViewComponent {
+          guard let mapView = _mapView else {
+            Logger.error("RNMBXMapView.removeAllFeaturesFromMap: mapView is nil")
+            return
+          }
+          mapAndMapViewComponent.removeFromMap(self, mapView: mapView, reason: reason)
+        }
+        // Handle RNMBXMapComponent
+        else if let mapComponent = entry.feature as? RNMBXMapComponent {
+          mapComponent.removeFromMap(self, reason: reason)
+        }
         entry.addedToMap = false
       }
     }
   }
 
   private func addFeaturesToMap(style: Style) {
+    guard let mapView = _mapView else {
+      Logger.error("RNMBXMapView.addFeaturesToMap: mapView is nil")
+      return
+    }
+
     features.forEach { entry in
       if (!entry.addedToMap) {
-        entry.feature.addToMap(self, style: style)
+        // Handle RNMBXMapAndMapViewComponent
+        if let mapAndMapViewComponent = entry.feature as? RNMBXMapAndMapViewComponent {
+          mapAndMapViewComponent.addToMap(self, mapView: mapView, style: style)
+        }
+        // Handle RNMBXMapComponent
+        else if let mapComponent = entry.feature as? RNMBXMapComponent {
+          mapComponent.addToMap(self, style: style)
+        }
         entry.addedToMap = true
       }
     }

package/ios/RNMBX/RNMBXNativeUserLocation.swift

@@ -1,7 +1,7 @@
 import MapboxMaps
 
 @objc
-public class RNMBXNativeUserLocation: UIView, RNMBXMapComponent {
+public class RNMBXNativeUserLocation: UIView, RNMBXMapAndMapViewComponent {
   weak var map : RNMBXMapView! = nil
   var imageManager: ImageManager? = nil
   
@@ -200,19 +200,19 @@ public class RNMBXNativeUserLocation: UIView, RNMBXMapComponent {
     }
   }
 
-  public func addToMap(_ map: RNMBXMapView, style: Style) {
+  public func addToMap(_ map: RNMBXMapView, mapView: MapView, style: Style) {
     self.map = map
- 
+
     _fetchImages(map)
     _apply()
   }
 
-  public func removeFromMap(_ map: RNMBXMapView, reason: RemovalReason) -> Bool {
-    if let location = map.mapView.location {
+  public func removeFromMap(_ map: RNMBXMapView, mapView: MapView, reason: RemovalReason) -> Bool {
+    if  let location = mapView.location {
       location.options.puckType = nil
       location.options.puckType = .none
     } else {
-      Logger.error("RNMBXNativeUserLocation.removeFromMap: location is nil")
+      Logger.error("[RNMBXNativeUserLocation] removeFromMap, location is null")
     }
     removeSubscriptions()
     self.map = nil

package/ios/RNMBX/RNMBXPointAnnotation.swift

@@ -248,18 +248,16 @@ public class RNMBXPointAnnotation : RNMBXInteractiveElement {
       }
     }
   
-  // MARK: - RNMBXMapComponent
-  
-  public override func addToMap(_ map: RNMBXMapView, style: Style) {
-    super.addToMap(map, style: style)
-    self.map = map
+  // MARK: - RNMBXMapAndMapViewComponent
+
+  public override func addToMap(_ map: RNMBXMapView, mapView: MapView, style: Style) {
+    super.addToMap(map, mapView: mapView, style: style)
     addIfPossible()
   }
 
-  public override func removeFromMap(_ map: RNMBXMapView, reason: RemovalReason) -> Bool {
+  public override func removeFromMap(_ map: RNMBXMapView, mapView: MapView, reason: RemovalReason) -> Bool {
     removeIfAdded()
-    self.map = nil
-    return true
+    return super.removeFromMap(map, mapView: mapView, reason: reason)
   }
   
   // MARK: - RNMBXInteractiveElement

package/ios/RNMBX/RNMBXPointAnnotationModule.h

@@ -1,5 +1,6 @@
 #import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
+#import "RNMBXViewResolver.h"
 
 #ifdef RCT_NEW_ARCH_ENABLED
 #import "rnmapbox_maps_specs.h"
@@ -9,9 +10,9 @@
 
 @interface RNMBXPointAnnotationModule : NSObject
 #ifdef RCT_NEW_ARCH_ENABLED
-<NativeRNMBXPointAnnotationModuleSpec>
+<NativeRNMBXPointAnnotationModuleSpec, RNMBXViewResolverDelegate>
 #else
-<RCTBridgeModule>
+<RCTBridgeModule, RNMBXViewResolverDelegate>
 #endif
 
 @end

package/ios/RNMBX/RNMBXPointAnnotationModule.mm

@@ -27,22 +27,14 @@ RCT_EXPORT_MODULE();
 
 - (void)withPointAnnotation:(nonnull NSNumber*)viewRef block:(void (^)(RNMBXPointAnnotation *))block reject:(RCTPromiseRejectBlock)reject methodName:(NSString *)methodName
 {
-#ifdef RCT_NEW_ARCH_ENABLED
-    [self.viewRegistry_DEPRECATED addUIBlock:^(RCTViewRegistry *viewRegistry) {
-        RNMBXPointAnnotationComponentView *componentView = [self.viewRegistry_DEPRECATED viewForReactTag:viewRef];
-        RNMBXPointAnnotation *view = componentView.contentView;
-        
-#else
-    [self.bridge.uiManager
-     addUIBlock:^(RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) {
-        RNMBXPointAnnotation *view = [uiManager viewForReactTag:viewRef];
-#endif // RCT_NEW_ARCH_ENABLED
-        if (view != nil) {
-           block(view);
-        } else {
-            reject(methodName, [NSString stringWithFormat:@"Unknown reactTag: %@", viewRef], nil);
-        }
-    }];
+    [RNMBXViewResolver withViewRef:viewRef
+                          delegate:self
+                     expectedClass:[RNMBXPointAnnotation class]
+                             block:^(UIView *view) {
+                                 block((RNMBXPointAnnotation *)view);
+                             }
+                            reject:reject
+                        methodName:methodName];
 }
 
 

package/ios/RNMBX/RNMBXRasterArraySource.swift

@@ -0,0 +1,47 @@
+#if RNMBX_11
+@_spi(Experimental) import MapboxMaps
+
+@objc
+public class RNMBXRasterArraySource : RNMBXSource {
+  typealias SourceType = RasterArraySource
+
+  @objc public var url: String? = nil
+
+  @objc public var tileUrlTemplates: [String]? = nil
+
+  @objc public var minZoomLevel: NSNumber?
+  @objc public var maxZoomLevel: NSNumber?
+  @objc public var tileSize: NSNumber?
+
+  @objc public var sourceBounds: [NSNumber]? = nil
+
+  override func makeSource() -> Source
+  {
+    // Note: tileSize and bounds are read-only after initialization in RasterArraySource
+    // They can only be set via the constructor or are derived from the source
+    var result = RasterArraySource(id: self.id)
+    if let url = url {
+      result.url = url
+    } else {
+      result.tiles = tileUrlTemplates
+    }
+
+    if let minZoomLevel = minZoomLevel {
+      result.minzoom = minZoomLevel.doubleValue
+    }
+
+    if let maxZoomLevel = maxZoomLevel {
+      result.maxzoom = maxZoomLevel.doubleValue
+    }
+
+    // Note: tileSize and bounds are read-only properties in RasterArraySource
+    // and cannot be set directly. They are either:
+    // - Derived from the TileJSON when using url
+    // - Use default values when using tiles
+    // If custom values are needed, they should be included in the TileJSON response
+
+    return result
+  }
+
+}
+#endif

package/ios/RNMBX/RNMBXRasterArraySourceComponentView.h

@@ -0,0 +1,15 @@
+#ifdef RCT_NEW_ARCH_ENABLED
+
+#import <UIKit/UIKit.h>
+
+#import <React/RCTUIManager.h>
+#import <React/RCTViewComponentView.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface RNMBXRasterArraySourceComponentView : RCTViewComponentView
+@end
+
+NS_ASSUME_NONNULL_END
+
+#endif // RCT_NEW_ARCH_ENABLED