@rnmapbox/maps 10.1.0-beta.23 → 10.1.0-beta.25

package/android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXModelLayerManagerDelegate.java

@@ -0,0 +1,65 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaDelegate.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import androidx.annotation.Nullable;
+import com.facebook.react.bridge.DynamicFromObject;
+import com.facebook.react.uimanager.BaseViewManagerDelegate;
+import com.facebook.react.uimanager.BaseViewManagerInterface;
+
+public class RNMBXModelLayerManagerDelegate<T extends View, U extends BaseViewManagerInterface<T> & RNMBXModelLayerManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
+  public RNMBXModelLayerManagerDelegate(U viewManager) {
+    super(viewManager);
+  }
+  @Override
+  public void setProperty(T view, String propName, @Nullable Object value) {
+    switch (propName) {
+      case "sourceID":
+        mViewManager.setSourceID(view, new DynamicFromObject(value));
+        break;
+      case "existing":
+        mViewManager.setExisting(view, new DynamicFromObject(value));
+        break;
+      case "filter":
+        mViewManager.setFilter(view, new DynamicFromObject(value));
+        break;
+      case "aboveLayerID":
+        mViewManager.setAboveLayerID(view, new DynamicFromObject(value));
+        break;
+      case "belowLayerID":
+        mViewManager.setBelowLayerID(view, new DynamicFromObject(value));
+        break;
+      case "layerIndex":
+        mViewManager.setLayerIndex(view, new DynamicFromObject(value));
+        break;
+      case "maxZoomLevel":
+        mViewManager.setMaxZoomLevel(view, new DynamicFromObject(value));
+        break;
+      case "minZoomLevel":
+        mViewManager.setMinZoomLevel(view, new DynamicFromObject(value));
+        break;
+      case "sourceLayerID":
+        mViewManager.setSourceLayerID(view, new DynamicFromObject(value));
+        break;
+      case "slot":
+        mViewManager.setSlot(view, new DynamicFromObject(value));
+        break;
+      case "id":
+        mViewManager.setId(view, new DynamicFromObject(value));
+        break;
+      case "reactStyle":
+        mViewManager.setReactStyle(view, new DynamicFromObject(value));
+        break;
+      default:
+        super.setProperty(view, propName, value);
+    }
+  }
+}

package/android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXModelLayerManagerInterface.java

@@ -0,0 +1,28 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaInterface.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import com.facebook.react.bridge.Dynamic;
+
+public interface RNMBXModelLayerManagerInterface<T extends View> {
+  void setSourceID(T view, Dynamic value);
+  void setExisting(T view, Dynamic value);
+  void setFilter(T view, Dynamic value);
+  void setAboveLayerID(T view, Dynamic value);
+  void setBelowLayerID(T view, Dynamic value);
+  void setLayerIndex(T view, Dynamic value);
+  void setMaxZoomLevel(T view, Dynamic value);
+  void setMinZoomLevel(T view, Dynamic value);
+  void setSourceLayerID(T view, Dynamic value);
+  void setSlot(T view, Dynamic value);
+  void setId(T view, Dynamic value);
+  void setReactStyle(T view, Dynamic value);
+}

package/android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXModelsManagerDelegate.java

@@ -0,0 +1,32 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaDelegate.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import androidx.annotation.Nullable;
+import com.facebook.react.bridge.DynamicFromObject;
+import com.facebook.react.uimanager.BaseViewManagerDelegate;
+import com.facebook.react.uimanager.BaseViewManagerInterface;
+
+public class RNMBXModelsManagerDelegate<T extends View, U extends BaseViewManagerInterface<T> & RNMBXModelsManagerInterface<T>> extends BaseViewManagerDelegate<T, U> {
+  public RNMBXModelsManagerDelegate(U viewManager) {
+    super(viewManager);
+  }
+  @Override
+  public void setProperty(T view, String propName, @Nullable Object value) {
+    switch (propName) {
+      case "models":
+        mViewManager.setModels(view, new DynamicFromObject(value));
+        break;
+      default:
+        super.setProperty(view, propName, value);
+    }
+  }
+}

package/android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXModelsManagerInterface.java

@@ -0,0 +1,17 @@
+/**
+* This code was generated by [react-native-codegen](https://www.npmjs.com/package/react-native-codegen).
+*
+* Do not edit this file as changes may cause incorrect behavior and will be lost
+* once the code is regenerated.
+*
+* @generated by codegen project: GeneratePropsJavaInterface.js
+*/
+
+package com.facebook.react.viewmanagers;
+
+import android.view.View;
+import com.facebook.react.bridge.Dynamic;
+
+public interface RNMBXModelsManagerInterface<T extends View> {
+  void setModels(T view, Dynamic value);
+}

package/android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXNativeUserLocationManagerDelegate.java

@@ -46,6 +46,9 @@ public class RNMBXNativeUserLocationManagerDelegate<T extends View, U extends Ba
       case "visible":
         mViewManager.setVisible(view, value == null ? false : (boolean) value);
         break;
+      case "pulsing":
+        mViewManager.setPulsing(view, new DynamicFromObject(value));
+        break;
       default:
         super.setProperty(view, propName, value);
     }

package/android/src/main/old-arch/com/facebook/react/viewmanagers/RNMBXNativeUserLocationManagerInterface.java

@@ -21,4 +21,5 @@ public interface RNMBXNativeUserLocationManagerInterface<T extends View> {
   void setTopImage(T view, Dynamic value);
   void setScale(T view, Dynamic value);
   void setVisible(T view, boolean value);
+  void setPulsing(T view, Dynamic value);
 }

package/ios/RNMBX/RNMBXFabricPropConvert.h

@@ -14,28 +14,34 @@ BOOL RNMBXPropConvert_Optional_BOOL(const folly::dynamic &dyn, NSString* propert
 NSString* RNMBXPropConvert_Optional_NSString(const folly::dynamic &dyn, NSString* propertyName);
 id RNMBXPropConvert_Optional_ExpressionDouble(const folly::dynamic &dyn, NSString* propertyName);
 BOOL RNMBXPropConvert_BOOL(const folly::dynamic &dyn, NSString* propertyName);
+NSDictionary* RNMBXPropConvert_Optional_NSDictionary(const folly::dynamic &dyn, NSString* propertyName);
 
-#define RNMBX_OPTIONAL_RPOP_BOOL_NSNumber(name) \
+#define RNMBX_OPTIONAL_PROP_BOOL_NSNumber(name) \
   if ((!oldProps.get() || oldViewProps.name != newViewProps.name) && !newViewProps.name.isNull()) { \
     _view.name = RNMBXPropConvert_Optional_BOOL_NSNumber(newViewProps.name, @#name); \
   }
 
-#define RNMBX_OPTIONAL_RPOP_BOOL(name) \
+#define RNMBX_OPTIONAL_PROP_BOOL(name) \
   if ((!oldProps.get() || oldViewProps.name != newViewProps.name) && !newViewProps.name.isNull()) { \
     _view.name = RNMBXPropConvert_Optional_BOOL(newViewProps.name, @#name); \
   }
 
-#define RNMBX_OPTIONAL_RPOP_NSString(name) \
+#define RNMBX_OPTIONAL_PROP_NSString(name) \
   if ((!oldProps.get() || oldViewProps.name != newViewProps.name) && !newViewProps.name.isNull()) { \
     _view.name = RNMBXPropConvert_Optional_NSString(newViewProps.name, @#name); \
   }
 
-#define RNMBX_OPTIONAL_RPOP_ExpressionDouble(name) \
+#define RNMBX_OPTIONAL_PROP_ExpressionDouble(name) \
   if ((!oldProps.get() || oldViewProps.name != newViewProps.name) && !newViewProps.name.isNull()) { \
     _view.name = RNMBXPropConvert_Optional_ExpressionDouble(newViewProps.name, @#name); \
   }
 
-#define RNMBX_RPOP_BOOL(name) \
+#define RNMBX_PROP_BOOL(name) \
   if ((!oldProps.get() || oldViewProps.name != newViewProps.name)) { \
     _view.name = RNMBXPropConvert_BOOL(newViewProps.name, @#name); \
   }
+
+#define RNMBX_OPTIONAL_PROP_NSDictionary(name) \
+  if ((!oldProps.get() || oldViewProps.name != newViewProps.name)) { \
+    _view.name = RNMBXPropConvert_Optional_NSDictionary(newViewProps.name, @#name); \
+  }

package/ios/RNMBX/RNMBXFabricPropConvert.mm

@@ -128,4 +128,9 @@ id RNMBXPropConvert_Optional_ExpressionDouble(const folly::dynamic &dyn, NSStrin
   }
 }
 
+NSDictionary* RNMBXPropConvert_Optional_NSDictionary(const folly::dynamic &dyn, NSString* propertyName)
+{
+  return RNMBXPropConvert_ID(dyn);
+}
+
 #endif

package/ios/RNMBX/RNMBXInteractiveElement.swift

@@ -18,7 +18,7 @@ public class RNMBXInteractiveElement : UIView, RNMBXMapComponent {
   @objc public var id: String! = nil {
     willSet {
       if id != nil && newValue != id {
-        Logger.log(level:.warn, message: "Changing id from: \(optional: id) to \(optional: newValue), changing of id is supported")
+        Logger.log(level:.warn, message: "Changing id from: \(optional: id) to \(optional: newValue), changing of id is not supported")
         if let map = map { removeFromMap(map, reason: .ComponentChange) }
       }
     }

package/ios/RNMBX/RNMBXModelLayer.swift

@@ -0,0 +1,59 @@
+@_spi(Experimental) import MapboxMaps
+
+@objc(RNMBXModelLayer)
+public class RNMBXModelLayer: RNMBXVectorLayer {
+  typealias LayerType = ModelLayer
+
+  override func makeLayer(style: Style) throws -> Layer {
+    let vectorSource : VectorSource = try self.layerWithSourceID(in: style)
+    #if RNMBX_11
+    var layer = LayerType(id: self.id!, source: sourceID!)
+    #else
+    var layer = LayerType(id: self.id!)
+    #endif
+    layer.sourceLayer = self.sourceLayerID
+    layer.source = sourceID
+    return layer
+  }
+
+  override func layerType() -> Layer.Type {
+    return LayerType.self
+  }
+
+  override func apply(style : Style) throws {
+    try style.updateLayer(withId: id, type: LayerType.self) { (layer : inout ModelLayer) in
+      if self.styleLayer != nil {
+        self.setOptions(&self.styleLayer!)
+      }
+      if let styleLayer = self.styleLayer as? ModelLayer {
+        layer = styleLayer
+      }
+    }
+  }
+  
+  override func addStyles() {
+    if let style : Style = self.style {
+      let styler =  RNMBXStyle(style: self.style!)
+      styler.bridge = self.bridge
+      
+      if var styleLayer = self.styleLayer as? LayerType,
+         let reactStyle = reactStyle {
+        styler.modelLayer(
+          layer: &styleLayer,
+          reactStyle: reactStyle,
+          oldReactStyle: oldReatStyle,
+          applyUpdater: { (updater) in logged("RNMBXModelLayer.updateLayer") {
+            try style.updateLayer(withId: self.id, type: LayerType.self) { (layer: inout LayerType) in updater(&layer) }
+          }},
+          isValid: {
+            return self.isAddedToMap()
+          })
+        self.styleLayer = styleLayer
+      }
+    }
+  }
+  
+  func isAddedToMap() -> Bool {
+    return true
+  }
+}

package/ios/RNMBX/RNMBXModelLayerComponentView.h

@@ -0,0 +1,15 @@
+#ifdef RCT_NEW_ARCH_ENABLED
+
+#import <UIKit/UIKit.h>
+
+#import <React/RCTUIManager.h>
+#import <React/RCTViewComponentView.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+@interface RNMBXModelLayerComponentView : RCTViewComponentView
+@end
+
+NS_ASSUME_NONNULL_END
+
+#endif // RCT_NEW_ARCH_ENABLED

package/ios/RNMBX/RNMBXModelLayerComponentView.mm

@@ -0,0 +1,70 @@
+#ifdef RCT_NEW_ARCH_ENABLED
+
+#import "RNMBXModelLayerComponentView.h"
+#import "RNMBXFabricHelpers.h"
+
+#import <React/RCTConversions.h>
+#import <React/RCTFabricComponentsPlugins.h>
+#import <React/RCTBridge+Private.h>
+
+#import <react/renderer/components/rnmapbox_maps_specs/ComponentDescriptors.h>
+#import <react/renderer/components/rnmapbox_maps_specs/EventEmitters.h>
+#import <react/renderer/components/rnmapbox_maps_specs/Props.h>
+#import <react/renderer/components/rnmapbox_maps_specs/RCTComponentViewHelpers.h>
+
+using namespace facebook::react;
+
+@interface RNMBXModelLayerComponentView () <RCTRNMBXModelLayerViewProtocol>
+@end
+
+@implementation RNMBXModelLayerComponentView {
+    RNMBXModelLayer *_view;
+}
+
+- (instancetype)initWithFrame:(CGRect)frame
+{
+  if (self = [super initWithFrame:frame]) {
+    static const auto defaultProps = std::make_shared<const RNMBXModelLayerProps>();
+    _props = defaultProps;
+      [self prepareView];
+  }
+
+  return self;
+}
+
+- (void)prepareView
+{
+  _view =  [[RNMBXModelLayer alloc] init];
+  _view.bridge = [RCTBridge currentBridge];
+  self.contentView = _view;
+}
+
+#pragma mark - RCTComponentViewProtocol
+
++ (ComponentDescriptorProvider)componentDescriptorProvider
+{
+  return concreteComponentDescriptorProvider<RNMBXModelLayerComponentDescriptor>();
+}
+
+- (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
+{
+  const auto &newProps = static_cast<const RNMBXModelLayerProps &>(*props);
+  RNMBXSetCommonLayerProps(newProps, _view);
+
+  [super updateProps:props oldProps:oldProps];
+}
+
+- (void)prepareForRecycle
+{
+    [super prepareForRecycle];
+    [self prepareView];
+}
+
+@end
+
+Class<RCTComponentViewProtocol> RNMBXModelLayerCls(void)
+{
+  return RNMBXModelLayerComponentView.class;
+}
+
+#endif // RCT_NEW_ARCH_ENABLED

package/ios/RNMBX/RNMBXModelLayerViewManager.m

@@ -0,0 +1,12 @@
+#import <React/RCTBridgeModule.h>
+#import <React/RCTViewManager.h>
+
+@interface RCT_EXTERN_REMAP_MODULE(RNMBXModelLayer, RNMBXModelLayerViewManager, RCTViewManager)
+
+// circle layer props
+RCT_EXPORT_VIEW_PROPERTY(sourceLayerID, NSString)
+
+// standard layer props
+#include "CommonLayerProperties.H"
+
+@end

package/ios/RNMBX/RNMBXModelLayerViewManager.swift

@@ -0,0 +1,13 @@
+@objc(RNMBXModelLayerViewManager)
+class RNMBXModelLayerViewManager: RCTViewManager {
+    @objc
+    override static func requiresMainQueueSetup() -> Bool {
+        return true
+    }
+  
+    override func view() -> UIView! {
+      let layer = RNMBXModelLayer()
+      layer.bridge = self.bridge
+      return layer
+    }
+}

package/ios/RNMBX/RNMBXModels.swift

@@ -0,0 +1,63 @@
+@_spi(Experimental) import MapboxMaps
+
+@objc(RNMBXModels)
+open class RNMBXModels : UIView, RNMBXMapComponent {
+  var modelIdToUrl: [String: String] = [:]
+  
+  @objc(models)
+  public var models: NSDictionary {
+    set {
+      var newModels: [String: String] = [:]
+      newValue.forEach { (key, value) in
+        if let value = value as? NSDictionary, let key = key as? String {
+          if let uri = value["uri"] as? String {
+            newModels[key] = uri
+          } else if let url = value["url"] as? String {
+            newModels[key] = url
+          } else {
+            Logger.log(level: .error, message: "Unexpected value for model key: \(key) \(value) - no uri or url found")
+          }
+        }
+      }
+      self.modelIdToUrl = newModels
+    }
+    get {
+      Logger.error("RNMBXModels.models.getter not implemented")
+      return NSDictionary()
+    }
+  }
+  
+  func setModels(_ models: NSDictionary) {
+
+  }
+  
+  func addToMap(_ map: RNMBXMapView, style: Style) {
+    modelIdToUrl.forEach { (id, uri) in
+      logged("Models.addStyleModel") {
+        if let link = URL(string: uri), let scheme = link.scheme, let host = link.host,
+            let port = link.port {
+
+          // https://github.com/mapbox/mapbox-maps-ios/issues/2067
+          let uriWithoutQuery = "\(scheme)://\(host):\(port)\(link.path)"
+
+          try style.addStyleModel(modelId: id, modelUri: uriWithoutQuery)
+        } else {
+          try style.addStyleModel(modelId: id, modelUri: uri)
+        }
+      }
+    }
+  }
+  
+  func removeFromMap(_ map: RNMBXMapView, reason: RemovalReason) -> Bool {
+    modelIdToUrl.forEach { (id, _) in
+      #if RNMBX_11
+      try? map._mapView?.mapboxMap.removeStyleModel(modelId: id)
+      #endif
+    }
+    return true
+  }
+  
+  func waitForStyleLoad() -> Bool {
+    true
+  }
+}

package/ios/RNMBX/RNMBXModelsComponentView.h

@@ -0,0 +1,17 @@
+#ifdef RCT_NEW_ARCH_ENABLED
+
+#import <UIKit/UIKit.h>
+
+#import <React/RCTUIManager.h>
+#import <React/RCTViewComponentView.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+
+@interface RNMBXModelsComponentView : RCTViewComponentView
+
+@end
+
+NS_ASSUME_NONNULL_END
+
+#endif // RCT_NEW_ARCH_ENABLED

package/ios/RNMBX/RNMBXModelsComponentView.mm

@@ -0,0 +1,67 @@
+#ifdef RCT_NEW_ARCH_ENABLED
+
+#import "RNMBXModelsComponentView.h"
+
+#import <React/RCTConversions.h>
+#import <React/RCTFabricComponentsPlugins.h>
+
+#import <react/renderer/components/rnmapbox_maps_specs/ComponentDescriptors.h>
+#import <react/renderer/components/rnmapbox_maps_specs/EventEmitters.h>
+#import <react/renderer/components/rnmapbox_maps_specs/Props.h>
+#import <react/renderer/components/rnmapbox_maps_specs/RCTComponentViewHelpers.h>
+
+#import "rnmapbox_maps-Swift.pre.h"
+
+#import "RCTFollyConvert.h"
+#import "RNMBXFabricPropConvert.h"
+
+
+// TODO: use generated RNMBXModelsEventEmitter, but need 0.73+ for dynamic support
+using namespace facebook::react;
+
+@implementation RNMBXModelsComponentView {
+    RNMBXModels *_view;
+}
+
+- (instancetype)initWithFrame:(CGRect)frame
+{
+  if (self = [super initWithFrame:frame]) {
+    static const auto defaultProps = std::make_shared<const RNMBXModelsProps>();
+    _props = defaultProps;
+    _view = [[RNMBXModels alloc] init];
+    [self prepareView];
+    
+    self.contentView = _view;
+  }
+  
+  return self;
+}
+
+- (void)prepareView
+{
+}
+
+
+#pragma mark - RCTComponentViewProtocol
+
++ (ComponentDescriptorProvider)componentDescriptorProvider
+{
+  return concreteComponentDescriptorProvider<RNMBXModelsComponentDescriptor>();
+}
+
+- (void)updateProps:(const Props::Shared &)props oldProps:(const Props::Shared &)oldProps
+{
+  const auto &oldViewProps = static_cast<const RNMBXModelsProps &>(*oldProps);
+  const auto &newViewProps = static_cast<const RNMBXModelsProps &>(*props);
+
+  RNMBX_OPTIONAL_PROP_NSDictionary(models);
+  [super updateProps:props oldProps:oldProps];
+}
+@end
+
+Class<RCTComponentViewProtocol> RNMBXModelsCls(void)
+{
+  return RNMBXModelsComponentView.class;
+}
+
+#endif // RCT_NEW_ARCH_ENABLED

package/ios/RNMBX/RNMBXModelsManager.mm

@@ -0,0 +1,9 @@
+#import <React/RCTBridgeModule.h>
+#import <React/RCTViewManager.h>
+
+@interface RCT_EXTERN_REMAP_MODULE(RNMBXModels, RNMBXModelsManager, RCTViewManager)
+
+RCT_EXPORT_VIEW_PROPERTY(models, NSDictionary)
+
+@end
+

package/ios/RNMBX/RNMBXModelsManager.swift

@@ -0,0 +1,13 @@
+@objc(RNMBXModelsManager)
+public class RNMBXModelsManager : RCTViewManager {
+  @objc
+  public override static func requiresMainQueueSetup() -> Bool {
+    return true
+  }
+
+  public override func view() -> UIView! {
+    let layer = RNMBXModels()
+    return layer
+  }
+}
+

package/ios/RNMBX/RNMBXNativeUserLocation.swift

@@ -76,6 +76,9 @@ public class RNMBXNativeUserLocation: UIView, RNMBXMapComponent {
   
   @objc
   public var puckBearingEnabled: Bool = false
+  
+  @objc
+  public var pulsing: NSDictionary? = nil
 
   @objc
   override public func didSetProps(_ props: [String]) {
@@ -151,20 +154,7 @@ public class RNMBXNativeUserLocation: UIView, RNMBXMapComponent {
       return
     }
 
-    if (visible) {
-      if images.isEmpty {
-        location.options.puckType = .puck2D(.makeDefault(showBearing: puckBearingEnabled))
-      } else {
-        location.options.puckType = .puck2D(
-          Puck2DConfiguration(
-            topImage: self.images[.top],
-            bearingImage: self.images[.bearing],
-            shadowImage: self.images[.shadow],
-            scale: toDoubleValue(value: scale, name: "scale")
-          )
-        )
-      }
-    } else {
+    if (!visible) {
       let emptyImage = UIGraphicsImageRenderer(size: CGSize(width: 1, height: 1)).image { _ in }
       location.options.puckType = .puck2D(
         Puck2DConfiguration(
@@ -174,9 +164,50 @@ public class RNMBXNativeUserLocation: UIView, RNMBXMapComponent {
           scale: Value.constant(1.0)
         )
       )
+      return
+    } else {
+      var configuration : Puck2DConfiguration = images.isEmpty ?
+        .makeDefault(showBearing: puckBearingEnabled) : Puck2DConfiguration(
+          topImage: self.images[.top],
+          bearingImage: self.images[.bearing],
+          shadowImage: self.images[.shadow])
+      
+      if let scale = toDoubleValue(value: scale, name: "scale") {
+        configuration.scale = scale
+      }
+      
+      if let pulsing = pulsing {
+        if let kind = pulsing["kind"] as? String, kind == "default" {
+          configuration.pulsing = .default
+        } else {
+          var pulsingConfig = Puck2DConfiguration.Pulsing()
+          if let isEnabled = pulsing["isEnabled"] as? Bool {
+            pulsingConfig.isEnabled = isEnabled
+          }
+          
+          if let radius = pulsing["radius"] as? String {
+            if radius == "accuracy" {
+              pulsingConfig.radius = .accuracy
+            } else {
+              Logger.log(level: .error, message: "expected pulsing/radius to be either a number or accuracy but was \(radius)")
+            }
+          } else if let radius = pulsing["radius"] as? NSNumber {
+            pulsingConfig.radius = .constant(radius.doubleValue)
+          }
+          
+          if let color = pulsing["color"] as? Any {
+            if let uicolor = RCTConvert.uiColor(color) {
+              pulsingConfig.color = uicolor
+            } else {
+              Logger.log(level: .error, message: "expected color to be a color but was \(color)")
+            }
+          }
+          
+          configuration.pulsing = pulsingConfig
+        }
+      }
+      location.options.puckType = .puck2D(configuration)
     }
-
-
     location.options.puckBearingEnabled = puckBearingEnabled
     if let puckBearing = _puckBearing {
       location.options.puckBearing = puckBearing

package/ios/RNMBX/RNMBXNativeUserLocationComponentView.mm

@@ -57,13 +57,14 @@ using namespace facebook::react;
   const auto &oldViewProps = static_cast<const RNMBXNativeUserLocationProps &>(*oldProps);
   const auto &newViewProps = static_cast<const RNMBXNativeUserLocationProps &>(*props);
 
-  RNMBX_OPTIONAL_RPOP_NSString(puckBearing)
-  RNMBX_OPTIONAL_RPOP_BOOL(puckBearingEnabled)
-  RNMBX_OPTIONAL_RPOP_NSString(bearingImage)
-  RNMBX_OPTIONAL_RPOP_NSString(shadowImage)
-  RNMBX_OPTIONAL_RPOP_NSString(topImage)
-  RNMBX_OPTIONAL_RPOP_ExpressionDouble(scale)
-  RNMBX_RPOP_BOOL(visible)
+  RNMBX_OPTIONAL_PROP_NSString(puckBearing)
+  RNMBX_OPTIONAL_PROP_BOOL(puckBearingEnabled)
+  RNMBX_OPTIONAL_PROP_NSString(bearingImage)
+  RNMBX_OPTIONAL_PROP_NSString(shadowImage)
+  RNMBX_OPTIONAL_PROP_NSString(topImage)
+  RNMBX_OPTIONAL_PROP_ExpressionDouble(scale)
+  RNMBX_PROP_BOOL(visible)
+  RNMBX_OPTIONAL_PROP_NSDictionary(pulsing)
 
   [super updateProps:props oldProps:oldProps];