@rnmapbox/maps 10.0.0-beta.61 → 10.0.0-beta.64

package/android/install.md

@@ -4,7 +4,7 @@
 
   - mapbox: v10 latest mapbox implementation - *recommended*, not opensource requires access for download
   - maplibre: *DEFAULT* open source fork of older open source mapbox libraries with many improvements, will be removed in next version
-  - mapbox-gl: classic mapbox libraries - should work but will be dropped, recent versions are not open source and requires acess for download, will be removed in next version
+  - mapbox-gl: classic mapbox libraries - should work but will be dropped, recent versions are not open source and requires access for download, will be removed in next version
 
 ## Mapbox Maps SDK v10
 

package/android/rctmgl/src/main/java-mapboxgl/common/com/mapbox/rctmgl/components/styles/RCTMGLStyleFactory.java

@@ -80,9 +80,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "fillPatternTransition":
-              RCTMGLStyleFactory.setFillPatternTransition(layer, styleValue);
-              break;
         }
       }
     }
@@ -163,9 +160,6 @@ public class RCTMGLStyleFactory {
             case "lineDasharray":
               RCTMGLStyleFactory.setLineDasharray(layer, styleValue);
               break;
-            case "lineDasharrayTransition":
-              RCTMGLStyleFactory.setLineDasharrayTransition(layer, styleValue);
-              break;
             case "linePattern":
               style.addImage(styleValue, new DownloadMapImageTask.OnAllImagesLoaded() {
                   @Override
@@ -174,9 +168,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "linePatternTransition":
-              RCTMGLStyleFactory.setLinePatternTransition(layer, styleValue);
-              break;
             case "lineGradient":
               RCTMGLStyleFactory.setLineGradient(layer, styleValue);
               break;
@@ -564,9 +555,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "fillExtrusionPatternTransition":
-              RCTMGLStyleFactory.setFillExtrusionPatternTransition(layer, styleValue);
-              break;
             case "fillExtrusionHeight":
               RCTMGLStyleFactory.setFillExtrusionHeight(layer, styleValue);
               break;
@@ -719,9 +707,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "backgroundPatternTransition":
-              RCTMGLStyleFactory.setBackgroundPatternTransition(layer, styleValue);
-              break;
             case "backgroundOpacity":
               RCTMGLStyleFactory.setBackgroundOpacity(layer, styleValue);
               break;
@@ -871,14 +856,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setFillPatternTransition(FillLayer layer, RCTMGLStyleValue styleValue) {
-      TransitionOptions transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.setFillPatternTransition(transition);
-      }
-    }
-
     public static void setLineCap(LineLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.setProperties(PropertyFactory.lineCap(styleValue.getExpression()));
@@ -1051,14 +1028,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setLineDasharrayTransition(LineLayer layer, RCTMGLStyleValue styleValue) {
-      TransitionOptions transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.setLineDasharrayTransition(transition);
-      }
-    }
-
     public static void setLinePattern(LineLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         if (styleValue.isImageStringValue()) {
@@ -1071,14 +1040,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setLinePatternTransition(LineLayer layer, RCTMGLStyleValue styleValue) {
-      TransitionOptions transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.setLinePatternTransition(transition);
-      }
-    }
-
     public static void setLineGradient(LineLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.setProperties(PropertyFactory.lineGradient(styleValue.getExpression()));
@@ -1927,14 +1888,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setFillExtrusionPatternTransition(FillExtrusionLayer layer, RCTMGLStyleValue styleValue) {
-      TransitionOptions transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.setFillExtrusionPatternTransition(transition);
-      }
-    }
-
     public static void setFillExtrusionHeight(FillExtrusionLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.setProperties(PropertyFactory.fillExtrusionHeight(styleValue.getExpression()));
@@ -2207,14 +2160,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setBackgroundPatternTransition(BackgroundLayer layer, RCTMGLStyleValue styleValue) {
-      TransitionOptions transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.setBackgroundPatternTransition(transition);
-      }
-    }
-
     public static void setBackgroundOpacity(BackgroundLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.setProperties(PropertyFactory.backgroundOpacity(styleValue.getExpression()));

package/android/rctmgl/src/main/java-v10/com/mapbox/rctmgl/components/mapview/RCTMGLMapView.kt

@@ -733,19 +733,23 @@ open class RCTMGLMapView(private val mContext: Context, var mManager: RCTMGLMapV
     }
 
     fun queryRenderedFeaturesAtPoint(callbackID: String?, point: PointF, filter: Expression?, layerIDs: List<String>?) {
-        mMap?.queryRenderedFeatures(
-            ScreenCoordinate(point.x.toDouble(), point.y.toDouble()),
-            RenderedQueryOptions(layerIDs, filter)
-        ) { features ->
+        if (mMap == null) {
+            Logger.e("queryRenderedFeaturesAtPoint", "mapbox map is null")
+            return
+        }
+        val screenCoordinate = ScreenCoordinate(point.x.toDouble(), point.y.toDouble())
+        val queryGeometry = RenderedQueryGeometry(screenCoordinate)
+        val layers = layerIDs?.takeUnless { it.isEmpty() } ?: null;
+        val queryOptions = RenderedQueryOptions(layers, filter)
+        mMap.queryRenderedFeatures(queryGeometry, queryOptions) { features ->
             if (features.isValue) {
                 val featuresList = ArrayList<Feature?>()
                 for (i in features.value!!) {
                     featuresList.add(i.feature)
                 }
-
-                sendResponse(callbackID, {
+                sendResponse(callbackID) {
                     it.putString("data", FeatureCollection.fromFeatures(featuresList).toJson())
-                })
+                }
             } else {
                 Logger.e("queryRenderedFeaturesAtPoint", features.error ?: "n/a")
             }

package/android/rctmgl/src/main/java-v10/com/mapbox/rctmgl/components/styles/RCTMGLStyleFactory.java

@@ -91,9 +91,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "fillPatternTransition":
-              RCTMGLStyleFactory.setFillPatternTransition(layer, styleValue);
-              break;
         }
       }
     }
@@ -174,9 +171,6 @@ public class RCTMGLStyleFactory {
             case "lineDasharray":
               RCTMGLStyleFactory.setLineDasharray(layer, styleValue);
               break;
-            case "lineDasharrayTransition":
-              RCTMGLStyleFactory.setLineDasharrayTransition(layer, styleValue);
-              break;
             case "linePattern":
               style.addImage(styleValue, new DownloadMapImageTask.OnAllImagesLoaded() {
                   @Override
@@ -189,9 +183,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "linePatternTransition":
-              RCTMGLStyleFactory.setLinePatternTransition(layer, styleValue);
-              break;
             case "lineGradient":
               RCTMGLStyleFactory.setLineGradient(layer, styleValue);
               break;
@@ -593,9 +584,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "fillExtrusionPatternTransition":
-              RCTMGLStyleFactory.setFillExtrusionPatternTransition(layer, styleValue);
-              break;
             case "fillExtrusionHeight":
               RCTMGLStyleFactory.setFillExtrusionHeight(layer, styleValue);
               break;
@@ -752,9 +740,6 @@ public class RCTMGLStyleFactory {
                   }
               });
               break;
-            case "backgroundPatternTransition":
-              RCTMGLStyleFactory.setBackgroundPatternTransition(layer, styleValue);
-              break;
             case "backgroundOpacity":
               RCTMGLStyleFactory.setBackgroundOpacity(layer, styleValue);
               break;
@@ -1018,14 +1003,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setFillPatternTransition(FillLayer layer, RCTMGLStyleValue styleValue) {
-      StyleTransition transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.fillPatternTransition(transition);
-      }
-    }
-
     public static void setLineCap(LineLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.lineCap(styleValue.getExpression());
@@ -1198,14 +1175,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setLineDasharrayTransition(LineLayer layer, RCTMGLStyleValue styleValue) {
-      StyleTransition transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.lineDasharrayTransition(transition);
-      }
-    }
-
     public static void setLinePattern(LineLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         if (styleValue.isImageStringValue()) {
@@ -1218,14 +1187,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setLinePatternTransition(LineLayer layer, RCTMGLStyleValue styleValue) {
-      StyleTransition transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.linePatternTransition(transition);
-      }
-    }
-
     public static void setLineGradient(LineLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.lineGradient(styleValue.getExpression());
@@ -2090,14 +2051,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setFillExtrusionPatternTransition(FillExtrusionLayer layer, RCTMGLStyleValue styleValue) {
-      StyleTransition transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.fillExtrusionPatternTransition(transition);
-      }
-    }
-
     public static void setFillExtrusionHeight(FillExtrusionLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.fillExtrusionHeight(styleValue.getExpression());
@@ -2370,14 +2323,6 @@ public class RCTMGLStyleFactory {
       }
     }
 
-
-    public static void setBackgroundPatternTransition(BackgroundLayer layer, RCTMGLStyleValue styleValue) {
-      StyleTransition transition = styleValue.getTransition();
-      if (transition != null) {
-        layer.backgroundPatternTransition(transition);
-      }
-    }
-
     public static void setBackgroundOpacity(BackgroundLayer layer, RCTMGLStyleValue styleValue) {
       if (styleValue.isExpression()) {
         layer.backgroundOpacity(styleValue.getExpression());

package/ios/RCTMGL/RCTMGLStyle.h

@@ -38,7 +38,6 @@
 - (void)setFillTranslateTransition:(MGLFillStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillTranslateAnchor:(MGLFillStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillPattern:(MGLFillStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
-- (void)setFillPatternTransition:(MGLFillStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLineCap:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLineJoin:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLineMiterLimit:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
@@ -61,9 +60,7 @@
 - (void)setLineBlur:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLineBlurTransition:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLineDasharray:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
-- (void)setLineDasharrayTransition:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLinePattern:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
-- (void)setLinePatternTransition:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setLineGradient:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setSymbolPlacement:(MGLSymbolStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setSymbolSpacing:(MGLSymbolStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
@@ -171,7 +168,6 @@
 - (void)setFillExtrusionTranslateTransition:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillExtrusionTranslateAnchor:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillExtrusionPattern:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
-- (void)setFillExtrusionPatternTransition:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillExtrusionHeight:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillExtrusionHeightTransition:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setFillExtrusionBase:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
@@ -207,7 +203,6 @@
 - (void)setBackgroundColor:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setBackgroundColorTransition:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setBackgroundPattern:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
-- (void)setBackgroundPatternTransition:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setBackgroundOpacity:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setBackgroundOpacityTransition:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;
 - (void)setAnchor:(MGLLight *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue;

package/ios/RCTMGL/RCTMGLStyle.m

@@ -71,8 +71,6 @@
           }
         }];
       }
-    } else if ([prop isEqualToString:@"fillPatternTransition"]) {
-      [self setFillPatternTransition:layer withReactStyleValue:styleValue];
     } else {
       // TODO throw exception
     }
@@ -138,8 +136,6 @@
       [self setLineBlurTransition:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"lineDasharray"]) {
       [self setLineDasharray:layer withReactStyleValue:styleValue];
-    } else if ([prop isEqualToString:@"lineDasharrayTransition"]) {
-      [self setLineDasharrayTransition:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"linePattern"]) {
       if (![styleValue shouldAddImage]) {
         [self setLinePattern:layer withReactStyleValue:styleValue];
@@ -157,8 +153,6 @@
           }
         }];
       }
-    } else if ([prop isEqualToString:@"linePatternTransition"]) {
-      [self setLinePatternTransition:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"lineGradient"]) {
       [self setLineGradient:layer withReactStyleValue:styleValue];
     } else {
@@ -487,8 +481,6 @@
           }
         }];
       }
-    } else if ([prop isEqualToString:@"fillExtrusionPatternTransition"]) {
-      [self setFillExtrusionPatternTransition:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"fillExtrusionHeight"]) {
       [self setFillExtrusionHeight:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"fillExtrusionHeightTransition"]) {
@@ -637,8 +629,6 @@
           }
         }];
       }
-    } else if ([prop isEqualToString:@"backgroundPatternTransition"]) {
-      [self setBackgroundPatternTransition:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"backgroundOpacity"]) {
       [self setBackgroundOpacity:layer withReactStyleValue:styleValue];
     } else if ([prop isEqualToString:@"backgroundOpacityTransition"]) {
@@ -752,11 +742,6 @@
     layer.fillPattern = styleValue.mglStyleValue;
 }
 
-- (void)setFillPatternTransition:(MGLFillStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
-{
-    layer.fillPatternTransition = [styleValue getTransition];
-}
-
 
 
 - (void)setLineCap:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
@@ -869,21 +854,11 @@
     layer.lineDashPattern = styleValue.mglStyleValue;
 }
 
-- (void)setLineDasharrayTransition:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
-{
-    layer.lineDashPatternTransition = [styleValue getTransition];
-}
-
 - (void)setLinePattern:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
 {
     layer.linePattern = styleValue.mglStyleValue;
 }
 
-- (void)setLinePatternTransition:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
-{
-    layer.linePatternTransition = [styleValue getTransition];
-}
-
 - (void)setLineGradient:(MGLLineStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
 {
     layer.lineGradient = styleValue.mglStyleValue;
@@ -1427,11 +1402,6 @@
     layer.fillExtrusionPattern = styleValue.mglStyleValue;
 }
 
-- (void)setFillExtrusionPatternTransition:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
-{
-    layer.fillExtrusionPatternTransition = [styleValue getTransition];
-}
-
 - (void)setFillExtrusionHeight:(MGLFillExtrusionStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
 {
     layer.fillExtrusionHeight = styleValue.mglStyleValue;
@@ -1613,11 +1583,6 @@
     layer.backgroundPattern = styleValue.mglStyleValue;
 }
 
-- (void)setBackgroundPatternTransition:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
-{
-    layer.backgroundPatternTransition = [styleValue getTransition];
-}
-
 - (void)setBackgroundOpacity:(MGLBackgroundStyleLayer *)layer withReactStyleValue:(RCTMGLStyleValue *)styleValue
 {
     layer.backgroundOpacity = styleValue.mglStyleValue;

package/ios/RCTMGL-v10/RCTMGLLocationModule.swift

@@ -7,6 +7,8 @@ class RCTMGLLocation: NSObject {
   
   var heading : CLHeading? = nil
 
+  var timestamp: Date? = nil
+
   func toJSON() -> [String:Any] {
     return [
       "coords": [
@@ -18,7 +20,7 @@ class RCTMGLLocation: NSObject {
         "course": location.course,
         "speed": location.speed,
       ],
-      "timestamp": location.timestamp.timeIntervalSince1970 * 1000
+      "timestamp": (timestamp ?? location.timestamp).timeIntervalSince1970 * 1000
     ]
   }
 }
@@ -41,6 +43,11 @@ protocol RCTMGLLocationManagerDelegate : AnyObject {
 }
 
 class RCTMGLLocationManager : LocationProviderDelegate {
+  enum LocationUpdateType {
+    case heading
+    case location
+  }
+
   var provider: LocationProvider
   
   var lastKnownLocation : CLLocation?
@@ -49,15 +56,15 @@ class RCTMGLLocationManager : LocationProviderDelegate {
   weak var delegate: RCTMGLLocationManagerDelegate?
   weak var locationProviderDelage: LocationProviderDelegate?
   
-  var listeners: [RCTMGLLocationBlock] = []
-  
   init() {
     provider = AppleLocationProvider()
     provider.setDelegate(self)
   }
   
   func setDistanceFilter(_ distanceFilter: CLLocationDistance) {
-    provider.locationProviderOptions.distanceFilter = distanceFilter
+    var options = provider.locationProviderOptions
+    options.distanceFilter = distanceFilter
+    provider.locationProviderOptions = options
   }
   
   func start() {
@@ -74,7 +81,7 @@ class RCTMGLLocationManager : LocationProviderDelegate {
     provider.setDelegate(EmptyLocationProviderDelegate())
   }
   
-  func _convertToMapboxLocation(_ location: CLLocation?) -> RCTMGLLocation {
+  func _convertToMapboxLocation(_ location: CLLocation?, type: LocationUpdateType) -> RCTMGLLocation {
     guard let location = location else {
       return RCTMGLLocation()
     }
@@ -82,19 +89,22 @@ class RCTMGLLocationManager : LocationProviderDelegate {
     let userLocation = RCTMGLLocation()
     userLocation.location = location;
     userLocation.heading = lastKnownHeading
+    switch type {
+    case .location:
+      userLocation.timestamp = location.timestamp
+    case .heading:
+      userLocation.timestamp = lastKnownHeading!.timestamp
+    }
     return userLocation;
   }
   
-  func _updateDelegate() {
+  func _updateDelegate(type: LocationUpdateType) {
     if delegate == nil {
       return;
     }
 
-    let userLocation = _convertToMapboxLocation(lastKnownLocation)
+    let userLocation = _convertToMapboxLocation(lastKnownLocation, type: type)
 
-    for listener in listeners {
-      listener(userLocation)
-    }
     delegate?.locationManager(self, didUpdateLocation: userLocation)
   }
   
@@ -102,14 +112,14 @@ class RCTMGLLocationManager : LocationProviderDelegate {
   
   func locationProvider(_ provider: LocationProvider, didUpdateLocations locations: [CLLocation]) {
     lastKnownLocation = locations.last
-    self._updateDelegate()
+    self._updateDelegate(type: .location)
     
     locationProviderDelage?.locationProvider(provider, didUpdateLocations: locations)
   }
   
   func locationProvider(_ provider: LocationProvider, didUpdateHeading newHeading: CLHeading) {
     lastKnownHeading = newHeading
-    self._updateDelegate()
+    self._updateDelegate(type: .heading)
     
     locationProviderDelage?.locationProvider(provider, didUpdateHeading: newHeading)
   }
@@ -231,9 +241,7 @@ class RCTMGLLocationModule: RCTEventEmitter, RCTMGLLocationManagerDelegate {
   
   @objc
   override func constantsToExport() -> [AnyHashable: Any]! {
-    return [
-      "foo": "bar"
-    ];
+    return [:];
   }
 
   @objc override func supportedEvents() -> [String]
@@ -242,8 +250,8 @@ class RCTMGLLocationModule: RCTEventEmitter, RCTMGLLocationManagerDelegate {
   }
   
   @objc func start(_ minDisplacement: CLLocationDistance) {
+    if minDisplacement >= 0.0 { locationManager.setDistanceFilter(minDisplacement) }
     locationManager.start()
-    locationManager.setDistanceFilter(minDisplacement)
   }
   
   @objc func stop() {
@@ -279,7 +287,7 @@ class RCTMGLLocationModule: RCTEventEmitter, RCTMGLLocationManagerDelegate {
     guard let _ = bridge else {
       return
     }
-   
+
     self.sendEvent(withName: RCT_MAPBOX_USER_LOCATION_UPDATE, body: location.toJSON())
   }
 

package/ios/RCTMGL-v10/RCTMGLMapView.swift

@@ -33,7 +33,9 @@ open class RCTMGLMapView : MapView {
   var layerWaiters : [String:[(String) -> Void]] = [:]
   
   lazy var pointAnnotationManager : PointAnnotationManager = {
-    return PointAnnotationManager(annotations: annotations, mapView: mapView)
+    let result = PointAnnotationManager(annotations: annotations, mapView: mapView)
+    self._removeMapboxLongPressGestureRecognizer()
+    return result
   }()
 
   lazy var calloutAnnotationManager : MapboxMaps.PointAnnotationManager = {
@@ -221,8 +223,8 @@ open class RCTMGLMapView : MapView {
     }
   }
   
-  @objc func setReactCompassViewPosition(_ position: NSNumber) {
-    mapView.ornaments.options.compass.position = toOrnamentPositon(Int(truncating: position))
+  @objc func setReactCompassViewPosition(_ position: NSInteger) {
+    mapView.ornaments.options.compass.position = toOrnamentPositon(Int(truncating: NSNumber(value: position)))
   }
   
   @objc func setReactCompassViewMargins(_ margins: CGPoint) {
@@ -329,6 +331,14 @@ open class RCTMGLMapView : MapView {
     
     return nil
   }
+
+  func _removeMapboxLongPressGestureRecognizer() {
+    mapView.gestureRecognizers?.forEach { recognizer in
+      if (String(describing: type(of:recognizer)) == "MapboxLongPressGestureRecognizer") {
+        mapView.removeGestureRecognizer(recognizer)
+      }
+    }
+  }
 }
 
 // MARK: - event handlers
@@ -992,23 +1002,16 @@ class PointAnnotationManager : AnnotationInteractionDelegate {
               }
 
       case .changed:
-          guard let annotation = self.draggedAnnotation else {
+          guard var annotation = self.draggedAnnotation else {
               return
           }
         
           self.onDragHandler(self.manager, didDetectDraggedAnnotations: [annotation], dragState: .changed, targetPoint: targetPoint)
 
-          // For some reason Mapbox doesn't let us update the geometry of an existing annotation
-          // so we have to create a whole new one.
-          var newAnnotation = PointAnnotation(id: annotation.id, coordinate: targetPoint)
-          newAnnotation.image = annotation.image
-          newAnnotation.userInfo = annotation.userInfo
-          
-          var newAnnotations = self.manager.annotations.filter { an in
-              return an.id != annotation.id
+          let idx = self.manager.annotations.firstIndex { an in return an.id == annotation.id }
+          if let idx = idx {
+            self.manager.annotations[idx].point = Point(targetPoint)
           }
-          newAnnotations.append(newAnnotation)
-          manager.annotations = newAnnotations
       case .cancelled, .ended:
         guard let annotation = self.draggedAnnotation else {
             return
@@ -1023,7 +1026,6 @@ class PointAnnotationManager : AnnotationInteractionDelegate {
       }
   }
   
-  
   func remove(_ annotation: PointAnnotation) {
     manager.annotations.removeAll(where: {$0.id == annotation.id})
   }
@@ -1032,15 +1034,16 @@ class PointAnnotationManager : AnnotationInteractionDelegate {
     manager.annotations.append(annotation)
     manager.syncSourceAndLayerIfNeeded()
   }
-
-  func refresh(_ annotation: PointAnnotation) {
+  
+  func update(_ annotation: PointAnnotation) {
     let index = manager.annotations.firstIndex { $0.id == annotation.id }
-    if let index = index {
-      manager.annotations[index] = annotation
-      manager.syncSourceAndLayerIfNeeded()
-    } else {
-      Logger.log(level: .warn, message: "RCTMGL - PointAnnotation.refresh: expected annotation already there - adding")
-      add(annotation)
+    
+    guard let index = index else {
+      Logger.log(level: .warn, message: "RCTMGL - PointAnnotation.refresh: annotation not found")
+      return
     }
+    
+    manager.annotations[index] = annotation
+    manager.syncSourceAndLayerIfNeeded()
   }
 }

package/ios/RCTMGL-v10/RCTMGLMapViewManager.swift

@@ -29,7 +29,7 @@ extension RCTMGLMapViewManager {
       self.bridge.uiManager.addUIBlock { (manager, viewRegistry) in
         let view = viewRegistry![reactTag]
 
-        guard let view = view! as? RCTMGLMapView else {
+        guard let view = view, let view = view as? RCTMGLMapView else {
           RCTMGLLogError("Invalid react tag, could not find RCTMGLMapView");
           rejecter(name, "Unknown find reactTag: \(reactTag)", nil)
           return;
@@ -188,7 +188,7 @@ extension RCTMGLMapViewManager {
         let point = CGPoint(x: CGFloat(point[0].floatValue), y: CGFloat(point[1].floatValue))
 
         logged("queryRenderedFeaturesAtPoint.option", rejecter: rejecter) {
-          let options = try RenderedQueryOptions(layerIds: layerIDs, filter: filter?.asExpression())
+          let options = try RenderedQueryOptions(layerIds: (layerIDs ?? []).isEmpty ? nil : layerIDs, filter: filter?.asExpression())
           
           mapboxMap.queryRenderedFeatures(with: point, options: options) { result in
             switch result {