@rmyndharis/aimhooman 0.1.2 → 0.1.4

package/src/scan-session.mjs

@@ -67,9 +67,11 @@ export function scanEntries(repo, engine, entries, options = {}) {
             increment(stats.skipped, 'binary');
             // Binary classification only skips text-oriented policy rules. Secret
             // signatures are ASCII byte sequences, so latin1 preserves a
-            // one-byte-to-one-code-unit view and prevents one NUL from hiding
-            // credential material while keeping the existing byte limits.
-            matched = engine.checkContent(entry.path, blob.toString('latin1'), {
+            // one-byte-to-one-code-unit view and keeps the existing byte limits.
+            // Stripping NULs is what defeats hiding credential material behind
+            // them: one injected NUL breaks a signature, and a multi-byte
+            // encoding like UTF-16 injects one per character.
+            matched = engine.checkContent(entry.path, blob.toString('latin1').replace(/\0/g, ''), {
                 categories: ['secret'],
             });
         } else {
@@ -113,6 +115,10 @@ function readObjects(repo, objectIds, expectedBytes = 0) {
         encoding: 'buffer',
         maxBuffer: Math.max(2 * 1024 * 1024, expectedBytes + unique.length * 256 + 1024),
         timeout: GIT_TIMEOUT_MS,
+        // Same reason as gitBuf in gitx.mjs: without an explicit stdio,
+        // execFileSync echoes the child's stderr before it checks the exit
+        // status, so git's raw output reaches the terminal even on success.
+        stdio: ['pipe', 'pipe', 'pipe'],
     });
     const objects = new Map();
     const failures = [];

package/src/scan-target.mjs

@@ -11,7 +11,16 @@ import { commitChanges, commitMessage, commitSnapshot, historyRange } from './hi
 import { DEFAULT_SCAN_LIMITS, scanEntries } from './scan-session.mjs';
 import { loadRulesWithDiagnostics } from './rules.mjs';
 
-const PROFILE_RANK = { clean: 0, compliance: 1, strict: 2 };
+// A tiebreak for the one profile a range report has to name, not a strength
+// lattice. Clean and compliance are not ordered against each other: compliance
+// allows the six attribution rules clean blocks or reviews, no shipped rule runs
+// the other way, and applyExplicitProfile refuses to move between them in either
+// direction. No single profile is truthful for a mixed range, so this only
+// settles which policy object gets reported — clean outranks compliance because
+// a value read as the strongest must not name the profile that allows what the
+// other blocks. Enforcement never reads this: each commit is scanned under its
+// own policy and the exit code uses each finding's own scanProfile.
+const PROFILE_RANK = { compliance: 0, clean: 1, strict: 2 };
 const REVIEW_REQUIRED_PATH_RULES = new Set([
     'generic.agent-instructions',
     'generic.project-policy',