@rmrdeveloper/sideroom-pi 7.0.0 → 7.0.1

package/extensions/ask/index.ts

@@ -1,7 +1,12 @@
 import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
 import { Text } from '@earendil-works/pi-tui';
 import { executeAsk } from './execute.ts';
-import { AskParamsSchema, type AskResult, TOOL_NAME } from './model.ts';
+import {
+  AskParamsSchema,
+  type AskResult,
+  prepareAskArguments,
+  TOOL_NAME,
+} from './model.ts';
 
 export const ASK_DESCRIPTION =
   'Ask the user one or more questions in the language they are speaking. Use for clarifying requirements, getting preferences, or confirming decisions. Each question must include a recommended option. For a single question, shows a simple option list. For multiple questions, shows a tab-based interface.';
@@ -27,6 +32,7 @@ export default function registerAsk(pi: ExtensionAPI): void {
     promptSnippet: ASK_PROMPT_SNIPPET,
     promptGuidelines: ASK_PROMPT_GUIDELINES,
     parameters: AskParamsSchema,
+    prepareArguments: prepareAskArguments,
     executionMode: 'sequential',
     execute: async (_toolCallId, params, _signal, _onUpdate, ctx) =>
       executeAsk(params, ctx),

package/extensions/ask/model.ts

@@ -79,13 +79,118 @@ export type ParseAskResult =
   | { readonly ok: true; readonly questions: readonly AskQuestion[] }
   | { readonly ok: false; readonly message: string };
 
+interface JsonWireObject {
+  readonly [key: string]: JsonWireValue | undefined;
+}
+
+type JsonWireValue =
+  | string
+  | number
+  | boolean
+  | null
+  | readonly JsonWireValue[]
+  | JsonWireObject;
+
+export function prepareAskArguments(args: unknown): AskParams {
+  return decodeAskWireArgs(args) as AskParams;
+}
+
+function decodeAskWireArgs(args: unknown): JsonWireValue {
+  if (!isJsonWireObject(args)) {
+    return toJsonWireValue(args);
+  }
+
+  const questions = decodeAskQuestions(args.questions);
+  if (questions === args.questions) {
+    return args;
+  }
+
+  return { ...args, questions };
+}
+
+function decodeAskQuestions(
+  value: JsonWireValue | undefined,
+): JsonWireValue | undefined {
+  if (value === undefined) {
+    return value;
+  }
+
+  const parsed = decodeJsonWireField(value);
+  if (!Array.isArray(parsed)) {
+    return parsed;
+  }
+
+  let changed = parsed !== value;
+  const questions = parsed.map((question) => {
+    const decoded = decodeAskQuestion(question);
+    if (decoded !== question) {
+      changed = true;
+    }
+    return decoded;
+  });
+  if (!changed) {
+    return value;
+  }
+  return questions;
+}
+
+function decodeAskQuestion(question: JsonWireValue): JsonWireValue {
+  if (!isJsonWireObject(question)) {
+    return question;
+  }
+
+  const options = decodeJsonWireField(question.options);
+  if (options === question.options) {
+    return question;
+  }
+
+  return { ...question, options };
+}
+
+function decodeJsonWireField(
+  value: JsonWireValue | undefined,
+): JsonWireValue | undefined {
+  if (typeof value !== 'string') {
+    return value;
+  }
+
+  try {
+    return JSON.parse(value) as JsonWireValue;
+  } catch {
+    return value;
+  }
+}
+
+function isJsonWireObject(value: unknown): value is JsonWireObject {
+  return value !== null && typeof value === 'object' && !Array.isArray(value);
+}
+
+function toJsonWireValue(value: unknown): JsonWireValue {
+  if (
+    value === null ||
+    typeof value === 'string' ||
+    typeof value === 'number' ||
+    typeof value === 'boolean'
+  ) {
+    return value;
+  }
+  if (Array.isArray(value)) {
+    return value.map(toJsonWireValue);
+  }
+  if (isJsonWireObject(value)) {
+    return value;
+  }
+  return null;
+}
+
 export function parseAskParams(value: unknown): ParseAskResult {
-  if (!Check(AskParamsSchema, value)) {
-    return { ok: false, message: schemaErrorMessage(value) };
+  const decoded = decodeAskWireArgs(value);
+  if (!Check(AskParamsSchema, decoded)) {
+    return { ok: false, message: schemaErrorMessage(decoded) };
   }
 
   const seen = new Set<string>();
-  for (const question of value.questions) {
+  for (const question of decoded.questions) {
     if (seen.has(question.id)) {
       return {
         ok: false,
@@ -101,7 +206,7 @@ export function parseAskParams(value: unknown): ParseAskResult {
     }
   }
 
-  return { ok: true, questions: normalizeQuestions(value.questions) };
+  return { ok: true, questions: normalizeQuestions(decoded.questions) };
 }
 
 export function normalizeQuestions(

package/extensions/todo/index.ts

@@ -2,7 +2,7 @@ import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
 import { Text } from '@earendil-works/pi-tui';
 import { executeTodo, type TodoToolDetails } from './execute.ts';
 import { registerGuardEvents } from './guards.ts';
-import { TOOL_NAME, TodoParamsSchema } from './model.ts';
+import { prepareTodoArguments, TOOL_NAME, TodoParamsSchema } from './model.ts';
 import {
   type BoardLifecycle,
   commitBoard,
@@ -60,6 +60,7 @@ function registerTodoTool(
     promptSnippet: TODO_PROMPT_SNIPPET,
     promptGuidelines: TODO_PROMPT_GUIDELINES,
     parameters: TodoParamsSchema,
+    prepareArguments: prepareTodoArguments,
     executionMode: 'sequential',
     execute: async (_toolCallId, params, _signal, _onUpdate, ctx) => {
       const result = executeTodo(params, ctx, store.items);

package/extensions/todo/model.ts

@@ -115,13 +115,84 @@ const STATUS_MARKS: Readonly<Record<TodoStatus, string>> = {
 const BOARD_INSTRUCTIONS =
   'Call sideroom_todo update before the next item. While any item is pending, exactly one must be in_progress. Complete the current item and start the next in the same update. propose replaces the list; update patches by id.';
 
+interface JsonWireObject {
+  readonly [key: string]: JsonWireValue | undefined;
+}
+
+type JsonWireValue =
+  | string
+  | number
+  | boolean
+  | null
+  | readonly JsonWireValue[]
+  | JsonWireObject;
+
+export function prepareTodoArguments(args: unknown): TodoParams {
+  return decodeTodoWireArgs(args) as TodoParams;
+}
+
+function decodeTodoWireArgs(args: unknown): JsonWireValue {
+  if (!isJsonWireObject(args)) {
+    return toJsonWireValue(args);
+  }
+
+  const items = decodeJsonWireField(args.items);
+  const patches = decodeJsonWireField(args.patches);
+  if (items === args.items && patches === args.patches) {
+    return args;
+  }
+
+  return {
+    ...args,
+    ...('items' in args ? { items } : {}),
+    ...('patches' in args ? { patches } : {}),
+  };
+}
+
+function decodeJsonWireField(
+  value: JsonWireValue | undefined,
+): JsonWireValue | undefined {
+  if (typeof value !== 'string') {
+    return value;
+  }
+
+  try {
+    return JSON.parse(value) as JsonWireValue;
+  } catch {
+    return value;
+  }
+}
+
+function isJsonWireObject(value: unknown): value is JsonWireObject {
+  return value !== null && typeof value === 'object' && !Array.isArray(value);
+}
+
+function toJsonWireValue(value: unknown): JsonWireValue {
+  if (
+    value === null ||
+    typeof value === 'string' ||
+    typeof value === 'number' ||
+    typeof value === 'boolean'
+  ) {
+    return value;
+  }
+  if (Array.isArray(value)) {
+    return value.map(toJsonWireValue);
+  }
+  if (isJsonWireObject(value)) {
+    return value;
+  }
+  return null;
+}
+
 export function parseTodoParams(value: unknown): ParseTodoResult {
-  if (!Check(TodoParamsSchema, value)) {
+  const decoded = decodeTodoWireArgs(value);
+  if (!Check(TodoParamsSchema, decoded)) {
     return { ok: false, message: 'Error: Invalid sideroom_todo parameters' };
   }
 
-  if (value.action === TODO_ACTION.propose) {
-    const items = normalizeItems(value.items);
+  if (decoded.action === TODO_ACTION.propose) {
+    const items = normalizeItems(decoded.items);
     if (!items.ok) {
       return { ok: false, message: items.message };
     }
@@ -135,7 +206,7 @@ export function parseTodoParams(value: unknown): ParseTodoResult {
     };
   }
 
-  const patches = normalizePatches(value.patches);
+  const patches = normalizePatches(decoded.patches);
   if (!patches.ok) {
     return { ok: false, message: patches.message };
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmrdeveloper/sideroom-pi",
-  "version": "7.0.0",
+  "version": "7.0.1",
   "description": "A global Pi package with a questionnaire, work board, edited-file view, and coding guidelines for parent agents.",
   "type": "module",
   "files": [