@rmrdeveloper/sideroom-pi 5.0.1 → 7.0.0

package/package.json

@@ -1,41 +1,42 @@
 {
   "name": "@rmrdeveloper/sideroom-pi",
-  "version": "5.0.1",
-  "description": "A global Pi package that runs an isolated coding-agent pipeline through /sideroom.",
+  "version": "7.0.0",
+  "description": "A global Pi package with a questionnaire, work board, edited-file view, and coding guidelines for parent agents.",
   "type": "module",
   "files": [
-    "dist",
-    "src/assets",
-    "skills"
+    "extensions",
+    "assets",
+    "skills",
+    "!extensions/**/*.test.ts"
   ],
   "scripts": {
-    "build": "esbuild src/pi-extension.ts --bundle --platform=node --format=esm --outfile=dist/pi-extension.js --packages=external",
-    "prepublishOnly": "npm run check && npm run build",
+    "prepublishOnly": "npm run check",
     "changeset": "changeset",
     "changeset:status": "changeset status",
     "version-packages": "changeset version",
-    "release": "npm run check && changeset publish",
     "commitlint": "commitlint",
     "types": "tsc --noEmit",
-    "test": "node --test src/core/agents.test.ts src/core/catalog.test.ts src/core/findings.test.ts src/core/grilling.test.ts src/core/orchestrator.test.ts src/pi-command.test.ts src/runtimes/pi.test.ts",
-    "lint": "biome lint src commitlint.config.mjs",
-    "lint:fix": "biome lint --write src commitlint.config.mjs",
-    "format": "biome format --write src package.json biome.json commitlint.config.mjs .changeset/config.json",
-    "format:check": "biome format src package.json biome.json commitlint.config.mjs .changeset/config.json",
-    "check": "npm run types && biome check src package.json biome.json commitlint.config.mjs .changeset/config.json && npm test"
+    "test": "node --test 'extensions/**/*.test.ts'",
+    "lint": "biome lint extensions scripts commitlint.config.mjs",
+    "lint:fix": "biome lint --write extensions scripts commitlint.config.mjs",
+    "format": "biome format --write extensions scripts package.json biome.json commitlint.config.mjs .changeset/config.json",
+    "format:check": "biome format extensions scripts package.json biome.json commitlint.config.mjs .changeset/config.json",
+    "check:if-blocks": "node scripts/check-if-blocks.mjs",
+    "check": "npm run types && npm run check:if-blocks && biome check extensions scripts package.json biome.json commitlint.config.mjs .changeset/config.json && npm test"
   },
   "engines": {
     "node": ">=22.19.0"
   },
   "keywords": [
-    "agents",
-    "ai",
-    "coding-agents",
-    "multi-agent",
-    "orchestration",
     "pi",
     "pi-package",
-    "pi-sdk",
+    "pi-extension",
+    "questionnaire",
+    "todo",
+    "edited-files",
+    "sideroom_ask",
+    "sideroom_todo",
+    "guidelines",
     "typescript"
   ],
   "license": "MIT",
@@ -48,23 +49,26 @@
   },
   "pi": {
     "extensions": [
-      "./dist/pi-extension.js"
+      "./extensions"
     ],
     "skills": [
       "./skills"
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "*"
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*",
+    "typebox": "*"
   },
   "devDependencies": {
-    "@earendil-works/pi-coding-agent": "0.84.4",
     "@biomejs/biome": "2.5.11",
     "@changesets/cli": "^3.0.2",
     "@commitlint/cli": "^21.2.2",
     "@commitlint/config-conventional": "^21.2.2",
+    "@earendil-works/pi-coding-agent": "0.84.4",
+    "@earendil-works/pi-tui": "0.84.4",
     "@types/node": "^22.20.1",
-    "esbuild": "^0.25.0",
+    "typebox": "1.3.7",
     "typescript": "^5.6.0"
   }
 }

package/skills/sideroom-guidelines/SKILL.md

@@ -0,0 +1,77 @@
+---
+name: sideroom-guidelines
+description: "Trigger: write, edit, coding, Java, Laravel, TypeScript, Python, Go, Rust. Apply Sideroom coding principles before changing code."
+license: MIT
+metadata:
+  author: RMRdeveloper
+  version: "1.0"
+---
+
+# Sideroom guidelines
+
+## Activation Contract
+
+Load this skill before `write` or `edit`. Load at most one file from `references/languages/` for the path being changed.
+
+## Hard Rules
+
+- Follow the Do/Don't table. Language files override syntax and framework idiom only.
+- Do not load language files you are not editing this turn.
+- Fail fast, keep control flow flat, and validate once at the boundary.
+
+## Decision Gates
+
+| Path | Read |
+|------|------|
+| `.java` | `references/languages/java.md` |
+| `.php` | `references/languages/php-laravel.md` |
+| `.ts` `.tsx` | `references/languages/typescript.md` |
+| `.py` | `references/languages/python.md` |
+| `.go` | `references/languages/go.md` |
+| `.rs` | `references/languages/rust.md` |
+| other | shared table only |
+
+## Execution Steps
+
+1. Apply the table to the change.
+2. Read the matching language file, if any.
+3. Ship the smallest change that satisfies the current requirement.
+
+## Do / Don't
+
+| Do | Don't |
+| --- | --- |
+| Braces around every `if` body (Python: a full indented suite) | Unbraced or one-line conditional bodies |
+| Early return on bad input | Pyramid `if/else` nesting |
+| Explicit error, fail now | Fallbacks that hide the real failure |
+| One responsibility per unit | Validate + transform + persist + notify together |
+| Extract when duplication repeats | Abstract before a second real use |
+| Simplest solution for the current problem | Layers, hooks, or config "just in case" |
+| Build only what is needed today | Fields or branches for a future case |
+| Compose small focused units | Deep inheritance for unrelated behavior |
+| Talk only to immediate collaborators | Reach through another object's internals |
+| A function either does or returns, not both | Side effects inside a getter |
+| Validate once at the edge | Re-check the same invariant inward |
+| One validator per input | Two validators for the same body/query |
+| Let errors surface with context | Empty `catch` or catch-and-continue |
+| Return new values instead of mutating input | Mutate parameters |
+| One meaning per null/undefined | Overload null for several business states |
+| Inject dependencies | Hardcode infra that blocks tests |
+| Inner layers depend on nothing outward | Domain imports of DB/HTTP/framework types |
+| Names that reveal role or domain meaning | `data`, `info`, `temp`, `result`, `obj` |
+| Named const/enum/contract for domain literals | Magic strings |
+| Depend on ports where variation is real | Couple a use case to a concrete implementation |
+| Comments only for non-obvious intent | Narration, noise, or stale TODOs |
+
+## Output Contract
+
+Changed code follows the table and the loaded language delta. No extra files, layers, or comments unless the change requires them.
+
+## References
+
+- `references/languages/java.md`
+- `references/languages/php-laravel.md`
+- `references/languages/typescript.md`
+- `references/languages/python.md`
+- `references/languages/go.md`
+- `references/languages/rust.md`

package/skills/sideroom-guidelines/references/languages/go.md

@@ -0,0 +1,27 @@
+# Go
+
+Delta only. Keep the shared table.
+
+- Braces on every `if`. Keep `err` checks as flat guard clauses; do not nest the happy path.
+- Return errors with context. Do not `panic` for expected business failure, and do not ignore `err`.
+- Do not mutate slices or maps passed in as input; return a new value.
+
+```go
+// Bad
+func loadUser(id string) (*User, error) {
+    user, err := repo.Get(id)
+    if err == nil {
+        return user, nil
+    }
+    return nil, nil
+}
+
+// Good
+func loadUser(id string) (*User, error) {
+    user, err := repo.Get(id)
+    if err != nil {
+        return nil, fmt.Errorf("load user %s: %w", id, err)
+    }
+    return user, nil
+}
+```

package/skills/sideroom-guidelines/references/languages/java.md

@@ -0,0 +1,24 @@
+# Java
+
+Delta only. Keep the shared table.
+
+- Braces on every `if` / `else`, including one-line guards.
+- Fail fast with a clear exception. Do not hide a missing value behind a silent default.
+- Domain code depends on ports, not `new` of infrastructure types.
+
+```java
+// Bad
+public int shippingCost(Order order) {
+    Zone zone = zones.getOrDefault(order.zoneId(), Zone.DEFAULT);
+    return zone.baseCost();
+}
+
+// Good
+public int shippingCost(Order order) {
+    Zone zone = zones.get(order.zoneId());
+    if (zone == null) {
+        throw new IllegalArgumentException("Unknown zoneId: " + order.zoneId());
+    }
+    return zone.baseCost();
+}
+```

package/skills/sideroom-guidelines/references/languages/php-laravel.md

@@ -0,0 +1,26 @@
+# PHP / Laravel
+
+Delta only. Keep the shared table.
+
+- Braces on every `if` / `else`.
+- `FormRequest` (or one equivalent boundary) is the single validator. Services trust that contract and do not re-check the same rules.
+- Keep Eloquent/HTTP types out of domain logic.
+
+```php
+// Bad — Service repeats the FormRequest rule
+class ProfileService {
+    public function update(array $data) {
+        if (empty($data['email'])) {
+            throw new \InvalidArgumentException('email required');
+        }
+        $this->user->update($data);
+    }
+}
+
+// Good — Service trusts validated input
+class ProfileService {
+    public function update(array $validated) {
+        $this->user->update($validated);
+    }
+}
+```

package/skills/sideroom-guidelines/references/languages/python.md

@@ -0,0 +1,21 @@
+# Python
+
+Delta only. Keep the shared table.
+
+- Use a complete indented suite for every `if` / `else`. Never a one-line conditional body.
+- Treat `None` as "not set" or "explicitly empty" — pick one meaning and keep it. Do not use `None` for a real business state that deserves its own value.
+- Prefer returning new collections over mutating a caller's list or dict.
+
+```python
+# Bad
+def get_discount(user):
+    if user: return 0.2 if user.is_active else 0
+
+# Good
+def get_discount(user):
+    if user is None:
+        return 0
+    if not user.is_active:
+        return 0
+    return 0.2
+```

package/skills/sideroom-guidelines/references/languages/rust.md

@@ -0,0 +1,19 @@
+# Rust
+
+Delta only. Keep the shared table.
+
+- Prefer `Result` and `?`. Do not `.unwrap()` / `.expect()` in library or production paths.
+- Let errors surface with context (`map_err`, `anyhow`, or an equivalent). Do not swallow with `let _ =`.
+- Do not mutate the caller's value when returning a new one is enough.
+
+```rust
+// Bad
+fn load_user(id: &str) -> User {
+    repo.get(id).unwrap()
+}
+
+// Good
+fn load_user(id: &str) -> Result<User, LoadUserError> {
+    repo.get(id).map_err(|err| LoadUserError::from_repo(id, err))
+}
+```

package/skills/sideroom-guidelines/references/languages/typescript.md

@@ -0,0 +1,30 @@
+# TypeScript
+
+Delta only. Keep the shared table.
+
+- Braces on every `if` / `else`, including one-line guards.
+- Pick one meaning for `undefined` vs `null` and keep it. Do not use either as a stand-in for a named business state.
+- Name domain literals once (`const` / enum / const object). Do not scatter magic strings.
+
+```ts
+// Bad
+function getDiscount(user?: { plan?: { discount: number } }) {
+  if (!user) {
+    return null;
+  }
+  if (!user.plan) {
+    return null;
+  }
+  if (user.plan.discount === 0) {
+    return null;
+  }
+}
+
+// Good
+function getDiscount(user: { plan?: { discount: number } } | undefined): number {
+  if (user === undefined || user.plan === undefined) {
+    return 0;
+  }
+  return user.plan.discount;
+}
+```