@rmdes/indiekit-endpoint-webmention-io 1.0.1 → 1.0.2

package/lib/controllers/blocklist.js

@@ -5,6 +5,26 @@
 import { getBlocklist, unblockDomain } from "../storage/blocklist.js";
 import { unhideByDomain } from "../storage/webmentions.js";
 
+/**
+ * Format a date for display. Returns a human-readable string or null.
+ * NEVER pass raw Date objects to Nunjucks templates — the | date filter
+ * crashes on both Date objects and undefined/null.
+ * @param {*} value
+ * @returns {string|null}
+ */
+function formatDate(value) {
+  if (!value) return null;
+  const d = value instanceof Date ? value : new Date(value);
+  if (Number.isNaN(d.getTime())) return null;
+  return d.toLocaleDateString("en-GB", {
+    year: "numeric",
+    month: "short",
+    day: "numeric",
+    hour: "2-digit",
+    minute: "2-digit",
+  });
+}
+
 export const blocklistController = {
   /**
    * GET /blocklist - Blocklist management page
@@ -21,9 +41,7 @@ export const blocklistController = {
         const raw = await getBlocklist(collection);
         entries = raw.map((entry) => ({
           ...entry,
-          blockedAt: entry.blockedAt instanceof Date
-            ? entry.blockedAt.toISOString()
-            : entry.blockedAt,
+          blockedAt: formatDate(entry.blockedAt),
         }));
       }
 

package/lib/controllers/dashboard.js

@@ -16,14 +16,37 @@ import { getSyncState } from "../sync.js";
 import { getMentionType, getMentionTitle, getAuthorName } from "../utils.js";
 
 /**
- * Convert Date objects to ISO strings for Nunjucks date filter
+ * Format a date for direct display in templates (NOT through macros).
+ * Returns a human-readable string or null.
  * @param {*} value
- * @returns {string|undefined}
+ * @returns {string|null}
  */
-function toDateString(value) {
-  if (!value) return undefined;
+function formatDate(value) {
+  if (!value) return null;
+  const d = value instanceof Date ? value : new Date(value);
+  if (Number.isNaN(d.getTime())) return null;
+  return d.toLocaleDateString("en-GB", {
+    year: "numeric",
+    month: "short",
+    day: "numeric",
+    hour: "2-digit",
+    minute: "2-digit",
+  });
+}
+
+/**
+ * Convert any date value to an ISO 8601 string safe for the Nunjucks | date
+ * filter (which calls date-fns parseISO — crashes on Date objects, null, and
+ * undefined). Use this for values that pass through mention()/card() macros.
+ * @param {*} value
+ * @returns {string|null}
+ */
+function toISO(value) {
+  if (!value) return null;
   if (value instanceof Date) return value.toISOString();
-  return String(value);
+  const d = new Date(value);
+  if (Number.isNaN(d.getTime())) return null;
+  return d.toISOString();
 }
 
 export const dashboardController = {
@@ -42,7 +65,7 @@ export const dashboardController = {
           counts: { total: 0, hidden: 0, visible: 0 },
           syncState: {
             ...getSyncState(),
-            lastSync: toDateString(getSyncState().lastSync),
+            lastSync: formatDate(getSyncState().lastSync),
           },
           cursor: {},
           filter: "all",
@@ -96,7 +119,7 @@ export const dashboardController = {
           locale: application.locale,
           title: getMentionTitle({ name: item.name, "wm-property": item.wmProperty }),
           description: html ? { html } : undefined,
-          published: toDateString(item.published || item.wmReceived),
+          published: toISO(item.published || item.wmReceived),
           url: item.sourceUrl,
           user: {
             avatar: { src: item.authorPhoto },
@@ -127,7 +150,7 @@ export const dashboardController = {
         counts,
         syncState: {
           ...getSyncState(),
-          lastSync: toDateString(getSyncState().lastSync),
+          lastSync: formatDate(getSyncState().lastSync),
         },
         cursor,
         filter,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-webmention-io",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Webmention moderation endpoint for Indiekit. Syncs webmentions from webmention.io into MongoDB with delete, block, and privacy removal capabilities.",
   "keywords": [
     "indiekit",

package/views/webmentions-blocklist.njk

@@ -173,7 +173,7 @@
           </span>
         </td>
         <td>{{ entry.mentionsHidden or 0 }}</td>
-        <td>{{ entry.blockedAt | date }}</td>
+        <td>{{ entry.blockedAt }}</td>
         <td>
           <form method="post" action="{{ wmEndpoint }}/blocklist/{{ entry.domain | urlencode }}/delete" style="display:inline">
             <button type="submit" class="button button--small button--secondary"

package/views/webmentions.njk

@@ -139,7 +139,7 @@
   <div class="wm-actions-bar">
     <span class="wm-sync-info">
       {% if syncState.lastSync %}
-        {{ __("webmention-io.sync.lastSync") }}: {{ syncState.lastSync | date }}
+        {{ __("webmention-io.sync.lastSync") }}: {{ syncState.lastSync }}
       {% else %}
         {{ __("webmention-io.sync.never") }}
       {% endif %}