@rmdes/indiekit-endpoint-syndicate 1.0.0-beta.45 → 1.0.0-beta.48

package/lib/utils.js

@@ -1,23 +1,18 @@
 /**
  * Get post data for a single post
+ * Get every post awaiting syndication
+ *
+ * A post is awaiting syndication while `mp-syndicate-to` remains: it is
+ * deleted once every target has returned a URL, and replaced with the
+ * targets that failed otherwise. Posts already syndicated to some of their
+ * targets are therefore still awaiting the rest, and `syndicateToTargets`
+ * skips the ones already done. Oldest first, so a backlog is syndicated in
+ * the order it was published.
  * @param {object} postsCollection - Posts database collection
- * @param {string} url - URL of existing post (optional)
- * @returns {Promise<object>} Post data for given URL else oldest post awaiting syndication
+ * @returns {Promise<Array<object>>} Post data, oldest first
  */
-export const getPostData = async (postsCollection, url) => {
-  if (url) {
-    return postsCollection.findOne({
-      "properties.url": url,
-    });
-  }
-
-  // A post is awaiting syndication while `mp-syndicate-to` remains: it is
-  // deleted once every target has returned a URL, and replaced with the
-  // targets that failed otherwise. Posts already syndicated to some of their
-  // targets are therefore still awaiting the rest, and `syndicateToTargets`
-  // skips the ones already done. Oldest first, so a backlog is syndicated in
-  // the order it was published.
-  const items = await postsCollection
+export const getPostsAwaitingSyndication = async (postsCollection) => {
+  return postsCollection
     .find({
       "properties.mp-syndicate-to": {
         $exists: true,
@@ -27,35 +22,39 @@ export const getPostData = async (postsCollection, url) => {
       },
     })
     .sort({ "properties.published": 1 })
-    .limit(1)
     .toArray();
-
-  return items[0];
 };
 
 /**
- * Get ALL posts awaiting syndication (batch mode)
+ * Get post data
  * @param {object} postsCollection - Posts database collection
- * @returns {Promise<Array>} Array of post data objects
+ * @param {string} url - URL of existing post (optional)
+ * @returns {Promise<object>} Post data for given URL else oldest post awaiting syndication
  */
-export const getAllPostData = async (postsCollection) => {
-  const items = await postsCollection
-    .find({
-      "properties.mp-syndicate-to": {
-        $exists: true,
-      },
-      // No syndication filter — let syndicateToTargets() handle dedup
-      "properties.post-status": {
-        $ne: "draft",
-      },
-    })
-
-    .sort({ "properties.published": -1 })
-    .toArray();
+export const getPostData = async (postsCollection, url) => {
+  if (url) {
+    return postsCollection.findOne({
+      "properties.url": url,
+    });
+  }
 
-  return items;
+  const [oldest] = await getPostsAwaitingSyndication(postsCollection);
+  return oldest;
 };
 
+/**
+ * Get ALL posts awaiting syndication (batch mode)
+ *
+ * This was a second copy of `getPostsAwaitingSyndication`'s query that differed
+ * only in sorting `published: -1`, so a backlog went out newest first and
+ * arrived on the timeline in reverse. The duplicate is gone: both callers now
+ * share one query, oldest first, which is what the comment above already
+ * claimed and what upstream's batch path does.
+ * @param {object} postsCollection - Posts database collection
+ * @returns {Promise<Array<object>>} Post data, oldest first
+ */
+export const getAllPostData = getPostsAwaitingSyndication;
+
 /**
  * Check if target already returned a syndication URL
  * @param {Array} syndicatedUrls - Syndication URLs
@@ -221,7 +220,6 @@ export const syndicateToTargets = async (
   };
 };
 
-
 /**
  * HEAD a URL and report its status, 0 on network error or timeout
  * @param {string} url - URL to check
@@ -246,13 +244,16 @@ const headCheck = async (url) => {
 /**
  * GET a page and return its status plus the og:image it declares.
  * @param {string} url - Page URL
- * @returns {Promise<{status: number, ogImage: string|undefined}>}
+ * @returns {Promise<{status: number, ogImage?: string}>}
  */
 const fetchOgImage = async (url) => {
   try {
     const controller = new AbortController();
     const timeoutId = setTimeout(() => controller.abort(), 5000);
-    const response = await fetch(url, { redirect: "follow", signal: controller.signal });
+    const response = await fetch(url, {
+      redirect: "follow",
+      signal: controller.signal,
+    });
     clearTimeout(timeoutId);
     if (response.status !== 200) return { status: response.status };
     const html = await response.text();
@@ -301,4 +302,3 @@ export async function isPostReady(postUrl, me, options = {}) {
   const ogStatus = await headCheck(ogImage);
   return { ready: ogStatus === 200, postStatus, ogStatus };
 }
-

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-syndicate",
-  "version": "1.0.0-beta.45",
+  "version": "1.0.0-beta.48",
   "description": "Syndication endpoint for Indiekit. Fork of @indiekit/endpoint-syndicate with batch syndication support and bug fixes.",
   "keywords": [
     "indiekit",
@@ -29,13 +29,13 @@
   },
   "dependencies": {
     "@indiekit/error": "^1.0.0-beta.28",
-    "express": "^5.2.1",
+    "express": "^5.3.0",
     "jsonwebtoken": "^9.0.3"
   },
   "publishConfig": {
     "access": "public"
   },
   "scripts": {
-    "test": "node --test test/*.js"
+    "test": "node --test \"tests/**/*.test.js\""
   }
 }