@rmdes/indiekit-endpoint-syndicate 1.0.0-beta.42 → 1.0.0-beta.44

package/lib/controllers/syndicate.js

@@ -239,14 +239,16 @@ export const syndicateController = {
               `[syndication] Syndicated: ${result.url} (${result.syndicatedUrls.length} target(s))`,
             );
           } catch (error) {
+            const message =
+              error instanceof Error ? error.message : String(error);
             results.push({
               url: postData.properties?.url,
               success: false,
-              error: error.message,
+              error: message,
             });
 
             console.error(
-              `[syndication] Failed: ${postData.properties?.url} - ${error.message}`,
+              `[syndication] Failed: ${postData.properties?.url} - ${message}`,
             );
           }
 

package/lib/utils.js

@@ -2,7 +2,7 @@
  * Get post data for a single post
  * @param {object} postsCollection - Posts database collection
  * @param {string} url - URL of existing post (optional)
- * @returns {Promise<object>} Post data for given URL else most recent pending post
+ * @returns {Promise<object>} Post data for given URL else oldest post awaiting syndication
  */
 export const getPostData = async (postsCollection, url) => {
   if (url) {
@@ -15,7 +15,8 @@ export const getPostData = async (postsCollection, url) => {
   // deleted once every target has returned a URL, and replaced with the
   // targets that failed otherwise. Posts already syndicated to some of their
   // targets are therefore still awaiting the rest, and `syndicateToTargets`
-  // skips the ones already done.
+  // skips the ones already done. Oldest first, so a backlog is syndicated in
+  // the order it was published.
   const items = await postsCollection
     .find({
       "properties.mp-syndicate-to": {
@@ -25,7 +26,7 @@ export const getPostData = async (postsCollection, url) => {
         $ne: "draft",
       },
     })
-    .sort({ "properties.published": -1 })
+    .sort({ "properties.published": 1 })
     .limit(1)
     .toArray();
 
@@ -63,12 +64,13 @@ export const getAllPostData = async (postsCollection) => {
  */
 export const hasSyndicationUrl = (syndicatedUrls, syndicateTo) => {
   return syndicatedUrls.some((url) => {
-    try {
-      const { origin } = new URL(url);
-      return syndicateTo.includes(origin);
-    } catch {
+    // `syndication` is stored as given, so may hold values that aren’t URLs
+    if (!URL.canParse(url)) {
       return false;
     }
+
+    const { origin } = new URL(url);
+    return syndicateTo.includes(origin);
   });
 };
 
@@ -208,7 +210,7 @@ export const syndicateToTargets = async (
       } catch (error) {
         // Add failed syndication target to list of failed targets
         failedTargets.push(target.info.uid);
-        console.error(error.message);
+        console.error(error);
       }
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-syndicate",
-  "version": "1.0.0-beta.42",
+  "version": "1.0.0-beta.44",
   "description": "Syndication endpoint for Indiekit. Fork of @indiekit/endpoint-syndicate with batch syndication support and bug fixes.",
   "keywords": [
     "indiekit",