@rmdes/indiekit-endpoint-rss 1.0.16 → 1.0.17

package/index.js

@@ -6,14 +6,11 @@ import { dashboardController } from "./lib/controllers/dashboard.js";
 import { feedsController } from "./lib/controllers/feeds.js";
 import { itemsController } from "./lib/controllers/items.js";
 import { statusController } from "./lib/controllers/status.js";
-import { startSync } from "./lib/sync.js";
+import { startSync, stopSync } from "./lib/sync.js";
 import { waitForReady } from "@rmdes/indiekit-startup-gate";
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 
-const protectedRouter = express.Router();
-const publicRouter = express.Router();
-
 const defaults = {
   mountPath: "/rssapi",
   syncInterval: 900_000, // 15 minutes
@@ -56,44 +53,60 @@ export default class RssEndpoint {
   /**
    * Protected routes (require authentication)
    * Admin dashboard and feed management (write operations)
+   *
+   * Built once per instance. Indiekit reads this getter twice while mounting
+   * (once to test it, once to pass it to router.use), so a router built on
+   * every read registers every handler twice.
+   * @returns {express.Router}
    */
   get routes() {
+    if (this._routes) return this._routes;
+
+    const router = express.Router();
+
     // Dashboard
-    protectedRouter.get("/", dashboardController.get);
+    router.get("/", dashboardController.get);
 
     // Manual sync trigger
-    protectedRouter.post("/sync", dashboardController.sync);
+    router.post("/sync", dashboardController.sync);
 
     // Clear items and re-sync
-    protectedRouter.post("/clear-resync", dashboardController.clearResync);
+    router.post("/clear-resync", dashboardController.clearResync);
 
     // Feed management (protected - requires auth)
-    protectedRouter.post("/api/feeds", express.json(), feedsController.add);
-    protectedRouter.delete("/api/feeds/:id", feedsController.remove);
-    protectedRouter.patch("/api/feeds/:id", express.json(), feedsController.toggle);
+    router.post("/api/feeds", express.json(), feedsController.add);
+    router.delete("/api/feeds/:id", feedsController.remove);
+    router.patch("/api/feeds/:id", express.json(), feedsController.toggle);
 
     // Manual refresh (protected)
-    protectedRouter.post("/api/refresh", statusController.refresh);
+    router.post("/api/refresh", statusController.refresh);
 
-    return protectedRouter;
+    this._routes = router;
+    return router;
   }
 
   /**
    * Public routes (no authentication required)
    * Read-only JSON API endpoints for frontend
+   * @returns {express.Router}
    */
   get routesPublic() {
+    if (this._routesPublic) return this._routesPublic;
+
+    const router = express.Router();
+
     // Feeds API (read-only)
-    publicRouter.get("/api/feeds", feedsController.list);
+    router.get("/api/feeds", feedsController.list);
 
     // Items API (read-only)
-    publicRouter.get("/api/items", itemsController.list);
-    publicRouter.get("/api/items/:id", itemsController.get);
+    router.get("/api/items", itemsController.list);
+    router.get("/api/items/:id", itemsController.get);
 
     // Status API (read-only)
-    publicRouter.get("/api/status", statusController.status);
+    router.get("/api/status", statusController.status);
 
-    return publicRouter;
+    this._routesPublic = router;
+    return router;
   }
 
   init(Indiekit) {
@@ -121,5 +134,6 @@ export default class RssEndpoint {
 
   destroy() {
     this._stopGate?.();
+    stopSync();
   }
 }

package/lib/controllers/feeds.js

@@ -85,7 +85,7 @@ export const feedsController = {
         description: feedMeta.description,
         imageUrl: feedMeta.imageUrl,
         enabled: true,
-        addedAt: new Date(),
+        addedAt: new Date().toISOString(),
         lastFetchedAt: null,
         lastError: null,
         itemCount: 0,

package/lib/sync.js

@@ -1,6 +1,7 @@
 import { RssClient } from "./rss-client.js";
 
 let syncInterval = null;
+let initialSyncTimeout = null;
 let syncState = {
   lastSync: null,
   syncing: false,
@@ -25,12 +26,16 @@ export function getSyncState() {
 export function startSync(Indiekit, options) {
   const intervalMs = options.syncInterval || 900_000; // 15 minutes default
 
+  // Starting twice would orphan the previous timers with no handle to clear.
+  stopSync();
+
   console.log(
     `[RSS] Starting background sync with ${intervalMs / 60_000}min interval`
   );
 
   // Initial sync after delay
-  setTimeout(() => {
+  initialSyncTimeout = setTimeout(() => {
+    initialSyncTimeout = null;
     runSync(Indiekit, options).catch((err) => {
       console.error("[RSS] Initial sync error:", err.message);
     });
@@ -48,9 +53,16 @@ export function startSync(Indiekit, options) {
  * Stop background sync
  */
 export function stopSync() {
-  if (syncInterval) {
-    clearInterval(syncInterval);
-    syncInterval = null;
+  const wasRunning = Boolean(syncInterval || initialSyncTimeout);
+
+  // Both timers matter: destroy() within the first 10 seconds would otherwise
+  // still fire an initial sync against a torn-down plugin.
+  clearTimeout(initialSyncTimeout);
+  initialSyncTimeout = null;
+  clearInterval(syncInterval);
+  syncInterval = null;
+
+  if (wasRunning) {
     console.log("[RSS] Background sync stopped");
   }
 }
@@ -88,6 +100,7 @@ export async function runSync(dbOrIndiekit, options) {
 
     // Create indexes if they don't exist
     await createIndexes(feedsCollection, itemsCollection);
+    await normalizeLegacyFeedDates(feedsCollection);
 
     // Get all enabled feeds
     const feeds = await feedsCollection.find({ enabled: true }).toArray();
@@ -258,6 +271,35 @@ async function createIndexes(feedsCollection, itemsCollection) {
   await itemsCollection.createIndex({ fetchedAt: -1 });
 }
 
+/**
+ * Rewrite legacy BSON Date values of `addedAt` as ISO 8601 strings.
+ *
+ * Indiekit stores dates as ISO strings. Feeds added before that was fixed hold
+ * a BSON Date, and in BSON a Date sorts after every string — so a mixed
+ * collection buries newly added feeds at the bottom of { addedAt: -1 }.
+ * No-op once every row has been converted.
+ * @param {Collection} feedsCollection - Feeds collection
+ * @returns {Promise<number>} Number of feeds normalized
+ */
+export async function normalizeLegacyFeedDates(feedsCollection) {
+  const legacy = await feedsCollection
+    .find({ addedAt: { $type: "date" } })
+    .toArray();
+
+  for (const feed of legacy) {
+    await feedsCollection.updateOne(
+      { _id: feed._id },
+      { $set: { addedAt: feed.addedAt.toISOString() } },
+    );
+  }
+
+  if (legacy.length > 0) {
+    console.log(`[RSS] Normalized addedAt on ${legacy.length} feed(s)`);
+  }
+
+  return legacy.length;
+}
+
 /**
  * Prune items older than the retention period.
  *

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-rss",
-  "version": "1.0.16",
+  "version": "1.0.17",
   "description": "RSS feed reader endpoint for Indiekit. Aggregates multiple feeds, caches in MongoDB, displays on frontend.",
   "keywords": [
     "indiekit",