@rmdes/indiekit-endpoint-rss 1.0.14 → 1.0.16

package/README.md

@@ -36,7 +36,8 @@ export default {
       maxItemsPerFeed: 50,           // Max items per feed to cache
       fetchTimeout: 10_000,          // 10 second timeout per feed
       maxConcurrentFetches: 3,       // Parallel feed fetches
-      retentionDays: 30              // Days to keep items
+      retentionDays: 30,             // Days to keep items
+      minItemsPerFeed: 10            // Newest items always kept, whatever their age
     })
   ],
   // MongoDB database is REQUIRED

package/index.js

@@ -7,6 +7,7 @@ import { feedsController } from "./lib/controllers/feeds.js";
 import { itemsController } from "./lib/controllers/items.js";
 import { statusController } from "./lib/controllers/status.js";
 import { startSync } from "./lib/sync.js";
+import { waitForReady } from "@rmdes/indiekit-startup-gate";
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 
@@ -20,6 +21,7 @@ const defaults = {
   fetchTimeout: 10_000,
   maxConcurrentFetches: 3,
   retentionDays: 30,
+  minItemsPerFeed: 10,
 };
 
 export default class RssEndpoint {
@@ -110,7 +112,14 @@ export default class RssEndpoint {
 
     // Start background sync if database is available
     if (Indiekit.config.application.mongodbUrl) {
-      startSync(Indiekit, this.options);
+      this._stopGate = waitForReady(
+        () => startSync(Indiekit, this.options),
+        { label: "RSS" },
+      );
     }
   }
+
+  destroy() {
+    this._stopGate?.();
+  }
 }

package/lib/sync.js

@@ -122,6 +122,7 @@ export async function runSync(dbOrIndiekit, options) {
       itemsCollection,
       feedsCollection,
       retentionDays,
+      options.minItemsPerFeed ?? 10,
     );
 
     syncState.lastSync = new Date().toISOString();
@@ -258,40 +259,67 @@ async function createIndexes(feedsCollection, itemsCollection) {
 }
 
 /**
- * Prune items older than retention period and update feed item counts
+ * Prune items older than the retention period.
+ *
+ * The newest `minItemsPerFeed` items of every feed are kept whatever their
+ * age. Without that floor a low-traffic feed whose whole backlog predates the
+ * cutoff is emptied and refetched on every single sync, so it churns forever
+ * and always reads as empty.
  * @param {Collection} itemsCollection - Items collection
  * @param {Collection} feedsCollection - Feeds collection
  * @param {number} retentionDays - Days to keep items
+ * @param {number} minItemsPerFeed - Newest items always kept per feed
  * @returns {Promise<number>} Number of items pruned
  */
-async function pruneOldItems(itemsCollection, feedsCollection, retentionDays) {
+export async function pruneOldItems(
+  itemsCollection,
+  feedsCollection,
+  retentionDays,
+  minItemsPerFeed = 10,
+) {
   const cutoff = new Date();
   cutoff.setDate(cutoff.getDate() - retentionDays);
 
   try {
-    const result = await itemsCollection.deleteMany({
-      pubDate: { $lt: cutoff },
-    });
-
-    if (result.deletedCount > 0) {
-      console.log(
-        `[RSS] Pruned ${result.deletedCount} items older than ${retentionDays} days`,
-      );
-
-      // Update item counts for all feeds
-      const feeds = await feedsCollection.find({}).toArray();
-      for (const feed of feeds) {
-        const count = await itemsCollection.countDocuments({
+    const feeds = await feedsCollection.find({}).toArray();
+    let deletedCount = 0;
+
+    for (const feed of feeds) {
+      const keep = await itemsCollection
+        .find({ feedId: feed._id })
+        .sort({ pubDate: -1 })
+        .limit(minItemsPerFeed)
+        .project({ _id: 1 })
+        .toArray();
+
+      const result = await itemsCollection.deleteMany({
+        feedId: feed._id,
+        // $ne: null also excludes missing dates: in BSON null sorts before
+        // Date, so a bare $lt would delete every undated item as "too old".
+        pubDate: { $lt: cutoff, $ne: null },
+        _id: { $nin: keep.map((item) => item._id) },
+      });
+
+      if (result.deletedCount > 0) {
+        deletedCount += result.deletedCount;
+
+        const itemCount = await itemsCollection.countDocuments({
           feedId: feed._id,
         });
         await feedsCollection.updateOne(
           { _id: feed._id },
-          { $set: { itemCount: count } },
+          { $set: { itemCount } },
         );
       }
     }
 
-    return result.deletedCount;
+    if (deletedCount > 0) {
+      console.log(
+        `[RSS] Pruned ${deletedCount} items older than ${retentionDays} days`,
+      );
+    }
+
+    return deletedCount;
   } catch (err) {
     console.error("[RSS] Prune error:", err.message);
     return 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-rss",
-  "version": "1.0.14",
+  "version": "1.0.16",
   "description": "RSS feed reader endpoint for Indiekit. Aggregates multiple feeds, caches in MongoDB, displays on frontend.",
   "keywords": [
     "indiekit",
@@ -30,6 +30,9 @@
   },
   "type": "module",
   "main": "index.js",
+  "scripts": {
+    "test": "node --test \"test/*.test.js\""
+  },
   "exports": {
     ".": "./index.js"
   },
@@ -41,6 +44,7 @@
     "index.js"
   ],
   "dependencies": {
+    "@rmdes/indiekit-startup-gate": "^1.0.0",
     "@indiekit/error": "^1.0.0-beta.25",
     "express": "^5.0.0",
     "rss-parser": "^3.13.0",