@rmdes/indiekit-endpoint-lastfm 1.0.0 → 1.0.2

package/lib/lastfm-client.js

@@ -50,10 +50,28 @@ export class LastFmClient {
       },
     });
 
+    // Check content type before parsing
+    const contentType = response.headers.get("content-type") || "";
+
     if (!response.ok) {
+      // Handle non-JSON error responses (e.g., HTML error pages)
+      if (!contentType.includes("application/json")) {
+        const text = await response.text();
+        console.error("[Last.fm] Non-JSON error response:", text.slice(0, 200));
+        throw new IndiekitError(`Last.fm API returned ${response.status}: ${response.statusText}`, {
+          status: response.status,
+        });
+      }
       throw await IndiekitError.fromFetch(response);
     }
 
+    // Handle non-JSON success responses (shouldn't happen but be safe)
+    if (!contentType.includes("application/json")) {
+      const text = await response.text();
+      console.error("[Last.fm] Unexpected non-JSON response:", text.slice(0, 200));
+      throw new Error("Last.fm API returned non-JSON response");
+    }
+
     const data = await response.json();
 
     // Check for Last.fm API errors

package/lib/utils.js

@@ -302,12 +302,18 @@ export function formatLovedTrack(track) {
  * @returns {object} - Formatted artist
  */
 export function formatTopArtist(artist, rank) {
+  // Handle edge cases where artist data might be malformed
+  let name = artist?.name;
+  if (typeof name !== "string") {
+    name = name?.["#text"] || String(name || "Unknown Artist");
+  }
+
   return {
     rank,
-    name: artist.name,
-    playCount: parseInt(artist.playcount) || 0,
-    url: artist.url,
-    mbid: artist.mbid || null,
+    name,
+    playCount: parseInt(artist?.playcount) || 0,
+    url: artist?.url || null,
+    mbid: artist?.mbid || null,
     imageUrl: getCoverUrl(artist),
   };
 }
@@ -319,13 +325,28 @@ export function formatTopArtist(artist, rank) {
  * @returns {object} - Formatted album
  */
 export function formatTopAlbum(album, rank) {
+  // Handle edge cases where album data might be malformed
+  let title = album?.name;
+  if (typeof title !== "string") {
+    title = title?.["#text"] || String(title || "Unknown Album");
+  }
+
+  // Extract artist name from various possible formats
+  let artist = album?.artist;
+  if (typeof artist === "object" && artist !== null) {
+    artist = artist.name || artist["#text"] || "Unknown Artist";
+  }
+  if (typeof artist !== "string") {
+    artist = String(artist || "Unknown Artist");
+  }
+
   return {
     rank,
-    title: album.name,
-    artist: album.artist?.name || album.artist?.["#text"] || album.artist,
-    playCount: parseInt(album.playcount) || 0,
-    url: album.url,
-    mbid: album.mbid || null,
+    title,
+    artist,
+    playCount: parseInt(album?.playcount) || 0,
+    url: album?.url || null,
+    mbid: album?.mbid || null,
     coverUrl: getCoverUrl(album),
   };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-lastfm",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Last.fm scrobble and listening activity endpoint for Indiekit. Display listening history, loved tracks, and statistics.",
   "keywords": [
     "indiekit",