@rmdes/indiekit-endpoint-github 1.2.6 → 1.2.7

package/index.js

@@ -2,6 +2,8 @@ import express from "express";
 import { fileURLToPath } from "node:url";
 import path from "node:path";
 
+import { waitForReady } from "@rmdes/indiekit-startup-gate";
+
 import { activityController } from "./lib/controllers/activity.js";
 import { changelogController } from "./lib/controllers/changelog.js";
 import { commitsController } from "./lib/controllers/commits.js";
@@ -115,13 +117,22 @@ export default class GitHubEndpoint {
 
     // Start background sync for starred repos (if token + DB available)
     if (this.options.token && Indiekit.database) {
-      import("./lib/starred-sync.js")
-        .then(({ startStarredSync }) => {
-          startStarredSync(Indiekit, this.options);
-        })
-        .catch((error) => {
-          console.error("[GitHub Stars] Sync scheduler failed to start:", error.message);
-        });
+      this._stopGate = waitForReady(
+        () => {
+          import("./lib/starred-sync.js")
+            .then(({ startStarredSync }) => {
+              startStarredSync(Indiekit, this.options);
+            })
+            .catch((error) => {
+              console.error("[GitHub Stars] Sync scheduler failed to start:", error.message);
+            });
+        },
+        { label: "GitHub" },
+      );
     }
   }
+
+  destroy() {
+    this._stopGate?.();
+  }
 }

package/lib/controllers/activity.js

@@ -109,16 +109,16 @@ export const activityController = {
           activity = utils.extractRepoActivity(events, username);
         }
       } catch (apiError) {
-        console.error("[Activity] API error:", apiError.message);
-        return response.json({ activity: [], error: "GitHub API temporarily unavailable" });
+        return response
+          .status(apiError.status || 500)
+          .json({ error: apiError.message });
       }
 
       activity = activity.slice(0, limits.activity);
 
       response.json({ activity });
     } catch (error) {
-      console.error("[Activity] Controller error:", error.message);
-      response.json({ activity: [], error: "GitHub API temporarily unavailable" });
+      next(error);
     }
   },
 };

package/lib/controllers/changelog.js

@@ -206,16 +206,7 @@ export const changelogController = {
         generatedAt: new Date().toISOString(),
       });
     } catch (error) {
-      console.error("[Changelog] API error:", error.message);
-      response.json({
-        commits: [],
-        categories: {},
-        commitCategories: {},
-        totalCommits: 0,
-        days: daysValue || 30,
-        generatedAt: new Date().toISOString(),
-        error: "GitHub API temporarily unavailable",
-      });
+      next(error);
     }
   },
 };

package/lib/controllers/stars.js

@@ -69,16 +69,16 @@ export const starsController = {
       try {
         starred = await client.getUserStarred(username, limits.stars);
       } catch (apiError) {
-        console.error("[Stars] API error:", apiError.message);
-        return response.json({ stars: [], error: "GitHub API temporarily unavailable" });
+        return response
+          .status(apiError.status || 500)
+          .json({ error: apiError.message });
       }
 
       const stars = utils.formatStarred(starred);
 
       response.json({ stars });
     } catch (error) {
-      console.error("[Stars] Controller error:", error.message);
-      response.json({ stars: [], error: "GitHub API temporarily unavailable" });
+      next(error);
     }
   },
 };

package/lib/github-client.js

@@ -22,7 +22,7 @@ export class GitHubClient {
   async fetch(endpoint) {
     const url = `${BASE_URL}${endpoint}`;
 
-    // Check cache first — return fresh data immediately
+    // Check cache first
     const cached = this.cache.get(url);
     if (cached && Date.now() - cached.timestamp < this.cacheTtl) {
       return cached.data;
@@ -37,40 +37,28 @@ export class GitHubClient {
       headers.Authorization = `Bearer ${this.token}`;
     }
 
-    try {
-      const response = await fetch(url, { headers });
-
-      if (!response.ok) {
-        // Only use fromFetch for JSON error responses; GitHub sometimes returns
-        // HTML error pages (e.g., 502 Bad Gateway) which cause SyntaxError noise
-        const contentType = response.headers.get("content-type") || "";
-        if (contentType.includes("json")) {
-          throw await IndiekitError.fromFetch(response);
-        }
-
-        throw new IndiekitError(response.statusText, {
-          status: response.status,
-          code: response.statusText,
-        });
+    const response = await fetch(url, { headers });
+
+    if (!response.ok) {
+      // Only use fromFetch for JSON error responses; GitHub sometimes returns
+      // HTML error pages (e.g., 502 Bad Gateway) which cause SyntaxError noise
+      const contentType = response.headers.get("content-type") || "";
+      if (contentType.includes("json")) {
+        throw await IndiekitError.fromFetch(response);
       }
 
-      const data = await response.json();
+      throw new IndiekitError(response.statusText, {
+        status: response.status,
+        code: response.statusText,
+      });
+    }
 
-      // Cache result
-      this.cache.set(url, { data, timestamp: Date.now() });
+    const data = await response.json();
 
-      return data;
-    } catch (error) {
-      // Stale-while-error: if we have stale cached data, return it
-      if (cached) {
-        console.warn(
-          `[GitHub] API error for ${endpoint}: ${error.message}. Serving stale cache (age: ${Math.round((Date.now() - cached.timestamp) / 60_000)}min)`,
-        );
-        return cached.data;
-      }
+    // Cache result
+    this.cache.set(url, { data, timestamp: Date.now() });
 
-      throw error;
-    }
+    return data;
   }
 
   /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-github",
-  "version": "1.2.6",
+  "version": "1.2.7",
   "description": "GitHub activity endpoint for Indiekit. Display commits, stars, contributions, and featured repositories.",
   "keywords": [
     "indiekit",
@@ -40,6 +40,7 @@
   ],
   "dependencies": {
     "@indiekit/error": "^1.0.0-beta.25",
+    "@rmdes/indiekit-startup-gate": "^1.0.0",
     "express": "^5.0.0"
   },
   "peerDependencies": {