@rmdes/indiekit-endpoint-activitypub 3.6.1 → 3.6.3

package/lib/mastodon/backfill-timeline.js

@@ -21,6 +21,7 @@ export async function backfillTimeline(collections) {
 
   // Get local profile for author info
   const profile = await ap_profile?.findOne({});
+  const siteUrl = profile?.url?.replace(/\/$/, "") || "";
   const author = profile
     ? {
         name: profile.name || "",
@@ -58,24 +59,30 @@ export async function backfillTimeline(collections) {
       continue;
     }
 
-    // Map JF2 properties to timeline item format
-    const content = normalizeContent(props.content);
+    // Build content — interaction types (bookmark, like, repost) may not have
+    // body content, so synthesize it from the interaction target URL
+    const content = buildContent(props);
     const type = mapPostType(props["post-type"]);
 
+    // Extract categories + inline hashtags from content
+    const categories = normalizeArray(props.category);
+    const inlineHashtags = extractHashtags(content.text + " " + (content.html || ""));
+    const mergedCategories = mergeCategories(categories, inlineHashtags);
+
     const timelineItem = {
       uid,
       url: uid,
       type,
-      content,
+      content: rewriteHashtagLinks(content, siteUrl),
       author,
       published: props.published || props.date || new Date().toISOString(),
       createdAt: props.published || props.date || new Date().toISOString(),
       visibility: "public",
       sensitive: false,
-      category: normalizeArray(props.category),
-      photo: normalizeMediaArray(props.photo),
-      video: normalizeMediaArray(props.video),
-      audio: normalizeMediaArray(props.audio),
+      category: mergedCategories,
+      photo: normalizeMediaArray(props.photo, siteUrl),
+      video: normalizeMediaArray(props.video, siteUrl),
+      audio: normalizeMediaArray(props.audio, siteUrl),
       readBy: [],
     };
 
@@ -107,6 +114,55 @@ export async function backfillTimeline(collections) {
   return { total: allPosts.length, inserted, skipped };
 }
 
+// ─── Content Building ─────────────────────────────────────────────────────────
+
+/**
+ * Build content from JF2 properties, synthesizing content for interaction types.
+ * Bookmarks, likes, and reposts often have no body text — show the target URL.
+ */
+function buildContent(props) {
+  const raw = normalizeContent(props.content);
+
+  // If there's already content, use it
+  if (raw.text || raw.html) return raw;
+
+  // Synthesize content for interaction types
+  const bookmarkOf = props["bookmark-of"];
+  const likeOf = props["like-of"];
+  const repostOf = props["repost-of"];
+  const name = props.name;
+
+  if (bookmarkOf) {
+    const label = name || bookmarkOf;
+    return {
+      text: `Bookmarked: ${label}`,
+      html: `<p>Bookmarked: <a href="${escapeHtml(bookmarkOf)}">${escapeHtml(label)}</a></p>`,
+    };
+  }
+
+  if (likeOf) {
+    return {
+      text: `Liked: ${likeOf}`,
+      html: `<p>Liked: <a href="${escapeHtml(likeOf)}">${escapeHtml(likeOf)}</a></p>`,
+    };
+  }
+
+  if (repostOf) {
+    const label = name || repostOf;
+    return {
+      text: `Reposted: ${label}`,
+      html: `<p>Reposted: <a href="${escapeHtml(repostOf)}">${escapeHtml(label)}</a></p>`,
+    };
+  }
+
+  // Article with title but no body
+  if (name) {
+    return { text: name, html: `<p>${escapeHtml(name)}</p>` };
+  }
+
+  return raw;
+}
+
 /**
  * Normalize content from JF2 properties to { text, html } format.
  */
@@ -122,6 +178,58 @@ function normalizeContent(content) {
   return { text: "", html: "" };
 }
 
+// ─── Hashtag Handling ─────────────────────────────────────────────────────────
+
+/**
+ * Extract hashtags from text content.
+ * Matches #word patterns, returns lowercase tag names without the # prefix.
+ */
+function extractHashtags(text) {
+  if (!text) return [];
+  const matches = text.match(/(?:^|\s)#([a-zA-Z_]\w*)/g);
+  if (!matches) return [];
+  return [...new Set(matches.map((m) => m.trim().slice(1).toLowerCase()))];
+}
+
+/**
+ * Merge explicit categories with inline hashtags (deduplicated, case-insensitive).
+ */
+function mergeCategories(categories, hashtags) {
+  const seen = new Set(categories.map((c) => c.toLowerCase()));
+  const result = [...categories];
+  for (const tag of hashtags) {
+    if (!seen.has(tag)) {
+      seen.add(tag);
+      result.push(tag);
+    }
+  }
+  return result;
+}
+
+/**
+ * Rewrite hashtag links in HTML from site-internal (/categories/tag/) to
+ * Mastodon-compatible format. Mastodon clients use the tag objects, not
+ * inline links, but having correct href helps with link following.
+ */
+function rewriteHashtagLinks(content, siteUrl) {
+  if (!content.html) return content;
+  // Rewrite /categories/tag/ links to /tags/tag (Mastodon convention)
+  let html = content.html.replace(
+    /href="\/categories\/([^/"]+)\/?"/g,
+    (_, tag) => `href="${siteUrl}/tags/${tag}" class="hashtag" rel="tag"`,
+  );
+  // Also rewrite absolute site category links
+  if (siteUrl) {
+    html = html.replace(
+      new RegExp(`href="${escapeRegex(siteUrl)}/categories/([^/"]+)/?"`, "g"),
+      (_, tag) => `href="${siteUrl}/tags/${tag}" class="hashtag" rel="tag"`,
+    );
+  }
+  return { ...content, html };
+}
+
+// ─── Post Type Mapping ────────────────────────────────────────────────────────
+
 /**
  * Map Micropub post-type to timeline type.
  */
@@ -138,12 +246,15 @@ function mapPostType(postType) {
     case "repost":
       return "boost";
     case "like":
+    case "bookmark":
       return "note";
     default:
       return "note";
   }
 }
 
+// ─── Normalization Helpers ────────────────────────────────────────────────────
+
 /**
  * Normalize a value to an array of strings.
  */
@@ -154,14 +265,47 @@ function normalizeArray(value) {
 }
 
 /**
- * Normalize media values (can be strings or objects with url property).
+ * Normalize media values — resolves relative URLs to absolute.
+ *
+ * @param {*} value - String, object with url, or array thereof
+ * @param {string} siteUrl - Base site URL for resolving relative paths
  */
-function normalizeMediaArray(value) {
+function normalizeMediaArray(value, siteUrl) {
   if (!value) return [];
   const arr = Array.isArray(value) ? value : [value];
   return arr.map((item) => {
-    if (typeof item === "string") return item;
-    if (typeof item === "object" && item.url) return item;
+    if (typeof item === "string") return resolveUrl(item, siteUrl);
+    if (typeof item === "object" && item.url) {
+      return { ...item, url: resolveUrl(item.url, siteUrl) };
+    }
     return null;
   }).filter(Boolean);
 }
+
+/**
+ * Resolve a URL — if relative, prepend the site URL.
+ */
+function resolveUrl(url, siteUrl) {
+  if (!url) return url;
+  if (url.startsWith("http://") || url.startsWith("https://")) return url;
+  if (url.startsWith("/")) return `${siteUrl}${url}`;
+  return `${siteUrl}/${url}`;
+}
+
+/**
+ * Escape HTML entities.
+ */
+function escapeHtml(str) {
+  return str
+    .replace(/&/g, "&amp;")
+    .replace(/</g, "&lt;")
+    .replace(/>/g, "&gt;")
+    .replace(/"/g, "&quot;");
+}
+
+/**
+ * Escape regex special characters.
+ */
+function escapeRegex(str) {
+  return str.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+}

package/lib/mastodon/routes/oauth.js

@@ -310,7 +310,7 @@ router.post("/oauth/authorize", async (req, res, next) => {
           "error_description",
           "The resource owner denied the request",
         );
-        return res.redirect(url.toString());
+        return redirectToUri(res, redirect_uri, url.toString());
       }
       return res.status(403).json({
         error: "access_denied",
@@ -362,7 +362,7 @@ router.post("/oauth/authorize", async (req, res, next) => {
     // Redirect with code
     const url = new URL(redirect_uri);
     url.searchParams.set("code", code);
-    res.redirect(url.toString());
+    redirectToUri(res, redirect_uri, url.toString());
   } catch (error) {
     next(error);
   }
@@ -600,4 +600,36 @@ function extractClientCredentials(req) {
   };
 }
 
+/**
+ * Redirect to a URI, handling custom schemes for native apps.
+ *
+ * HTTP(S) redirect URIs use a standard 302 redirect (web clients).
+ * Custom scheme URIs (fedilab://, moshidon-android-auth://) use an
+ * HTML page with JavaScript + meta refresh. Android Chrome Custom Tabs
+ * block 302 redirects to non-HTTP schemes but allow client-side navigation.
+ *
+ * @param {object} res - Express response
+ * @param {string} originalUri - The registered redirect_uri (to detect scheme)
+ * @param {string} fullUrl - The complete redirect URL with query params
+ */
+function redirectToUri(res, originalUri, fullUrl) {
+  if (originalUri.startsWith("http://") || originalUri.startsWith("https://")) {
+    return res.redirect(fullUrl);
+  }
+
+  // Native app — HTML page with JS redirect + meta refresh fallback
+  res.type("html").send(`<!DOCTYPE html>
+<html lang="en">
+<head>
+  <meta charset="utf-8">
+  <meta http-equiv="refresh" content="0;url=${fullUrl}">
+  <title>Redirecting…</title>
+</head>
+<body>
+  <p>Redirecting to application…</p>
+  <script>window.location.href = ${JSON.stringify(fullUrl)};</script>
+</body>
+</html>`);
+}
+
 export default router;

package/lib/mastodon/routes/statuses.js

@@ -219,6 +219,34 @@ router.post("/api/v1/statuses", async (req, res, next) => {
     const handle = pluginOptions.handle || "user";
     const actorUrl = profile?.url || `${publicationUrl}/users/${handle}`;
 
+    // Extract hashtags from status text and merge with any Micropub categories
+    const categories = data.properties.category || [];
+    const inlineHashtags = (statusText || "").match(/(?:^|\s)#([a-zA-Z_]\w*)/g);
+    if (inlineHashtags) {
+      const existing = new Set(categories.map((c) => c.toLowerCase()));
+      for (const match of inlineHashtags) {
+        const tag = match.trim().slice(1).toLowerCase();
+        if (!existing.has(tag)) {
+          existing.add(tag);
+          categories.push(tag);
+        }
+      }
+    }
+
+    // Resolve relative media URLs to absolute
+    const resolveMedia = (items) => {
+      if (!items || !items.length) return [];
+      return items.map((item) => {
+        if (typeof item === "string") {
+          return item.startsWith("http") ? item : `${publicationUrl.replace(/\/$/, "")}/${item.replace(/^\//, "")}`;
+        }
+        if (item?.url && !item.url.startsWith("http")) {
+          return { ...item, url: `${publicationUrl.replace(/\/$/, "")}/${item.url.replace(/^\//, "")}` };
+        }
+        return item;
+      });
+    };
+
     const now = new Date().toISOString();
     const timelineItem = await addTimelineItem(collections, {
       uid: postUrl,
@@ -234,16 +262,16 @@ router.post("/api/v1/statuses", async (req, res, next) => {
       createdAt: now,
       author: {
         name: profile?.name || handle,
-        url: actorUrl,
+        url: profile?.url || publicationUrl,
         photo: profile?.icon || "",
         handle: `@${handle}`,
         emojis: [],
         bot: false,
       },
-      photo: data.properties.photo || [],
-      video: data.properties.video || [],
-      audio: data.properties.audio || [],
-      category: data.properties.category || [],
+      photo: resolveMedia(data.properties.photo || []),
+      video: resolveMedia(data.properties.video || []),
+      audio: resolveMedia(data.properties.audio || []),
+      category: categories,
       counts: { replies: 0, boosts: 0, likes: 0 },
       linkPreviews: [],
       mentions: [],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-activitypub",
-  "version": "3.6.1",
+  "version": "3.6.3",
   "description": "ActivityPub federation endpoint for Indiekit via Fedify. Adds full fediverse support: actor, inbox, outbox, followers, following, syndication, and Mastodon migration.",
   "keywords": [
     "indiekit",