@rmdes/indiekit-endpoint-activitypub 2.4.0 → 2.4.2

package/index.js

@@ -1000,18 +1000,27 @@ export default class ActivityPubEndpoint {
         );
       }
 
-      // Drop non-sparse indexes if they exist (created by earlier versions),
-      // then recreate with sparse:true so multiple null values are allowed.
-      this._collections.ap_muted.dropIndex("url_1").catch(() => {});
-      this._collections.ap_muted.dropIndex("keyword_1").catch(() => {});
-      this._collections.ap_muted.createIndex(
-        { url: 1 },
-        { unique: true, sparse: true, background: true },
-      );
-      this._collections.ap_muted.createIndex(
-        { keyword: 1 },
-        { unique: true, sparse: true, background: true },
-      );
+      // Muted collection — sparse unique indexes (allow multiple null values)
+      this._collections.ap_muted
+        .dropIndex("url_1")
+        .catch(() => {})
+        .then(() =>
+          this._collections.ap_muted.createIndex(
+            { url: 1 },
+            { unique: true, sparse: true, background: true },
+          ),
+        )
+        .catch(() => {});
+      this._collections.ap_muted
+        .dropIndex("keyword_1")
+        .catch(() => {})
+        .then(() =>
+          this._collections.ap_muted.createIndex(
+            { keyword: 1 },
+            { unique: true, sparse: true, background: true },
+          ),
+        )
+        .catch(() => {});
 
       this._collections.ap_blocked.createIndex(
         { url: 1 },

package/lib/controllers/api-timeline.js

@@ -10,6 +10,7 @@ import {
   getBlockedUrls,
   getFilterMode,
 } from "../storage/moderation.js";
+import { stripQuoteReferenceHtml } from "../og-unfurl.js";
 
 export function apiTimelineController(mountPath) {
   return async (request, response, next) => {
@@ -134,6 +135,14 @@ export function apiTimelineController(mountPath) {
         }
       }
 
+      // Strip "RE:" paragraphs from items that have quote embeds
+      for (const item of items) {
+        const quoteRef = item.quoteUrl || item.quote?.url || item.quote?.uid;
+        if (item.quote && quoteRef && item.content?.html) {
+          item.content.html = stripQuoteReferenceHtml(item.content.html, quoteRef);
+        }
+      }
+
       const csrfToken = getToken(request.session);
 
       // Render each card server-side using the same Nunjucks template

package/lib/controllers/post-detail.js

@@ -1,9 +1,9 @@
 // Post detail controller — view individual AP posts/notes/articles
 import { Article, Note, Person, Service, Application } from "@fedify/fedify/vocab";
 import { getToken } from "../csrf.js";
-import { extractObjectData } from "../timeline-store.js";
+import { extractObjectData, extractActorInfo } from "../timeline-store.js";
 import { getCached, setCache } from "../lookup-cache.js";
-import { fetchAndStoreQuote } from "../og-unfurl.js";
+import { fetchAndStoreQuote, stripQuoteReferenceHtml } from "../og-unfurl.js";
 
 // Load parent posts (inReplyTo chain) up to maxDepth levels
 async function loadParentChain(ctx, documentLoader, timelineCol, parentUrl, maxDepth = 5) {
@@ -332,6 +332,20 @@ export function postDetailController(mountPath, plugin) {
 
           if (quoteObject) {
             const quoteData = await extractObjectData(quoteObject, { documentLoader: qLoader });
+
+            // If author photo is empty, try fetching the actor directly
+            if (!quoteData.author.photo && quoteData.author.url) {
+              try {
+                const actor = await qCtx.lookupObject(new URL(quoteData.author.url), { documentLoader: qLoader });
+                if (actor) {
+                  const actorInfo = await extractActorInfo(actor, { documentLoader: qLoader });
+                  if (actorInfo.photo) quoteData.author.photo = actorInfo.photo;
+                }
+              } catch {
+                // Actor fetch failed — keep existing author data
+              }
+            }
+
             timelineItem.quote = {
               url: quoteData.url || quoteData.uid,
               uid: quoteData.uid,
@@ -342,11 +356,24 @@ export function postDetailController(mountPath, plugin) {
               photo: quoteData.photo?.slice(0, 1) || [],
             };
 
+            // Strip RE: paragraph from parent content
+            const quoteRef = timelineItem.quoteUrl || timelineItem.quote.url || timelineItem.quote.uid;
+            if (timelineItem.content?.html && quoteRef) {
+              timelineItem.content.html = stripQuoteReferenceHtml(
+                timelineItem.content.html,
+                quoteRef,
+              );
+            }
+
             // Persist for future requests (fire-and-forget)
             if (timelineCol) {
+              const persistUpdate = { $set: { quote: timelineItem.quote } };
+              if (timelineItem.content?.html) {
+                persistUpdate.$set["content.html"] = timelineItem.content.html;
+              }
               timelineCol.updateOne(
                 { $or: [{ uid: objectUrl }, { url: objectUrl }] },
-                { $set: { quote: timelineItem.quote } },
+                persistUpdate,
               ).catch(() => {});
             }
           }
@@ -355,6 +382,14 @@ export function postDetailController(mountPath, plugin) {
         }
       }
 
+      // Strip RE: paragraph for items with existing quote data (render-time cleanup)
+      if (timelineItem.quote && timelineItem.content?.html) {
+        const quoteRef = timelineItem.quoteUrl || timelineItem.quote.url || timelineItem.quote.uid;
+        if (quoteRef) {
+          timelineItem.content.html = stripQuoteReferenceHtml(timelineItem.content.html, quoteRef);
+        }
+      }
+
       const csrfToken = getToken(request.session);
 
       response.render("activitypub-post-detail", {

package/lib/controllers/reader.js

@@ -19,6 +19,7 @@ import {
   getFilterMode,
 } from "../storage/moderation.js";
 import { getFollowedTags } from "../storage/followed-tags.js";
+import { stripQuoteReferenceHtml } from "../og-unfurl.js";
 
 // Re-export controllers from split modules for backward compatibility
 export {
@@ -196,6 +197,14 @@ export function readerController(mountPath) {
         }
       }
 
+      // Strip "RE:" paragraphs from items that have quote embeds
+      for (const item of items) {
+        const quoteRef = item.quoteUrl || item.quote?.url || item.quote?.uid;
+        if (item.quote && quoteRef && item.content?.html) {
+          item.content.html = stripQuoteReferenceHtml(item.content.html, quoteRef);
+        }
+      }
+
       // CSRF token for interaction forms
       const csrfToken = getToken(request.session);
 

package/lib/og-unfurl.js

@@ -267,6 +267,22 @@ export async function fetchAndStoreQuote(collections, uid, quoteUrl, ctx, docume
 
     const quoteData = await extractObjectData(object, { documentLoader });
 
+    // If author photo is empty, try fetching the actor directly
+    if (!quoteData.author.photo && quoteData.author.url) {
+      try {
+        const actor = await ctx.lookupObject(new URL(quoteData.author.url), { documentLoader });
+        if (actor) {
+          const { extractActorInfo } = await import("./timeline-store.js");
+          const actorInfo = await extractActorInfo(actor, { documentLoader });
+          if (actorInfo.photo) {
+            quoteData.author.photo = actorInfo.photo;
+          }
+        }
+      } catch {
+        // Actor fetch failed — keep existing author data
+      }
+    }
+
     const quote = {
       url: quoteData.url || quoteData.uid,
       uid: quoteData.uid,
@@ -277,11 +293,46 @@ export async function fetchAndStoreQuote(collections, uid, quoteUrl, ctx, docume
       photo: quoteData.photo?.slice(0, 1) || [],
     };
 
-    await collections.ap_timeline.updateOne(
-      { uid },
-      { $set: { quote } },
-    );
+    // Strip the "RE: <link>" paragraph from the parent post's content
+    // Mastodon adds this as: <p>RE: <a href="QUOTE_URL">...</a></p>
+    const update = { $set: { quote } };
+    const parentItem = await collections.ap_timeline.findOne({ uid });
+    if (parentItem?.content?.html) {
+      const cleaned = stripQuoteReferenceHtml(parentItem.content.html, quoteUrl);
+      if (cleaned !== parentItem.content.html) {
+        update.$set["content.html"] = cleaned;
+      }
+    }
+
+    await collections.ap_timeline.updateOne({ uid }, update);
   } catch (error) {
     console.error(`[og-unfurl] Failed to fetch quote for ${uid}: ${error.message}`);
   }
 }
+
+/**
+ * Strip the "RE: <link>" paragraph that Mastodon adds for quoted posts.
+ * Removes <p> elements containing "RE:" followed by a link to the quote URL.
+ * @param {string} html - Content HTML
+ * @param {string} quoteUrl - URL of the quoted post
+ * @returns {string} Cleaned HTML
+ */
+export function stripQuoteReferenceHtml(html, quoteUrl) {
+  if (!html || !quoteUrl) return html;
+  // Match <p> containing "RE:" and a link whose href contains the quote domain+path
+  // Mastodon uses both /users/X/statuses/Y and /@X/Y URL formats
+  try {
+    const quoteUrlObj = new URL(quoteUrl);
+    const quoteDomain = quoteUrlObj.hostname;
+    // Escape special regex chars in domain
+    const domainEscaped = quoteDomain.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+    // Match <p>RE: <a href="...DOMAIN...">...</a></p> (with optional whitespace)
+    const re = new RegExp(
+      `<p>\\s*RE:\\s*<a\\s[^>]*href="[^"]*${domainEscaped}[^"]*"[^>]*>.*?</a>\\s*</p>`,
+      "i",
+    );
+    return html.replace(re, "").trim();
+  } catch {
+    return html;
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-activitypub",
-  "version": "2.4.0",
+  "version": "2.4.2",
   "description": "ActivityPub federation endpoint for Indiekit via Fedify. Adds full fediverse support: actor, inbox, outbox, followers, following, syndication, and Mastodon migration.",
   "keywords": [
     "indiekit",