@rmdes/indiekit-endpoint-activitypub 2.10.1 → 2.11.0

package/index.js

@@ -8,6 +8,7 @@ import {
 import {
   jf2ToActivityStreams,
   jf2ToAS2Activity,
+  parseMentions,
 } from "./lib/jf2-to-as2.js";
 import { dashboardController } from "./lib/controllers/dashboard.js";
 import {
@@ -467,6 +468,40 @@ export default class ActivityPubEndpoint {
             }
           }
 
+          // Resolve @user@domain mentions in content via WebFinger
+          const contentText = properties.content?.html || properties.content || "";
+          const mentionHandles = parseMentions(contentText);
+          const resolvedMentions = [];
+          const mentionRecipients = [];
+
+          for (const { handle } of mentionHandles) {
+            try {
+              const mentionedActor = await ctx.lookupObject(
+                new URL(`acct:${handle}`),
+              );
+              if (mentionedActor?.id) {
+                resolvedMentions.push({
+                  handle,
+                  actorUrl: mentionedActor.id.href,
+                });
+                mentionRecipients.push({
+                  handle,
+                  actorUrl: mentionedActor.id.href,
+                  actor: mentionedActor,
+                });
+                console.info(
+                  `[ActivityPub] Resolved mention @${handle} → ${mentionedActor.id.href}`,
+                );
+              }
+            } catch (error) {
+              console.warn(
+                `[ActivityPub] Could not resolve mention @${handle}: ${error.message}`,
+              );
+              // Still add with no actorUrl so it gets a fallback link
+              resolvedMentions.push({ handle, actorUrl: null });
+            }
+          }
+
           const activity = jf2ToAS2Activity(
             properties,
             actorUrl,
@@ -475,6 +510,7 @@ export default class ActivityPubEndpoint {
               replyToActorUrl: replyToActor?.url,
               replyToActorHandle: replyToActor?.handle,
               visibility: self.options.defaultVisibility,
+              mentions: resolvedMentions,
             },
           );
 
@@ -529,12 +565,35 @@ export default class ActivityPubEndpoint {
             }
           }
 
+          // Deliver to mentioned actors' inboxes (skip reply-to author, already delivered above)
+          for (const { handle: mHandle, actorUrl: mUrl, actor: mActor } of mentionRecipients) {
+            if (replyToActor?.url === mUrl) continue;
+            try {
+              await ctx.sendActivity(
+                { identifier: handle },
+                mActor,
+                activity,
+                { orderingKey: properties.url },
+              );
+              console.info(
+                `[ActivityPub] Mention delivered to @${mHandle}: ${mUrl}`,
+              );
+            } catch (error) {
+              console.warn(
+                `[ActivityPub] Failed to deliver mention to @${mHandle}: ${error.message}`,
+              );
+            }
+          }
+
           // Determine activity type name
           const typeName =
             activity.constructor?.name || "Create";
           const replyNote = replyToActor
             ? ` (reply to ${replyToActor.url})`
             : "";
+          const mentionNote = mentionRecipients.length > 0
+            ? ` (mentions: ${mentionRecipients.map(m => `@${m.handle}`).join(", ")})`
+            : "";
 
           await logActivity(self._collections.ap_activities, {
             direction: "outbound",
@@ -542,7 +601,7 @@ export default class ActivityPubEndpoint {
             actorUrl: self._publicationUrl,
             objectUrl: properties.url,
             targetUrl: properties["in-reply-to"] || undefined,
-            summary: `Sent ${typeName} for ${properties.url} to ${followerCount} followers${replyNote}`,
+            summary: `Sent ${typeName} for ${properties.url} to ${followerCount} followers${replyNote}${mentionNote}`,
           });
 
           console.info(

package/lib/jf2-to-as2.js

@@ -36,6 +36,50 @@ function linkifyUrls(html) {
   );
 }
 
+/**
+ * Parse @user@domain mention patterns from text content.
+ * Returns array of { handle: "user@domain", username: "user", domain: "domain.tld" }.
+ */
+export function parseMentions(text) {
+  if (!text) return [];
+  // Strip HTML tags for parsing
+  const plain = text.replace(/<[^>]*>/g, " ");
+  const mentionRegex = /(?<![\/\w])@([\w.-]+)@([\w.-]+\.\w{2,})/g;
+  const mentions = [];
+  const seen = new Set();
+  let match;
+  while ((match = mentionRegex.exec(plain)) !== null) {
+    const handle = `${match[1]}@${match[2]}`;
+    if (!seen.has(handle.toLowerCase())) {
+      seen.add(handle.toLowerCase());
+      mentions.push({ handle, username: match[1], domain: match[2] });
+    }
+  }
+  return mentions;
+}
+
+/**
+ * Replace @user@domain patterns in HTML with linked mentions.
+ * resolvedMentions: [{ handle, actorUrl }]
+ * Unresolved handles get a WebFinger-style link as fallback.
+ */
+function linkifyMentions(html, resolvedMentions) {
+  if (!html || !resolvedMentions?.length) return html;
+  for (const { handle, actorUrl } of resolvedMentions) {
+    // Escape handle for regex (dots, hyphens)
+    const escaped = handle.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
+    // Match @handle not already inside an HTML tag attribute or anchor text
+    const pattern = new RegExp(`(?<!["\\/\\w])@${escaped}(?![\\w])`, "gi");
+    const parts = handle.split("@");
+    const url = actorUrl || `https://${parts[1]}/@${parts[0]}`;
+    html = html.replace(
+      pattern,
+      `<a href="${url}" class="mention" rel="nofollow noopener" target="_blank">@${handle}</a>`,
+    );
+  }
+  return html;
+}
+
 // ---------------------------------------------------------------------------
 // Plain JSON-LD (content negotiation on individual post URLs)
 // ---------------------------------------------------------------------------
@@ -137,10 +181,27 @@ export function jf2ToActivityStreams(properties, actorUrl, publicationUrl, optio
   }
 
   const tags = buildPlainTags(properties, publicationUrl, object.tag);
+
+  // Add Mention tags + cc addressing + content linkification for @mentions
+  const resolvedMentions = options.mentions || [];
+  for (const { handle, actorUrl: mentionUrl } of resolvedMentions) {
+    if (mentionUrl) {
+      tags.push({ type: "Mention", href: mentionUrl, name: `@${handle}` });
+      if (!object.cc.includes(mentionUrl)) {
+        object.cc.push(mentionUrl);
+      }
+    }
+  }
+
   if (tags.length > 0) {
     object.tag = tags;
   }
 
+  // Linkify @mentions in content (resolved get actor links, unresolved get profile links)
+  if (resolvedMentions.length > 0 && object.content) {
+    object.content = linkifyMentions(object.content, resolvedMentions);
+  }
+
   return {
     "@context": "https://www.w3.org/ns/activitystreams",
     type: "Create",
@@ -292,7 +353,7 @@ export function jf2ToAS2Activity(properties, actorUrl, publicationUrl, options =
     noteOptions.attachments = fedifyAttachments;
   }
 
-  // Tags: hashtags + Mention for reply addressing
+  // Tags: hashtags + Mention for reply addressing + @mentions
   const fedifyTags = buildFedifyTags(properties, publicationUrl, postType);
 
   if (replyToActorUrl) {
@@ -304,10 +365,46 @@ export function jf2ToAS2Activity(properties, actorUrl, publicationUrl, options =
     );
   }
 
+  // Add Mention tags + cc addressing for resolved @mentions
+  const resolvedMentions = options.mentions || [];
+  const ccUrls = [];
+  for (const { handle, actorUrl: mentionUrl } of resolvedMentions) {
+    if (mentionUrl) {
+      // Skip if same as replyToActorUrl (already added above)
+      const alreadyTagged = replyToActorUrl && mentionUrl === replyToActorUrl;
+      if (!alreadyTagged) {
+        fedifyTags.push(
+          new Mention({
+            href: new URL(mentionUrl),
+            name: `@${handle}`,
+          }),
+        );
+      }
+      ccUrls.push(new URL(mentionUrl));
+    }
+  }
+
+  // Merge mention actors into cc/ccs
+  if (ccUrls.length > 0) {
+    if (noteOptions.ccs) {
+      noteOptions.ccs = [...noteOptions.ccs, ...ccUrls];
+    } else if (noteOptions.cc) {
+      noteOptions.ccs = [noteOptions.cc, ...ccUrls];
+      delete noteOptions.cc;
+    } else {
+      noteOptions.ccs = ccUrls;
+    }
+  }
+
   if (fedifyTags.length > 0) {
     noteOptions.tags = fedifyTags;
   }
 
+  // Linkify @mentions in content
+  if (resolvedMentions.length > 0 && noteOptions.content) {
+    noteOptions.content = linkifyMentions(noteOptions.content, resolvedMentions);
+  }
+
   const object = isArticle
     ? new Article(noteOptions)
     : new Note(noteOptions);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rmdes/indiekit-endpoint-activitypub",
-  "version": "2.10.1",
+  "version": "2.11.0",
   "description": "ActivityPub federation endpoint for Indiekit via Fedify. Adds full fediverse support: actor, inbox, outbox, followers, following, syndication, and Mastodon migration.",
   "keywords": [
     "indiekit",