@rm0nroe/coach-claw 1.0.7 → 1.0.8

package/coach/tests/test_celebrate_dedup.py

@@ -383,12 +383,16 @@ def test_celebrate_block_includes_verbatim_instruction(cup, now):
 def test_celebrate_combines_all_event_kinds(cup, now):
     """Regression + streak + graduation + level-up — verify ordering and
     that all four sections are present without bleeding into each other."""
+    # Use slug-form ids whose humanized fallback (`-` → space) matches
+    # the asserted display text. display_name() is now the single
+    # source of truth — marker `name` is ignored, so synthetic ids
+    # without an override render via humanized-slug fallback.
     block = cup._assemble_celebrate_block(
-        grads=[{"id": "g1", "name": "pattern g", "direction": "positive",
+        grads=[{"id": "pattern-g", "name": "pattern g", "direction": "positive",
                 "graduated_reason": "present-5-runs"}],
-        regs=[{"id": "r1", "name": "pattern r",
+        regs=[{"id": "pattern-r", "name": "pattern r",
                "originally_graduated_at": "2026-04-01"}],
-        streak_rewards=[{"id": "s1", "name": "pattern s",
+        streak_rewards=[{"id": "pattern-s", "name": "pattern s",
                          "direction": "negative", "streak": 2, "target": 5,
                          "xp_awarded": 1}],
         levelup={"from": "L3 X", "to": "Y", "to_idx": 3, "xp_at_levelup": 100},

package/coach/tests/test_hook_render_env.py

@@ -146,9 +146,10 @@ def test_regression_terminal_uses_blockquote(cup):
           "originally_graduated_at": "2026-04-01"}],
         env="terminal",
     )
-    # Verbatim banner: name (not slug) appears in the heading; the
-    # graduation date is interpolated into the body sentence.
-    assert "> ⚠️ **Regressed: Edits without testing**" in block
+    # Verbatim banner: display_name override wins over marker name, so
+    # the heading shows the curated wording. Graduation date is
+    # interpolated into the body sentence.
+    assert "> ⚠️ **Regressed: edits without testing**" in block
     assert "(was graduated 2026-04-01)" in block
     assert "edits-without-testing" not in block  # slug must not leak
     assert "---" not in block
@@ -160,7 +161,7 @@ def test_regression_ide_uses_hr_frame(cup):
           "originally_graduated_at": "2026-04-01"}],
         env="ide",
     )
-    assert "⚠️ **Regressed** — `Edits without testing`" in block
+    assert "⚠️ **Regressed** — `edits without testing`" in block
     assert "edits-without-testing" not in block  # slug must not leak
     assert block.startswith("---\n")
     assert block.endswith("\n---")
@@ -292,6 +293,46 @@ def test_graduation_ide_positive(cup):
 # attribution — graduation ceremonies get bespoke colors.
 # -----------------------------------------------------------------------------
 
+def test_curated_override_wins_over_marker_name(cup):
+    """Regression: when a marker carries a `name` that differs from the
+    curated WORDING_OVERRIDES entry for that slug, the override MUST win.
+    The teammate-found bug was the milestone renderers preferring marker
+    name over display_name's resolution chain — defeating the natural-
+    language override contract for known awkward phrases."""
+    # `commit-without-testing` carries marker name "commit without
+    # testing" (analyze.py:350), but the curated override is the richer
+    # "committing without testing".
+    streak_block = cup._streak_reward_block(
+        [{"id": "commit-without-testing", "name": "commit without testing",
+          "direction": "negative", "streak": 3, "target": 5, "xp_awarded": 1}],
+        env="terminal",
+    )
+    assert "committing without testing" in streak_block, (
+        "streak reward banner ignored the curated override"
+    )
+    assert "`commit without testing`" not in streak_block, (
+        "marker name leaked through despite override match"
+    )
+
+    grad_block = cup._graduation_block(
+        [{"id": "commit-without-testing", "name": "commit without testing",
+          "direction": "negative", "graduated_reason": "absent-5-runs"}],
+        env="terminal",
+    )
+    assert "GRADUATED: committing without testing" in grad_block, (
+        "graduation banner ignored the curated override"
+    )
+
+    reg_block = cup._regression_block(
+        [{"id": "commit-without-testing", "name": "commit without testing",
+          "originally_graduated_at": "2026-04-01"}],
+        env="terminal",
+    )
+    assert "Regressed: committing without testing" in reg_block, (
+        "regression banner ignored the curated override"
+    )
+
+
 def test_graduation_negative_full_bar_is_yellow(cup):
     block = cup._graduation_block(
         [{"id": "edits-without-testing", "name": "edits without testing",

package/hooks/coach-user-prompt.py

@@ -574,12 +574,11 @@ def _regression_block(
         if not isinstance(r, dict):
             continue
         rid = r.get("id", "?")
+        # display_name is the single source of truth: curated override →
+        # profile.name → humanized slug. Marker name is intentionally
+        # ignored here so a curated WORDING_OVERRIDES entry always wins
+        # over whatever wording the marker happened to carry at write time.
         rname = _display_name(rid, profile) if rid != "?" else rid
-        # Marker may carry richer wording than display_name resolves;
-        # prefer the explicit name field when present and non-slug.
-        marker_name = r.get("name")
-        if marker_name and marker_name != rid:
-            rname = marker_name
         originally_at = r.get("originally_graduated_at", "?")
         sentence = (
             f"Re-detected this run, so it's off the mastered list "
@@ -608,10 +607,10 @@ def _streak_reward_block(
         if not isinstance(r, dict):
             continue
         rid = r.get("id", "?")
+        # See _regression_block: display_name is authoritative; the
+        # marker's `name` field is intentionally ignored so curated
+        # overrides win over whatever the marker carried at write time.
         rname = _display_name(rid, profile) if rid != "?" else rid
-        marker_name = r.get("name")
-        if marker_name and marker_name != rid:
-            rname = marker_name
         streak = int(r.get("streak", 0))
         target = int(r.get("target", 5))
         xp = int(r.get("xp_awarded", 1))
@@ -652,10 +651,10 @@ def _graduation_block(
         if not isinstance(g, dict):
             continue
         gid = g.get("id", "?")
+        # See _regression_block: display_name is authoritative; the
+        # marker's `name` field is intentionally ignored so curated
+        # overrides win over whatever the marker carried at write time.
         gname = _display_name(gid, profile) if gid != "?" else gid
-        marker_name = g.get("name")
-        if marker_name and marker_name != gid:
-            gname = marker_name
         direction = g.get("direction", "negative")
         if direction == "positive":
             sentence = positive_sentence
@@ -749,21 +748,17 @@ def _assemble_celebrate_block(
     graduated_ids = {g.get("id") for g in (grads or []) if isinstance(g, dict) and g.get("id")}
     streak_rewards = [s for s in streak_rewards if s.get("id") not in graduated_ids]
 
-    # Pass C: normalize each reward's `name` field via display_name so both
-    # the default-theme and bespoke-theme render paths see user-facing
-    # wording (override → profile.name → humanized slug). The bespoke path
-    # in banner_themes.py reads `r["name"]` directly without any
-    # display-name lookup; without this pass it would leak slugs (e.g.,
-    # `under-planning` if profile.name is broken). We rebuild dicts to
-    # avoid mutating the marker payload.
+    # Pass C: normalize each reward's `name` field via display_name so
+    # both the default-theme and bespoke-theme render paths see the same
+    # user-facing wording (override → profile.name → humanized slug).
+    # display_name is authoritative — the marker's own `name` field is
+    # ignored so a curated WORDING_OVERRIDES entry always wins over
+    # whatever wording the marker carried at write time. We rebuild
+    # dicts to avoid mutating the marker payload.
     normalized: list[dict] = []
     for s in streak_rewards:
         sid = s.get("id", "?")
-        marker_name = s.get("name")
-        if marker_name and marker_name != sid:
-            display = marker_name
-        else:
-            display = _display_name(sid, profile) if sid != "?" else sid
+        display = _display_name(sid, profile) if sid != "?" else sid
         normalized.append({**s, "name": display})
     streak_rewards = normalized
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rm0nroe/coach-claw",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "description": "A self-evolving coaching layer for Claude Code.",
   "license": "MIT",
   "homepage": "https://rm0nroe.github.io/coach-claw/",