@rm0nroe/coach-claw 1.0.6

package/coach/tests/test_hook_render_env.py

@@ -0,0 +1,364 @@
+"""coach-user-prompt.py: render-shape branching by environment.
+
+Verifies each of the six render functions emits the right shape per env:
+  - terminal: blockquote `> ` shape (current default, must not regress)
+  - ide:      HR-framed `---` shape with bold + code-span pills
+
+For celebrate banners (streak/graduation/regression/levelup) the hook
+now emits the **final banner markdown verbatim** — Claude reproduces it
+unchanged. So these assertions pin the literal banner text, not
+instruction templates.
+"""
+from __future__ import annotations
+
+import importlib.util
+from pathlib import Path
+
+import pytest
+
+
+@pytest.fixture(scope="module")
+def cup():
+    repo_path = Path(__file__).resolve().parents[2] / "hooks" / "coach-user-prompt.py"
+    path = repo_path if repo_path.exists() else Path.home() / ".claude" / "hooks" / "coach-user-prompt.py"
+    if not path.exists():
+        pytest.skip(f"hook not installed at {path}")
+    spec = importlib.util.spec_from_file_location("cup_under_test_renderenv", str(path))
+    mod = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(mod)
+    return mod
+
+
+# -----------------------------------------------------------------------------
+# _ide_label transformations
+# -----------------------------------------------------------------------------
+
+def test_ide_label_strips_italics_and_colon(cup):
+    assert cup._ide_label("*Tip:*") == "🦞 **Tip**"
+    assert cup._ide_label("*Pointer:*") == "🦞 **Pointer**"
+
+
+def test_ide_label_strips_leading_emoji_token(cup):
+    assert cup._ide_label("*🎯 Tip:*") == "🦞 **Tip**"
+    assert cup._ide_label("*✏️ Tip:*") == "🦞 **Tip**"
+    assert cup._ide_label("*🧭 Heads up:*") == "🦞 **Heads up**"
+
+
+def test_ide_label_strips_redundant_lobster(cup):
+    """Skill labels already have 🦞; the helper drops it then re-adds the
+    persona prefix so the output never has 🦞🦞."""
+    assert cup._ide_label("*🦞 From Coach Claw:*") == "🦞 **From Coach Claw**"
+    assert cup._ide_label("*🦞 Coach:*") == "🦞 **Coach**"
+
+
+def test_ide_label_handles_multiword_label(cup):
+    assert cup._ide_label("*Worth noting:*") == "🦞 **Worth noting**"
+    assert cup._ide_label("*Good pattern:*") == "🦞 **Good pattern**"
+
+
+def test_ide_label_always_prefixes_lobster(cup):
+    """Every IDE label leads with 🦞 — universal coach signature."""
+    for label in cup.WEAKNESS_LABELS + cup.STRENGTH_LABELS + cup.SKILL_LABELS:
+        assert cup._ide_label(label).startswith("🦞 **")
+
+
+# -----------------------------------------------------------------------------
+# _xp_attribution — terminal vs IDE shape
+# -----------------------------------------------------------------------------
+
+def test_xp_attribution_terminal_uses_italics(cup):
+    """Terminal shape: lines wrapped in `_..._` for theme-driven dim."""
+    lines = cup._xp_attribution(
+        {"kind": "weakness", "entry_id": "edits-without-testing", "clean_streak": 2,
+         "reward_hint": {"action": "test_run", "xp": 2, "description": "test run"}},
+        env="terminal",
+    )
+    assert all(line.startswith("_") and line.endswith("_") for line in lines)
+    assert all("`" not in line for line in lines)  # no code spans in terminal shape
+
+
+def test_xp_attribution_ide_uses_code_span_pills(cup):
+    """IDE shape: lines wrapped in backticks → pill backgrounds."""
+    lines = cup._xp_attribution(
+        {"kind": "weakness", "entry_id": "edits-without-testing", "clean_streak": 2,
+         "reward_hint": {"action": "test_run", "xp": 2, "description": "test run"}},
+        env="ide",
+    )
+    assert all(line.startswith("`") and line.endswith("`") for line in lines)
+    assert all("_" not in line for line in lines)  # no italic markers
+
+
+def test_xp_attribution_ide_skill_single_line(cup):
+    """Skills have only one attribution line in both envs."""
+    lines = cup._xp_attribution(
+        {"kind": "skill", "entry_id": "deploy-to-vercel"}, env="ide"
+    )
+    assert len(lines) == 1
+    assert lines[0].startswith("`↑ +")
+    assert "/deploy-to-vercel" in lines[0]
+
+
+def test_xp_attribution_default_env_is_terminal(cup):
+    """No env arg = terminal shape (backward compat)."""
+    lines = cup._xp_attribution({"kind": "skill", "entry_id": "test-skill"})
+    assert lines[0].startswith("_↑ +")
+
+
+# -----------------------------------------------------------------------------
+# _levelup_block — terminal vs IDE
+# -----------------------------------------------------------------------------
+
+def test_levelup_terminal_uses_blockquote(cup):
+    block = cup._levelup_block(
+        {"from": "L3 Practitioner", "to": "Reviewer", "to_idx": 3, "xp_at_levelup": 1247},
+        env="terminal",
+    )
+    # Verbatim banner: title and stock body, both blockquote-prefixed.
+    assert "> 🎉 **Level up!** You're now **L4 Reviewer**." in block
+    assert "> A new craft tier unlocks at 1247 XP." in block
+    assert "---" not in block
+
+
+def test_levelup_ide_uses_hr_frame(cup):
+    block = cup._levelup_block(
+        {"from": "L3 Practitioner", "to": "Reviewer", "to_idx": 3, "xp_at_levelup": 1247},
+        env="ide",
+    )
+    # Banner emitted at column 0 (HR-framed). Hook used to emit a
+    # 4-space indented template inside an instruction block; verbatim
+    # render means no leading indentation.
+    assert "🎉 **LEVEL UP** — `L4 Reviewer` · `1247 XP total`" in block
+    assert "A new craft tier unlocks." in block
+    assert block.startswith("---\n")
+    assert block.endswith("\n---")
+    # Setext-H2 guard: bottom `---` must be preceded by a blank line.
+    assert "\n\n---" in block
+    assert "> " not in block  # no terminal blockquote signature
+
+
+# -----------------------------------------------------------------------------
+# _regression_block — terminal vs IDE
+# -----------------------------------------------------------------------------
+
+def test_regression_terminal_uses_blockquote(cup):
+    block = cup._regression_block(
+        [{"id": "edits-without-testing", "name": "Edits without testing",
+          "originally_graduated_at": "2026-04-01"}],
+        env="terminal",
+    )
+    # Verbatim banner: name (not slug) appears in the heading; the
+    # graduation date is interpolated into the body sentence.
+    assert "> ⚠️ **Regressed: Edits without testing**" in block
+    assert "(was graduated 2026-04-01)" in block
+    assert "edits-without-testing" not in block  # slug must not leak
+    assert "---" not in block
+
+
+def test_regression_ide_uses_hr_frame(cup):
+    block = cup._regression_block(
+        [{"id": "edits-without-testing", "name": "Edits without testing",
+          "originally_graduated_at": "2026-04-01"}],
+        env="ide",
+    )
+    assert "⚠️ **Regressed** — `Edits without testing`" in block
+    assert "edits-without-testing" not in block  # slug must not leak
+    assert block.startswith("---\n")
+    assert block.endswith("\n---")
+    assert "\n\n---" in block  # Setext-H2 guard
+
+
+# -----------------------------------------------------------------------------
+# _streak_reward_block — terminal vs IDE
+# -----------------------------------------------------------------------------
+
+def test_streak_reward_terminal_negative(cup):
+    """Negative direction → ↓ arrow, name (not slug) in body."""
+    block = cup._streak_reward_block(
+        [{"id": "edits-without-testing", "name": "edits without testing",
+          "direction": "negative", "streak": 3, "target": 5, "xp_awarded": 1}],
+        env="terminal",
+    )
+    expected = "> ↓ `edits without testing` `🔴🔴🔴⚪⚪` 3/5 · `-1`"
+    assert expected in block
+    assert "↑" not in block
+    assert "edits-without-testing" not in block  # slug must not leak
+
+
+def test_streak_reward_terminal_positive(cup):
+    """Positive direction → ↑ arrow."""
+    block = cup._streak_reward_block(
+        [{"id": "safe-git-hygiene", "name": "safe git hygiene",
+          "direction": "positive", "streak": 4, "target": 5, "xp_awarded": 2}],
+        env="terminal",
+    )
+    expected = "> ↑ `safe git hygiene` `🔴🔴🔴🔴⚪` 4/5 · `+2`"
+    assert expected in block
+    assert "↓" not in block
+
+
+def test_streak_reward_ide_negative(cup):
+    block = cup._streak_reward_block(
+        [{"id": "edits-without-testing", "name": "edits without testing",
+          "direction": "negative", "streak": 3, "target": 5, "xp_awarded": 1}],
+        env="ide",
+    )
+    expected = "↓ `edits without testing` · `🔴🔴🔴⚪⚪ 3/5` · `-1`"
+    assert expected in block
+    assert "↑" not in block
+    assert block.startswith("---\n")
+    assert block.endswith("\n---")
+    assert "\n\n---" in block  # Setext-H2 guard
+
+
+def test_streak_reward_ide_positive(cup):
+    block = cup._streak_reward_block(
+        [{"id": "safe-git-hygiene", "name": "safe git hygiene",
+          "direction": "positive", "streak": 4, "target": 5, "xp_awarded": 2}],
+        env="ide",
+    )
+    expected = "↑ `safe git hygiene` · `🔴🔴🔴🔴⚪ 4/5` · `+2`"
+    assert expected in block
+    assert "↓" not in block
+
+
+# -----------------------------------------------------------------------------
+# _graduation_block — terminal vs IDE, both directions
+# -----------------------------------------------------------------------------
+
+def test_graduation_terminal_negative(cup):
+    """Negative graduation → GRADUATED ⚡️ shape with weakness-retired body.
+    No POSITIVE shape may leak into the output (verbatim, not template)."""
+    block = cup._graduation_block(
+        [{"id": "edits-without-testing", "name": "edits without testing",
+          "direction": "negative", "graduated_reason": "absent-5-runs"}],
+        env="terminal",
+    )
+    assert "> 🎓⚡️ **GRADUATED: edits without testing**  `+5 XP`" in block
+    assert "5 clean Coach insights runs in a row — weakness retired." in block
+    assert "MASTERED" not in block  # positive shape must NOT appear
+    assert "core strength" not in block
+    assert "edits-without-testing" not in block  # slug must not leak
+    assert "---" not in block
+
+
+def test_graduation_terminal_positive(cup):
+    """Positive graduation → MASTERED 🌟 shape with core-strength body.
+    No NEGATIVE shape may leak (the original bug)."""
+    block = cup._graduation_block(
+        [{"id": "safe-git-hygiene", "name": "safe git hygiene",
+          "direction": "positive", "graduated_reason": "present-5-runs"}],
+        env="terminal",
+    )
+    assert "> 🎓🌟 **MASTERED: safe git hygiene**  `+5 XP`" in block
+    assert "core strength" in block
+    assert "GRADUATED" not in block  # negative shape must NOT appear
+    assert "weakness retired" not in block  # the original bug — must stay gone
+    assert "safe-git-hygiene" not in block  # slug must not leak
+    assert "---" not in block
+
+
+def test_graduation_ide_negative(cup):
+    block = cup._graduation_block(
+        [{"id": "edits-without-testing", "name": "edits without testing",
+          "direction": "negative", "graduated_reason": "absent-5-runs"}],
+        env="ide",
+    )
+    assert "🎓 **GRADUATED** ⚡ — `edits without testing` · `+5 XP`" in block
+    assert "weakness retired" in block
+    assert "MASTERED" not in block  # positive shape must NOT appear
+    assert block.startswith("---\n")
+    assert block.endswith("\n---")
+    assert "\n\n---" in block  # Setext-H2 guard
+
+
+def test_graduation_ide_positive(cup):
+    block = cup._graduation_block(
+        [{"id": "safe-git-hygiene", "name": "safe git hygiene",
+          "direction": "positive", "graduated_reason": "present-5-runs"}],
+        env="ide",
+    )
+    assert "🎓 **MASTERED** 🌟 — `safe git hygiene` · `+5 XP`" in block
+    assert "core strength" in block
+    assert "GRADUATED" not in block  # negative shape must NOT appear
+    assert block.startswith("---\n")
+    assert block.endswith("\n---")
+    assert "\n\n---" in block  # Setext-H2 guard
+
+
+# -----------------------------------------------------------------------------
+# _completion_banner — terminal vs IDE, all kinds
+# -----------------------------------------------------------------------------
+
+def test_completion_banner_terminal_skill(cup):
+    block = cup._completion_banner(
+        [("entry:deploy-to-vercel", {
+            "kind": "skill", "entry_id": "deploy-to-vercel",
+            "spec": {"action": "skill_invoke", "skill_id": "deploy-to-vercel"},
+        })],
+        env="terminal",
+    )
+    assert "> ✅ **Tip cleared** — `/deploy-to-vercel` invoked" in block
+    assert "---" not in block
+
+
+def test_completion_banner_ide_skill(cup):
+    block = cup._completion_banner(
+        [("entry:deploy-to-vercel", {
+            "kind": "skill", "entry_id": "deploy-to-vercel",
+            "spec": {"action": "skill_invoke", "skill_id": "deploy-to-vercel"},
+        })],
+        env="ide",
+    )
+    assert "  ---" in block
+    assert "✅ **Tip cleared** — `/deploy-to-vercel` invoked" in block
+    assert "\n\n  ---" in block  # Setext-H2 guard
+
+
+def test_completion_banner_ide_weakness(cup):
+    block = cup._completion_banner(
+        [("entry:edits-without-testing", {
+            "kind": "weakness", "entry_id": "edits-without-testing",
+            "clean_streak": 2,
+            "spec": {"action": "test_run", "xp": 2, "description": "test run"},
+        })],
+        env="ide",
+    )
+    assert "  ---" in block
+    assert "✅ **Tip cleared** — `edits-without-testing`" in block
+    assert "`+2 XP banked`" in block
+    assert "`streak 🔴🔴⚪⚪⚪ advances next /coach-insights`" in block
+
+
+def test_completion_banner_ide_strength(cup):
+    block = cup._completion_banner(
+        [("entry:tests-after-edits", {
+            "kind": "strength", "entry_id": "tests-after-edits",
+            "positive_streak": 2,
+            "spec": {"action": "test_run", "xp": 2, "description": "test run"},
+        })],
+        env="ide",
+    )
+    assert "  ---" in block
+    assert "💪 **Strength reinforced** — `tests-after-edits`" in block
+    assert "`strength streak 🔴🔴⚪⚪⚪`" in block
+
+
+# -----------------------------------------------------------------------------
+# All renderers preserve current default behavior when env arg omitted
+# -----------------------------------------------------------------------------
+
+@pytest.mark.parametrize("call", [
+    lambda c: c._levelup_block({"from": "L3", "to": "Reviewer", "to_idx": 3, "xp_at_levelup": 100}),
+    lambda c: c._regression_block([{"id": "p1", "name": "P", "originally_graduated_at": "2026-01-01"}]),
+    lambda c: c._streak_reward_block([{"id": "p1", "name": "P", "streak": 1, "target": 5, "xp_awarded": 1}]),
+    lambda c: c._graduation_block([{"id": "p1", "name": "P", "direction": "negative", "graduated_reason": "x"}]),
+    lambda c: c._completion_banner([("e:p1", {"kind": "skill", "entry_id": "p1",
+                                              "spec": {"action": "skill_invoke", "skill_id": "p1"}})]),
+])
+def test_omitted_env_arg_preserves_terminal_shape(cup, call):
+    """No env arg = terminal shape (backward compat invariant)."""
+    block = call(cup)
+    assert "> " in block  # terminal blockquote present
+    # IDE-only signature characters absent
+    assert "    ---" not in block
+    assert "  ---\n" not in block

package/coach/tests/test_hook_session_id_guard.py

@@ -0,0 +1,160 @@
+"""Hook guard: refuse stateful writes when session_id is missing.
+
+v0.5.2 fix for two narrow but real bugs surfaced during the uninstall
+e2e:
+
+  R1 — `coach-session-start.py` spawned `bank.py` and `insights-llm.sh`
+        fire-and-forget regardless of payload. An ad-hoc smoke test
+        (`echo '{}' | python3 hook.py`) on a freshly-installed empty
+        coach dir would let bank.py race against an in-progress restore
+        and write a bogus `.pending_levelup` jumping the user from
+        Builder → Virtuoso.
+
+  R2 — `coach-user-prompt.py` fell through to writing an empty/sentinel
+        `session_key` into pending markers' `consumed_by` list. Real
+        Claude Code sessions then saw the marker as already-consumed
+        and skipped rendering.
+
+The guard: if no `session_id`/`sessionId`/`transcript_path`/`transcriptPath`
+in the payload, exit 0 silently with NO subprocess spawn and NO marker
+mutation. Real Claude Code events always carry one of those fields; the
+only callers without them are smoke tests and malformed input.
+"""
+from __future__ import annotations
+
+import json
+import os
+import subprocess
+import sys
+from pathlib import Path
+
+import pytest
+
+
+HOOKS_DIR = Path(__file__).resolve().parents[2] / "hooks"
+SESSION_START = HOOKS_DIR / "coach-session-start.py"
+USER_PROMPT = HOOKS_DIR / "coach-user-prompt.py"
+
+
+def _run_hook(hook_path: Path, payload: dict, claude_dir: Path) -> subprocess.CompletedProcess:
+    """Invoke a hook with the given payload, isolating COACH_DIR via $HOME."""
+    env = os.environ.copy()
+    env["HOME"] = str(claude_dir.parent)
+    # Make sure the hook's `Path.home() / ".claude" / "coach"` resolves into
+    # our temp dir, not the user's real install.
+    return subprocess.run(
+        [sys.executable, str(hook_path)],
+        input=json.dumps(payload),
+        env=env,
+        text=True,
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        timeout=10,
+    )
+
+
+@pytest.fixture
+def fake_claude_home(tmp_path: Path) -> Path:
+    """Build a minimal `~/.claude/coach/` so hooks have somewhere to look."""
+    home = tmp_path / "home"
+    coach = home / ".claude" / "coach"
+    coach.mkdir(parents=True)
+    (coach / "bin").mkdir()
+    # A real bank.py would fire; we install a sentinel that records its run
+    # by touching a file. If the guard works, this file MUST NOT appear.
+    sentinel = coach / "bank-was-spawned.sentinel"
+    bank_py = coach / "bin" / "bank.py"
+    bank_py.write_text(
+        f"#!/usr/bin/env python3\n"
+        f"from pathlib import Path\n"
+        f"Path({str(sentinel)!r}).write_text('spawned')\n"
+    )
+    bank_py.chmod(0o755)
+    return home
+
+
+def _hook_available(hook: Path) -> bool:
+    """Skip when the bundle isn't checked out (e.g. running from ~/.claude/coach/)."""
+    return hook.exists()
+
+
+def test_session_start_with_empty_input_does_nothing(fake_claude_home: Path) -> None:
+    """`echo '{}' | coach-session-start.py` exits 0 silently, no bank spawn."""
+    if not _hook_available(SESSION_START):
+        pytest.skip("hook source not in this checkout")
+
+    result = _run_hook(SESSION_START, {}, fake_claude_home)
+    assert result.returncode == 0
+    assert result.stdout.strip() == "", (
+        f"hook should produce no output for empty payload; got: {result.stdout!r}"
+    )
+
+    sentinel = fake_claude_home / ".claude" / "coach" / "bank-was-spawned.sentinel"
+    # bank.py spawn is detached, so we wait briefly to give a hypothetical
+    # spawn time to land. If the guard works, no spawn happened.
+    import time
+    time.sleep(0.5)
+    assert not sentinel.exists(), (
+        "bank.py was spawned despite missing session_id — guard regression"
+    )
+
+
+def test_session_start_with_session_id_proceeds(fake_claude_home: Path) -> None:
+    """Sanity: a payload WITH session_id should NOT be silenced by the guard.
+
+    We don't assert bank spawn here (it depends on a profile.yaml that we
+    haven't set up); we just assert the hook doesn't bail at the guard.
+    The hook is wrapped in a try/except that always exits 0, so we look
+    for a side effect: it should at least attempt to read the profile,
+    which means it got past the guard. Easiest signal: stdout is allowed
+    to be empty (silent because no profile), but exit must be 0 (failsafe).
+    """
+    if not _hook_available(SESSION_START):
+        pytest.skip("hook source not in this checkout")
+
+    result = _run_hook(SESSION_START, {"session_id": "test-abc"}, fake_claude_home)
+    assert result.returncode == 0
+
+
+def test_user_prompt_with_empty_input_does_not_consume_markers(
+    fake_claude_home: Path,
+) -> None:
+    """A pending marker's consumed_by must NOT gain an entry from `{}`."""
+    if not _hook_available(USER_PROMPT):
+        pytest.skip("hook source not in this checkout")
+
+    coach = fake_claude_home / ".claude" / "coach"
+    marker = coach / ".pending_streak_rewards"
+    marker.write_text(json.dumps({
+        "rewards": [{"id": "x", "name": "X", "streak": 3}],
+        "created_at": "2026-05-01T00:00:00+00:00",
+        "consumed_by": [],
+    }))
+
+    result = _run_hook(USER_PROMPT, {}, fake_claude_home)
+    assert result.returncode == 0
+    assert result.stdout.strip() == "", (
+        f"hook should produce no output for empty payload; got: {result.stdout!r}"
+    )
+
+    # The load-bearing assertion: consumed_by stays empty so the marker
+    # is still visible to the next REAL session.
+    after = json.loads(marker.read_text())
+    assert after["consumed_by"] == [], (
+        f"empty payload polluted consumed_by: {after['consumed_by']}"
+    )
+
+
+def test_user_prompt_with_transcript_path_proceeds(fake_claude_home: Path) -> None:
+    """Payload with transcript_path (no session_id) should still pass the guard."""
+    if not _hook_available(USER_PROMPT):
+        pytest.skip("hook source not in this checkout")
+
+    # transcript_path doesn't need to exist for the guard check — that's
+    # the job of later confinement logic. The guard is purely a presence test.
+    result = _run_hook(
+        USER_PROMPT,
+        {"transcript_path": "/tmp/nonexistent.jsonl"},
+        fake_claude_home,
+    )
+    assert result.returncode == 0