@rivi-software/agentic-seo-check 0.4.0 → 0.6.0

package/dist/core/rules/page-fixes.js

@@ -0,0 +1,107 @@
+/**
+ * Helpers for the fixes of the response, social, structured data, URL, loading, content and
+ * keyword rules: status lines, JSON-LD fragments quoted from the script that holds them, and URLs
+ * with a parameter or an origin swapped.
+ */
+import { STATUS_CODES } from "node:http";
+import { resolveUrl } from "../url.js";
+import { isLocalHost } from "./canonical.js";
+import { replaceHtml, slot, withContent } from "./fix.js";
+/** An HTTP/1.1 status line: "HTTP/1.1 301 Moved Permanently". */
+export const statusLine = (status) => {
+    const reason = STATUS_CODES[status];
+    return reason ? `HTTP/1.1 ${status} ${reason}` : `HTTP/1.1 ${status}`;
+};
+/** The status and Location of a permanent redirect to `location`. */
+export const permanentRedirect = (location) => `${statusLine(301)}\nLocation: ${location}`;
+/** Where a JSON-LD object sits, for an edit's `at`: its script, its type and its path inside the script. */
+export const jsonLdAt = (type, path = "") => `script[type="application/ld+json"] > ${type}${path && path !== "(root)" ? ` at ${path}` : ""}`;
+/** `text` as a regular expression that matches it literally. */
+const literal = (text) => text.replaceAll(/[$()*+.?[\\\]^{|}]/gu, String.raw `\$&`);
+/**
+ * `"key": value` as the script writes it (any spacing around the colon), or null when it is not
+ * there verbatim, for instance because the script escapes a character the value holds.
+ */
+export const jsonProperty = (scriptText, key, value) => {
+    const json = JSON.stringify(value);
+    if (!scriptText || json === undefined) {
+        return null;
+    }
+    // Both parts are escaped literals joined by \s*, so the pattern cannot backtrack. The lookahead
+    // keeps `"position": 1` from matching the start of `"position": 10`.
+    const match = new RegExp(`${literal(JSON.stringify(key))}\\s*:\\s*${literal(json)}(?![\\w.+-])`, "u").exec(scriptText);
+    return match ? match[0] : null;
+};
+/** A JSON value for a JSON-LD fix, safe inside a <script>: "<" is escaped so "</script>" cannot end it. */
+export const json = (value) => JSON.stringify(value).replaceAll("<", String.raw `\u003c`);
+/**
+ * The origin to build absolute URLs from: the page's own, or a slot when the page is on a
+ * development host or is HTML without a URL, where only the author knows the production origin.
+ */
+export const productionOrigin = (page, source) => {
+    if (source !== "html" && !isLocalHost(page.url)) {
+        try {
+            return new URL(page.url).origin;
+        }
+        catch {
+            // Falls through to the slot.
+        }
+    }
+    return slot("https://www.example.com");
+};
+/** What a production-origin slot needs, for `write`. */
+export const ORIGIN_SLOT_WRITE = "The site's production origin (scheme and host, such as https://www.example.com), from the site URL setting rather than the development server.";
+/** Whether a `productionOrigin` is a slot the author fills in. */
+export const isSlot = (text) => text.includes("{{");
+/**
+ * `raw`, a URL as an attribute writes it, without the query parameters `drop` selects (and a
+ * `;jsessionid=` path parameter when `drop` selects "jsessionid"), written the way `raw` was:
+ * absolute stays absolute, a path stays a path.
+ */
+export const withoutParameters = (raw, base, drop) => {
+    const absolute = resolveUrl(raw, base);
+    if (!absolute) {
+        return raw;
+    }
+    const url = new URL(absolute);
+    if (drop("jsessionid")) {
+        url.pathname = url.pathname.replaceAll(/;jsessionid=[^/;]*/giu, "");
+    }
+    // A copy: deleting while the live iterator runs would skip the parameter after each one deleted.
+    const names = [...url.searchParams.keys()];
+    for (const name of names) {
+        if (drop(name)) {
+            url.searchParams.delete(name);
+        }
+    }
+    const search = url.searchParams.size > 0 ? url.search : "";
+    if (/^[a-z][\d+.a-z-]*:/iu.test(raw) || raw.startsWith("//")) {
+        return `${raw.startsWith("//") ? "//" : `${url.protocol}//`}${url.host}${url.pathname}${search}${url.hash}`;
+    }
+    return `${url.pathname}${search}${url.hash}`;
+};
+/** Sentences of visible text that end in a full stop, question or exclamation mark. */
+export const sentences = (text) => 
+// Text after the last end mark matches too (`|$`), so a run without one is read once instead of
+// once from every position in it, which took seconds on a long paragraph; it is dropped after.
+[...text.matchAll(/[^.!?]+(?:[.!?]|$)/gu)].flatMap((m) => /[.!?]$/u.test(m[0]) ? [m[0].trim()] : []);
+/**
+ * The edit that rewrites one text block: the element as written, with a slot for its content. A
+ * block quoted cut short is rebuilt from its start tag, so the code is still whole.
+ */
+export const rewriteBlock = (block, hint, write) => replaceHtml(block.outer, withContent(block.outer, slot(hint)) ??
+    `${block.tag}${slot(hint)}</${block.name}>`, { at: block.name, write });
+/** The block of `blocks` that scores highest, or null when none scores above 0. */
+export const bestBlock = (blocks, score) => {
+    let best = null;
+    let top = 0;
+    for (const block of blocks) {
+        const value = score(block);
+        if (value > top) {
+            best = block;
+            top = value;
+        }
+    }
+    return best;
+};
+//# sourceMappingURL=page-fixes.js.map

package/dist/core/rules/page-fixes.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"page-fixes.js","sourceRoot":"","sources":["../../../src/core/rules/page-fixes.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AACH,OAAO,EAAE,YAAY,EAAE,MAAM,WAAW,CAAC;AASzC,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AACvC,OAAO,EAAE,WAAW,EAAE,MAAM,gBAAgB,CAAC;AAC7C,OAAO,EAAE,WAAW,EAAE,IAAI,EAAE,WAAW,EAAE,MAAM,UAAU,CAAC;AAE1D,iEAAiE;AACjE,MAAM,CAAC,MAAM,UAAU,GAAG,CAAC,MAAc,EAAU,EAAE;IACnD,MAAM,MAAM,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC;IAEpC,OAAO,MAAM,CAAC,CAAC,CAAC,YAAY,MAAM,IAAI,MAAM,EAAE,CAAC,CAAC,CAAC,YAAY,MAAM,EAAE,CAAC;AACxE,CAAC,CAAC;AAEF,qEAAqE;AACrE,MAAM,CAAC,MAAM,iBAAiB,GAAG,CAAC,QAAgB,EAAU,EAAE,CAC5D,GAAG,UAAU,CAAC,GAAG,CAAC,eAAe,QAAQ,EAAE,CAAC;AAE9C,4GAA4G;AAC5G,MAAM,CAAC,MAAM,QAAQ,GAAG,CAAC,IAAY,EAAE,IAAI,GAAG,EAAE,EAAU,EAAE,CAC1D,wCAAwC,IAAI,GAAG,IAAI,IAAI,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,OAAO,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;AAElG,gEAAgE;AAChE,MAAM,OAAO,GAAG,CAAC,IAAY,EAAU,EAAE,CACvC,IAAI,CAAC,UAAU,CAAC,sBAAsB,EAAE,MAAM,CAAC,GAAG,CAAA,KAAK,CAAC,CAAC;AAE3D;;;GAGG;AACH,MAAM,CAAC,MAAM,YAAY,GAAG,CAC1B,UAA8B,EAC9B,GAAW,EACX,KAAgB,EACD,EAAE;IACjB,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;IAEnC,IAAI,CAAC,UAAU,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACtC,OAAO,IAAI,CAAC;IACd,CAAC;IAED,gGAAgG;IAChG,qEAAqE;IACrE,MAAM,KAAK,GAAG,IAAI,MAAM,CACtB,GAAG,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,YAAY,OAAO,CAAC,IAAI,CAAC,cAAc,EACtE,GAAG,CACJ,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;IAEnB,OAAO,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AACjC,CAAC,CAAC;AAEF,2GAA2G;AAC3G,MAAM,CAAC,MAAM,IAAI,GAAG,CAAC,KAAgB,EAAU,EAAE,CAC/C,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,UAAU,CAAC,GAAG,EAAE,MAAM,CAAC,GAAG,CAAA,QAAQ,CAAC,CAAC;AAE5D;;;GAGG;AACH,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAC9B,IAAmB,EACnB,MAAkB,EACV,EAAE;IACV,IAAI,MAAM,KAAK,MAAM,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;QAChD,IAAI,CAAC;YACH,OAAO,IAAI,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,MAAM,CAAC;QAClC,CAAC;QAAC,MAAM,CAAC;YACP,6BAA6B;QAC/B,CAAC;IACH,CAAC;IAED,OAAO,IAAI,CAAC,yBAAyB,CAAC,CAAC;AACzC,CAAC,CAAC;AAEF,wDAAwD;AACxD,MAAM,CAAC,MAAM,iBAAiB,GAC5B,gJAAgJ,CAAC;AAEnJ,kEAAkE;AAClE,MAAM,CAAC,MAAM,MAAM,GAAG,CAAC,IAAY,EAAW,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;AAErE;;;;GAIG;AACH,MAAM,CAAC,MAAM,iBAAiB,GAAG,CAC/B,GAAW,EACX,IAAY,EACZ,IAA+B,EACvB,EAAE;IACV,MAAM,QAAQ,GAAG,UAAU,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC;IAEvC,IAAI,CAAC,QAAQ,EAAE,CAAC;QACd,OAAO,GAAG,CAAC;IACb,CAAC;IAED,MAAM,GAAG,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,CAAC;IAE9B,IAAI,IAAI,CAAC,YAAY,CAAC,EAAE,CAAC;QACvB,GAAG,CAAC,QAAQ,GAAG,GAAG,CAAC,QAAQ,CAAC,UAAU,CAAC,uBAAuB,EAAE,EAAE,CAAC,CAAC;IACtE,CAAC;IAED,iGAAiG;IACjG,MAAM,KAAK,GAAG,CAAC,GAAG,GAAG,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,CAAC;IAE3C,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,IAAI,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC;YACf,GAAG,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QAChC,CAAC;IACH,CAAC;IAED,MAAM,MAAM,GAAG,GAAG,CAAC,YAAY,CAAC,IAAI,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC;IAE3D,IAAI,sBAAsB,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,EAAE,CAAC;QAC7D,OAAO,GAAG,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,GAAG,CAAC,QAAQ,IAAI,GAAG,GAAG,CAAC,IAAI,GAAG,GAAG,CAAC,QAAQ,GAAG,MAAM,GAAG,GAAG,CAAC,IAAI,EAAE,CAAC;IAC9G,CAAC;IAED,OAAO,GAAG,GAAG,CAAC,QAAQ,GAAG,MAAM,GAAG,GAAG,CAAC,IAAI,EAAE,CAAC;AAC/C,CAAC,CAAC;AAEF,uFAAuF;AACvF,MAAM,CAAC,MAAM,SAAS,GAAG,CAAC,IAAY,EAAY,EAAE;AAClD,gGAAgG;AAChG,+FAA+F;AAC/F,CAAC,GAAG,IAAI,CAAC,QAAQ,CAAC,sBAAsB,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,CACvD,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,CAC1C,CAAC;AAEJ;;;GAGG;AACH,MAAM,CAAC,MAAM,YAAY,GAAG,CAC1B,KAAgB,EAChB,IAAY,EACZ,KAAa,EACJ,EAAE,CACX,WAAW,CACT,KAAK,CAAC,KAAK,EACX,WAAW,CAAC,KAAK,CAAC,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;IAClC,GAAG,KAAK,CAAC,GAAG,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,KAAK,CAAC,IAAI,GAAG,EAC7C,EAAE,EAAE,EAAE,KAAK,CAAC,IAAI,EAAE,KAAK,EAAE,CAC1B,CAAC;AAEJ,mFAAmF;AACnF,MAAM,CAAC,MAAM,SAAS,GAAG,CACvB,MAAmB,EACnB,KAAmC,EACjB,EAAE;IACpB,IAAI,IAAI,GAAqB,IAAI,CAAC;IAClC,IAAI,GAAG,GAAG,CAAC,CAAC;IAEZ,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;QAC3B,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC;QAE3B,IAAI,KAAK,GAAG,GAAG,EAAE,CAAC;YAChB,IAAI,GAAG,KAAK,CAAC;YACb,GAAG,GAAG,KAAK,CAAC;QACd,CAAC;IACH,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC,CAAC"}

package/dist/core/rules/quoted-tags.d.ts

@@ -0,0 +1,23 @@
+/**
+ * The attributes of a quoted start tag, names lower-cased and values as written (character
+ * references not decoded). The first of a repeated attribute wins, as in a browser. Null for a
+ * quote cut short.
+ */
+export declare const readAttributes: (tag: string) => Map<string, string> | null;
+/** `element[name="value"]`, the selector of the element with that attribute value. */
+export declare const withAttributeSelector: (element: string, name: string, value: string) => string;
+/** The slot for the production origin, when the audit ran on a local or file URL. */
+export declare const ORIGIN_SLOT: string;
+export declare const ORIGIN_WRITE = "The site's production origin, such as https://www.example.com: this audit ran on a local URL or a file, so it cannot know it.";
+/**
+ * `url` as the live site writes it: as it is, or with its origin left as a slot when the audit ran
+ * on a local host or a file, whose origin is not the site's.
+ */
+export declare const liveUrl: (url: string, local: boolean) => string;
+/**
+ * `outer`, a whole element as quoted (`<h4 class="x">Text</h4>`), with its tag name changed in
+ * the start and end tag; null when the quote was cut or does not end in that element's end tag.
+ */
+export declare const renamed: (outer: string, from: string, to: string) => string | null;
+/** What sits between the start tag and the end tag of a whole quoted element, or null. */
+export declare const innerOf: (outer: string) => string | null;

package/dist/core/rules/quoted-tags.js

@@ -0,0 +1,79 @@
+/**
+ * Reading the tags a page quotes (`PageMarkup`, `ImageInfo.tag`) for the fixes of the page rules:
+ * attribute values, CSS selectors that find one element, and URLs as the live site should write
+ * them.
+ */
+import { slot } from "./fix.js";
+/*
+ * One attribute of a start tag: optional whitespace or a stray "/", a name, then maybe "=" and a
+ * value. The name and the separators share no character, so matching stays linear.
+ */
+const ATTRIBUTE = /[\s/]*(?<name>[^\s"'>/=]+)(?:\s*=\s*(?:"(?<dq>[^"]*)"|'(?<sq>[^']*)'|(?<uq>[^\s>]+)))?/uy;
+/**
+ * The attributes of a quoted start tag, names lower-cased and values as written (character
+ * references not decoded). The first of a repeated attribute wins, as in a browser. Null for a
+ * quote cut short.
+ */
+export const readAttributes = (tag) => {
+    const name = /^<[^\s/>]+/u.exec(tag);
+    if (!name || tag.endsWith("…")) {
+        return null;
+    }
+    const out = new Map();
+    ATTRIBUTE.lastIndex = name[0].length;
+    for (let m = ATTRIBUTE.exec(tag); m?.groups?.name; m = ATTRIBUTE.exec(tag)) {
+        const key = m.groups.name.toLowerCase();
+        if (!out.has(key)) {
+            out.set(key, m.groups.dq ?? m.groups.sq ?? m.groups.uq ?? "");
+        }
+    }
+    return out;
+};
+/** A value inside a double-quoted CSS attribute selector. */
+const cssString = (value) => value
+    .replaceAll("\\", "\\\\")
+    .replaceAll('"', '\\"')
+    .replaceAll(/[\n\r\f]/gu, " ");
+/** `element[name="value"]`, the selector of the element with that attribute value. */
+export const withAttributeSelector = (element, name, value) => `${element}[${name}="${cssString(value.slice(0, 200))}"]`;
+/** The slot for the production origin, when the audit ran on a local or file URL. */
+export const ORIGIN_SLOT = slot("production origin");
+export const ORIGIN_WRITE = "The site's production origin, such as https://www.example.com: this audit ran on a local URL or a file, so it cannot know it.";
+/**
+ * `url` as the live site writes it: as it is, or with its origin left as a slot when the audit ran
+ * on a local host or a file, whose origin is not the site's.
+ */
+export const liveUrl = (url, local) => {
+    if (!local) {
+        return url;
+    }
+    try {
+        const u = new URL(url);
+        return `${ORIGIN_SLOT}${u.pathname}${u.search}`;
+    }
+    catch {
+        return url;
+    }
+};
+/**
+ * `outer`, a whole element as quoted (`<h4 class="x">Text</h4>`), with its tag name changed in
+ * the start and end tag; null when the quote was cut or does not end in that element's end tag.
+ */
+export const renamed = (outer, from, to) => {
+    const start = new RegExp(`^<${from}(?=[\\s/>])`, "iu");
+    const end = new RegExp(`</${from}\\s*>$`, "iu");
+    if (outer.endsWith("…") || !start.test(outer) || !end.test(outer)) {
+        return null;
+    }
+    return outer.replace(start, `<${to}`).replace(end, `</${to}>`);
+};
+/** What sits between the start tag and the end tag of a whole quoted element, or null. */
+export const innerOf = (outer) => {
+    const open = outer.indexOf(">");
+    const close = outer.lastIndexOf("</");
+    if (outer.endsWith("…") || open === -1 || close < open) {
+        return null;
+    }
+    return outer.slice(open + 1, close);
+};
+//# sourceMappingURL=quoted-tags.js.map

package/dist/core/rules/quoted-tags.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"quoted-tags.js","sourceRoot":"","sources":["../../../src/core/rules/quoted-tags.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AACH,OAAO,EAAE,IAAI,EAAE,MAAM,UAAU,CAAC;AAEhC;;;GAGG;AACH,MAAM,SAAS,GACb,0FAA0F,CAAC;AAE7F;;;;GAIG;AACH,MAAM,CAAC,MAAM,cAAc,GAAG,CAAC,GAAW,EAA8B,EAAE;IACxE,MAAM,IAAI,GAAG,aAAa,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IAErC,IAAI,CAAC,IAAI,IAAI,GAAG,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,CAAC;QAC/B,OAAO,IAAI,CAAC;IACd,CAAC;IAED,MAAM,GAAG,GAAG,IAAI,GAAG,EAAkB,CAAC;IACtC,SAAS,CAAC,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC;IAErC,KAAK,IAAI,CAAC,GAAG,SAAS,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,GAAG,SAAS,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;QAC3E,MAAM,GAAG,GAAG,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;QAExC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;YAClB,GAAG,CAAC,GAAG,CAAC,GAAG,EAAE,CAAC,CAAC,MAAM,CAAC,EAAE,IAAI,CAAC,CAAC,MAAM,CAAC,EAAE,IAAI,CAAC,CAAC,MAAM,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;QAChE,CAAC;IACH,CAAC;IAED,OAAO,GAAG,CAAC;AACb,CAAC,CAAC;AAEF,6DAA6D;AAC7D,MAAM,SAAS,GAAG,CAAC,KAAa,EAAU,EAAE,CAC1C,KAAK;KACF,UAAU,CAAC,IAAI,EAAE,MAAM,CAAC;KACxB,UAAU,CAAC,GAAG,EAAE,KAAK,CAAC;KACtB,UAAU,CAAC,YAAY,EAAE,GAAG,CAAC,CAAC;AAEnC,sFAAsF;AACtF,MAAM,CAAC,MAAM,qBAAqB,GAAG,CACnC,OAAe,EACf,IAAY,EACZ,KAAa,EACL,EAAE,CAAC,GAAG,OAAO,IAAI,IAAI,KAAK,SAAS,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,IAAI,CAAC;AAEvE,qFAAqF;AACrF,MAAM,CAAC,MAAM,WAAW,GAAG,IAAI,CAAC,mBAAmB,CAAC,CAAC;AAErD,MAAM,CAAC,MAAM,YAAY,GACvB,+HAA+H,CAAC;AAElI;;;GAGG;AACH,MAAM,CAAC,MAAM,OAAO,GAAG,CAAC,GAAW,EAAE,KAAc,EAAU,EAAE;IAC7D,IAAI,CAAC,KAAK,EAAE,CAAC;QACX,OAAO,GAAG,CAAC;IACb,CAAC;IAED,IAAI,CAAC;QACH,MAAM,CAAC,GAAG,IAAI,GAAG,CAAC,GAAG,CAAC,CAAC;QAEvB,OAAO,GAAG,WAAW,GAAG,CAAC,CAAC,QAAQ,GAAG,CAAC,CAAC,MAAM,EAAE,CAAC;IAClD,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,GAAG,CAAC;IACb,CAAC;AACH,CAAC,CAAC;AAEF;;;GAGG;AACH,MAAM,CAAC,MAAM,OAAO,GAAG,CACrB,KAAa,EACb,IAAY,EACZ,EAAU,EACK,EAAE;IACjB,MAAM,KAAK,GAAG,IAAI,MAAM,CAAC,KAAK,IAAI,aAAa,EAAE,IAAI,CAAC,CAAC;IACvD,MAAM,GAAG,GAAG,IAAI,MAAM,CAAC,KAAK,IAAI,QAAQ,EAAE,IAAI,CAAC,CAAC;IAEhD,IAAI,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC;QAClE,OAAO,IAAI,CAAC;IACd,CAAC;IAED,OAAO,KAAK,CAAC,OAAO,CAAC,KAAK,EAAE,IAAI,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,GAAG,EAAE,KAAK,EAAE,GAAG,CAAC,CAAC;AACjE,CAAC,CAAC;AAEF,0FAA0F;AAC1F,MAAM,CAAC,MAAM,OAAO,GAAG,CAAC,KAAa,EAAiB,EAAE;IACtD,MAAM,IAAI,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;IAChC,MAAM,KAAK,GAAG,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IAEtC,IAAI,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,IAAI,IAAI,KAAK,CAAC,CAAC,IAAI,KAAK,GAAG,IAAI,EAAE,CAAC;QACvD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,OAAO,KAAK,CAAC,KAAK,CAAC,IAAI,GAAG,CAAC,EAAE,KAAK,CAAC,CAAC;AACtC,CAAC,CAAC"}

package/dist/core/rules/response.js

@@ -1,5 +1,26 @@
 import { isLocalHost } from "./canonical.js";
+import { addEdit, removeEdit, replaceEdit } from "./fix.js";
+import { permanentRedirect, statusLine } from "./page-fixes.js";
 import { defineRule, GOOGLE_DOCS } from "./rule.js";
+/** Where a redirect hop sends the request: the next hop's URL, or the final URL after the last. */
+const nextUrl = (response, index) => response.redirectChain[index + 1]?.url ?? response.finalUrl;
+/** A hop's status line and Location, as the server answered. */
+const hopResponse = (response, index, hop) => `${statusLine(hop.status)}\nLocation: ${nextUrl(response, index)}`;
+/** A redirect that keeps its kind (permanent or temporary) but sends the request to `location`. */
+const redirectTo = (status, location) => `${statusLine(status)}\nLocation: ${location}`;
+/** Edits that point the links to `from` at `to`: they are on other pages, so the edit names them. */
+const linkEdit = (from, to) => replaceEdit("html", from, to, {
+    at: 'a[href], link[rel="canonical"], link[rel="alternate"]',
+    write: "In every internal link, canonical, hreflang link and sitemap entry across the site that names the redirecting URL (also when written as a relative path).",
+});
+/** The page has markup of its own, so it is HTML served with the wrong type rather than a file. */
+const looksLikeHtml = (page) => page.markup.html !== null ||
+    page.markup.head !== null ||
+    page.titles.length > 0;
+/** Headers that make a response unsafe to share from a CDN cache: it is set up per visitor. */
+const isPersonal = (response) => "set-cookie" in response.headers ||
+    /\b(?:private|no-store)\b/iu.test(response.headers["cache-control"] ?? "") ||
+    /\b(?:cookie|authorization)\b/iu.test(response.headers["vary"] ?? "");
 export const responseRules = [
     defineRule({
         id: "response.error-status",
@@ -9,6 +30,12 @@ export const responseRules = [
         recommendation: "Fix the route or server error. If the page was removed on purpose, return 410 (or 404) and remove internal links and sitemap entries pointing to it.",
     }, ({ response }, make) => response?.status && response.status >= 400
         ? make(`URL returned HTTP ${response.status}.`, {
+            fix: [
+                replaceEdit("http", statusLine(response.status), statusLine(200), {
+                    at: "status line",
+                    write: "Fix the route or the server error so the page answers 200 with its content. If the page was removed on purpose, answer 410 Gone instead and remove the links and sitemap entries that point to it.",
+                }),
+            ],
             evidence: { status: response.status, finalUrl: response.finalUrl },
         })
         : null),
@@ -23,6 +50,7 @@ export const responseRules = [
         const [hop] = response?.redirectChain ?? [];
         return response && hop && response.redirectChain.length === 1
             ? make(`Request redirected (${hop.status}) to ${response.finalUrl}.`, {
+                fix: [linkEdit(hop.url, response.finalUrl)],
                 evidence: {
                     chain: response.redirectChain,
                     finalUrl: response.finalUrl,
@@ -39,6 +67,15 @@ export const responseRules = [
         docs: GOOGLE_DOCS.redirects,
     }, ({ response }, make) => response && response.redirectChain.length >= 2
         ? make(`Redirect chain of ${response.redirectChain.length} hops ends at ${response.finalUrl}.`, {
+            // Every hop redirects straight to the end, keeping its kind; the last already does.
+            fix: [
+                ...response.redirectChain
+                    .slice(0, -1)
+                    .map((hop, i) => replaceEdit("http", hopResponse(response, i, hop), redirectTo(hop.status, response.finalUrl), { url: hop.url, at: "status line and Location" })),
+                ...(response.redirectChain[0]
+                    ? [linkEdit(response.redirectChain[0].url, response.finalUrl)]
+                    : []),
+            ],
             evidence: {
                 chain: response.redirectChain,
                 finalUrl: response.finalUrl,
@@ -55,7 +92,20 @@ export const responseRules = [
     }, ({ response, thresholds }, make) => response?.timeMs !== null &&
         response?.timeMs !== undefined &&
         response.timeMs > thresholds.slowResponseMs
-        ? make(`HTML response took ${response.timeMs} ms (single measurement; threshold ${thresholds.slowResponseMs} ms).`, { evidence: { timeMs: response.timeMs } })
+        ? make(`HTML response took ${response.timeMs} ms (single measurement; threshold ${thresholds.slowResponseMs} ms).`, {
+            // A CDN may cache only a page that is the same for every visitor.
+            fix: [
+                isPersonal(response)
+                    ? replaceEdit("http", `${response.timeMs} ms`, "under 800 ms", {
+                        at: "time to first byte",
+                        write: "The response is set up per visitor (cookies or private caching), so it must not come from a shared cache: speed up the server work for this URL instead (database queries, API calls during render, a cache of the data it fetches).",
+                    })
+                    : addEdit("http", "response headers", "Cache-Control: public, s-maxage=300, stale-while-revalidate=86400", {
+                        write: "Lets the CDN serve this HTML from its cache for 5 minutes and refresh it in the background. Set it only when the page is the same for every visitor; otherwise speed up the server work for this URL. Aim for a time to first byte under 800 ms.",
+                    }),
+            ],
+            evidence: { timeMs: response.timeMs },
+        })
         : null),
     defineRule({
         id: "response.not-html",
@@ -63,17 +113,25 @@ export const responseRules = [
         severity: "warning",
         description: "The response Content-Type is not HTML.",
         recommendation: "Serve pages with Content-Type: text/html; charset=utf-8.",
-    }, ({ response }, make) => {
+    }, ({ page, response }, make) => {
         const contentType = response?.contentType;
         if (!contentType) {
             return null;
         }
         const ct = contentType.toLowerCase();
-        return !ct.includes("html") && !ct.includes("xhtml")
-            ? make(`Content-Type is "${contentType}", not HTML.`, {
-                evidence: { contentType },
-            })
-            : null;
+        if (ct.includes("html") || ct.includes("xhtml")) {
+            return null;
+        }
+        // A file such as a PDF keeps its type; HTML sent with the wrong one gets text/html.
+        const fix = looksLikeHtml(page)
+            ? replaceEdit("http", `Content-Type: ${contentType}`, "Content-Type: text/html; charset=utf-8", { at: "Content-Type" })
+            : removeEdit("sitemap", `<loc>${response.finalUrl}</loc>`, {
+                write: "This URL serves a file, not a page, so its type is right: if a sitemap lists it, remove its <url> entry, and audit an HTML page instead.",
+            });
+        return make(`Content-Type is "${contentType}", not HTML.`, {
+            fix: [fix],
+            evidence: { contentType },
+        });
     }),
     defineRule({
         id: "response.not-https",
@@ -86,6 +144,12 @@ export const responseRules = [
         response.finalUrl.startsWith("http://") &&
         !isLocalHost(response.finalUrl)
         ? make("Page is served over http:// instead of https://.", {
+            fix: [
+                replaceEdit("http", statusLine(response.status ?? 200), permanentRedirect(response.finalUrl.replace(/^http:/iu, "https:")), {
+                    at: "status line and Location",
+                    write: "Serve the site over https first (a TLS certificate for this host, which most hosts and CDNs issue for free), then redirect every http URL to its https twin. Build canonicals, sitemaps and links from the https origin.",
+                }),
+            ],
             evidence: { finalUrl: response.finalUrl },
         })
         : null),

package/dist/core/rules/response.js.map

@@ -1 +1 @@
-{"version":3,"file":"response.js","sourceRoot":"","sources":["../../../src/core/rules/response.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAAE,MAAM,gBAAgB,CAAC;AAC7C,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,WAAW,CAAC;AAEpD,MAAM,CAAC,MAAM,aAAa,GAAG;IAC3B,UAAU,CACR;QACE,EAAE,EAAE,uBAAuB;QAC3B,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,OAAO;QACjB,WAAW,EAAE,4CAA4C;QACzD,cAAc,EACZ,sJAAsJ;KACzJ,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE,CACrB,QAAQ,EAAE,MAAM,IAAI,QAAQ,CAAC,MAAM,IAAI,GAAG;QACxC,CAAC,CAAC,IAAI,CAAC,qBAAqB,QAAQ,CAAC,MAAM,GAAG,EAAE;YAC5C,QAAQ,EAAE,EAAE,MAAM,EAAE,QAAQ,CAAC,MAAM,EAAE,QAAQ,EAAE,QAAQ,CAAC,QAAQ,EAAE;SACnE,CAAC;QACJ,CAAC,CAAC,IAAI,CACX;IACD,UAAU,CACR;QACE,EAAE,EAAE,qBAAqB;QACzB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,MAAM;QAChB,WAAW,EAAE,8CAA8C;QAC3D,cAAc,EACZ,8GAA8G;QAChH,IAAI,EAAE,WAAW,CAAC,SAAS;KAC5B,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE;QACrB,MAAM,CAAC,GAAG,CAAC,GAAG,QAAQ,EAAE,aAAa,IAAI,EAAE,CAAC;QAE5C,OAAO,QAAQ,IAAI,GAAG,IAAI,QAAQ,CAAC,aAAa,CAAC,MAAM,KAAK,CAAC;YAC3D,CAAC,CAAC,IAAI,CAAC,uBAAuB,GAAG,CAAC,MAAM,QAAQ,QAAQ,CAAC,QAAQ,GAAG,EAAE;gBAClE,QAAQ,EAAE;oBACR,KAAK,EAAE,QAAQ,CAAC,aAAa;oBAC7B,QAAQ,EAAE,QAAQ,CAAC,QAAQ;iBAC5B;aACF,CAAC;YACJ,CAAC,CAAC,IAAI,CAAC;IACX,CAAC,CACF;IACD,UAAU,CACR;QACE,EAAE,EAAE,yBAAyB;QAC7B,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EACT,4EAA4E;QAC9E,cAAc,EACZ,qIAAqI;QACvI,IAAI,EAAE,WAAW,CAAC,SAAS;KAC5B,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE,CACrB,QAAQ,IAAI,QAAQ,CAAC,aAAa,CAAC,MAAM,IAAI,CAAC;QAC5C,CAAC,CAAC,IAAI,CACF,qBAAqB,QAAQ,CAAC,aAAa,CAAC,MAAM,iBAAiB,QAAQ,CAAC,QAAQ,GAAG,EACvF;YACE,QAAQ,EAAE;gBACR,KAAK,EAAE,QAAQ,CAAC,aAAa;gBAC7B,QAAQ,EAAE,QAAQ,CAAC,QAAQ;aAC5B;SACF,CACF;QACH,CAAC,CAAC,IAAI,CACX;IACD,UAAU,CACR;QACE,EAAE,EAAE,eAAe;QACnB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EACT,gFAAgF;QAClF,cAAc,EACZ,yIAAyI;QAC3I,IAAI,EAAE,WAAW,CAAC,GAAG;KACtB,EACD,CAAC,EAAE,QAAQ,EAAE,UAAU,EAAE,EAAE,IAAI,EAAE,EAAE,CACjC,QAAQ,EAAE,MAAM,KAAK,IAAI;QACzB,QAAQ,EAAE,MAAM,KAAK,SAAS;QAC9B,QAAQ,CAAC,MAAM,GAAG,UAAU,CAAC,cAAc;QACzC,CAAC,CAAC,IAAI,CACF,sBAAsB,QAAQ,CAAC,MAAM,sCAAsC,UAAU,CAAC,cAAc,OAAO,EAC3G,EAAE,QAAQ,EAAE,EAAE,MAAM,EAAE,QAAQ,CAAC,MAAM,EAAE,EAAE,CAC1C;QACH,CAAC,CAAC,IAAI,CACX;IACD,UAAU,CACR;QACE,EAAE,EAAE,mBAAmB;QACvB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,wCAAwC;QACrD,cAAc,EACZ,0DAA0D;KAC7D,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE;QACrB,MAAM,WAAW,GAAG,QAAQ,EAAE,WAAW,CAAC;QAE1C,IAAI,CAAC,WAAW,EAAE,CAAC;YACjB,OAAO,IAAI,CAAC;QACd,CAAC;QAED,MAAM,EAAE,GAAG,WAAW,CAAC,WAAW,EAAE,CAAC;QAErC,OAAO,CAAC,EAAE,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,QAAQ,CAAC,OAAO,CAAC;YAClD,CAAC,CAAC,IAAI,CAAC,oBAAoB,WAAW,cAAc,EAAE;gBAClD,QAAQ,EAAE,EAAE,WAAW,EAAE;aAC1B,CAAC;YACJ,CAAC,CAAC,IAAI,CAAC;IACX,CAAC,CACF;IACD,UAAU,CACR;QACE,EAAE,EAAE,oBAAoB;QACxB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,0CAA0C;QACvD,cAAc,EACZ,iIAAiI;KACpI,EACD,CAAC,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,EAAE,CAC7B,MAAM,KAAK,KAAK;QAChB,QAAQ;QACR,QAAQ,CAAC,QAAQ,CAAC,UAAU,CAAC,SAAS,CAAC;QACvC,CAAC,WAAW,CAAC,QAAQ,CAAC,QAAQ,CAAC;QAC7B,CAAC,CAAC,IAAI,CAAC,kDAAkD,EAAE;YACvD,QAAQ,EAAE,EAAE,QAAQ,EAAE,QAAQ,CAAC,QAAQ,EAAE;SAC1C,CAAC;QACJ,CAAC,CAAC,IAAI,CACX;CACF,CAAC"}
+{"version":3,"file":"response.js","sourceRoot":"","sources":["../../../src/core/rules/response.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,WAAW,EAAE,MAAM,gBAAgB,CAAC;AAC7C,OAAO,EAAE,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,UAAU,CAAC;AAC5D,OAAO,EAAE,iBAAiB,EAAE,UAAU,EAAE,MAAM,iBAAiB,CAAC;AAChE,OAAO,EAAE,UAAU,EAAE,WAAW,EAAE,MAAM,WAAW,CAAC;AAEpD,mGAAmG;AACnG,MAAM,OAAO,GAAG,CAAC,QAAsB,EAAE,KAAa,EAAU,EAAE,CAChE,QAAQ,CAAC,aAAa,CAAC,KAAK,GAAG,CAAC,CAAC,EAAE,GAAG,IAAI,QAAQ,CAAC,QAAQ,CAAC;AAE9D,gEAAgE;AAChE,MAAM,WAAW,GAAG,CAAC,QAAsB,EAAE,KAAa,EAAE,GAAgB,EAAE,EAAE,CAC9E,GAAG,UAAU,CAAC,GAAG,CAAC,MAAM,CAAC,eAAe,OAAO,CAAC,QAAQ,EAAE,KAAK,CAAC,EAAE,CAAC;AAErE,mGAAmG;AACnG,MAAM,UAAU,GAAG,CAAC,MAAc,EAAE,QAAgB,EAAU,EAAE,CAC9D,GAAG,UAAU,CAAC,MAAM,CAAC,eAAe,QAAQ,EAAE,CAAC;AAEjD,qGAAqG;AACrG,MAAM,QAAQ,GAAG,CAAC,IAAY,EAAE,EAAU,EAAW,EAAE,CACrD,WAAW,CAAC,MAAM,EAAE,IAAI,EAAE,EAAE,EAAE;IAC5B,EAAE,EAAE,uDAAuD;IAC3D,KAAK,EACH,2JAA2J;CAC9J,CAAC,CAAC;AAEL,mGAAmG;AACnG,MAAM,aAAa,GAAG,CAAC,IAAmB,EAAW,EAAE,CACrD,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI;IACzB,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI;IACzB,IAAI,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC;AAEzB,+FAA+F;AAC/F,MAAM,UAAU,GAAG,CAAC,QAAsB,EAAW,EAAE,CACrD,YAAY,IAAI,QAAQ,CAAC,OAAO;IAChC,4BAA4B,CAAC,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,eAAe,CAAC,IAAI,EAAE,CAAC;IAC1E,gCAAgC,CAAC,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC;AAExE,MAAM,CAAC,MAAM,aAAa,GAAG;IAC3B,UAAU,CACR;QACE,EAAE,EAAE,uBAAuB;QAC3B,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,OAAO;QACjB,WAAW,EAAE,4CAA4C;QACzD,cAAc,EACZ,sJAAsJ;KACzJ,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE,CACrB,QAAQ,EAAE,MAAM,IAAI,QAAQ,CAAC,MAAM,IAAI,GAAG;QACxC,CAAC,CAAC,IAAI,CAAC,qBAAqB,QAAQ,CAAC,MAAM,GAAG,EAAE;YAC5C,GAAG,EAAE;gBACH,WAAW,CACT,MAAM,EACN,UAAU,CAAC,QAAQ,CAAC,MAAM,CAAC,EAC3B,UAAU,CAAC,GAAG,CAAC,EACf;oBACE,EAAE,EAAE,aAAa;oBACjB,KAAK,EACH,oMAAoM;iBACvM,CACF;aACF;YACD,QAAQ,EAAE,EAAE,MAAM,EAAE,QAAQ,CAAC,MAAM,EAAE,QAAQ,EAAE,QAAQ,CAAC,QAAQ,EAAE;SACnE,CAAC;QACJ,CAAC,CAAC,IAAI,CACX;IACD,UAAU,CACR;QACE,EAAE,EAAE,qBAAqB;QACzB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,MAAM;QAChB,WAAW,EAAE,8CAA8C;QAC3D,cAAc,EACZ,8GAA8G;QAChH,IAAI,EAAE,WAAW,CAAC,SAAS;KAC5B,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE;QACrB,MAAM,CAAC,GAAG,CAAC,GAAG,QAAQ,EAAE,aAAa,IAAI,EAAE,CAAC;QAE5C,OAAO,QAAQ,IAAI,GAAG,IAAI,QAAQ,CAAC,aAAa,CAAC,MAAM,KAAK,CAAC;YAC3D,CAAC,CAAC,IAAI,CAAC,uBAAuB,GAAG,CAAC,MAAM,QAAQ,QAAQ,CAAC,QAAQ,GAAG,EAAE;gBAClE,GAAG,EAAE,CAAC,QAAQ,CAAC,GAAG,CAAC,GAAG,EAAE,QAAQ,CAAC,QAAQ,CAAC,CAAC;gBAC3C,QAAQ,EAAE;oBACR,KAAK,EAAE,QAAQ,CAAC,aAAa;oBAC7B,QAAQ,EAAE,QAAQ,CAAC,QAAQ;iBAC5B;aACF,CAAC;YACJ,CAAC,CAAC,IAAI,CAAC;IACX,CAAC,CACF;IACD,UAAU,CACR;QACE,EAAE,EAAE,yBAAyB;QAC7B,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EACT,4EAA4E;QAC9E,cAAc,EACZ,qIAAqI;QACvI,IAAI,EAAE,WAAW,CAAC,SAAS;KAC5B,EACD,CAAC,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE,CACrB,QAAQ,IAAI,QAAQ,CAAC,aAAa,CAAC,MAAM,IAAI,CAAC;QAC5C,CAAC,CAAC,IAAI,CACF,qBAAqB,QAAQ,CAAC,aAAa,CAAC,MAAM,iBAAiB,QAAQ,CAAC,QAAQ,GAAG,EACvF;YACE,oFAAoF;YACpF,GAAG,EAAE;gBACH,GAAG,QAAQ,CAAC,aAAa;qBACtB,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;qBACZ,GAAG,CAAC,CAAC,GAAG,EAAE,CAAC,EAAE,EAAE,CACd,WAAW,CACT,MAAM,EACN,WAAW,CAAC,QAAQ,EAAE,CAAC,EAAE,GAAG,CAAC,EAC7B,UAAU,CAAC,GAAG,CAAC,MAAM,EAAE,QAAQ,CAAC,QAAQ,CAAC,EACzC,EAAE,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,EAAE,EAAE,0BAA0B,EAAE,CACjD,CACF;gBACH,GAAG,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC,CAAC;oBAC3B,CAAC,CAAC,CAAC,QAAQ,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC,GAAG,EAAE,QAAQ,CAAC,QAAQ,CAAC,CAAC;oBAC9D,CAAC,CAAC,EAAE,CAAC;aACR;YACD,QAAQ,EAAE;gBACR,KAAK,EAAE,QAAQ,CAAC,aAAa;gBAC7B,QAAQ,EAAE,QAAQ,CAAC,QAAQ;aAC5B;SACF,CACF;QACH,CAAC,CAAC,IAAI,CACX;IACD,UAAU,CACR;QACE,EAAE,EAAE,eAAe;QACnB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EACT,gFAAgF;QAClF,cAAc,EACZ,yIAAyI;QAC3I,IAAI,EAAE,WAAW,CAAC,GAAG;KACtB,EACD,CAAC,EAAE,QAAQ,EAAE,UAAU,EAAE,EAAE,IAAI,EAAE,EAAE,CACjC,QAAQ,EAAE,MAAM,KAAK,IAAI;QACzB,QAAQ,EAAE,MAAM,KAAK,SAAS;QAC9B,QAAQ,CAAC,MAAM,GAAG,UAAU,CAAC,cAAc;QACzC,CAAC,CAAC,IAAI,CACF,sBAAsB,QAAQ,CAAC,MAAM,sCAAsC,UAAU,CAAC,cAAc,OAAO,EAC3G;YACE,kEAAkE;YAClE,GAAG,EAAE;gBACH,UAAU,CAAC,QAAQ,CAAC;oBAClB,CAAC,CAAC,WAAW,CACT,MAAM,EACN,GAAG,QAAQ,CAAC,MAAM,KAAK,EACvB,cAAc,EACd;wBACE,EAAE,EAAE,oBAAoB;wBACxB,KAAK,EACH,sOAAsO;qBACzO,CACF;oBACH,CAAC,CAAC,OAAO,CACL,MAAM,EACN,kBAAkB,EAClB,mEAAmE,EACnE;wBACE,KAAK,EACH,kPAAkP;qBACrP,CACF;aACN;YACD,QAAQ,EAAE,EAAE,MAAM,EAAE,QAAQ,CAAC,MAAM,EAAE;SACtC,CACF;QACH,CAAC,CAAC,IAAI,CACX;IACD,UAAU,CACR;QACE,EAAE,EAAE,mBAAmB;QACvB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,wCAAwC;QACrD,cAAc,EACZ,0DAA0D;KAC7D,EACD,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,EAAE,IAAI,EAAE,EAAE;QAC3B,MAAM,WAAW,GAAG,QAAQ,EAAE,WAAW,CAAC;QAE1C,IAAI,CAAC,WAAW,EAAE,CAAC;YACjB,OAAO,IAAI,CAAC;QACd,CAAC;QAED,MAAM,EAAE,GAAG,WAAW,CAAC,WAAW,EAAE,CAAC;QAErC,IAAI,EAAE,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,QAAQ,CAAC,OAAO,CAAC,EAAE,CAAC;YAChD,OAAO,IAAI,CAAC;QACd,CAAC;QAED,oFAAoF;QACpF,MAAM,GAAG,GAAG,aAAa,CAAC,IAAI,CAAC;YAC7B,CAAC,CAAC,WAAW,CACT,MAAM,EACN,iBAAiB,WAAW,EAAE,EAC9B,wCAAwC,EACxC,EAAE,EAAE,EAAE,cAAc,EAAE,CACvB;YACH,CAAC,CAAC,UAAU,CAAC,SAAS,EAAE,QAAQ,QAAQ,CAAC,QAAQ,QAAQ,EAAE;gBACvD,KAAK,EACH,0IAA0I;aAC7I,CAAC,CAAC;QAEP,OAAO,IAAI,CAAC,oBAAoB,WAAW,cAAc,EAAE;YACzD,GAAG,EAAE,CAAC,GAAG,CAAC;YACV,QAAQ,EAAE,EAAE,WAAW,EAAE;SAC1B,CAAC,CAAC;IACL,CAAC,CACF;IACD,UAAU,CACR;QACE,EAAE,EAAE,oBAAoB;QACxB,QAAQ,EAAE,UAAU;QACpB,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,0CAA0C;QACvD,cAAc,EACZ,iIAAiI;KACpI,EACD,CAAC,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,EAAE,CAC7B,MAAM,KAAK,KAAK;QAChB,QAAQ;QACR,QAAQ,CAAC,QAAQ,CAAC,UAAU,CAAC,SAAS,CAAC;QACvC,CAAC,WAAW,CAAC,QAAQ,CAAC,QAAQ,CAAC;QAC7B,CAAC,CAAC,IAAI,CAAC,kDAAkD,EAAE;YACvD,GAAG,EAAE;gBACH,WAAW,CACT,MAAM,EACN,UAAU,CAAC,QAAQ,CAAC,MAAM,IAAI,GAAG,CAAC,EAClC,iBAAiB,CACf,QAAQ,CAAC,QAAQ,CAAC,OAAO,CAAC,UAAU,EAAE,QAAQ,CAAC,CAChD,EACD;oBACE,EAAE,EAAE,0BAA0B;oBAC9B,KAAK,EACH,0NAA0N;iBAC7N,CACF;aACF;YACD,QAAQ,EAAE,EAAE,QAAQ,EAAE,QAAQ,CAAC,QAAQ,EAAE;SAC1C,CAAC;QACJ,CAAC,CAAC,IAAI,CACX;CACF,CAAC"}

package/dist/core/rules/rule.d.ts

@@ -1,4 +1,4 @@
-import type { ExtractedPage, Finding, PageSource, ResponseInfo, RuleMeta, Severity, Thresholds } from "../types.js";
+import type { ExtractedPage, Finding, FixEdit, PageSource, ResponseInfo, RuleMeta, Severity, Thresholds } from "../types.js";
 export interface PageContext {
     page: ExtractedPage;
     source: PageSource;
@@ -14,13 +14,26 @@ export interface Rule {
 export interface FindingExtras {
     severity?: Severity;
     recommendation?: string;
+    /**
+     * The edits that resolve this finding here. Required, so no rule can report a problem without
+     * its fix; an empty list only for a finding about the audit itself rather than the site.
+     */
+    fix: FixEdit[];
+    /**
+     * What this finding is about, when a rule can report more than one per page (a JSON-LD type, a
+     * sitemap URL). It goes into the finding's id only, so two findings of one rule keep apart. It
+     * stays with the object `finding()` returns: set `url` on that object rather than copying it.
+     */
+    key?: string;
     selector?: string;
     evidence?: Finding["evidence"];
 }
-/** Build a finding from rule metadata, overriding only what differs for this instance. */
-export declare const finding: (meta: RuleMeta, message: string, extras?: FindingExtras) => Finding;
-export declare const defineRule: (meta: RuleMeta, check: (ctx: PageContext, make: (message: string, extras?: FindingExtras) => Finding) => Finding[] | Finding | null | undefined) => Rule;
 export declare const cap: <T>(items: T[], max?: number) => T[];
+/** The `key` a finding was made with, for its id. */
+export declare const findingKey: (f: Finding) => string | undefined;
+/** Build a finding from rule metadata, overriding only what differs for this instance. */
+export declare const finding: (meta: RuleMeta, message: string, extras: FindingExtras) => Finding;
+export declare const defineRule: (meta: RuleMeta, check: (ctx: PageContext, make: (message: string, extras: FindingExtras) => Finding) => Finding[] | Finding | null | undefined) => Rule;
 export declare const GOOGLE_DOCS: {
     readonly titles: "https://developers.google.com/search/docs/appearance/title-link";
     readonly snippets: "https://developers.google.com/search/docs/appearance/snippet";

package/dist/core/rules/rule.js

@@ -1,5 +1,9 @@
+export const cap = (items, max = 10) => items.length > max ? items.slice(0, max) : items;
+const findingKeys = new WeakMap();
+/** The `key` a finding was made with, for its id. */
+export const findingKey = (f) => findingKeys.get(f);
 /** Build a finding from rule metadata, overriding only what differs for this instance. */
-export const finding = (meta, message, extras = {}) => {
+export const finding = (meta, message, extras) => {
     const f = {
         rule: meta.id,
         severity: extras.severity ?? meta.severity,
@@ -7,6 +11,12 @@ export const finding = (meta, message, extras = {}) => {
         message,
         recommendation: extras.recommendation ?? meta.recommendation,
     };
+    if (extras.fix.length) {
+        f.fix = cap(extras.fix);
+    }
+    if (extras.key) {
+        findingKeys.set(f, extras.key);
+    }
     if (extras.selector) {
         f.selector = extras.selector;
     }
@@ -28,7 +38,6 @@ export const defineRule = (meta, check) => ({
         return Array.isArray(result) ? result : [result];
     },
 });
-export const cap = (items, max = 10) => items.length > max ? items.slice(0, max) : items;
 export const GOOGLE_DOCS = {
     titles: "https://developers.google.com/search/docs/appearance/title-link",
     snippets: "https://developers.google.com/search/docs/appearance/snippet",

package/dist/core/rules/rule.js.map

@@ -1 +1 @@
-{"version":3,"file":"rule.js","sourceRoot":"","sources":["../../../src/core/rules/rule.ts"],"names":[],"mappings":"AA+BA,0FAA0F;AAC1F,MAAM,CAAC,MAAM,OAAO,GAAG,CACrB,IAAc,EACd,OAAe,EACf,MAAM,GAAkB,EAAE,EACjB,EAAE;IACX,MAAM,CAAC,GAAY;QACjB,IAAI,EAAE,IAAI,CAAC,EAAE;QACb,QAAQ,EAAE,MAAM,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ;QAC1C,QAAQ,EAAE,IAAI,CAAC,QAAQ;QACvB,OAAO;QACP,cAAc,EAAE,MAAM,CAAC,cAAc,IAAI,IAAI,CAAC,cAAc;KAC7D,CAAC;IAEF,IAAI,MAAM,CAAC,QAAQ,EAAE,CAAC;QACpB,CAAC,CAAC,QAAQ,GAAG,MAAM,CAAC,QAAQ,CAAC;IAC/B,CAAC;IAED,IAAI,MAAM,CAAC,QAAQ,EAAE,CAAC;QACpB,CAAC,CAAC,QAAQ,GAAG,MAAM,CAAC,QAAQ,CAAC;IAC/B,CAAC;IAED,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;QACd,CAAC,CAAC,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC;IACrB,CAAC;IAED,OAAO,CAAC,CAAC;AACX,CAAC,CAAC;AAEF,MAAM,CAAC,MAAM,UAAU,GAAG,CACxB,IAAc,EACd,KAG2C,EACrC,EAAE,CAAC,CAAC;IACV,IAAI;IACJ,KAAK,CAAC,GAAG;QACP,MAAM,MAAM,GAAG,KAAK,CAAC,GAAG,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,CAC5C,OAAO,CAAC,IAAI,EAAE,OAAO,EAAE,MAAM,CAAC,CAC/B,CAAC;QAEF,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;IACnD,CAAC;CACF,CAAC,CAAC;AAEH,MAAM,CAAC,MAAM,GAAG,GAAG,CAAI,KAAU,EAAE,GAAG,GAAG,EAAE,EAAO,EAAE,CAClD,KAAK,CAAC,MAAM,GAAG,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC;AAEnD,MAAM,CAAC,MAAM,WAAW,GAAG;IACzB,MAAM,EAAE,iEAAiE;IACzE,QAAQ,EAAE,8DAA8D;IACxE,SAAS,EACP,wFAAwF;IAC1F,UAAU,EACR,6EAA6E;IAC/E,SAAS,EACP,0EAA0E;IAC5E,QAAQ,EACN,+EAA+E;IACjF,QAAQ,EACN,sFAAsF;IACxF,MAAM,EAAE,oEAAoE;IAC5E,KAAK,EACH,6EAA6E;IAC/E,YAAY,EACV,2EAA2E;IAC7E,aAAa,EACX,iFAAiF;IACnF,cAAc,EACZ,4FAA4F;IAC9F,UAAU,EACR,8FAA8F;IAChG,GAAG,EAAE,iCAAiC;IACtC,MAAM,EACJ,uGAAuG;IACzG,SAAS,EACP,2EAA2E;IAC7E,QAAQ,EACN,iGAAiG;IACnG,EAAE,EAAE,iBAAiB;IACrB,OAAO,EACL,sEAAsE;CAChE,CAAC"}
+{"version":3,"file":"rule.js","sourceRoot":"","sources":["../../../src/core/rules/rule.ts"],"names":[],"mappings":"AA2CA,MAAM,CAAC,MAAM,GAAG,GAAG,CAAI,KAAU,EAAE,GAAG,GAAG,EAAE,EAAO,EAAE,CAClD,KAAK,CAAC,MAAM,GAAG,GAAG,CAAC,CAAC,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC;AAEnD,MAAM,WAAW,GAAG,IAAI,OAAO,EAAmB,CAAC;AAEnD,qDAAqD;AACrD,MAAM,CAAC,MAAM,UAAU,GAAG,CAAC,CAAU,EAAsB,EAAE,CAC3D,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;AAErB,0FAA0F;AAC1F,MAAM,CAAC,MAAM,OAAO,GAAG,CACrB,IAAc,EACd,OAAe,EACf,MAAqB,EACZ,EAAE;IACX,MAAM,CAAC,GAAY;QACjB,IAAI,EAAE,IAAI,CAAC,EAAE;QACb,QAAQ,EAAE,MAAM,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ;QAC1C,QAAQ,EAAE,IAAI,CAAC,QAAQ;QACvB,OAAO;QACP,cAAc,EAAE,MAAM,CAAC,cAAc,IAAI,IAAI,CAAC,cAAc;KAC7D,CAAC;IAEF,IAAI,MAAM,CAAC,GAAG,CAAC,MAAM,EAAE,CAAC;QACtB,CAAC,CAAC,GAAG,GAAG,GAAG,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC;IAC1B,CAAC;IAED,IAAI,MAAM,CAAC,GAAG,EAAE,CAAC;QACf,WAAW,CAAC,GAAG,CAAC,CAAC,EAAE,MAAM,CAAC,GAAG,CAAC,CAAC;IACjC,CAAC;IAED,IAAI,MAAM,CAAC,QAAQ,EAAE,CAAC;QACpB,CAAC,CAAC,QAAQ,GAAG,MAAM,CAAC,QAAQ,CAAC;IAC/B,CAAC;IAED,IAAI,MAAM,CAAC,QAAQ,EAAE,CAAC;QACpB,CAAC,CAAC,QAAQ,GAAG,MAAM,CAAC,QAAQ,CAAC;IAC/B,CAAC;IAED,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC;QACd,CAAC,CAAC,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC;IACrB,CAAC;IAED,OAAO,CAAC,CAAC;AACX,CAAC,CAAC;AAEF,MAAM,CAAC,MAAM,UAAU,GAAG,CACxB,IAAc,EACd,KAG2C,EACrC,EAAE,CAAC,CAAC;IACV,IAAI;IACJ,KAAK,CAAC,GAAG;QACP,MAAM,MAAM,GAAG,KAAK,CAAC,GAAG,EAAE,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,CAC5C,OAAO,CAAC,IAAI,EAAE,OAAO,EAAE,MAAM,CAAC,CAC/B,CAAC;QAEF,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;IACnD,CAAC;CACF,CAAC,CAAC;AAEH,MAAM,CAAC,MAAM,WAAW,GAAG;IACzB,MAAM,EAAE,iEAAiE;IACzE,QAAQ,EAAE,8DAA8D;IACxE,SAAS,EACP,wFAAwF;IAC1F,UAAU,EACR,6EAA6E;IAC/E,SAAS,EACP,0EAA0E;IAC5E,QAAQ,EACN,+EAA+E;IACjF,QAAQ,EACN,sFAAsF;IACxF,MAAM,EAAE,oEAAoE;IAC5E,KAAK,EACH,6EAA6E;IAC/E,YAAY,EACV,2EAA2E;IAC7E,aAAa,EACX,iFAAiF;IACnF,cAAc,EACZ,4FAA4F;IAC9F,UAAU,EACR,8FAA8F;IAChG,GAAG,EAAE,iCAAiC;IACtC,MAAM,EACJ,uGAAuG;IACzG,SAAS,EACP,2EAA2E;IAC7E,QAAQ,EACN,iGAAiG;IACnG,EAAE,EAAE,iBAAiB;IACrB,OAAO,EACL,sEAAsE;CAChE,CAAC"}

package/dist/core/rules/social.js

@@ -1,5 +1,72 @@
-import { normalizeUrl } from "../url.js";
+import { normalizeUrl, resolveUrl } from "../url.js";
+import { addHtml, escapeAttribute, setAttributeEdit, slot } from "./fix.js";
+import { isSlot, ORIGIN_SLOT_WRITE, productionOrigin } from "./page-fixes.js";
 import { defineRule, GOOGLE_DOCS } from "./rule.js";
+/** The URL og:url should name: the canonical, or the page itself. */
+const pageUrlFor = (page, source) => {
+    if (page.canonical) {
+        return page.canonical;
+    }
+    const origin = productionOrigin(page, source);
+    if (!isSlot(origin)) {
+        return page.url;
+    }
+    try {
+        return `${origin}${new URL(page.url).pathname}`;
+    }
+    catch {
+        return `${origin}/`;
+    }
+};
+/**
+ * The <meta> tag for one Open Graph property, with the value the page already states elsewhere
+ * (its title, description, canonical) or a slot for what only the author knows (the image).
+ */
+const ogTag = (page, source, property) => {
+    const meta = (value) => `<meta property="og:${property}" content="${value}">`;
+    switch (property) {
+        case "title": {
+            return page.title
+                ? { code: meta(escapeAttribute(page.title)) }
+                : {
+                    code: meta(slot("page title")),
+                    write: "og:title: the page's title as it should read in a share.",
+                };
+        }
+        case "description": {
+            return page.metaDescription
+                ? { code: meta(escapeAttribute(page.metaDescription)) }
+                : {
+                    code: meta(slot("share description")),
+                    write: "og:description: one or two sentences on what the page offers.",
+                };
+        }
+        case "image": {
+            return {
+                code: meta(`${productionOrigin(page, source)}${slot("/path/to/share-image.jpg")}`),
+                write: "og:image: the absolute URL of an image for share previews, at least 1200x630 pixels; the origin is the site's production origin.",
+            };
+        }
+        case "url": {
+            const url = pageUrlFor(page, source);
+            return {
+                code: meta(isSlot(url) ? url : escapeAttribute(url)),
+                write: isSlot(url) ? ORIGIN_SLOT_WRITE : undefined,
+            };
+        }
+        default: {
+            return { code: meta("website") };
+        }
+    }
+};
+/** One edit adding the given Open Graph tags to <head>, with what the slots in them need. */
+const addOgTags = (page, source, properties) => {
+    const tags = properties.map((p) => ogTag(page, source, p));
+    const writes = tags.flatMap((t) => (t.write ? [t.write] : []));
+    return addHtml("head", tags.map((t) => t.code).join("\n"), writes.length > 0
+        ? `${writes.join(" ")} og:type is "website"; use "article" for an article.`
+        : undefined);
+};
 const OG_CORE = ["title", "description", "image"];
 const OG_RECOMMENDED = [
     "title",
@@ -14,6 +81,8 @@ const TWITTER_CARDS = new Set([
     "app",
     "player",
 ]);
+/** A large image card when the page has an image to show in it, else the small one. */
+const cardFor = (page) => page.og["image"] || page.twitter["image"] ? "summary_large_image" : "summary";
 export const socialRules = [
     defineRule({
         id: "og.missing",
@@ -22,9 +91,10 @@ export const socialRules = [
         description: "No Open Graph tags (og:title, og:description, og:image) are present.",
         recommendation: "Add og:title, og:description, og:image (absolute URL, at least 1200x630), og:url and og:type so shares on social platforms and chat apps render a rich preview.",
         docs: GOOGLE_DOCS.og,
-    }, ({ page }, make) => OG_CORE.some((k) => page.og[k])
+    }, ({ page, source }, make) => OG_CORE.some((k) => page.og[k])
         ? null
         : make("Page has no Open Graph tags.", {
+            fix: [addOgTags(page, source, OG_RECOMMENDED)],
             selector: 'head > meta[property^="og:"]',
         })),
     defineRule({
@@ -34,13 +104,14 @@ export const socialRules = [
         description: "Some Open Graph tags are present but one or more of og:title, og:description, og:image, og:url, og:type is missing.",
         recommendation: "Fill in the missing Open Graph properties. og:image and og:description have the biggest effect on share previews.",
         docs: GOOGLE_DOCS.og,
-    }, ({ page }, make) => {
+    }, ({ page, source }, make) => {
         if (!OG_CORE.some((k) => page.og[k])) {
             return null;
         }
         const missing = OG_RECOMMENDED.filter((k) => !page.og[k]);
         return missing.length
             ? make(`Open Graph is missing: ${missing.map((m) => `og:${m}`).join(", ")}.`, {
+                fix: [addOgTags(page, source, missing)],
                 selector: 'head > meta[property^="og:"]',
                 evidence: { missing, present: Object.keys(page.og) },
             })
@@ -53,14 +124,25 @@ export const socialRules = [
         description: "og:image is not an absolute URL.",
         recommendation: "Use a full https:// URL for og:image; most platforms ignore relative image paths.",
         docs: GOOGLE_DOCS.og,
-    }, ({ page }, make) => {
+    }, ({ page, source }, make) => {
         const img = page.og["image"];
-        return img && !/^https?:\/\//iu.test(img)
-            ? make(`og:image "${img}" is not an absolute URL.`, {
-                selector: 'head > meta[property="og:image"]',
-                evidence: { image: img },
-            })
-            : null;
+        if (!img || /^https?:\/\//iu.test(img)) {
+            return null;
+        }
+        // The path the page meant, on the production origin (a slot when the page is on a dev host).
+        const origin = productionOrigin(page, source);
+        const resolved = resolveUrl(img, page.url);
+        const absolute = isSlot(origin)
+            ? `${origin}${resolved ? new URL(resolved).pathname + new URL(resolved).search : `/${img.replace(/^\/+/u, "")}`}`
+            : (resolved ?? img);
+        const selector = 'head > meta[property="og:image"]';
+        return make(`og:image "${img}" is not an absolute URL.`, {
+            fix: [
+                setAttributeEdit(page.markup.social["og:image"] ?? null, selector, "content", isSlot(absolute) ? absolute : escapeAttribute(absolute), isSlot(absolute) ? ORIGIN_SLOT_WRITE : undefined),
+            ],
+            selector,
+            evidence: { image: img },
+        });
     }),
     defineRule({
         id: "og.url-mismatch",
@@ -78,6 +160,9 @@ export const socialRules = [
         const b = normalizeUrl(page.canonical);
         return a && b && a !== b
             ? make("og:url does not match the canonical URL.", {
+                fix: [
+                    setAttributeEdit(page.markup.social["og:url"] ?? null, 'head > meta[property="og:url"]', "content", escapeAttribute(page.canonical)),
+                ],
                 selector: 'head > meta[property="og:url"]',
                 evidence: { ogUrl, canonical: page.canonical },
             })
@@ -93,6 +178,9 @@ export const socialRules = [
     }, ({ page }, make) => page.twitter["card"]
         ? null
         : make("Page has no twitter:card tag.", {
+            fix: [
+                addHtml("head", `<meta name="twitter:card" content="${cardFor(page)}">`),
+            ],
             selector: 'head > meta[name="twitter:card"]',
         })),
     defineRule({
@@ -106,6 +194,9 @@ export const socialRules = [
         const { card } = page.twitter;
         return card && !TWITTER_CARDS.has(card.toLowerCase())
             ? make(`twitter:card "${card}" is not a valid card type.`, {
+                fix: [
+                    setAttributeEdit(page.markup.social["twitter:card"] ?? null, 'head > meta[name="twitter:card"]', "content", cardFor(page)),
+                ],
                 selector: 'head > meta[name="twitter:card"]',
                 evidence: { card },
             })