@rivet-health/design-system 40.7.0 → 40.7.1

package/fesm2020/rivet-health-design-system.mjs

@@ -2064,12 +2064,19 @@ var RivSelect;
             return this.byId.has(option.id);
         }
         add(option) {
-            if (this.byId.has(option.id)) {
-                // Preserve insertion order while swapping to the newer object
-                // reference. Rebuilding the full Set matches the previous
-                // implementation's semantics; the cost of that rebuild only hits
-                // the rare "re-add existing" path — the common O(N²) case (fresh
-                // adds during construction) no longer pays it.
+            const existing = this.byId.get(option.id);
+            if (existing === option) {
+                // Same object reference — nothing to update. Ancestor re-adds
+                // during a selection snapshot hit this path repeatedly, so keeping
+                // it O(1) is what prevents the tree-select N² blow-up seen in
+                // RVT-25470.
+                return this;
+            }
+            if (existing !== undefined) {
+                // Different reference, same id — swap the stored ref while
+                // preserving Set insertion order. The rebuild is O(N), but this
+                // path is rare in practice (the hot ancestor-snapshot loop takes
+                // the identity fast-path above).
                 const items = [...this].map(o => (o.id === option.id ? option : o));
                 this.byId.set(option.id, option);
                 super.clear();
@@ -2410,17 +2417,22 @@ var RivSelect;
         const snapshot = new OptionSet(state.selection.selected);
         const topLevelOptions = getTopLevelOptions(state.sourceOptionGroups);
         const [parents] = getRelationshipMaps(topLevelOptions);
-        // For each selected option, add all its ancestors to the snapshot
+        // Sibling leaves share ancestors, so once we've walked up through a
+        // given parent id we can stop — anything above it has already been
+        // added by a previous iteration. Without this short-circuit the loop
+        // re-runs findOption (which is a full tree walk) once per shared
+        // ancestor edge, which was the #2 hotspot behind OptionSet.add in
+        // RVT-25470's profile.
+        const visited = new Set();
         for (const selectedOption of state.selection.selected) {
-            let currentId = selectedOption.id;
-            let parentId = parents.get(currentId);
-            while (parentId !== undefined) {
+            let parentId = parents.get(selectedOption.id);
+            while (parentId !== undefined && !visited.has(parentId)) {
+                visited.add(parentId);
                 const parentOption = findOption(topLevelOptions, parentId);
                 if (parentOption) {
                     snapshot.add(parentOption);
                 }
-                currentId = parentId;
-                parentId = parents.get(currentId);
+                parentId = parents.get(parentId);
             }
         }
         return snapshot;