@ripwords/myinvois-client 0.1.2 → 0.1.4

package/CHANGELOG.md

@@ -1,6 +1,34 @@
 # Changelog
 
 
+## v0.1.4
+
+[compare changes](https://github.com/Ripwords/MyInvoisClient/compare/v0.1.3...v0.1.4)
+
+### 💅 Refactors
+
+- Extend RegistrationType to include 'ARMY' and update related interfaces in documents.d.ts and index.ts for improved type safety ([955ccee](https://github.com/Ripwords/MyInvoisClient/commit/955ccee))
+
+### 🏡 Chore
+
+- Update release scripts to remove npm publish command and ensure git push follows changelog generation ([ba56b4a](https://github.com/Ripwords/MyInvoisClient/commit/ba56b4a))
+
+### ❤️ Contributors
+
+- JJ <teohjjteoh@gmail.com>
+
+## v0.1.3
+
+[compare changes](https://github.com/Ripwords/MyInvoisClient/compare/v0.1.2...v0.1.3)
+
+### 💅 Refactors
+
+- Add industry classification fields to Supplier interface in documents.d.ts, update invoice generation logic in document.ts, and enhance related tests for improved type safety and clarity ([648858a](https://github.com/Ripwords/MyInvoisClient/commit/648858a))
+
+### ❤️ Contributors
+
+- JJ <teohjjteoh@gmail.com>
+
 ## v0.1.2
 
 [compare changes](https://github.com/Ripwords/MyInvoisClient/compare/v0.1.1...v0.1.2)

package/package.json

@@ -1,16 +1,15 @@
 {
   "name": "@ripwords/myinvois-client",
-  "version": "0.1.2",
+  "version": "0.1.4",
   "description": "MyInvois client",
   "scripts": {
     "build": "tsdown",
     "prerelease": "bun run lint && bun run build",
     "postrelease": "git push --follow-tags",
     "changelog": "changelogen --release",
-    "publish": "npm publish --access public && git push --follow-tags",
-    "release": "bun run prerelease && bun run changelog && bun run publish",
-    "release:minor": "bun run prerelease && bun run changelog --minor && bun run publish",
-    "release:major": "bun run prerelease && bun run changelog --major && bun run publish",
+    "release": "bun run prerelease && bun run changelog && git push --follow-tags",
+    "release:minor": "bun run prerelease && bun run changelog --minor && git push --follow-tags",
+    "release:major": "bun run prerelease && bun run changelog --major && git push --follow-tags",
     "lint": "oxlint",
     "test": "vitest"
   },

package/src/index.ts

@@ -3,6 +3,7 @@ import { platformLogin } from './api/platform/platformLogin'
 import type {
   DocumentStatus,
   InvoiceV1_1,
+  RegistrationType,
   SigningCredentials,
 } from './types/documents'
 import { getBaseUrl } from './utils/getBaseUrl'
@@ -114,7 +115,7 @@ export class MyInvoisClient {
    */
   async verifyTin(
     tin: string,
-    idType: 'NRIC' | 'ARMY' | 'PASSPORT' | 'BRN',
+    idType: RegistrationType,
     idValue: string,
   ): Promise<boolean> {
     try {

package/src/types/documents.d.ts

@@ -1,14 +1,11 @@
-import type { EInvoiceTypeCode } from './e-invoice.d.ts'
+import type { ClassificationCode } from './classification-codes.d.ts'
 import type { CurrencyCode } from './currencies.d.ts'
+import type { EInvoiceTypeCode } from './e-invoice.d.ts'
+import type { MSICCode } from './msic-codes.d.ts'
 import type { IssuerDigitalSignature } from './signatures.d.ts'
 import type { TaxTypeCode } from './tax-types.d.ts'
-import type { CountryCode } from './country-code.d.ts'
-import type { ClassificationCode } from './classification-codes.d.ts'
-import type { UnitTypeCode } from './unit-types.d.ts'
-import type { PaymentModeCode } from './payment-modes.d.ts'
-import type { MSICCode } from './msic-codes.d.ts'
 
-export type RegistrationType = 'BRN' | 'NRIC' | 'PASSPORT'
+export type RegistrationType = 'BRN' | 'NRIC' | 'PASSPORT' | 'ARMY'
 
 // Based on https://sdk.myinvois.hasil.gov.my/documents/invoice-v1-1/
 
@@ -49,7 +46,7 @@ export interface Supplier {
   registrationType: RegistrationType
   /**
    * Supplier's Registration / Identification Number / Passport Number.
-   * Format depends on schemeID: NRIC (12), BRN (20), PASSPORT (12), ARMY (12).
+   * Format depends on schemeID: NRIC (12), BRN (20), PASSPORT (12)
    * @example BRN: 202001234567
    */
   registrationNumber: string
@@ -59,6 +56,16 @@ export interface Supplier {
    * @example +60123456789
    */
   contactNumber: string
+  /**
+   * Supplier's industry classification code. Max 10 chars.
+   * @example 41001
+   */
+  industryClassificationCode: MSICCode['code']
+  /**
+   * Supplier's industry classification description. Max 300 chars.
+   * @example Other retail sale in non-specialised stores
+   */
+  industryClassificationDescription: MSICCode['description']
 }
 
 /**
@@ -75,13 +82,13 @@ export interface Buyer {
    */
   tin: string
   /**
-   * Buyer's Registration Type. NRIC, BRN, PASSPORT, ARMY
+   * Buyer's Registration Type. NRIC, BRN, PASSPORT
    * @example BRN
    */
   registrationType: RegistrationType
   /**
    * Buyer's Registration / Identification Number / Passport Number.
-   * Format depends on schemeID: NRIC (12), BRN (20), PASSPORT (12), ARMY (12).
+   * Format depends on schemeID: NRIC (12), BRN (20), PASSPORT (12).
    * @example BRN: 202001234567
    */
   registrationNumber: string

package/src/utils/document.ts

@@ -81,8 +81,8 @@ export const generateCleanInvoiceObject = (
             // Industry Classification - required field
             IndustryClassificationCode: [
               {
-                _: '47900', // Default to trading/general commerce
-                name: 'Other retail sale in non-specialised stores',
+                _: invoice.supplier.industryClassificationCode,
+                name: invoice.supplier.industryClassificationDescription,
               },
             ],
 

package/test/dynamicInvoiceFeatures.test.ts

@@ -238,6 +238,8 @@ describe('Dynamic Invoice Features', () => {
           state: '14',
           country: 'MYS',
         },
+        industryClassificationCode: '41001',
+        industryClassificationDescription: 'Test Industry',
       },
 
       buyer: {

package/test/signAndSubmitInvoice.test.ts

@@ -44,6 +44,8 @@ const createMinimalTestInvoice = (): InvoiceV1_1 => {
         state: '14', // Wilayah Persekutuan Kuala Lumpur
         country: 'MYS',
       },
+      industryClassificationCode: '41001',
+      industryClassificationDescription: 'Test Industry',
     },
 
     // === BUYER (using consolidated buyer for testing) ===

package/test/signature-diagnostics.test.ts

@@ -44,6 +44,8 @@ describe('Signature Diagnostics', () => {
           state: '14',
           country: 'MYS',
         },
+        industryClassificationCode: '41001',
+        industryClassificationDescription: 'Test Industry',
       },
 
       buyer: {