@riocrypto/common-server 1.0.2920 → 1.0.2924

package/build/helpers/resolve-processor.js

@@ -24,7 +24,12 @@ const pickByShare = (candidates, position) => {
 // from the configured split.
 //
 // A percentage divides volume between the rails that are actually available to
-// the customer; it is not a switch. A rail left at zero, left out of the rule, or
+// the customer; it is not a switch. On a scheduled corridor the percentages are
+// whichever window covers the current minute where that corridor banks, so the
+// same order placed two hours later can be divided differently. Everything below
+// that point is indifferent to where the shares came from.
+//
+// A rail left at zero, left out of the rule, or
 // belonging to a corridor with no rule at all still takes their orders when it is
 // the only one available to them, which is why the candidate set comes from the
 // corridor rather than from the rule. What keeps an order away from a rail is the
@@ -96,6 +101,11 @@ const resolveProcessor = ({ country, fiat, purpose, routingConfig, excludedProce
     // ruleless until an admin first saves one - as is any corridor whose shares
     // were all cleared, since the settings page stores that as no rule at all.
     const rule = getRule(routingConfig, country, fiat, purpose);
+    // The split in force at this instant, which on a scheduled corridor depends on
+    // what time it is where the corridor banks. Resolved from `decidedAt` so the
+    // shares, the window and the timestamp recorded on the decision can never end
+    // up describing different minutes.
+    const { percentages: configuredPercentages, matchedWindow } = (0, common_1.resolveProcessorRoutingPercentages)(rule, country, fiat, purpose, decidedAt);
     // Starts from the corridor's rails rather than from the rails the rule names,
     // because a percentage decides how volume is divided between the rails a
     // customer can use - it is not what makes a rail usable. Also drops any share
@@ -139,11 +149,21 @@ const resolveProcessor = ({ country, fiat, purpose, routingConfig, excludedProce
     const candidates = enablementOverridden
         ? eligible
         : eligible.filter((processor) => !disabled.includes(processor) && !gatedUnset.includes(processor));
-    // What was filtered, carried by every decision below. Kept in one place so a
-    // branch cannot quietly stop reporting one of them, since these sets are the
-    // whole reason a decision can still be explained weeks later.
-    const filtered = Object.assign({ corridor, excluded: excludedProcessors, disabled,
-        unset }, (enablementOverridden ? { enablementOverridden: true } : {}));
+    // What was filtered and which window the shares came from, carried by every
+    // decision below. Kept in one place so a branch cannot quietly stop reporting
+    // one of them, since this is the whole reason a decision can still be explained
+    // weeks later. The window is recorded even on the refusals, because "the
+    // afternoon window gave Fintoc everything and this customer has Fintoc off" is
+    // the shape of the question that gets asked.
+    const filtered = Object.assign(Object.assign({ corridor, excluded: excludedProcessors, disabled,
+        unset }, (enablementOverridden ? { enablementOverridden: true } : {})), (matchedWindow
+        ? {
+            window: {
+                startMinute: matchedWindow.startMinute,
+                endMinute: matchedWindow.endMinute,
+            },
+        }
+        : {}));
     if (!candidates.length) {
         return Object.assign(Object.assign({ 
             // Told apart because they are different conversations. One customer turned
@@ -155,13 +175,10 @@ const resolveProcessor = ({ country, fiat, purpose, routingConfig, excludedProce
                 : common_1.RoutingDecisionReason.NoEnabledCandidate }, filtered), { decidedAt });
     }
     const shares = candidates
-        .map((processor) => {
-        var _a;
-        return ({
-            processor,
-            percentage: Number((_a = rule === null || rule === void 0 ? void 0 : rule.percentages) === null || _a === void 0 ? void 0 : _a[processor]) || 0,
-        });
-    })
+        .map((processor) => ({
+        processor,
+        percentage: Number(configuredPercentages[processor]) || 0,
+    }))
         .filter((candidate) => candidate.percentage > 0);
     const percentages = Object.fromEntries(shares.map((share) => [share.processor, share.percentage]));
     // None of the rails this customer can use carries a share - or no rule is

package/build/models/alfin-withdrawal.js

@@ -77,6 +77,21 @@ const buildAlfinWithdrawal = (mongoose) => {
             },
         },
     });
+    // Nothing here was indexed, so the background workers below were reading the
+    // whole collection every few seconds. Both indexes are multikey over the
+    // parts array, which is allowed because the fields belong to the same array
+    // rather than to parallel ones.
+    // Settlement reconciliation and treasury part submission both hunt for parts
+    // sitting in `processing`, on a timer, forever. Parts in that state are a
+    // small minority of a collection that only grows, which is what makes the
+    // scan worth removing.
+    AlfinWithdrawalSchema.index({
+        "AlfinWithdrawals.status": 1,
+        "AlfinWithdrawals.statusCheckAfter": 1,
+    });
+    // The treasury import reads the recent internal transfers on every run, to
+    // recognise the statement lines of transfers Rio sent itself.
+    AlfinWithdrawalSchema.index({ type: 1, createdAt: -1 });
     AlfinWithdrawalSchema.statics.build = (attrs) => {
         return new AlfinWithdrawal(attrs);
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@riocrypto/common-server",
-  "version": "1.0.2920",
+  "version": "1.0.2924",
   "description": "",
   "main": "./build/index.js",
   "types": "./build/index.d.ts",
@@ -28,7 +28,7 @@
     "@google-cloud/secret-manager": "^5.6.0",
     "@google-cloud/storage": "^7.19.0",
     "@hyperdx/node-opentelemetry": "^0.10.3",
-    "@riocrypto/common": "1.0.2720",
+    "@riocrypto/common": "1.0.2722",
     "@slack/web-api": "^7.15.0",
     "@types/express": "^4.17.25",
     "axios": "1.18.1",