@riocrypto/common-server 1.0.2667 → 1.0.2668

package/build/helpers/generate-payment-reference.js

@@ -10,9 +10,11 @@ const generateReference = (order) => {
     // Using last 6 chars alone caused collisions (~50/month) because the counter
     // portion can overlap across different MongoDB instances/pods.
     //
-    // Solution: Use 7 consecutive chars from the random portion (8-14).
-    // This gives 16^7 = 268 million combinations vs 16^6 = 16.7 million (16x better).
-    // Using consecutive chars from the ID keeps it simple and traceable.
-    return order.id.slice(8, 15).toUpperCase();
+    // Solution: 2 chars from random portion (8-9) + last 6 chars of order ID.
+    // Last 6 chars are kept for easy traceability by finance team.
+    // This gives 16^8 = 4.3 billion combinations vs 16^6 = 16.7 million (256x better).
+    const randomPrefix = order.id.slice(8, 10);
+    const last6 = order.id.slice(-6);
+    return (randomPrefix + last6).toUpperCase();
 };
 exports.generateReference = generateReference;

package/build/helpers/get-bulk-payment-from-reference.js

@@ -28,11 +28,13 @@ const getBulkPaymentFromReference = (reference, mongoose) => __awaiter(void 0, v
             ],
         },
     });
-    // Reference format uses 7 consecutive chars from the random portion (8-14)
+    // Reference format: 2 chars from random portion (8-9) + last 6 chars of ID
     const bulkPayment = bulkPayments.find((bulkPayment) => {
         const bulkPaymentId = bulkPayment.id.toString().toLowerCase();
-        const reference7Chars = bulkPaymentId.slice(8, 15);
-        return referenceText.includes(reference7Chars);
+        const randomPrefix = bulkPaymentId.slice(8, 10);
+        const last6 = bulkPaymentId.slice(-6);
+        const reference8Chars = randomPrefix + last6;
+        return referenceText.includes(reference8Chars);
     });
     if (!bulkPayment) {
         throw new Error("Bulk payment not found");

package/build/helpers/get-order-from-reference.js

@@ -47,11 +47,13 @@ const getOrderFromReference = (reference, mongoose) => __awaiter(void 0, void 0,
             break;
         }
         // Check each order ID against the reference
-        // Reference format uses 7 consecutive chars from the random portion (8-14)
+        // Reference format: 2 chars from random portion (8-9) + last 6 chars of order ID
         for (const order of orders) {
             const orderId = order._id.toString().toLowerCase();
-            const reference7Chars = orderId.slice(8, 15);
-            if (referenceText.includes(reference7Chars)) {
+            const randomPrefix = orderId.slice(8, 10);
+            const last6 = orderId.slice(-6);
+            const reference8Chars = randomPrefix + last6;
+            if (referenceText.includes(reference8Chars)) {
                 // Found a match, now fetch the full order document
                 foundOrder = yield Order.findById(order._id);
                 break;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@riocrypto/common-server",
-  "version": "1.0.2667",
+  "version": "1.0.2668",
   "description": "",
   "main": "./build/index.js",
   "types": "./build/index.d.ts",