@riocrypto/common-server 1.0.2666 → 1.0.2667

package/build/helpers/generate-payment-reference.js

@@ -2,7 +2,17 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.generateReference = void 0;
 const generateReference = (order) => {
-    const referenceNumber = order.id.slice(-6);
-    return referenceNumber;
+    // MongoDB ObjectId structure (24 hex chars):
+    // - chars 0-7: timestamp (4 bytes)
+    // - chars 8-17: random value (5 bytes)
+    // - chars 18-23: incrementing counter (3 bytes)
+    //
+    // Using last 6 chars alone caused collisions (~50/month) because the counter
+    // portion can overlap across different MongoDB instances/pods.
+    //
+    // Solution: Use 7 consecutive chars from the random portion (8-14).
+    // This gives 16^7 = 268 million combinations vs 16^6 = 16.7 million (16x better).
+    // Using consecutive chars from the ID keeps it simple and traceable.
+    return order.id.slice(8, 15).toUpperCase();
 };
 exports.generateReference = generateReference;

package/build/helpers/get-bulk-payment-from-reference.js

@@ -28,10 +28,11 @@ const getBulkPaymentFromReference = (reference, mongoose) => __awaiter(void 0, v
             ],
         },
     });
+    // Reference format uses 7 consecutive chars from the random portion (8-14)
     const bulkPayment = bulkPayments.find((bulkPayment) => {
         const bulkPaymentId = bulkPayment.id.toString().toLowerCase();
-        const last6Chars = bulkPaymentId.slice(-6);
-        return referenceText.includes(last6Chars);
+        const reference7Chars = bulkPaymentId.slice(8, 15);
+        return referenceText.includes(reference7Chars);
     });
     if (!bulkPayment) {
         throw new Error("Bulk payment not found");

package/build/helpers/get-order-from-reference.js

@@ -47,10 +47,11 @@ const getOrderFromReference = (reference, mongoose) => __awaiter(void 0, void 0,
             break;
         }
         // Check each order ID against the reference
+        // Reference format uses 7 consecutive chars from the random portion (8-14)
         for (const order of orders) {
             const orderId = order._id.toString().toLowerCase();
-            const last6Chars = orderId.slice(-6);
-            if (referenceText.includes(last6Chars)) {
+            const reference7Chars = orderId.slice(8, 15);
+            if (referenceText.includes(reference7Chars)) {
                 // Found a match, now fetch the full order document
                 foundOrder = yield Order.findById(order._id);
                 break;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@riocrypto/common-server",
-  "version": "1.0.2666",
+  "version": "1.0.2667",
   "description": "",
   "main": "./build/index.js",
   "types": "./build/index.d.ts",