@rimori/client 2.5.46-next.0 → 2.5.47-next.0

package/dist/fromRimori/PluginTypes.d.ts

@@ -107,6 +107,12 @@ export interface RimoriPluginConfig<T extends object = object> {
         user_path: string;
         /** Path to developer documentation for plugin development */
         developer_path: string;
+        /**
+         * Optional path to side-panel / browser-extension specific usage notes. Kept separate so it
+         * can be shown on its own when the plugin runs in the extension side panel, and appended to
+         * the main user docs when read in the full app — avoiding a duplicated description.
+         */
+        sidebar_path?: string;
     };
     /**
      * Configuration for the plugin's web worker if it uses background processing or exposes actions to other plugins.

package/dist/plugin/module/PluginModule.d.ts

@@ -54,6 +54,14 @@ export declare class PluginModule {
      * @throws {Error} if RLS blocks the operation.
      */
     setSettings(settings: any): Promise<void>;
+    /**
+     * Seeds the plugin's default settings row without ever clobbering an existing one.
+     * Used by getSettings when no row was read. Inserts the defaults; if a concurrent
+     * writer already created the row (unique-violation) — or it existed all along and
+     * the read merely missed it — re-reads and returns the persisted settings instead
+     * of the defaults. This keeps the read-triggered seed idempotent and race-safe.
+     */
+    private seedDefaultSettings;
     /**
      * Get the settings for the plugin. T can be any type of settings, UserSettings or SystemSettings.
      * @param defaultSettings The default settings to use if no settings are found.

package/dist/plugin/module/PluginModule.js

@@ -146,6 +146,44 @@ export class PluginModule {
             throw insertError;
         }
     }
+    /**
+     * Seeds the plugin's default settings row without ever clobbering an existing one.
+     * Used by getSettings when no row was read. Inserts the defaults; if a concurrent
+     * writer already created the row (unique-violation) — or it existed all along and
+     * the read merely missed it — re-reads and returns the persisted settings instead
+     * of the defaults. This keeps the read-triggered seed idempotent and race-safe.
+     */
+    async seedDefaultSettings(defaults) {
+        const isGuildSetting = !this.rimoriInfo.guild.allowUserPluginSettings;
+        const payload = {
+            plugin_id: this.pluginId,
+            settings: defaults,
+            guild_id: this.rimoriInfo.guild.id,
+            is_guild_setting: isGuildSetting,
+        };
+        if (isGuildSetting) {
+            payload.user_id = null;
+        }
+        const { error } = await this.supabase.schema('public').from('plugin_settings').insert(payload);
+        if (!error) {
+            // Keep the read cache consistent with what we just persisted.
+            this.settingsPromise = Promise.resolve(defaults);
+            return defaults;
+        }
+        // Row already exists (another instance won the race, or the earlier read missed
+        // it). Adopt the persisted row rather than overwriting it with our defaults.
+        if (error.code === '23505' /* unique_violation */) {
+            this.settingsPromise = undefined; // force a fresh refetch
+            const existing = await this.fetchSettings();
+            return existing ?? defaults;
+        }
+        // Genuine failure — drop the optimistic cache so reads refetch the truth.
+        this.settingsPromise = undefined;
+        if (error.code === '42501' || error.message?.includes('policy')) {
+            throw new Error(`Cannot set ${isGuildSetting ? 'guild' : 'user'} settings: Permission denied.`);
+        }
+        throw error;
+    }
     /**
      * Get the settings for the plugin. T can be any type of settings, UserSettings or SystemSettings.
      * @param defaultSettings The default settings to use if no settings are found.
@@ -154,8 +192,17 @@ export class PluginModule {
     async getSettings(defaultSettings) {
         const storedSettings = await this.fetchSettings();
         if (!storedSettings) {
-            await this.setSettings(defaultSettings);
-            return defaultSettings;
+            // No row read — seed defaults, but NEVER overwrite on conflict. During first
+            // onboarding several independent PluginModule instances read settings at once:
+            // the federated main-panel hooks AND the plugin worker, which runs in its own
+            // runtime with its own client + single-flight cache and so doesn't share the
+            // in-flight dedupe above. They all reach this null branch before any row exists
+            // and race to create it. An unconditional write here both 409s on the unique
+            // index (ux_plugin_settings_guild_plugin_user) and lets a loser clobber a
+            // freshly-persisted row (e.g. is_inited:true) back to defaults. Insert-if-absent
+            // and adopt the existing row on conflict — this also guards against a transient
+            // read miss (fetchSettings swallows errors → null) overwriting good data.
+            return (await this.seedDefaultSettings(defaultSettings));
         }
         // Key-count migration runs at most once per plugin lifetime. Concurrent callers
         // share the fetchSettings promise; the first to resume here flips the flag (a

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rimori/client",
-  "version": "2.5.46-next.0",
+  "version": "2.5.47-next.0",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "repository": {
@@ -51,6 +51,7 @@
     "prebuild": "pnpm sync-db-types",
     "predev": "pnpm sync-db-types",
     "build": "tsc",
+    "check": "tsc --noEmit --pretty",
     "dev": "tsc -w  --preserveWatchOutput",
     "lint": "pnpm exec eslint . --fix",
     "format": "prettier --write .",