@rigour-labs/core 6.9.0-rc.2 → 6.9.0-rc.3

package/dist/review-learning/learn-from-reviews.js

@@ -46,7 +46,7 @@ export async function learnFromReviews(cwd, options) {
         const byNumber = new Map(prs.filter(pr => pr.mergedAt).map(pr => [pr.number, pr]));
         const reverts = new Map([...byNumber.values()].map(pr => [pr.number, revertOf(git, pr, { mainRef: options.mainRef, until: options.until })]));
         for (const lesson of merged.lessons) {
-            if (lesson.state !== 'candidate' || lesson.evidence.some(e => e.kind === 'outcome' || e.kind === 'counter'))
+            if (lesson.state !== 'candidate' || lesson.evidence.some(e => e.kind === 'outcome' || e.kind === 'lines' || e.kind === 'counter'))
                 continue;
             for (const point of lesson.evidence.filter(e => (e.kind ?? 'point') === 'point')) {
                 const pr = byNumber.get(point.pr);
@@ -54,7 +54,8 @@ export async function learnFromReviews(cwd, options) {
                     continue;
                 const found = (point.actedOn === false ? reverts.get(pr.number) : undefined) ?? outcomeFor(git, lesson, pr, { mainRef: options.mainRef, until: options.until, windowDays: options.windowDays });
                 if (found) {
-                    lesson.evidence.push(found);
+                    // A fix on the point's lines, or a revert, is evidence for a person to promote in Studio, never a promotion (lessonState).
+                    lesson.evidence.push(found.kind === 'outcome' ? { ...found, kind: 'lines' } : found);
                     break;
                 }
             }

package/dist/review-learning/lessons.d.ts

@@ -12,12 +12,13 @@ import type { Git, ReviewBody, ReviewComment } from './acted-on.js';
  *   lines     a later fix changed the point's own lines (outcome-evidence.ts): shown for a person to promote or dismiss,
  *             never a promotion on its own (a fix on the same lines is often unrelated work);
  *   dismissed a person looked at that evidence and set it aside: the lesson stays as it was;
+ *   reclassified  a lesson an outcome alone had promoted, back to a candidate when outcomes stopped promoting (once);
  *   against   a later pull request a review found repeating the lesson merged anyway and settled clean;
  *   demoted   enough independent `against` pull requests took back a lesson evidence had promoted: a candidate again,
  *             until a person promotes it.
  * A record from before evidence kinds has none: it is a `point`.
  */
-export type EvidenceKind = 'point' | 'outcome' | 'counter' | 'correction' | 'accepted' | 'rejected' | 'norule' | 'followup' | 'lines' | 'dismissed' | 'against' | 'demoted';
+export type EvidenceKind = 'point' | 'outcome' | 'counter' | 'correction' | 'accepted' | 'rejected' | 'norule' | 'followup' | 'lines' | 'dismissed' | 'against' | 'demoted' | 'reclassified';
 export interface LessonEvidence {
     kind?: EvidenceKind;
     pr: number;
@@ -59,9 +60,9 @@ export interface ReviewLesson {
     updatedAt: string;
 }
 /**
- * A lesson's state from its evidence trail. A person's decision wins; then an outcome; counter-evidence
- * holds a candidate back; recurrence across pull requests and authors is enough only without it. A record
- * from before evidence kinds keeps the state it had.
+ * A lesson's state from its evidence trail. A person's decision wins; then a person's correction; counter-evidence
+ * holds a candidate back; recurrence across pull requests and authors is enough only without it. An outcome is
+ * evidence, never a promotion. A record from before evidence kinds keeps the state it had.
  */
 export declare function lessonState(lesson: ReviewLesson): Pick<ReviewLesson, 'state' | 'promotedBy'>;
 /** The point of a review comment: its bold title, else its first sentence, without tool output or markup. */

package/dist/review-learning/lessons.js

@@ -35,9 +35,9 @@ const PLAIN_WORDS = new Set(['when', 'that', 'this', 'with', 'from', 'before', '
 const NOT_CODE = /(\.(md|mdx|txt|ya?ml|json|lock|snap)$)|(\.(test|spec)\.[cm]?[jt]sx?$)|(^|\/)(__tests__|docs?|migrations|\.github)\//i;
 const NOT_SYMBOLS = new Set(['this', 'that', 'with', 'from', 'return', 'const', 'await', 'async', 'function', 'true', 'false', 'null', 'undefined', 'string', 'number', 'boolean', 'export', 'import', 'type', 'interface', 'else', 'when', 'then', 'should', 'line', 'lines']);
 /**
- * A lesson's state from its evidence trail. A person's decision wins; then an outcome; counter-evidence
- * holds a candidate back; recurrence across pull requests and authors is enough only without it. A record
- * from before evidence kinds keeps the state it had.
+ * A lesson's state from its evidence trail. A person's decision wins; then a person's correction; counter-evidence
+ * holds a candidate back; recurrence across pull requests and authors is enough only without it. An outcome is
+ * evidence, never a promotion. A record from before evidence kinds keeps the state it had.
  */
 export function lessonState(lesson) {
     const kinds = new Set(lesson.evidence.map(e => e.kind));
@@ -56,8 +56,8 @@ export function lessonState(lesson) {
         return { state: 'candidate' };
     if (kinds.has('correction'))
         return { state: 'verified', promotedBy: 'correction' };
-    if (kinds.has('outcome'))
-        return { state: 'verified', promotedBy: 'outcome' };
+    // An outcome (a later fix on the point's lines, a revert) no longer promotes on its own: judged by a person against
+    // real history, it was most often unrelated work. It is shown in Studio for a person to promote.
     if (kinds.has('counter'))
         return { state: 'candidate' };
     const points = lesson.evidence.filter(e => (e.kind ?? 'point') === 'point');
@@ -227,12 +227,29 @@ export function lessonsPath(cwd) {
 export function readLessons(cwd) {
     try {
         const parsed = JSON.parse(fs.readFileSync(lessonsPath(cwd), 'utf8'));
-        return Array.isArray(parsed?.lessons) ? parsed.lessons : [];
+        return Array.isArray(parsed?.lessons) ? parsed.lessons.map(reclassified) : [];
     }
     catch {
         return [];
     }
 }
+/** Why a lesson an outcome alone had promoted is a candidate again. */
+const RECLASSIFIED = 'promoted by the exact-line rule, which no longer promotes on its own';
+/**
+ * A lesson stored as verified by an outcome (a later fix on its lines, or a revert), as every reader sees it now that
+ * outcomes no longer promote: its state worked out again from its evidence, and, when that leaves it a candidate, one
+ * `reclassified` record saying why. Never deleted, nothing else changed; the next write keeps it, and a lesson that
+ * already has the record is left as it is. Recurrence, a correction or a person's decision keeps a lesson verified.
+ */
+function reclassified(lesson) {
+    if (lesson.state !== 'verified' || lesson.promotedBy !== 'outcome' || lesson.evidence.some(e => e.kind === 'reclassified'))
+        return lesson;
+    const next = lessonState(lesson);
+    if (next.state === 'verified')
+        return { ...lesson, ...next };
+    const at = new Date().toISOString();
+    return { ...lesson, state: 'candidate', promotedBy: undefined, evidence: [...lesson.evidence, { kind: 'reclassified', pr: lesson.evidence[0]?.pr ?? 0, comment: `reclassified-${lesson.id}`, author: '', detail: RECLASSIFIED, at }] };
+}
 export function writeLessons(cwd, lessons) {
     const file = lessonsPath(cwd);
     fs.mkdirSync(path.dirname(file), { recursive: true });

package/dist/review-learning/outcome-evidence.d.ts

@@ -13,8 +13,8 @@
  * lesson warns against; the reviewer's lessons step, review event `lessons_applied`) and the pull request merged anyway
  * and settled clean: CI passed on the merge commit, no fix touched the lesson's file in the window, and no revert. A
  * pull request that followed the lesson, or that no review checked against it, never counts. `demote_after` such pull
- * requests, independent (more than one author, or merged at least a week apart), take back a lesson evidence promoted
- * (by an outcome or by recurrence): it is `demoted` to a candidate. A lesson a person promoted, or corrected into being,
+ * requests, independent (more than one author, or merged at least a week apart), take back a lesson recurrence
+ * promoted: it is `demoted` to a candidate. A lesson a person promoted, or corrected into being,
  * is not.
  */
 import type { PrOutcome } from '../outcomes/outcome.js';

package/dist/review-learning/outcome-evidence.js

@@ -44,7 +44,7 @@ export function applyOutcomeEvidence(lessons, records, applied, options) {
             }
         }
         // Against it: later pull requests a review found repeating it, merged anyway, settled clean.
-        if (lesson.state === 'verified' && (lesson.promotedBy === 'outcome' || lesson.promotedBy === 'recurrence')) {
+        if (lesson.state === 'verified' && lesson.promotedBy === 'recurrence') {
             for (const [pr, ids] of applied) {
                 const record = byPr.get(pr);
                 if (own.has(pr) || !ids.has(lesson.id) || !record || !settledClean(record, lesson.file))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rigour-labs/core",
-  "version": "6.9.0-rc.2",
+  "version": "6.9.0-rc.3",
   "description": "Rigour's review engine: deterministic gates on changed lines, rules and lessons learned from your team's fixes, and per-check precision from what you fix versus dismiss, across TypeScript, JavaScript, Python, Go, Ruby and C#.",
   "engines": {
     "node": ">=22.13"
@@ -75,11 +75,11 @@
     "@anthropic-ai/sdk": "^0.132.1",
     "pg": "^8.16.3",
     "openai": "^5.23.2",
-    "@rigour-labs/brain-darwin-arm64": "6.9.0-rc.2",
-    "@rigour-labs/brain-darwin-x64": "6.9.0-rc.2",
-    "@rigour-labs/brain-linux-arm64": "6.9.0-rc.2",
-    "@rigour-labs/brain-linux-x64": "6.9.0-rc.2",
-    "@rigour-labs/brain-win-x64": "6.9.0-rc.2"
+    "@rigour-labs/brain-darwin-arm64": "6.9.0-rc.3",
+    "@rigour-labs/brain-darwin-x64": "6.9.0-rc.3",
+    "@rigour-labs/brain-linux-arm64": "6.9.0-rc.3",
+    "@rigour-labs/brain-win-x64": "6.9.0-rc.3",
+    "@rigour-labs/brain-linux-x64": "6.9.0-rc.3"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",