@rigour-labs/core 6.7.7 → 6.7.8

package/dist/review/reviewer/context.d.ts

@@ -31,6 +31,8 @@ export interface ContextInput {
     router: RouterPolicy | undefined;
     /** Which of the team's review lessons the judges see (gates.deep.review_lessons): verified by default, all, or off. */
     lessons?: LessonMode;
+    /** The pull request under review: lessons learned only from it are its own reviews, which the judge already reads. */
+    pr?: number;
     /** The previous verdict's panel decisions, and the files changed since it. */
     previousPanel: PanelItem[] | undefined;
     touched: Set<string>;

package/dist/review/reviewer/context.js

@@ -24,6 +24,9 @@ export const REVIEW_DISMISSALS = path.join('.rigour', 'dismissed-review-items.js
 const MAX_DOCS = 10;
 /** Team standards a judge is shown with the lessons about the changed files. */
 const JUDGE_STANDARDS = 15;
+/** File lessons a judge is shown: on a pull request touching a hundred files, enough for every file, at most this many per file. */
+const JUDGE_FILE_LESSONS = 30;
+const JUDGE_LESSONS_PER_FILE = 3;
 /** Rules from the repository's own rules files a judge is asked to answer, most relevant first. */
 const JUDGE_RULES = 15;
 const MAX_SETTLED = 40;
@@ -78,7 +81,7 @@ export function buildContext(input) {
         task = undefined;
     }
     // A judge reads the whole pull request: more of what the team taught fits than an agent's one question at the stop.
-    const lessons = input.lessons === 'off' ? [] : lessonsForDiff(input.cwd, input.diff, input.lessons, JUDGE_STANDARDS).map(lessonView);
+    const lessons = input.lessons === 'off' ? [] : lessonsForDiff(input.cwd, input.diff, input.lessons, JUDGE_STANDARDS, JUDGE_FILE_LESSONS, JUDGE_LESSONS_PER_FILE, input.pr).map(lessonView);
     if (lessons.length)
         sections.push(`## Lessons this team taught on earlier reviews, for what this change touches (context: a lesson never blocks on its own; a finding still needs its quote)\n${lessons.map(l => `- ${describeLesson(l)}`).join('\n')}`);
     // The repository's own rules, always: the reviewer is the boundary, and what the team wrote is the standard it checks.

package/dist/review/reviewer/verdict.js

@@ -224,7 +224,8 @@ export function account(verdict, previousOpen, verify) {
     for (const r of verdict.rules ?? []) {
         if (r.status !== 'broken' || !r.rule)
             continue;
-        const item = { id: id('repo-rule', r.file, r.id), kind: 'rule', class: 'repo-rule', file: r.file, line: r.line, issue: `breaks a rule this repository wrote for itself (${r.source}): ${r.rule}`, consequence: r.requirement ? 'the team wrote this rule as a requirement' : 'the team wrote this rule as guidance', ...(r.quote ? { quote: r.quote } : {}), evidence: r.evidence, reviewer: r.reviewer };
+        // The rule's own words are the issue, so the same point found as a finding reads alike; where it came from is the evidence.
+        const item = { id: id('repo-rule', r.file, r.id), kind: 'rule', class: 'repo-rule', file: r.file, line: r.line, issue: r.rule, consequence: r.requirement ? 'the team wrote this rule as a requirement' : 'the team wrote this rule as guidance', ...(r.quote ? { quote: r.quote } : {}), evidence: `breaks a rule this repository wrote for itself (${r.source})${r.evidence ? `: ${r.evidence}` : ''}`, reviewer: r.reviewer };
         if (r.requirement)
             add(item);
         else
@@ -274,8 +275,10 @@ export function account(verdict, previousOpen, verify) {
     }
     return { open: onePerRootCause(open), unverified, resolved, answerInReply, notes, advisory: onePerRootCause(advisory) };
 }
-/** How alike two items' words must be to be the same point made in two places. */
+/** How alike two items' words must be to be the same point made in two places; and, on the same lines, to be one point said two ways. */
 const SAME_POINT = 0.6;
+const SAME_PLACE = 0.3;
+const SAME_LINES = 3;
 /**
  * The same point found in several places is one item carrying every location, so a person reads one
  * line, not one per file. Blocking is unchanged: the item blocks until every location is fixed.
@@ -283,7 +286,9 @@ const SAME_POINT = 0.6;
 function onePerRootCause(items) {
     const kept = [];
     for (const item of items) {
-        const same = item.kind === 'prior' ? undefined : kept.find(k => k.kind !== 'prior' && k.class === item.class && textSimilarity(k, item) >= SAME_POINT);
+        // The same class in the same words anywhere, or any two non-human items on the same lines that read alike (a rule break and the finding it caused).
+        const nearby = (k) => !!k.file && k.file === item.file && k.line !== undefined && item.line !== undefined && Math.abs(k.line - item.line) <= SAME_LINES;
+        const same = item.kind === 'prior' ? undefined : kept.find(k => k.kind !== 'prior' && ((k.class === item.class && textSimilarity(k, item) >= SAME_POINT) || (nearby(k) && textSimilarity(k, item) >= SAME_PLACE)));
         if (!same) {
             kept.push(item);
             continue;

package/dist/review/reviewer.js

@@ -141,7 +141,7 @@ async function review(cwd, base, config, exec, progress, options) {
     const sincePrevious = previousIsAncestor ? new Set((await git(['diff', '--name-only', `${previous.head}..HEAD`])).split('\n').filter(Boolean)) : new Set();
     const changedFiles = [...fullDiff.matchAll(/^diff --git a\/.* b\/(.*)$/gm)].map(m => m[1]);
     const context = buildContext({
-        cwd, stateRoot, dismissals, diff: fullDiff, router: config.gates.deep?.router, lessons: config.gates.deep?.review_lessons, touched: sincePrevious, checks: options.checks ?? [],
+        cwd, stateRoot, dismissals, diff: fullDiff, router: config.gates.deep?.router, lessons: config.gates.deep?.review_lessons, ...(pr ? { pr: pr.number } : {}), touched: sincePrevious, checks: options.checks ?? [],
         previousPanel: previousIsAncestor ? store.readJson(previous.verdict)?.panel?.items : undefined,
         docs: await relatedDocs(cwd, changedFiles, exec),
     });

package/dist/review/reviewer.test.js

@@ -420,7 +420,7 @@ describe('verdicts', () => {
             return { verdict, ...account(verdict, undefined, verify) };
         };
         const broken = judged([{ id: 'r1', status: 'broken', file: 'src/job.ts', line: 2, quote: 'return 1;', evidence: 'no lock before the read' }]);
-        expect(broken.open.map(i => [i.kind, i.class, i.issue])).toEqual([['rule', 'repo-rule', 'breaks a rule this repository wrote for itself (AGENTS.md): Every job must take the lock before its first read.']]);
+        expect(broken.open.map(i => [i.kind, i.class, i.issue, i.evidence])).toEqual([['rule', 'repo-rule', 'Every job must take the lock before its first read.', 'breaks a rule this repository wrote for itself (AGENTS.md): no lock before the read']]);
         expect(judged([{ id: 'r1', status: 'broken', file: 'src/job.ts', line: 2 }])).toMatchObject({ open: [], unverified: [expect.objectContaining({ kind: 'rule' })] }); // no quote: not shown as a block
         expect(judged([{ id: 'r2', status: 'broken', file: 'src/job.ts', line: 2, quote: 'return 1;' }])).toMatchObject({ open: [], advisory: [expect.objectContaining({ class: 'repo-rule' })] }); // guidance: shown, never a block
         expect(judged([{ id: 'r1', status: 'followed' }, { id: 'r1', status: 'not-applicable' }])).toMatchObject({ open: [], notes: [], advisory: [], unverified: [] });
@@ -437,9 +437,14 @@ describe('verdicts', () => {
         const { open } = account(verdict, undefined, checkoutVerifier(repo));
         expect(open.map(i => [i.kind, i.class, i.locations ?? []])).toEqual([
             ['prior', 'prior point', []], ['prior', 'prior point', []],
-            ['finding', 'production-cost', [{ file: 'a.ts', line: 1 }]], // the same point in another file: one item, both places
-            ['finding', 'correctness', []], // a different class is a different point
+            // The same point in another file, and the same point said as another class on the next line: one item, every place.
+            ['finding', 'production-cost', [{ file: 'a.ts', line: 1 }, { file: 'src/job.ts', line: 2 }]],
         ]);
+        // A rule break and the finding it caused, on the same lines and in like words, are one item.
+        const twice = account({ ...EMPTY, prior_points: [], findings: [{ class: 'correctness', file: 'src/job.ts', line: 2, issue: 'the raw table name is inlined instead of the JOBS_TABLE constant', input: 'any run', consequence: 'a rename misses it', quote: 'return 1;' }],
+            rules: [{ id: 'r', status: 'broken', file: 'src/job.ts', line: 2, quote: 'return 1;', rule: 'Import the JOBS_TABLE constant; do not inline the raw table name again.', source: 'AGENTS.md', requirement: true }] }, undefined, checkoutVerifier(repo));
+        expect(twice.open.map(i => i.class)).toEqual(['repo-rule']);
+        expect(twice.open[0].locations).toEqual([{ file: 'src/job.ts', line: 2 }]);
     });
     it('keeps reads, scans, redundancy and merge impact as notes with stable ids, and answers non-blocking points in the reply', () => {
         const verdict = {

package/dist/review-learning/lessons.d.ts

@@ -94,6 +94,8 @@ export declare function matchLessons(lessons: ReviewLesson[], change: ChangeShap
     includeCandidates?: boolean;
     limit?: number;
     standards?: number;
+    perFile?: number;
+    excludePr?: number;
 }): ReviewLesson[];
 /** RIGOUR_REVIEW_LESSONS points at a lessons file outside the clone (CI, or a team's shared copy). */
 export declare function lessonsPath(cwd: string): string;

package/dist/review-learning/lessons.js

@@ -179,6 +179,9 @@ export function mergeLessons(existing, incoming) {
  * change; the best-evidenced few follow the file lessons.
  */
 export function matchLessons(lessons, change, options = {}) {
+    // A lesson whose only evidence is the pull request under review is already in front of the judge as the reviewer's own points.
+    if (options.excludePr !== undefined)
+        lessons = lessons.filter(l => !l.evidence.length || l.evidence.some(e => e.pr !== options.excludePr));
     const dirs = new Set(change.files.map(f => path.posix.dirname(f)));
     const scored = lessons
         .filter(l => !!l.file && (l.state === 'verified' || (options.includeCandidates && l.state === 'candidate')) && !NOT_CODE.test(l.file))
@@ -199,7 +202,20 @@ export function matchLessons(lessons, change, options = {}) {
         .sort((a, b) => b.shared - a.shared || b.lesson.evidence.length - a.lesson.evidence.length)
         .slice(0, options.standards ?? MAX_STANDARDS)
         .map(s => s.lesson);
-    return [...scored.slice(0, options.limit ?? 5).map(s => s.lesson), ...standards];
+    // On a large change, one file's many lessons must not crowd out another file's only one: a cap per file, then the total.
+    const perFile = options.perFile ?? Infinity;
+    const taken = [];
+    const perFileCount = new Map();
+    for (const { lesson } of scored) {
+        if (taken.length >= (options.limit ?? 5))
+            break;
+        const n = perFileCount.get(lesson.file) ?? 0;
+        if (n >= perFile)
+            continue;
+        perFileCount.set(lesson.file, n + 1);
+        taken.push(lesson);
+    }
+    return [...taken, ...standards];
 }
 /** RIGOUR_REVIEW_LESSONS points at a lessons file outside the clone (CI, or a team's shared copy). */
 export function lessonsPath(cwd) {

package/dist/review-learning/repo-rules.test.js

@@ -29,6 +29,9 @@ describe('repository rules', () => {
         expect(rules[1]).toMatchObject({ paths: ['src/lib/delivery.ts'], symbols: ['deliverOrder'] });
         expect(rules[0].paths).toEqual(['migrations/']);
         expect(rules.map(r => r.requirement)).toEqual([true, true, false]); // "never", "every"; "prefer" is guidance
+        // A section that only describes an exception, with no imperative, is guidance; one that ends in an imperative is a requirement.
+        const [exceptionOnly, withImperative] = splitRules('AGENTS.md', '- **One narrow exception:** the queue table is still literally named `study_jobs`, not renamed with the feature.\n\n- **One narrow exception:** the queue table is still literally named `study_jobs`. Import the `JOBS_TABLE` constant; do not inline the raw table name again.\n');
+        expect([exceptionOnly.requirement, withImperative.requirement]).toEqual([false, true]);
         expect(rules[0].id).toMatch(/^[0-9a-f]{10}$/);
         expect(splitRules('AGENTS.md', AGENTS)[0].id).toBe(rules[0].id); // stable across runs
     });

package/dist/review-learning/review-learning.test.js

@@ -95,6 +95,15 @@ describe('lessons', () => {
         const change = { files: ['src/orders.ts'], symbols: new Set(['insert', 'insertOrder', 'orderId']) };
         expect(matchLessons(lessons, change).map(l => l.id)).toEqual(['2', '1']); // two specific shared names outrank a same-file lesson with only generic ones
         expect(matchLessons(lessons, change, { includeCandidates: true }).map(l => l.id)).toEqual(['2', '1', '3']);
+        // A lesson learned only from the pull request under review is its own reviews, already in front of the judge.
+        const own = { ...base, id: '7', text: 'from this very pull request', file: 'src/orders.ts', state: 'verified', evidence: [{ pr: 42, comment: 'c', author: 'r' }] };
+        const also = { ...own, id: '8', text: 'from this and another', evidence: [{ pr: 42, comment: 'c', author: 'r' }, { pr: 3, comment: 'd', author: 'r' }] };
+        expect(matchLessons([...lessons, own, also], change, { excludePr: 42 }).map(l => l.id).sort()).toEqual(['1', '2', '8']); // '7' is left out; '8' has evidence elsewhere too
+        // One file's many lessons never crowd out another file's only one.
+        const many = Array.from({ length: 6 }, (_, i) => ({ ...base, id: `m${i}`, text: `orders lesson ${i}`, file: 'src/orders.ts', state: 'verified', symbols: ['insertOrder', 'orderId'] }));
+        const lone = { ...base, id: 'lone', text: 'the only lesson about the manifest', file: 'src/manifest.sha', state: 'verified' };
+        const served = matchLessons([...many, lone], { files: ['src/orders.ts', 'src/manifest.sha'], symbols: new Set(['insertOrder', 'orderId']) }, { limit: 4, perFile: 3 });
+        expect(served.map(l => l.id)).toEqual(['m0', 'm1', 'm2', 'lone']);
     });
 });
 describe('learning from one pull request as it goes', () => {

package/dist/review-learning/team-lessons.d.ts

@@ -4,8 +4,8 @@ export type LessonMode = 'verified' | 'all' | 'off';
 export declare const DEFAULT_LESSON_MODE: LessonMode;
 /** The team's review lessons in play for this mode: none when off, verified ones by default. */
 export declare function activeLessons(cwd: string, mode?: LessonMode): ReviewLesson[];
-/** `standards`: how many team standards may come with the file lessons (a judge reading a whole pull request takes more than an agent's one question). */
-export declare function lessonsForDiff(cwd: string, diff: string, mode?: LessonMode, standards?: number): ReviewLesson[];
+/** `standards`, `limit`, `perFile`: how many team standards and file lessons may come, and how many per file (a judge reading a whole pull request takes more than an agent's one question). */
+export declare function lessonsForDiff(cwd: string, diff: string, mode?: LessonMode, standards?: number, limit?: number, perFile?: number, excludePr?: number): ReviewLesson[];
 /** The points this team rejected that a change touches: what the judges are told is settled. */
 export declare function rejectedForDiff(cwd: string, diff: string): ReviewLesson[];
 /** A lesson as a judge or agent sees it, in one place. */

package/dist/review-learning/team-lessons.js

@@ -13,14 +13,14 @@ export function activeLessons(cwd, mode = DEFAULT_LESSON_MODE) {
         return [];
     return readLessons(cwd).filter(l => mode === 'all' || l.state === 'verified');
 }
-/** `standards`: how many team standards may come with the file lessons (a judge reading a whole pull request takes more than an agent's one question). */
-export function lessonsForDiff(cwd, diff, mode = DEFAULT_LESSON_MODE, standards) {
+/** `standards`, `limit`, `perFile`: how many team standards and file lessons may come, and how many per file (a judge reading a whole pull request takes more than an agent's one question). */
+export function lessonsForDiff(cwd, diff, mode = DEFAULT_LESSON_MODE, standards, limit, perFile, excludePr) {
     if (mode === 'off')
         return [];
     const lessons = readLessons(cwd);
     if (lessons.length === 0)
         return [];
-    return matchLessons(lessons, changeShape(diff), { includeCandidates: mode === 'all', ...(standards !== undefined ? { standards } : {}) });
+    return matchLessons(lessons, changeShape(diff), { includeCandidates: mode === 'all', ...(standards !== undefined ? { standards } : {}), ...(limit !== undefined ? { limit } : {}), ...(perFile !== undefined ? { perFile } : {}), ...(excludePr !== undefined ? { excludePr } : {}) });
 }
 /** The points this team rejected that a change touches: what the judges are told is settled. */
 export function rejectedForDiff(cwd, diff) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rigour-labs/core",
-  "version": "6.7.7",
+  "version": "6.7.8",
   "description": "Rigour's review engine: deterministic gates on changed lines, rules and lessons learned from your team's fixes, and per-check precision from what you fix versus dismiss, across TypeScript, JavaScript, Python, Go, Ruby and C#.",
   "engines": {
     "node": ">=22.13"
@@ -72,11 +72,11 @@
     "@anthropic-ai/sdk": "^0.30.1",
     "pg": "^8.16.3",
     "openai": "^5.23.2",
-    "@rigour-labs/brain-darwin-arm64": "6.7.7",
-    "@rigour-labs/brain-darwin-x64": "6.7.7",
-    "@rigour-labs/brain-linux-arm64": "6.7.7",
-    "@rigour-labs/brain-win-x64": "6.7.7",
-    "@rigour-labs/brain-linux-x64": "6.7.7"
+    "@rigour-labs/brain-darwin-arm64": "6.7.8",
+    "@rigour-labs/brain-darwin-x64": "6.7.8",
+    "@rigour-labs/brain-linux-x64": "6.7.8",
+    "@rigour-labs/brain-linux-arm64": "6.7.8",
+    "@rigour-labs/brain-win-x64": "6.7.8"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",