@rigour-labs/core 6.7.4 → 6.7.5

package/dist/review-learning/lessons.js

@@ -21,8 +21,8 @@ const MAX_TEXT = 220;
 const MAX_SYMBOLS = 8;
 /**
  * Recurrence is weak evidence, and only when independent: the same point on this many pull requests,
- * by this many different authors, raised by different reviewers or by one reviewer in different words
- * (a senior re-raising a standard counts; a bot pasting its template on every pull request does not).
+ * by this many different authors, raised by different reviewers or by one person in different words
+ * (a senior re-raising a standard counts; a bot rewording its own point on every pull request does not).
  */
 const RECUR_PRS = 2;
 const RECUR_AUTHORS = 2;
@@ -61,7 +61,8 @@ export function lessonState(lesson) {
     const prs = new Set(points.map(e => e.pr)).size;
     const authors = new Set(points.map(e => e.prAuthor).filter(Boolean)).size;
     const reviewers = new Set(points.map(e => e.author).filter(Boolean)).size;
-    const wordings = new Set(points.map(e => normalize(e.text ?? '')).filter(Boolean)).size;
+    // One person raising it again in their own words is a standard; a bot rewording its own point on every pull request is not.
+    const wordings = new Set(points.filter(e => e.source !== 'bot').map(e => normalize(e.text ?? '')).filter(Boolean)).size;
     const independent = reviewers >= 2 || wordings >= 2;
     return prs >= RECUR_PRS && authors >= RECUR_AUTHORS && independent ? { state: 'verified', promotedBy: 'recurrence' } : { state: 'candidate' };
 }
@@ -77,7 +78,15 @@ export function lessonText(body) {
         .join('\n');
     const bold = /\*\*(.+?)\*\*/.exec(cleaned)?.[1]?.trim();
     const text = bold || cleaned.replace(/\s+/g, ' ').trim().split(/(?<=[.!?])\s/)[0] || '';
-    return text.replace(/[*_]/g, '').slice(0, MAX_TEXT).trim();
+    return pointText(text.replace(/[*_]/g, '')).slice(0, MAX_TEXT).trim();
+}
+/**
+ * A point's words without a review bot's scaffolding (`In src/a.ts around lines 10-12:`), or '' when
+ * nothing but a path or a location is left: a file name alone teaches nothing.
+ */
+function pointText(text) {
+    const bare = text.trim().replace(/^(in\s+\S+\s+)?around\s+lines?\s+[\d\s,–-]+:\s*/i, '').trim();
+    return /^[`'"]?[\w@.~/[\]()+-]+[`'"]?:?$/.test(bare) ? '' : bare;
 }
 /** Identifiers a lesson is about: those the comment names, then those on the lines it pointed at. */
 export function lessonSymbols(body, codeLines) {
@@ -118,7 +127,7 @@ export function lessonFromComment(git, comment, at = new Date().toISOString()) {
  */
 export function lessonsFromReview(review, changedAfter, at = new Date().toISOString()) {
     return bodyPoints(review.body).flatMap((point, i) => {
-        const text = point.replace(/[*_]/g, '').slice(0, MAX_TEXT).trim();
+        const text = pointText(point.replace(/[*_]/g, '')).slice(0, MAX_TEXT).trim();
         if (text.length < 12)
             return [];
         const named = /(?:^|[\s`(])((?:[\w.-]+\/)+[\w.-]+\.\w+)/.exec(point)?.[1];

package/dist/review-learning/review-learning.test.js

@@ -8,7 +8,7 @@ import { learnFromReviews } from './learn-from-reviews.js';
 import { outcomeFor } from './outcomes.js';
 import { rulesFromReviews } from './rules-from-reviews.js';
 import { describeLesson, lessonView } from './team-lessons.js';
-import { decideLesson, isSpecific, lessonState, lessonText, matchLessons, mergeLessons, readLessons, writeLessons } from './lessons.js';
+import { decideLesson, isSpecific, lessonState, lessonText, lessonsFromReview, matchLessons, mergeLessons, readLessons, writeLessons } from './lessons.js';
 import { lessonsForDiff, lessonsSection } from './team-lessons.js';
 let repo;
 const git = (...args) => execFileSync('git', ['-C', repo, ...args], { encoding: 'utf8' }).trim();
@@ -40,6 +40,14 @@ describe('acted on', () => {
     });
 });
 describe('lessons', () => {
+    it('never makes a lesson of a bare path or a review bot\'s line-range scaffolding', () => {
+        expect(lessonText('src/routes/learner/+layout.ts')).toBe('');
+        expect(lessonText('`src/routes/learner/api/[planId]/+server.ts`')).toBe('');
+        expect(lessonText('In src/a.ts around lines 10-12: Check the lock before the first read.')).toBe('Check the lock before the first read.');
+        expect(lessonText('Around line 124-141: Add a test for the failed save.')).toBe('Add a test for the failed save.');
+        expect(lessonsFromReview({ id: '1', prNumber: 3, commit: 'c', author: 'rabbit[bot]', source: 'bot', body: '- `src/a/b.ts`\n- Bound both ends of the time window.' }, ['src/a/b.ts']).map(l => l.text))
+            .toEqual(['Bound both ends of the time window.']);
+    });
     it('keeps the point of a review comment and drops tool output and markup', () => {
         const body = '_⚠️ Potential issue_ | _🟠 Major_\n\n**Use an upsert keyed on `id`.**\n\n<details>\n<summary>🏁 Script executed</summary>\nrg -n insert\n</details>';
         expect(lessonText(body)).toBe('Use an upsert keyed on `id`.');
@@ -53,6 +61,7 @@ describe('lessons', () => {
         expect(lessonState(lesson(point(1, 'ann'), point(2, 'ann')))).toEqual({ state: 'candidate' }); // two PRs, one author: weak, not enough
         expect(lessonState(lesson(point(1, 'ann'), point(2, 'bob', 'bot')))).toEqual({ state: 'verified', promotedBy: 'recurrence' }); // a bot's point counts the same
         const said = (e, text) => ({ ...e, text });
+        expect(lessonState(lesson(said(point(1, 'ann', 'bot', 'helper[bot]'), 'Around line 60-103: update the callers.'), said(point(2, 'bob', 'bot', 'helper[bot]'), 'Around line 12-14: update the loader.')))).toEqual({ state: 'candidate' }); // a bot rewording its own point is one source
         expect(lessonState(lesson(said(point(1, 'ann', 'bot', 'helper[bot]'), 'Consider more tests.'), said(point(2, 'bob', 'bot', 'helper[bot]'), 'Consider more tests.')))).toEqual({ state: 'candidate' }); // one bot's template on every PR is one source
         expect(lessonState(lesson(said(point(1, 'ann', 'person', 'lead'), 'Regenerate the API client after changing the schema.'), said(point(2, 'bob', 'person', 'lead'), 'The generated client is stale again.')))).toEqual({ state: 'verified', promotedBy: 'recurrence' }); // a senior re-raising it in their own words
         expect(lessonState(lesson(point(1, 'ann'), point(2, 'bob'), { kind: 'norule', pr: 1, comment: 'n', author: '' }))).toEqual({ state: 'candidate' }); // no rule in it: never promoted again

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rigour-labs/core",
-  "version": "6.7.4",
+  "version": "6.7.5",
   "description": "Rigour's review engine: deterministic gates on changed lines, rules and lessons learned from your team's fixes, and per-check precision from what you fix versus dismiss, across TypeScript, JavaScript, Python, Go, Ruby and C#.",
   "engines": {
     "node": ">=22.13"
@@ -72,11 +72,11 @@
     "@anthropic-ai/sdk": "^0.30.1",
     "pg": "^8.16.3",
     "openai": "^5.23.2",
-    "@rigour-labs/brain-darwin-arm64": "6.7.4",
-    "@rigour-labs/brain-win-x64": "6.7.4",
-    "@rigour-labs/brain-linux-arm64": "6.7.4",
-    "@rigour-labs/brain-linux-x64": "6.7.4",
-    "@rigour-labs/brain-darwin-x64": "6.7.4"
+    "@rigour-labs/brain-darwin-x64": "6.7.5",
+    "@rigour-labs/brain-linux-arm64": "6.7.5",
+    "@rigour-labs/brain-win-x64": "6.7.5",
+    "@rigour-labs/brain-darwin-arm64": "6.7.5",
+    "@rigour-labs/brain-linux-x64": "6.7.5"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",