@rigour-labs/core 6.12.2 → 6.12.3-rc.1

package/dist/review/changed-lines.d.ts

@@ -8,7 +8,8 @@
  * - contextFindings: deep findings elsewhere in a changed file; returned so
  *   nothing the model found disappears, never blocking.
  * - unlocated: no file at all; counted, never shown as a changed-line finding.
- * - outside: any other finding on an unchanged line; counted.
+ * - outside: any other finding on an unchanged line; counted, and kept in
+ *   outsideFindings so a check whose findings are all here can say so.
  *
  * The CLI, the MCP tool and the GitHub integration all use this, so the same
  * change gets the same verdict everywhere.
@@ -22,5 +23,6 @@ export interface ChangedLineSplit {
     contextFindings: Failure[];
     unlocated: number;
     outside: number;
+    outsideFindings: Failure[];
 }
 export declare function splitByChangedLines(failures: Failure[], changedLines: Record<string, Set<number>>, spans?: Record<string, LineSpan[]>, removed?: Record<string, RemovedBlock[]>): ChangedLineSplit;

package/dist/review/changed-lines.js

@@ -1,6 +1,6 @@
 import { anchorInChangedFunction } from './changed-function-spans.js';
 export function splitByChangedLines(failures, changedLines, spans = {}, removed = {}) {
-    const split = { findings: [], fileFindings: [], contextFindings: [], unlocated: 0, outside: 0 };
+    const split = { findings: [], fileFindings: [], contextFindings: [], unlocated: 0, outside: 0, outsideFindings: [] };
     for (const failure of failures) {
         const files = failure.files ?? [];
         if (files.length === 0) {
@@ -10,7 +10,7 @@ export function splitByChangedLines(failures, changedLines, spans = {}, removed
             if (files.some(file => changedLines[file]))
                 split.fileFindings.push(failure);
             else
-                split.outside++;
+                leftOutside(split, failure);
         }
         else if (files.some(file => changedLines[file]?.has(failure.line) || removedInside(failure, removed[file]))) {
             split.findings.push(failure);
@@ -19,11 +19,15 @@ export function splitByChangedLines(failures, changedLines, spans = {}, removed
             placeDeepFinding(failure, files, changedLines, spans, split);
         }
         else {
-            split.outside++;
+            leftOutside(split, failure);
         }
     }
     return split;
 }
+function leftOutside(split, failure) {
+    split.outside++;
+    split.outsideFindings.push(failure);
+}
 function placeDeepFinding(failure, files, changedLines, spans, split) {
     for (const file of files) {
         const anchorLine = anchorInChangedFunction(failure.line, changedLines[file], spans[file]);

package/dist/review/review.d.ts

@@ -40,6 +40,8 @@ export interface ReviewResult {
     preexisting: number;
     /** The same, by check. A check whose findings were all the base's reads PASS in the report's summary. */
     preexistingByCheck: Record<string, number>;
+    /** By check, findings only on lines the change did not touch. A check whose findings were all such reads PASS in the report's summary. */
+    outsideChangeByCheck: Record<string, number>;
     /** A diff given with no base whose change HEAD already holds (committed work): nothing was compared, so nothing was dropped as the base's. */
     baseUnknown?: boolean;
     changedLines: Record<string, Set<number>>;

package/dist/review/review.js

@@ -39,7 +39,7 @@ export async function reviewChange(input) {
     const changedLines = withoutGenerated(input.cwd, parseDiff(diff));
     const targets = input.files?.length ? input.files : Object.keys(changedLines);
     if (targets.length === 0) {
-        return { status: 'PASS', findings: [], fileFindings: [], contextFindings: [], advisory: [], muted: 0, dismissed: 0, dismissedByGate: {}, unlocated: 0, excludedOutsideChangedLines: 0, preexisting: 0, preexistingByCheck: {}, changedLines, report: null, gateErrors: [], controlFilesChanged: controlFiles(diff), hints: [], covered: [] };
+        return { status: 'PASS', findings: [], fileFindings: [], contextFindings: [], advisory: [], muted: 0, dismissed: 0, dismissedByGate: {}, unlocated: 0, excludedOutsideChangedLines: 0, preexisting: 0, preexistingByCheck: {}, outsideChangeByCheck: {}, changedLines, report: null, gateErrors: [], controlFilesChanged: controlFiles(diff), hints: [], covered: [] };
     }
     // The team's compiled checks run before the deep review, so it is told what they found and which lessons they covered.
     const compiled = compiledChecksOn(input.cwd, changedLines, input.config);
@@ -73,6 +73,8 @@ export async function reviewChange(input) {
     else if (input.typed)
         reviewCheck('redundancy', 'redundancy', typed.failures);
     const split = splitByChangedLines(report.failures, changedLines, deep ? changedFunctionSpans(input.cwd, changedLines) : {}, removedByFile(diff));
+    const outside = new Set(split.outsideFindings);
+    const outsideChangeByCheck = passChecksOnlyLeftOut(report, split.outsideFindings, report.failures.filter(f => !outside.has(f)));
     const deepError = deepAnalysisError(report);
     // The goal's findings are about the change as a whole (a file it should not touch, an item it never did), not a line, so they skip the changed-line split.
     const goal = input.goalDescription !== undefined ? parseGoal(input.goalDescription, fileNames(input.cwd, diff)) : undefined;
@@ -97,6 +99,7 @@ export async function reviewChange(input) {
         excludedOutsideChangedLines: split.outside,
         preexisting,
         preexistingByCheck,
+        outsideChangeByCheck,
         ...(baseUnknown ? { baseUnknown } : {}),
         changedLines,
         report,
@@ -110,15 +113,16 @@ export async function reviewChange(input) {
     };
 }
 /**
- * A check that failed only on what the base already had passes for this change: its summary reads PASS, and the
- * count, by check, says what it left out. A check with a finding the change introduced keeps FAIL.
+ * A check whose findings were all left out of this change's verdict (what the base already had, or lines the change
+ * did not touch) passes for it: its summary reads PASS, and the count, by check, says what it left out. A check with
+ * any finding still in play keeps FAIL.
  */
-function passOnlyPreexisting(report, preexisting) {
+function passChecksOnlyLeftOut(report, leftOut, kept) {
     const byCheck = {};
     const check = (f) => gateOf(f) ?? f.id;
-    for (const f of preexisting)
+    for (const f of leftOut)
         byCheck[check(f)] = (byCheck[check(f)] ?? 0) + 1;
-    const remaining = new Set(report.failures.map(check));
+    const remaining = new Set(kept.map(check));
     for (const id of Object.keys(byCheck))
         if (report.summary[id] === 'FAIL' && !remaining.has(id))
             report.summary[id] = 'PASS';
@@ -143,7 +147,7 @@ async function dropPreexisting(input, report, targets) {
         const { preexisting } = splitIntroduced(rules, await baseFindings(input.cwd, input.config, commit, targets));
         const old = new Set(preexisting);
         report.failures = report.failures.filter(f => !old.has(f));
-        return { preexisting: old.size, byCheck: passOnlyPreexisting(report, preexisting) };
+        return { preexisting: old.size, byCheck: passChecksOnlyLeftOut(report, preexisting, report.failures) };
     }
     catch {
         return { preexisting: 0 }; // the comparison is a courtesy; it never fails a review

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rigour-labs/core",
-  "version": "6.12.2",
+  "version": "6.12.3-rc.1",
   "description": "Rigour's review engine: deterministic gates on changed lines, rules and lessons learned from your team's fixes, and per-check precision from what you fix versus dismiss, across TypeScript, JavaScript, Python, Go, Ruby and C#.",
   "engines": {
     "node": ">=22.13"
@@ -75,11 +75,11 @@
     "@anthropic-ai/sdk": "^0.132.1",
     "pg": "^8.16.3",
     "openai": "^5.23.2",
-    "@rigour-labs/brain-darwin-arm64": "6.12.2",
-    "@rigour-labs/brain-linux-arm64": "6.12.2",
-    "@rigour-labs/brain-darwin-x64": "6.12.2",
-    "@rigour-labs/brain-win-x64": "6.12.2",
-    "@rigour-labs/brain-linux-x64": "6.12.2"
+    "@rigour-labs/brain-darwin-arm64": "6.12.3-rc.1",
+    "@rigour-labs/brain-darwin-x64": "6.12.3-rc.1",
+    "@rigour-labs/brain-linux-x64": "6.12.3-rc.1",
+    "@rigour-labs/brain-win-x64": "6.12.3-rc.1",
+    "@rigour-labs/brain-linux-arm64": "6.12.3-rc.1"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",