@rigour-labs/core 6.12.1 → 6.12.2-rc.2

package/dist/index.d.ts

@@ -49,7 +49,7 @@ export { decideCompiledCheck, proposeCompiledChecks, readCompiledChecks, suspens
 export { ruleWriterFor } from './review/reviewer/rule-writer.js';
 export { backtestLast, formatLast, scoreLast, LAST_LEDGER_PATH, type LastReport } from './review/backtest-last.js';
 export { buildRecord, recordLines, recordIntact, type ReviewRecord } from './review/reviewer/record.js';
-export { readLessons, writeLessons, decideLesson, acceptSuggestedText, scopeLesson, lessonState, pendingDecision, matchLessons, lessonText, lessonsPath, type ReviewLesson, type LessonEvidence } from './review-learning/lessons.js';
+export { readLessons, writeLessons, decideLesson, acceptSuggestedText, scopeLesson, lessonState, pendingDecision, quietBotCandidate, matchLessons, lessonText, lessonsPath, type ReviewLesson, type LessonEvidence } from './review-learning/lessons.js';
 export { lessonsForDiff, lessonsSection, type LessonMode } from './review-learning/team-lessons.js';
 export { recordAgentWrites, captureHumanEdits } from './review-learning/human-edits.js';
 export { readRepoRules, rulesForDiff, rulesSection, splitRules, type RepoRule } from './review-learning/repo-rules.js';

package/dist/index.js

@@ -47,7 +47,7 @@ export { decideCompiledCheck, proposeCompiledChecks, readCompiledChecks, suspens
 export { ruleWriterFor } from './review/reviewer/rule-writer.js';
 export { backtestLast, formatLast, scoreLast, LAST_LEDGER_PATH } from './review/backtest-last.js';
 export { buildRecord, recordLines, recordIntact } from './review/reviewer/record.js';
-export { readLessons, writeLessons, decideLesson, acceptSuggestedText, scopeLesson, lessonState, pendingDecision, matchLessons, lessonText, lessonsPath } from './review-learning/lessons.js';
+export { readLessons, writeLessons, decideLesson, acceptSuggestedText, scopeLesson, lessonState, pendingDecision, quietBotCandidate, matchLessons, lessonText, lessonsPath } from './review-learning/lessons.js';
 export { lessonsForDiff, lessonsSection } from './review-learning/team-lessons.js';
 export { recordAgentWrites, captureHumanEdits } from './review-learning/human-edits.js';
 export { readRepoRules, rulesForDiff, rulesSection, splitRules } from './review-learning/repo-rules.js';

package/dist/review-learning/lessons.d.ts

@@ -77,6 +77,8 @@ export interface ReviewLesson {
  * evidence, never a promotion. A record from before evidence kinds keeps the state it had.
  */
 export declare function lessonState(lesson: ReviewLesson): Pick<ReviewLesson, 'state' | 'promotedBy'>;
+/** Every point on the lesson came from a review bot: it is recorded, but never verified or served until a person decides. */
+export declare function raisedOnlyByBots(lesson: ReviewLesson): boolean;
 /**
  * The point of a review comment: its bold title, else its first sentence and, when that only says what is
  * wrong, the first later sentence that says what to do. Without tool output or markup.
@@ -135,6 +137,11 @@ export declare function readLessons(cwd: string): ReviewLesson[];
  * (`lines`); undefined when nothing waits on a person. Studio and the outcome numbers read it, so they never disagree.
  */
 export declare function pendingDecision(lesson: ReviewLesson): LessonEvidence | undefined;
+/**
+ * A candidate only review bots raised, with nothing waiting on a person: hidden from the default lists (`--list`,
+ * Studio) and counted instead. One taken back or reclassified stays in view, so its reason is seen.
+ */
+export declare function quietBotCandidate(lesson: ReviewLesson): boolean;
 export declare function writeLessons(cwd: string, lessons: ReviewLesson[]): void;
 /** A person's decision on a lesson, kept as evidence: accepted makes it a lesson, rejected an anti-lesson. Undefined for an unknown id. */
 export declare function decideLesson(cwd: string, id: string, decision: 'accepted' | 'rejected' | 'dismissed', by: string, why?: string): ReviewLesson | undefined;

package/dist/review-learning/lessons.js

@@ -62,6 +62,9 @@ export function lessonState(lesson) {
     // real history, it was most often unrelated work. It is shown in Studio for a person to promote.
     if (kinds.has('counter'))
         return { state: 'candidate' };
+    // A lesson is never verified without a person: review bots agreeing with each other are not a team's standard.
+    if (raisedOnlyByBots(lesson))
+        return { state: 'candidate' };
     const points = lesson.evidence.filter(e => (e.kind ?? 'point') === 'point');
     const prs = new Set(points.map(e => e.pr)).size;
     const authors = new Set(points.map(e => e.prAuthor).filter(Boolean)).size;
@@ -71,6 +74,11 @@ export function lessonState(lesson) {
     const independent = reviewers >= 2 || wordings >= 2;
     return prs >= RECUR_PRS && authors >= RECUR_AUTHORS && independent ? { state: 'verified', promotedBy: 'recurrence' } : { state: 'candidate' };
 }
+/** Every point on the lesson came from a review bot: it is recorded, but never verified or served until a person decides. */
+export function raisedOnlyByBots(lesson) {
+    const points = lesson.evidence.filter(e => (e.kind ?? 'point') === 'point');
+    return points.length > 0 && points.every(e => e.source === 'bot');
+}
 /** A sentence that tells the author what to do, not only what is wrong. */
 const INSTRUCTION = /^(?:please\s+)?(?:use|pick|avoid|don'?t|do not|never|always|make|keep|move|read|filter|check|change|drop|add|remove|pass|split|prefer|replace|rename|derive|select|return|validate|extract|bound|lock)\b|\b(?:should|must|instead)\b/i;
 /**
@@ -235,7 +243,7 @@ export function matchLessons(lessons, change, options = {}) {
     // A lesson whose only evidence is the pull request under review is already in front of the judge as the reviewer's own points.
     if (options.excludePr !== undefined)
         lessons = lessons.filter(l => !l.evidence.length || l.evidence.some(e => e.pr !== options.excludePr));
-    const inPlay = (l) => l.state === 'verified' || (!!options.includeCandidates && l.state === 'candidate');
+    const inPlay = (l) => l.state === 'verified' || (!!options.includeCandidates && l.state === 'candidate' && !raisedOnlyByBots(l));
     // A person made these the repository's standards: every change gets them, whatever its files or words; most-raised first.
     const repo = lessons
         .filter(l => l.scope === 'repo' && inPlay(l))
@@ -327,22 +335,33 @@ export function pendingDecision(lesson) {
     const last = lesson.evidence.filter(e => e.kind === 'demoted' || e.kind === 'lines' || e.kind === 'reclassified' || e.kind === 'accepted' || e.kind === 'rejected' || e.kind === 'dismissed').at(-1);
     return last?.kind === 'demoted' || last?.kind === 'lines' || last?.kind === 'reclassified' ? last : undefined;
 }
+/**
+ * A candidate only review bots raised, with nothing waiting on a person: hidden from the default lists (`--list`,
+ * Studio) and counted instead. One taken back or reclassified stays in view, so its reason is seen.
+ */
+export function quietBotCandidate(lesson) {
+    return lesson.state === 'candidate' && raisedOnlyByBots(lesson) && !pendingDecision(lesson);
+}
 /** Why a lesson an outcome alone had promoted is a candidate again. */
 const RECLASSIFIED = 'promoted by the exact-line rule, which no longer promotes on its own';
+/** Why a lesson recurrence had promoted on review bots' points alone is a candidate again. */
+const BOTS_ONLY = 'only review bots raised it (no person)';
 /**
- * A lesson stored as verified by an outcome (a later fix on its lines, or a revert), as every reader sees it now that
- * outcomes no longer promote: its state worked out again from its evidence, and, when that leaves it a candidate, one
- * `reclassified` record saying why. Never deleted, nothing else changed; the next write keeps it, and a lesson that
- * already has the record is left as it is. Recurrence, a correction or a person's decision keeps a lesson verified.
+ * A lesson stored as verified by a rule that no longer promotes on its own, as every reader sees it now: an outcome
+ * (a later fix on its lines, or a revert), or recurrence on review bots' points alone. Its state is worked out again
+ * from its evidence, and, when that leaves it a candidate, one `reclassified` record says why. Never deleted, nothing
+ * else changed; the next write keeps it, and a lesson that already has the record is left as it is. Recurrence with a
+ * person's point, a correction or a person's decision keeps a lesson verified.
  */
 function reclassified(lesson) {
-    if (lesson.state !== 'verified' || lesson.promotedBy !== 'outcome' || lesson.evidence.some(e => e.kind === 'reclassified'))
+    const byBots = lesson.promotedBy === 'recurrence' && raisedOnlyByBots(lesson);
+    if (lesson.state !== 'verified' || !(lesson.promotedBy === 'outcome' || byBots) || lesson.evidence.some(e => e.kind === 'reclassified'))
         return lesson;
     const next = lessonState(lesson);
     if (next.state === 'verified')
         return { ...lesson, ...next };
     const at = new Date().toISOString();
-    return { ...lesson, state: 'candidate', promotedBy: undefined, evidence: [...lesson.evidence, { kind: 'reclassified', pr: lesson.evidence[0]?.pr ?? 0, comment: `reclassified-${lesson.id}`, author: '', detail: RECLASSIFIED, at }] };
+    return { ...lesson, state: 'candidate', promotedBy: undefined, evidence: [...lesson.evidence, { kind: 'reclassified', pr: lesson.evidence[0]?.pr ?? 0, comment: `reclassified-${lesson.id}`, author: '', detail: byBots ? BOTS_ONLY : RECLASSIFIED, at }] };
 }
 export function writeLessons(cwd, lessons) {
     const file = lessonsPath(cwd);

package/dist/review-learning/team-lessons.js

@@ -5,14 +5,14 @@
  */
 import path from 'path';
 import { parseDiff } from '../utils/diff.js';
-import { matchLessons, readLessons } from './lessons.js';
+import { matchLessons, raisedOnlyByBots, readLessons } from './lessons.js';
 /** Lessons a person or repeated evidence verified reach the reviewer unless a team turns them off. */
 export const DEFAULT_LESSON_MODE = 'verified';
 /** The team's review lessons in play for this mode: none when off, verified ones by default. */
 export function activeLessons(cwd, mode = DEFAULT_LESSON_MODE) {
     if (mode === 'off')
         return [];
-    return readLessons(cwd).filter(l => mode === 'all' || l.state === 'verified');
+    return readLessons(cwd).filter(l => mode === 'all' ? !(l.state === 'candidate' && raisedOnlyByBots(l)) : l.state === 'verified');
 }
 /** `standards`, `limit`, `perFile`: how many team standards and file lessons may come, and how many per file (a judge reading a whole pull request takes more than an agent's one question). */
 export function lessonsForDiff(cwd, diff, mode = DEFAULT_LESSON_MODE, standards, limit, perFile, excludePr) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rigour-labs/core",
-  "version": "6.12.1",
+  "version": "6.12.2-rc.2",
   "description": "Rigour's review engine: deterministic gates on changed lines, rules and lessons learned from your team's fixes, and per-check precision from what you fix versus dismiss, across TypeScript, JavaScript, Python, Go, Ruby and C#.",
   "engines": {
     "node": ">=22.13"
@@ -75,11 +75,11 @@
     "@anthropic-ai/sdk": "^0.132.1",
     "pg": "^8.16.3",
     "openai": "^5.23.2",
-    "@rigour-labs/brain-darwin-x64": "6.12.1",
-    "@rigour-labs/brain-linux-x64": "6.12.1",
-    "@rigour-labs/brain-linux-arm64": "6.12.1",
-    "@rigour-labs/brain-darwin-arm64": "6.12.1",
-    "@rigour-labs/brain-win-x64": "6.12.1"
+    "@rigour-labs/brain-darwin-arm64": "6.12.2-rc.2",
+    "@rigour-labs/brain-darwin-x64": "6.12.2-rc.2",
+    "@rigour-labs/brain-linux-arm64": "6.12.2-rc.2",
+    "@rigour-labs/brain-win-x64": "6.12.2-rc.2",
+    "@rigour-labs/brain-linux-x64": "6.12.2-rc.2"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",