@rigour-labs/cli 6.12.3-rc.1 → 6.12.3-rc.3

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -10,7 +10,7 @@
10
10
  import chalk from 'chalk';
11
11
  import fs from 'fs';
12
12
  import path from 'path';
13
- import { findingKey } from '@rigour-labs/core';
13
+ import { findingKey, gateOf } from '@rigour-labs/core';
14
14
  import { enabledHere } from './personal.js';
15
15
  import { printReceipt } from './review-receipt.js';
16
16
  const SHOWN = 5;
@@ -51,14 +51,23 @@ function printFindings(result, all) {
51
51
  console.log(chalk.dim(`\n …and ${count - SHOWN} more: rigour review --all`));
52
52
  console.log(chalk.dim('\n Wrong? Dismiss it once and it never comes back.\n'));
53
53
  }
54
- /** The left-out findings by check, most first (`: ast-analysis 12, file-size 1`), as `checked.preexisting` and `checked.outsideChange` give them in JSON. */
55
- function leftOutByCheck(result) {
54
+ /** Findings left out of the verdict, by check, most first (`: ast-analysis 12, file-size 1`), as `checked.preexisting` or `checked.outsideChange` gives them in JSON. */
55
+ function leftOutByCheck(counts) {
56
+ const parts = countsByCheck(new Map(Object.entries(counts ?? {})));
57
+ return parts ? `: ${parts}` : '';
58
+ }
59
+ /** `ast-analysis 12, file-size 3`: most first, then by name. */
60
+ function countsByCheck(byCheck) {
61
+ return [...byCheck].sort((a, b) => b[1] - a[1] || a[0].localeCompare(b[0])).map(([check, n]) => `${check} ${n}`).join(', ');
62
+ }
63
+ /** Findings about a changed file as a whole (no line), by the check that gave them: they fail their check without a row of their own. */
64
+ function fileFindingsByCheck(result) {
56
65
  const byCheck = new Map();
57
- for (const counts of [result.preexistingByCheck, result.outsideChangeByCheck])
58
- for (const [check, n] of Object.entries(counts ?? {}))
59
- byCheck.set(check, (byCheck.get(check) ?? 0) + n);
60
- const parts = [...byCheck].sort((a, b) => b[1] - a[1] || a[0].localeCompare(b[0])).map(([check, n]) => `${check} ${n}`);
61
- return parts.length ? `: ${parts.join(', ')}` : '';
66
+ for (const f of result.fileFindings) {
67
+ const check = gateOf(f) ?? f.id;
68
+ byCheck.set(check, (byCheck.get(check) ?? 0) + 1);
69
+ }
70
+ return countsByCheck(byCheck);
62
71
  }
63
72
  /** One line each, in plain words, for what was seen and never blocks. */
64
73
  function printQuietLines(result, notes) {
@@ -66,9 +75,16 @@ function printQuietLines(result, notes) {
66
75
  const seen = result.advisory.length + result.fileFindings.length;
67
76
  if (seen)
68
77
  lines.push(`Also seen, never blocking: ${seen} note${seen === 1 ? '' : 's'}${notes ? '' : ' (rigour review --notes)'}`);
69
- const before = result.preexisting + result.excludedOutsideChangedLines;
78
+ const wholeFile = fileFindingsByCheck(result);
79
+ if (wholeFile)
80
+ lines.push(`About a changed file as a whole: ${wholeFile}${notes ? ' (listed below)' : ', shown with --notes'}.`);
81
+ // Two kinds, each with its own pointer: show_preexisting lists only the first.
82
+ const before = result.preexisting;
70
83
  if (before)
71
- lines.push(`Not shown: ${before} issue${before === 1 ? '' : 's'} the code already had before this change${leftOutByCheck(result)} (review.show_preexisting: true lists them).`);
84
+ lines.push(`Not shown: ${before} issue${before === 1 ? '' : 's'} the code already had before this change${leftOutByCheck(result.preexistingByCheck)} (review.show_preexisting: true lists them).`);
85
+ const outside = result.excludedOutsideChangedLines;
86
+ if (outside)
87
+ lines.push(`Not shown: ${outside} issue${outside === 1 ? '' : 's'} on lines this change did not touch${leftOutByCheck(result.outsideChangeByCheck)}.`);
72
88
  if (result.baseUnknown)
73
89
  lines.push('Compared with no base: HEAD already holds this diff, so findings on its lines were not checked against the code before it. Pass --base to compare.');
74
90
  if (result.hints.length)
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@rigour-labs/cli",
3
- "version": "6.12.3-rc.1",
3
+ "version": "6.12.3-rc.3",
4
4
  "description": "Code review that happens while your agent writes: deterministic checks on the lines it changed, quiet unless it can prove a defect, and learning from your team's fixes and dismissals. Works with Claude Code, Cursor, Codex, Cline and Windsurf.",
5
5
  "engines": {
6
6
  "node": ">=22.13"
@@ -59,13 +59,13 @@
59
59
  "inquirer": "9.2.16",
60
60
  "ora": "^8.0.1",
61
61
  "yaml": "^2.8.2",
62
- "@rigour-labs/core": "6.12.3-rc.1"
62
+ "@rigour-labs/core": "6.12.3-rc.3"
63
63
  },
64
64
  "devDependencies": {
65
65
  "@types/fs-extra": "^11.0.4",
66
66
  "@types/inquirer": "9.0.7",
67
67
  "@types/node": "^25.0.3",
68
- "@rigour-labs/studio": "6.12.3-rc.1"
68
+ "@rigour-labs/studio": "6.12.3-rc.3"
69
69
  },
70
70
  "scripts": {
71
71
  "build": "tsc && pnpm bundle-studio",