@rigkit/engine 0.2.4 → 0.2.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rigkit/engine",
-  "version": "0.2.4",
+  "version": "0.2.5",
   "type": "module",
   "repository": {
     "type": "git",

package/src/engine.test.ts

@@ -274,6 +274,37 @@ describe("DevMachineEngine workflow runtime", () => {
     expect(status).toEqual({ workspace: "created", vmId: "vm-2" });
   });
 
+  test("rejects workspace names that are not shell-safe", async () => {
+    const projectDir = mkdtempSync(join(tmpdir(), "rigkit-"));
+    writeFileSync(
+      join(projectDir, "rig.config.ts"),
+      `
+        import { defineConfig, sequence } from "${import.meta.dir}/index.ts";
+
+        const root = sequence("workspace-names")
+          .step("ready", async () => ({ ctx: { ready: true } }))
+          .workspace({
+            create: async ({ workspace }) => ({ name: workspace.name }),
+            remove: async () => {},
+          });
+
+        export default defineConfig({
+          providers: {},
+          workflows: { root },
+        });
+      `,
+    );
+
+    const engine = await createDevMachineEngine({ projectDir });
+    await engine.load();
+
+    await expect(engine.fork({ name: "" })).rejects.toThrow("create requires a workspace name");
+    for (const name of ["some workspace", "some/workspace", "-workspace"]) {
+      await expect(engine.fork({ name })).rejects.toThrow("Workspace name");
+    }
+    expect(engine.listWorkspaces()).toEqual([]);
+  });
+
   test("loads multiple workflows from defineConfig", async () => {
     const projectDir = mkdtempSync(join(tmpdir(), "rigkit-"));
     writeFileSync(

package/src/engine.ts

@@ -727,7 +727,7 @@ export class DevMachineEngine {
   }
 
   async createWorkspace(input: { workflow?: string; machine?: string; name: string }): Promise<WorkspaceRecord> {
-    if (!input.name) throw new Error(`create requires a workspace name`);
+    assertValidWorkspaceName(input.name);
     if (this.getStateService().getWorkspace(input.name)) {
       throw new Error(`Workspace ${input.name} already exists`);
     }
@@ -1544,6 +1544,17 @@ function parseWorkspaceOperationId(value: string): { workspace: string; operatio
   };
 }
 
+const workspaceNamePattern = /^(?!-)[A-Za-z0-9._-]+$/;
+
+function assertValidWorkspaceName(value: string): void {
+  if (!value) throw new Error(`create requires a workspace name`);
+  if (!workspaceNamePattern.test(value)) {
+    throw new Error(
+      `Workspace name "${value}" is invalid. Use only letters, numbers, ".", "_", and "-", and do not start with "-".`,
+    );
+  }
+}
+
 async function resolveProviderDefinition(
   definition: WorkflowDefinition<any, any>["providers"][string],
 ): Promise<LoadedProviderDefinition> {

package/src/version.ts

@@ -1 +1 @@
-export const RIGKIT_ENGINE_VERSION = "0.2.4";
+export const RIGKIT_ENGINE_VERSION = "0.2.5";