@rightkit/release 0.2.28 → 0.2.29

package/legal-contract.mjs

@@ -135,24 +135,26 @@ export function assertLegalReleaseContract(root, legal, appName, platform) {
     appendices.push({ ...appendix, absolutePath: realFile });
   }
 
-  if (platform === "win") {
-    if (typeof legal.tauriConfig !== "string") fail(appName, "Windows legal gate requires legal.tauriConfig");
-    const tauriPath = path.resolve(appRoot, legal.tauriConfig);
-    if (!within(appRoot, tauriPath) || !existsSync(tauriPath)) fail(appName, `missing Tauri config: ${legal.tauriConfig}`);
-    const tauri = readJson(tauriPath, appName, "Tauri config");
-    // The in-app gate is the SINGLE assent surface (Adrian, 2026-07-17). An
-    // installer/DMG can only PRESENT the text: it cannot record who agreed, cannot
-    // ask the individual-vs-enterprise basis, and passive updaters reach neither —
-    // so a license page is duplicate presentation that captures nothing. This gate
-    // previously REQUIRED bundle.licenseFile; it now requires its absence.
-    const configured = tauri.bundle?.licenseFile;
-    if (typeof configured === "string" && configured.trim()) {
-      fail(
-        appName,
-        "Windows Tauri bundle.licenseFile must be absent: the in-app legal gate is the only assent surface, " +
-          "and an installer license page duplicates it without recording acceptance",
-      );
-    }
+  // The in-app gate is the SINGLE assent surface (Adrian, 2026-07-17). An
+  // installer/DMG can only PRESENT the text: it cannot record who agreed, cannot ask
+  // the individual-vs-enterprise basis, and passive updaters reach neither — so a
+  // license page is duplicate presentation that captures nothing. This gate
+  // previously REQUIRED bundle.licenseFile; it now requires its absence.
+  //
+  // Checked on EVERY platform, not just Windows: one bundle.licenseFile drives BOTH
+  // the NSIS license page and the macOS DMG SLA (branded-dmg.mjs derives its --eula
+  // from it), so a win-only check would let a mac build reintroduce the SLA.
+  if (typeof legal.tauriConfig !== "string") fail(appName, "the legal gate requires legal.tauriConfig");
+  const tauriPath = path.resolve(appRoot, legal.tauriConfig);
+  if (!within(appRoot, tauriPath) || !existsSync(tauriPath)) fail(appName, `missing Tauri config: ${legal.tauriConfig}`);
+  const tauri = readJson(tauriPath, appName, "Tauri config");
+  const configured = tauri.bundle?.licenseFile;
+  if (typeof configured === "string" && configured.trim()) {
+    fail(
+      appName,
+      "Tauri bundle.licenseFile must be absent: the in-app legal gate is the only assent surface, and an " +
+        "installer license page (NSIS) or DMG SLA duplicates it without recording acceptance",
+    );
   }
 
   return {

package/legal-contract.test.mjs

@@ -100,12 +100,27 @@ test("rejects an explicitly unresolved release blocker even without a checkbox",
   assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "win"), /release blocker/i);
 });
 
-test("requires Windows installer clickthrough to use the exact EULA snapshot", () => {
+test("rejects a Windows installer license page: the in-app gate is the only assent surface", () => {
   const { root, legal } = fixture();
   writeFileSync(path.join(root, "src-tauri", "tauri.conf.json"), JSON.stringify({ bundle: { licenseFile: "../legal/EULA.md" } }));
   assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "win"), /licenseFile must be absent/i);
 });
 
+test("rejects a macOS DMG SLA too — one licenseFile drives both bundlers", () => {
+  // branded-dmg.mjs derives its --eula from bundle.licenseFile, so a Windows-only
+  // check would let a mac release quietly reintroduce the mount-time SLA.
+  const { root, legal } = fixture();
+  writeFileSync(path.join(root, "src-tauri", "tauri.conf.json"), JSON.stringify({ bundle: { licenseFile: "../legal/EULA.md" } }));
+  assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "mac"), /licenseFile must be absent/i);
+});
+
+test("accepts an app whose installer carries no license page", () => {
+  const { root, legal } = fixture();
+  for (const platform of ["win", "mac"]) {
+    assert.doesNotThrow(() => assertLegalReleaseContract(root, legal, "fixture", platform));
+  }
+});
+
 test("requires third-party build provenance", () => {
   const { root, legal, manifest } = fixture();
   const notice = "Third-party software is included.\n";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rightkit/release",
-  "version": "0.2.28",
+  "version": "0.2.29",
   "description": "Portable Right Suite release CLI/SDK: signed installers, updater artifacts, patch/update routing, hardening, R2 publish, and RightApps registration.",
   "type": "module",
   "bin": {

package/right-suite-contract.test.mjs

@@ -327,7 +327,7 @@ test("RightKit exposes one current version manifest", () => {
     "@rightkit/legal": "0.3.0",
     "@rightkit/legal-ui": "0.1.0",
     "@rightkit/license": "0.1.6",
-    "@rightkit/release": "0.2.28",
+    "@rightkit/release": "0.2.29",
   });
   const licensePackage = JSON.parse(readFileSync(
     path.join(workspace, "tools/rightkit/packages/license/package.json"),

package/rightkit-versions.json

@@ -14,7 +14,7 @@
   "stagedNpm": {
     "@rightkit/legal": "0.3.0",
     "@rightkit/license": "0.1.6",
-    "@rightkit/release": "0.2.28",
+    "@rightkit/release": "0.2.29",
     "@rightkit/legal-ui": "0.1.0"
   },
   "cargo": {