@rightkit/release 0.2.27 → 0.2.29

package/cargo-contract.mjs

@@ -39,7 +39,7 @@ export function assertPublishedRightKitCargoDependencies(dependencies, published
     const allowed = configured instanceof Set ? configured : new Set(Array.isArray(configured) ? configured : [configured]);
     const exactVersions = new Set([...allowed].map((version) => `=${version}`));
     if (!CRATES_IO_SOURCES.has(dependency.source) || dependency.path || dependency.registry || !exactVersions.has(dependency.req)) {
-      throw new Error(`${label} ${dependency.name} must use an exact supported crates.io version (${[...exactVersions].join(" or ")})`);
+      throw new Error(`${label} ${dependency.name} must use exact crates.io versions (${[...exactVersions].join(" or ")})`);
     }
   }
   return checked;

package/legal-contract.mjs

@@ -135,20 +135,26 @@ export function assertLegalReleaseContract(root, legal, appName, platform) {
     appendices.push({ ...appendix, absolutePath: realFile });
   }
 
-  if (platform === "win") {
-    if (typeof legal.tauriConfig !== "string") fail(appName, "Windows legal gate requires legal.tauriConfig");
-    const tauriPath = path.resolve(appRoot, legal.tauriConfig);
-    if (!within(appRoot, tauriPath) || !existsSync(tauriPath)) fail(appName, `missing Tauri config: ${legal.tauriConfig}`);
-    const tauri = readJson(tauriPath, appName, "Tauri config");
-    const configured = tauri.bundle?.licenseFile;
-    if (typeof configured !== "string" || !configured.trim()) {
-      fail(appName, "Windows Tauri bundle.licenseFile must point to the snapshot EULA");
-    }
-    const configuredPath = path.resolve(path.dirname(tauriPath), configured);
-    const eula = resolvedDocuments.find((document) => document.role === "eula");
-    if (!eula || path.normalize(configuredPath).toLowerCase() !== path.normalize(eula.absolutePath).toLowerCase()) {
-      fail(appName, "Windows Tauri bundle.licenseFile must point to the exact EULA snapshot");
-    }
+  // The in-app gate is the SINGLE assent surface (Adrian, 2026-07-17). An
+  // installer/DMG can only PRESENT the text: it cannot record who agreed, cannot ask
+  // the individual-vs-enterprise basis, and passive updaters reach neither — so a
+  // license page is duplicate presentation that captures nothing. This gate
+  // previously REQUIRED bundle.licenseFile; it now requires its absence.
+  //
+  // Checked on EVERY platform, not just Windows: one bundle.licenseFile drives BOTH
+  // the NSIS license page and the macOS DMG SLA (branded-dmg.mjs derives its --eula
+  // from it), so a win-only check would let a mac build reintroduce the SLA.
+  if (typeof legal.tauriConfig !== "string") fail(appName, "the legal gate requires legal.tauriConfig");
+  const tauriPath = path.resolve(appRoot, legal.tauriConfig);
+  if (!within(appRoot, tauriPath) || !existsSync(tauriPath)) fail(appName, `missing Tauri config: ${legal.tauriConfig}`);
+  const tauri = readJson(tauriPath, appName, "Tauri config");
+  const configured = tauri.bundle?.licenseFile;
+  if (typeof configured === "string" && configured.trim()) {
+    fail(
+      appName,
+      "Tauri bundle.licenseFile must be absent: the in-app legal gate is the only assent surface, and an " +
+        "installer license page (NSIS) or DMG SLA duplicates it without recording acceptance",
+    );
   }
 
   return {

package/legal-contract.test.mjs

@@ -46,9 +46,11 @@ function fixture() {
     })),
   };
   writeFileSync(path.join(legalDir, "legal-manifest.json"), `${JSON.stringify(manifest, null, 2)}\n`);
+  // No bundle.licenseFile: the in-app gate is the single assent surface, so a
+  // compliant app ships an installer with no license page (Adrian, 2026-07-17).
   writeFileSync(
     path.join(tauriDir, "tauri.conf.json"),
-    `${JSON.stringify({ bundle: { licenseFile: "../legal/EULA.md" } }, null, 2)}\n`,
+    `${JSON.stringify({ bundle: { publisher: "Damned Ventures LLC" } }, null, 2)}\n`,
   );
   return {
     root,
@@ -98,10 +100,25 @@ test("rejects an explicitly unresolved release blocker even without a checkbox",
   assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "win"), /release blocker/i);
 });
 
-test("requires Windows installer clickthrough to use the exact EULA snapshot", () => {
+test("rejects a Windows installer license page: the in-app gate is the only assent surface", () => {
   const { root, legal } = fixture();
-  writeFileSync(path.join(root, "src-tauri", "tauri.conf.json"), JSON.stringify({ bundle: { licenseFile: "../legal/LICENSE.md" } }));
-  assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "win"), /licenseFile.*EULA/i);
+  writeFileSync(path.join(root, "src-tauri", "tauri.conf.json"), JSON.stringify({ bundle: { licenseFile: "../legal/EULA.md" } }));
+  assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "win"), /licenseFile must be absent/i);
+});
+
+test("rejects a macOS DMG SLA too — one licenseFile drives both bundlers", () => {
+  // branded-dmg.mjs derives its --eula from bundle.licenseFile, so a Windows-only
+  // check would let a mac release quietly reintroduce the mount-time SLA.
+  const { root, legal } = fixture();
+  writeFileSync(path.join(root, "src-tauri", "tauri.conf.json"), JSON.stringify({ bundle: { licenseFile: "../legal/EULA.md" } }));
+  assert.throws(() => assertLegalReleaseContract(root, legal, "fixture", "mac"), /licenseFile must be absent/i);
+});
+
+test("accepts an app whose installer carries no license page", () => {
+  const { root, legal } = fixture();
+  for (const platform of ["win", "mac"]) {
+    assert.doesNotThrow(() => assertLegalReleaseContract(root, legal, "fixture", platform));
+  }
 });
 
 test("requires third-party build provenance", () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rightkit/release",
-  "version": "0.2.27",
+  "version": "0.2.29",
   "description": "Portable Right Suite release CLI/SDK: signed installers, updater artifacts, patch/update routing, hardening, R2 publish, and RightApps registration.",
   "type": "module",
   "bin": {

package/pub-upload.mjs

@@ -0,0 +1,100 @@
+#!/usr/bin/env node
+import { accessSync, statSync } from "node:fs";
+import path from "node:path";
+import { spawnSync } from "node:child_process";
+
+const ACCOUNT_ID = "03ae77ccd7a07bcbb2dcfde47fa7ba3a";
+const BUCKETS = new Map([
+  ["public", "rightapps-downloads"],
+  ["private", "rightapps-updates"],
+]);
+// Wrangler always runs remotely through a package runner; which one exists is machine-specific
+// (a node install without npm/npx is normal when pnpm is the pinned package manager).
+const RUNNERS = [
+  { cmd: "npx", prefix: [] },
+  { cmd: "pnpm", prefix: ["dlx"] },
+];
+
+const [, , localFile, r2Key, bucketAlias = "public"] = process.argv;
+if (!localFile || !r2Key) {
+  console.error("Usage: node upload-large.mjs <localFile> <r2Key> [public|private]");
+  process.exit(1);
+}
+
+const bucket = BUCKETS.get(bucketAlias);
+if (!bucket) {
+  console.error(`upload-large: invalid bucket alias ${bucketAlias}; expected public|private`);
+  process.exit(1);
+}
+
+try {
+  accessSync(localFile);
+} catch {
+  console.error(`upload-large: missing local file: ${localFile}`);
+  process.exit(1);
+}
+
+const fileSize = statSync(localFile).size;
+const object = `${bucket}/${r2Key}`;
+const wranglerArgs = ["wrangler@4", "r2", "object", "put", object, "--file", path.resolve(localFile), "--remote"];
+const env = cleanCloudflareEnv(process.env);
+
+console.log(`Uploading ${path.basename(localFile)} (${(fileSize / 1024 / 1024).toFixed(1)} MB) -> ${object}`);
+console.log(`wrangler r2 object put ${object} --file ${path.resolve(localFile)} --remote`);
+
+// Resolve the package runner before the dry-run exit: a release box without one cannot upload,
+// and that must fail here rather than after a signed build has already been produced.
+const runner = resolveRunner(env);
+if (!runner) {
+  console.error(
+    "upload-large: no package runner found. Tried: " +
+      `${RUNNERS.map((entry) => [entry.cmd, ...entry.prefix].join(" ")).join(", ")}. ` +
+      "Install one, or set RIGHT_RELEASE_WRANGLER_RUNNER (e.g. \"pnpm dlx\").",
+  );
+  process.exit(1);
+}
+console.log(`runner: ${[runner.cmd, ...runner.prefix].join(" ")}`);
+
+if (process.env.RIGHT_RELEASE_UPLOAD_DRY_RUN === "1") {
+  process.exit(0);
+}
+
+const result = spawnSync(runner.cmd, [...runner.prefix, ...wranglerArgs], {
+  env,
+  stdio: "inherit",
+  shell: process.platform === "win32",
+  windowsHide: true,
+});
+
+if (result.error) {
+  console.error(`upload-large: failed to start wrangler: ${result.error.message}`);
+  process.exit(1);
+}
+process.exit(result.status ?? 1);
+
+function resolveRunner(env) {
+  const override = process.env.RIGHT_RELEASE_WRANGLER_RUNNER?.trim();
+  if (override) {
+    const [cmd, ...prefix] = override.split(/\s+/);
+    return { cmd, prefix };
+  }
+  for (const candidate of RUNNERS) {
+    const probe = spawnSync(candidate.cmd, ["--version"], {
+      env,
+      stdio: "ignore",
+      shell: process.platform === "win32",
+      windowsHide: true,
+    });
+    if (!probe.error && probe.status === 0) return candidate;
+  }
+  return null;
+}
+
+function cleanCloudflareEnv(source) {
+  const env = { ...source, CLOUDFLARE_ACCOUNT_ID: source.CLOUDFLARE_ACCOUNT_ID || ACCOUNT_ID };
+  delete env.CLOUDFLARE_API_KEY;
+  delete env.CLOUDFLARE_EMAIL;
+  delete env.CF_API_KEY;
+  delete env.CF_EMAIL;
+  return env;
+}