@rightkit/release 0.2.147 → 0.2.149

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rightkit/release",
-  "version": "0.2.147",
+  "version": "0.2.149",
   "description": "Portable release CLI/SDK with fail-closed public GitHub Releases and private R2 + RightApps distribution.",
   "license": "MIT OR Apache-2.0",
   "type": "module",

package/release.mjs

@@ -742,7 +742,8 @@ async function validateHostedWorkflows(root, appName, workflows, policy) {
     fail(`${appName} right-git-ci-only policy requires a valid .rightgit.json`);
   }
   const lanes = manifest?.lanes;
-  const safeLanes = new Set(["ci", "release-candidate"]);
+  // Mirrors the `lanes` enum in @rightkit/git manifest.schema.json.
+  const safeLanes = new Set(["ci", "qualification", "package-smoke", "release-candidate", "publish-npm", "publish-package-managers", "regenerate"]);
   if (manifest?.schemaVersion !== 1
     || manifest?.compile !== "github-actions-only"
     || !Array.isArray(lanes)
@@ -750,7 +751,7 @@ async function validateHostedWorkflows(root, appName, workflows, policy) {
     || !lanes.includes("ci")
     || new Set(lanes).size !== lanes.length
     || lanes.some((lane) => !safeLanes.has(lane))) {
-    fail(`${appName} right-git-ci-only policy requires compile=github-actions-only plus unique .rightgit.json lanes drawn from ["ci", "release-candidate"] and including "ci"`);
+    fail(`${appName} right-git-ci-only policy requires compile=github-actions-only plus unique .rightgit.json lanes drawn from [${[...safeLanes].map((lane) => `"${lane}"`).join(", ")}] and including "ci"`);
   }
   const expectedWorkflows = lanes.map((lane) => `${lane}.yml`).sort();
   if (JSON.stringify(workflows) !== JSON.stringify(expectedWorkflows)) {
@@ -798,6 +799,31 @@ async function validateHostedWorkflows(root, appName, workflows, policy) {
     const protectedMacosSigning = workflow === "release-candidate.yml"
       && manifest?.candidate?.signMacos === true
       && (legacySigningGate("macos-sign").test(macosSource) || admittedSigningGate("macos-sign").test(macosSource));
+    // @rightkit/git `devArtifact.mac: "sign"` renders a `dev-mac-sign` job into
+    // the managed ci.yml: push to the default branch only, release environment,
+    // Developer ID certificate secrets only (no notarization keys).
+    // @rightkit/git `regenerate` lane: manual-only, opens a pull request from a
+    // right-git/regenerate-<run> branch and never writes to the default branch.
+    // `contents: write` and `pull-requests: write` are accepted only inside that
+    // job, only when the manifest declares `regenerate`, and only when the
+    // workflow has no trigger other than workflow_dispatch and pushes solely to
+    // the right-git/regenerate-* branch namespace.
+    const regenerateSpan = workflow === "regenerate.yml" ? jobSpan("regenerate") : null;
+    const regenerateSource = regenerateSpan ? source.slice(regenerateSpan.start, regenerateSpan.end) : "";
+    const protectedRegenerate = workflow === "regenerate.yml"
+      && manifest?.regenerate && typeof manifest.regenerate.script === "string"
+      && /^on:\n  workflow_dispatch:\n(?!  )/m.test(source)
+      && /regenerate:\n    needs: \[private-repo-guard\]\n    if: \$\{\{ github\.event_name == 'workflow_dispatch' \}\}\n/.test(regenerateSource)
+      && /branch="right-git\/regenerate-\$\{\{ github\.run_id \}\}-\$\{\{ github\.run_attempt \}\}"\n/.test(regenerateSource)
+      && /git push origin "HEAD:refs\/heads\/\$branch"\n/.test(regenerateSource)
+      && !/git push(?![^\n]*"HEAD:refs\/heads\/\$branch")/.test(regenerateSource);
+    const allowedRegeneratePermissions = new Set(["contents", "pull-requests"]);
+    const devMacSpan = workflow === "ci.yml" ? jobSpan("dev-mac-sign") : null;
+    const devMacSource = devMacSpan ? source.slice(devMacSpan.start, devMacSpan.end) : "";
+    const allowedDevMacSecrets = new Set(["APPLE_CERTIFICATE_BASE64", "APPLE_CERTIFICATE_PASSWORD", "APPLE_KEYCHAIN_PASSWORD"]);
+    const protectedDevMacSigning = workflow === "ci.yml"
+      && manifest?.devArtifact?.mac === "sign"
+      && /dev-mac-sign:\n(?:    #[^\n]*\n)*    needs: \[ci\]\n    if: \$\{\{ github\.event_name == 'push' && github\.ref_name == github\.event\.repository\.default_branch \}\}\n    environment: /.test(devMacSource);
     const releaseChain = workflow === "release-candidate.yml" ? manifest?.candidate?.releaseChain : undefined;
     const allowedReleaseSecrets = new Set(releaseChain?.publishSecrets ?? []);
     const writePermissions = [...source.matchAll(/^\s*(actions|attestations|checks|contents|deployments|discussions|id-token|issues|models|packages|pages|pull-requests|security-events|statuses):\s*write\s*$/gmi)].map((match) => ({ name: match[1].toLowerCase(), index: match.index }));
@@ -815,12 +841,16 @@ async function validateHostedWorkflows(root, appName, workflows, policy) {
       && (legacyReleasePublishGate || admittedReleasePublishGate)
       && /\n    permissions:\n      contents: write\n/.test(publishSource);
     if (/^\s*permissions:\s*write-all\s*$/mi.test(source)
-      || writePermissions.some(({ name, index }) => name === "id-token"
-        ? !(protectedWindowsSigning && inside(index, windowsSpan))
-        : name !== "contents" || !protectedReleasePublish || !inside(index, publishSpan))
+      || writePermissions.some(({ name, index }) => {
+        if (protectedRegenerate && inside(index, regenerateSpan) && allowedRegeneratePermissions.has(name)) return false;
+        return name === "id-token"
+          ? !(protectedWindowsSigning && inside(index, windowsSpan))
+          : name !== "contents" || !protectedReleasePublish || !inside(index, publishSpan);
+      })
       || /pull_request_target\s*:/i.test(source)
       || /\bsecrets\s*\[/i.test(source)
       || requestedSecrets.some(({ name, index }) => !(protectedMacosSigning && inside(index, macosSpan) && allowedMacosSecrets.has(name))
+        && !(protectedDevMacSigning && inside(index, devMacSpan) && allowedDevMacSecrets.has(name))
         && !(protectedReleasePublish && inside(index, publishSpan) && allowedReleaseSecrets.has(name)))) {
       fail(`${appName} right-git managed ${workflow} requests release-capable permissions or secrets`);
     }

package/rightkit-versions.json

@@ -16,7 +16,7 @@
     "@rightkit/app-shell": "0.3.0",
     "@rightkit/ax": "0.2.4",
     "@rightkit/doc-render": "0.1.4",
-    "@rightkit/git": "0.2.33",
+    "@rightkit/git": "0.2.36",
     "@rightkit/hooks": "0.1.2",
     "@rightkit/i18n": "0.1.0",
     "@rightkit/legal": "0.3.1",
@@ -29,7 +29,7 @@
     "@rightkit/platform-ui": "0.2.0",
     "@rightkit/qa": "0.4.0",
     "@rightkit/qa-chrome": "0.1.3",
-    "@rightkit/release": "0.2.147",
+    "@rightkit/release": "0.2.149",
     "@rightkit/settings-ui": "0.3.0",
     "@rightkit/shell": "0.1.0",
     "@rightkit/tauri": "0.2.0",
@@ -74,7 +74,10 @@
       "0.2.29",
       "0.2.30",
       "0.2.31",
-      "0.2.32"
+      "0.2.32",
+      "0.2.33",
+      "0.2.34",
+      "0.2.35"
     ],
     "@rightkit/legal-ui": [
       "0.1.0",
@@ -179,7 +182,9 @@
       "0.2.143",
       "0.2.144",
       "0.2.145",
-      "0.2.146"
+      "0.2.146",
+      "0.2.147",
+      "0.2.148"
     ],
     "@rightkit/qa": [
       "0.1.0",
@@ -378,7 +383,7 @@
       "@rightkit/app-shell": "0.3.0",
       "@rightkit/ax": "0.2.4",
       "@rightkit/doc-render": "0.1.4",
-      "@rightkit/git": "0.2.33",
+      "@rightkit/git": "0.2.36",
       "@rightkit/hooks": "0.1.2",
       "@rightkit/i18n": "0.1.0",
       "@rightkit/legal": "0.3.1",
@@ -391,7 +396,7 @@
       "@rightkit/platform-ui": "0.2.0",
       "@rightkit/qa": "0.4.0",
       "@rightkit/qa-chrome": "0.1.3",
-      "@rightkit/release": "0.2.147",
+      "@rightkit/release": "0.2.148",
       "@rightkit/settings-ui": "0.3.0",
       "@rightkit/shell": "0.1.0",
       "@rightkit/tauri": "0.2.0",