@rig-c/review 4.9.0 → 4.10.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/docs/DESIGN.md +4 -4
- package/docs/REVIEW_PACKAGE.md +90 -16
- package/docs/STABILITY.md +100 -3
- package/package.json +2 -2
- package/src/chest-landmarks.ts +9 -4
- package/src/compare-html.ts +1 -1
- package/src/feedback-export.ts +2 -2
- package/src/feedback-validation.ts +11 -6
- package/src/frame-clock.ts +20 -4
- package/src/job-act.ts +60 -71
- package/src/job-api.ts +286 -40
- package/src/job-cli.ts +3 -2
- package/src/job-contract.ts +92 -5
- package/src/job-front.ts +19 -8
- package/src/job-host.ts +7 -1
- package/src/job-session.ts +136 -26
- package/src/job-source.ts +109 -14
- package/src/job-store.ts +7 -4
- package/src/manifest.ts +59 -7
- package/src/rebuild.ts +1 -1
- package/src/session.ts +9 -4
- package/src/stage-comment.ts +2 -1
- package/web/catalog-en.ts +26 -6
- package/web/catalog-ko.ts +49 -29
- package/web/chest-editor.ts +236 -31
- package/web/compare.css +2 -2
- package/web/i18n.ts +1 -3
- package/web/inspection-persistence.ts +19 -6
- package/web/interview-panel.ts +13 -80
- package/web/job-rig-screen.ts +59 -33
- package/web/job-session.ts +175 -40
- package/web/label-placement.ts +25 -8
- package/web/main.ts +314 -89
- package/web/part-selection.ts +2 -1
- package/web/parts-viewport-provider.ts +19 -6
- package/web/rebuild-client.ts +2 -4
- package/web/rig-host.ts +5 -4
- package/web/rig-overlays.ts +3 -2
- package/web/rig-viewport-provider.ts +6 -1
- package/web/stage-comments.ts +22 -21
- package/web/styles.css +21 -49
- package/web/workspace-layout.ts +4 -4
- package/web/workspace-ui.ts +5 -3
package/web/part-selection.ts
CHANGED
|
@@ -2,6 +2,7 @@
|
|
|
2
2
|
import type {Json} from '../src/manifest.ts';
|
|
3
3
|
import type {PosedFrame,RigPlayer,PoseBounds,SlotIdentitySnapshot} from '@rig-c/play';
|
|
4
4
|
import {parseControlPart,parsePartIdentity,type ControlPart,type ControlPartIdentity,type PartIdentityReason} from '../src/control.ts';
|
|
5
|
+
import {formatFixed} from '../src/frame-clock.ts';
|
|
5
6
|
import {t,setSourceAttribute,setSourceText,sourceAttribute} from './i18n.ts';
|
|
6
7
|
export interface PartDeclaration {skin:string;attachment:string;kind:string;path:string|null}
|
|
7
8
|
export interface PartEntry {slot:string;bone:string;setup:string|null;declarations:PartDeclaration[]}
|
|
@@ -195,7 +196,7 @@ const key=this.viewKey();if(!force&&key===this.selectionKey)return;this.selectio
|
|
|
195
196
|
nodes.info.textContent=observation?`${observation.mode==='solo'?'Solo':'In context'} · ${observation.drawn?observation.kind==='mesh'?`${observation.vertices} posed vertices · ${observation.triangles} triangles`:'Region · four posed corners':'Not drawn at current pose'} · Skin: ${observation.skin??'not set'} · Set: ${observation.set??'not set'}`:refusal?`Parts unavailable · ${refusal.message}. The whole rig stays drawn; no slot is selected, soloed or targeted from stale data.`:'Select an actual slot in the parts explorer. Selection preserves animation, time and physics history.';
|
|
196
197
|
for(const node of [nodes.declarations,nodes.bounds,nodes.unavailable,nodes.feedback])node.hidden=!observation;nodes.feedback.disabled=!observation;
|
|
197
198
|
nodes.declarations.textContent=observation?`${observation.activeAttachment?'Resolved public attachment: '+observation.activeAttachment.skin+' / '+observation.activeAttachment.attachment+'.':(observation.identityUnavailable??'No active drawable attachment: '+observation.reason)+'.'} Declared: ${observation.declarations.map(d=>`${d.skin} / ${d.attachment} (${d.kind})`).join('; ')||'none'}. ${observation.page?'Drawn page: '+observation.page:''}${observation.region?' · region '+observation.region:''}${observation.sequence!==null?' · sequence '+observation.sequence:''}`:'';
|
|
198
|
-
nodes.bounds.textContent=observation?observation.bounds
|
|
199
|
+
nodes.bounds.textContent=observation?observation.bounds?t('Selection bounds · world units / Y up: x {0}, y {1}, width {2}, height {3}. Conservative geometry/clip bounds; fit uses the existing 0.25–8× camera range.',[formatFixed(observation.bounds.x,2),formatFixed(observation.bounds.y,2),formatFixed(observation.bounds.width,2),formatFixed(observation.bounds.height,2)]):t('PART_FIT_UNAVAILABLE: no positive drawn bounds at the held pose.'):'';
|
|
199
200
|
}
|
|
200
201
|
|
|
201
202
|
}
|
|
@@ -168,10 +168,17 @@ export function bindPartsSubject(host:{
|
|
|
168
168
|
finally{for(const bitmap of bitmaps)bitmap.close();if(navigation===token){busy=false;host.el('stage-layout').setAttribute('aria-busy','false');comments?.refresh();}}
|
|
169
169
|
}
|
|
170
170
|
const redraw=()=>{void paint().catch(()=>{});};
|
|
171
|
-
const commentRegion=(pose:PartsPose,screen:ReturnType<typeof region
|
|
171
|
+
const commentRegion=(pose:PartsPose,screen:ReturnType<typeof region>,bounds?:{x:number;y:number;width:number;height:number})=>{
|
|
172
172
|
const frame=box(),a=unprojectMark(screen,pose.camera),b=unprojectMark({x:screen.x+screen.width,y:screen.y+screen.height},pose.camera);
|
|
173
173
|
const stable=(n:number)=>Math.abs(n-Math.round(n))<1e-6?Math.round(n):n;
|
|
174
|
-
return snapImageRegion(region({x:stable(a.x),y:stable(a.y)},{x:stable(b.x),y:stable(b.y)},{x:0,y:0,width:frame.w,height:frame.h}));
|
|
174
|
+
return snapImageRegion(region({x:stable(a.x),y:stable(a.y)},{x:stable(b.x),y:stable(b.y)},bounds??{x:0,y:0,width:frame.w,height:frame.h}));
|
|
175
|
+
};
|
|
176
|
+
const partsUnionBounds=(names:readonly string[]|undefined,r:ReturnType<typeof snapImageRegion>)=>{
|
|
177
|
+
const matched=(names??[]).flatMap(name=>{const entry=data.items.find(item=>item.name===name);return entry?[entry]:[];});
|
|
178
|
+
if(!matched.length)return undefined;
|
|
179
|
+
const minX=Math.min(...matched.map(i=>i.x)),minY=Math.min(...matched.map(i=>i.y));
|
|
180
|
+
const maxX=Math.max(...matched.map(i=>i.x+i.w)),maxY=Math.max(...matched.map(i=>i.y+i.h));
|
|
181
|
+
return r.x<maxX&&r.x+r.width>minX&&r.y<maxY&&r.y+r.height>minY?{x:minX,y:minY,width:maxX-minX,height:maxY-minY}:undefined;
|
|
175
182
|
};
|
|
176
183
|
const codec:CommentCodec<CommentRow,PartsPose>={
|
|
177
184
|
geometry:true,
|
|
@@ -187,16 +194,22 @@ export function bindPartsSubject(host:{
|
|
|
187
194
|
const hits=new Set<string>(),layers=visible.flatMap(box=>{const img=loaded.get(box.name);return img?[sourceAlpha(box,img)]:[];});
|
|
188
195
|
const stepX=Math.max(1,r.width/32),stepY=Math.max(1,r.height/32);
|
|
189
196
|
for(let y=r.y+.5;y<r.y+r.height;y+=stepY)for(let x=r.x+.5;x<r.x+r.width;x+=stepX){const hit=pickAssembly(layers,x,y);if(hit)hits.add(hit.name);}
|
|
197
|
+
if(!hits.size){
|
|
198
|
+
const overlaps=(entry:Item)=>entry.x<r.x+r.width&&entry.x+entry.w>r.x&&entry.y<r.y+r.height&&entry.y+entry.h>r.y;
|
|
199
|
+
const current=selected!==null?visible.find(entry=>entry.name===selected&&overlaps(entry)):undefined;
|
|
200
|
+
if(current)hits.add(current.name);
|
|
201
|
+
else for(const entry of visible)if(overlaps(entry))hits.add(entry.name);
|
|
202
|
+
}
|
|
190
203
|
return {selected:visible.filter(item=>hits.has(item.name)).map(item=>item.name),candidates};
|
|
191
204
|
},
|
|
192
205
|
create:async(pose,_view,screen,crop,_bookmark,summary,parts)=>{
|
|
193
|
-
const
|
|
206
|
+
const raw=commentRegion(pose,screen),single=pose.view.mode==='item',r=single?raw:commentRegion(pose,screen,partsUnionBounds(parts,raw));
|
|
194
207
|
return prepare({schema:'rig-review-parts-comment/2',id:crypto.randomUUID(),summary,sourceHash:data.sourceHash,parts:partsBinding(single?[pose.item.name]:parts??[]),rigRegion:single?{...r,x:r.x+pose.item.x,y:r.y+pose.item.y}:r,imageRegion:single?r:null,view:structuredClone(pose.view),crop,nativeCrop:null});
|
|
195
208
|
},
|
|
196
209
|
update:(raw,summary,parts,geometry)=>{
|
|
197
210
|
const existing=parsePartsIssue(raw,false,true,false);let updated=existing;
|
|
198
211
|
if(geometry){
|
|
199
|
-
const {pose,screen,crop}=geometry,
|
|
212
|
+
const {pose,screen,crop}=geometry,rawRegion=commentRegion(pose,screen),single=pose.view.mode==='item',r=single?rawRegion:commentRegion(pose,screen,partsUnionBounds(parts,rawRegion));
|
|
200
213
|
if(pose.sourceHash!==existing.sourceHash)throw new Error('PARTS_COMMENT_STALE_SOURCE');
|
|
201
214
|
updated={...existing,rigRegion:single?{...r,x:r.x+pose.item.x,y:r.y+pose.item.y}:r,imageRegion:single?r:null,view:structuredClone(pose.view),crop,nativeCrop:null};
|
|
202
215
|
}
|
|
@@ -213,7 +226,7 @@ export function bindPartsSubject(host:{
|
|
|
213
226
|
...(host.generalComments?{...host.generalComments,refusal:host.refusal}:{}),
|
|
214
227
|
}:undefined,toolbar:host.toolbar,listHost:host.commentsHost,openList:host.openComments,hasPicture:host.hasPicture,toggle:host.el<HTMLButtonElement>('stage-comment'),viewports:{rig:host.el('rig-viewport')},pose,pause:async()=>{},bookmark:()=>null,
|
|
215
228
|
restore:async raw=>{const issue=parsePartsIssue(raw,false,true,false);assertPartsIssueBinding(issue,sourceItems(),data.sourceHash);selected=issue.view.mode==='item'?issue.parts[0]!.name:null;solo=issue.view.mode==='item';comparison=issue.view.comparison??defaultPartsComparison();host.restoreMesh(issue.view.mesh);if(issue.view.visibleLayers){const visible=new Set(issue.view.visibleLayers.map(part=>part.name));hidden.clear();for(const item of data.items)if(!visible.has(item.name))hidden.add(item.name);}await paint();host.viewport.writeCamera('rig',data.painting&&solo?{...issue.view.camera,center:{x:issue.view.camera.center.x+item().x,y:issue.view.camera.center.y+item().y}}:issue.view.camera);host.viewport.activateCamera('rig');if(host.viewport.state.cameraSync)host.viewport.alignCameras();host.viewport.fitCamera();host.selectionChanged();},
|
|
216
|
-
feedback:()=>host.recordComments??host.issues,locked:host.locked,refusal:host.refusal,add:row=>{if(host.recordComments)host.recordComments.push(row);else host.issues.push(row as PartsIssue);},changed:host.changed,error:host.message,blocked:()=>busy||failed||disposed||!!host.submitting?.(),busy:()=>busy,codec});
|
|
229
|
+
feedback:()=>host.recordComments??host.issues,locked:host.locked,refusal:host.refusal,add:row=>{if(host.recordComments)host.recordComments.push(row);else host.issues.push(row as PartsIssue);},changed:host.changed,draftChanged:host.selectionChanged,error:host.message,blocked:()=>busy||failed||disposed||!!host.submitting?.(),busy:()=>busy,codec});
|
|
217
230
|
return {
|
|
218
231
|
frameSize:(target:CameraTarget):PartsFrame|null=>{
|
|
219
232
|
const frame=target==='rig'?drawnFrame:drawnReferenceFrame;if(!frame||!data.painting||!data.rigSize)return frame;
|
|
@@ -224,7 +237,7 @@ export function bindPartsSubject(host:{
|
|
|
224
237
|
return {...frame,world:{box:{x:bounds.x,y:bounds.y,width:bounds.w,height:bounds.h},origin,scale}};
|
|
225
238
|
},
|
|
226
239
|
image:(index:number)=>{const entry=data.items.find(item=>item.index===index);if(!entry)return Promise.reject(new Error('PARTS_IMAGE_UNAVAILABLE'));return image(entry);},
|
|
227
|
-
items:()=>data.items,sourceHash:()=>data.sourceHash,refreshComments:()=>comments?.refresh(),selected:()=>selected,solo:()=>solo,visible:(name:string)=>!hidden.has(name),issues:()=>host.issues,
|
|
240
|
+
items:()=>data.items,sourceHash:()=>data.sourceHash,refreshComments:()=>comments?.refresh(),hasPendingComment:()=>!!comments?.hasPendingComment(),commitDraft:()=>comments?.commitDraft()??Promise.resolve(true),selected:()=>selected,solo:()=>solo,visible:(name:string)=>!hidden.has(name),issues:()=>host.issues,
|
|
228
241
|
select:(name:string|null)=>{selected=name;if(name===null)solo=false;redraw();host.selectionChanged();},
|
|
229
242
|
isolate:(value:boolean)=>{
|
|
230
243
|
solo=value;
|
package/web/rebuild-client.ts
CHANGED
|
@@ -4,6 +4,7 @@
|
|
|
4
4
|
* the applied history for the page; the server owns every path and the producer's flags.
|
|
5
5
|
*/
|
|
6
6
|
import {setSourceText} from './i18n.ts';
|
|
7
|
+
import {bustLandmarkFields} from './chest-editor.ts';
|
|
7
8
|
import {ellipsePolygon,fitChestEllipse,CHEST_ELLIPSE_MIN_POINTS} from '../src/chest-regions.ts';
|
|
8
9
|
import {deriveBust,parseBustSpec,type BustSpec} from '../src/chest-landmarks.ts';
|
|
9
10
|
import {CONFIG_PATCH_SCHEMA,type ConfigPatch,type PatchCmd,type PatchOp} from '../src/config-patch.ts';
|
|
@@ -200,10 +201,7 @@ export function seedLandmarks(status:Pick<RebuildStatusView,'parts'|'contour'>,r
|
|
|
200
201
|
if(['apex_r','apex_l','cleavage'].some(k=>(read(`lm-${k}-x`)?.value??'').trim()||(read(`lm-${k}-y`)?.value??'').trim()))return null;
|
|
201
202
|
for(const p of status.parts){
|
|
202
203
|
const bust=(status.contour[p.name]?.contour as Record<string,unknown>|undefined)?.bust as Record<string,unknown>|undefined;if(!bust||typeof bust!=='object')continue;
|
|
203
|
-
const out
|
|
204
|
-
for(const k of ['apex_r','apex_l','cleavage'])if(Array.isArray(bust[k])&&(bust[k] as unknown[]).length===2){out[`lm-${k}-x`]=String((bust[k] as number[])[0]);out[`lm-${k}-y`]=String((bust[k] as number[])[1]);}
|
|
205
|
-
for(const k of ['alpha','clearance'])if(typeof bust[k]==='number')out[`lm-${k}`]=String(bust[k]);
|
|
206
|
-
for(const k of ['bone_r','bone_l'])if(typeof bust[k]==='string')out[`lm-${k}`]=bust[k] as string;
|
|
204
|
+
const out=bustLandmarkFields(bust);
|
|
207
205
|
return Object.keys(out).length?out:null;
|
|
208
206
|
}
|
|
209
207
|
return null;
|
package/web/rig-host.ts
CHANGED
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
* (`main.ts`): the job keeps the transport, the screen keeps its own view. Unset, the screen is the package page. */
|
|
3
3
|
import type {ModelAssets, PosedFrame} from '@rig-c/play';
|
|
4
4
|
import type {PartsIssue} from '../src/parts-comment.ts';
|
|
5
|
-
import type {PendingAskV3} from '../src/job-contract.ts';
|
|
5
|
+
import type {JobProgressV3, PendingAskV3} from '../src/job-contract.ts';
|
|
6
6
|
import type {ReviewSession} from '../src/session.ts';
|
|
7
7
|
import type {InspectionBookmark} from './inspection-persistence.ts';
|
|
8
8
|
import type {ControlView} from '../src/control.ts';
|
|
@@ -31,6 +31,7 @@ export interface RigHostScreen {
|
|
|
31
31
|
redraw(): void;
|
|
32
32
|
message(text: string, error?: boolean, diagnostic?: string): void;
|
|
33
33
|
pendingSubjects?(subjects:readonly PendingAskV3['subject'][]):void;
|
|
34
|
+
progress?(value: JobProgressV3 | null):void;
|
|
34
35
|
recordForms?(forms:readonly HTMLFormElement[]):void;
|
|
35
36
|
}
|
|
36
37
|
/** Only the content carried by an act the host has actually committed. This is local UI state, not an act field. */
|
|
@@ -43,12 +44,12 @@ export interface RigHost {
|
|
|
43
44
|
readonly waiting?:boolean;
|
|
44
45
|
readonly subject?:'parts';
|
|
45
46
|
readonly unavailable?:string;
|
|
46
|
-
readonly direction?:{readonly publicationId:string;readonly sourceHash:string};
|
|
47
|
-
readonly verdictComments?:{readonly publicationId:string;readonly sourceHash:string;readonly rows:CommentRow[];readonly available:()=>boolean};
|
|
47
|
+
readonly direction?:{readonly jobId?:string;readonly draftId?:string;readonly publicationId:string;readonly previousPublicationId?:string|null;readonly sourceHash:string};
|
|
48
|
+
readonly verdictComments?:{readonly jobId?:string;readonly draftId?:string;readonly publicationId:string;readonly previousPublicationId?:string|null;readonly sourceHash:string;readonly rows:CommentRow[];readonly available:()=>boolean};
|
|
48
49
|
readonly navigation?:RigHostNavigation;
|
|
49
50
|
/** Derived from the displayed subject's finalized verdict; never a mode or another subject's act. */
|
|
50
51
|
reviewState?(issues:number,sending:boolean):string;
|
|
51
|
-
readonly record?:{readonly publicationId?:string;readonly label:string;readonly sourceHash:string;readonly hasPicture:boolean;readonly missingPicture?:'rig'|'scene';readonly
|
|
52
|
+
readonly record?:{readonly jobId?:string;readonly draftId?:string;readonly publicationId?:string;readonly previousPublicationId?:string|null;readonly label:string;readonly sourceHash:string;readonly hasPicture:boolean;readonly missingPicture?:'rig'|'scene';readonly questionPicture?:true};
|
|
52
53
|
submitParts?(issues:readonly PartsIssue[], general?:readonly string[]):Promise<string>;
|
|
53
54
|
readonly access: InstanceAccess;
|
|
54
55
|
/** UI act authority is separate from a retained backdrop's immutable source access. */
|
package/web/rig-overlays.ts
CHANGED
|
@@ -1,5 +1,6 @@
|
|
|
1
1
|
/** Inspection graphics from the last successfully drawn public player pose. */
|
|
2
2
|
import {partBounds} from './part-selection.ts';
|
|
3
|
+
import {t} from './i18n.ts';
|
|
3
4
|
import {boxesIntersect,placeLabels,type LabelBox} from './label-placement.ts';
|
|
4
5
|
import type {BoneWorld,PosedFrame,RigPlayer} from '@rig-c/play';
|
|
5
6
|
|
|
@@ -270,7 +271,7 @@ export class RigOverlays {
|
|
|
270
271
|
}
|
|
271
272
|
// Labels avoid each other (#147): a moved label keeps a leader to its point; one with no free slot shows on hover only.
|
|
272
273
|
ctx.font='600 11px ui-monospace, monospace';
|
|
273
|
-
const placed=placeLabels(drawn.map(({marker,at})=>({at,width:ctx.measureText(marker.tag).width+8,pinned:marker.active})),{gap:10,rise:3,bounds:{width,height},obstacles:drawn.map(({marker,at})=>{const r=marker.active?8:6.5;return {x:at.x-r,y:at.y-r,w:r*2,h:r*2};})});
|
|
274
|
+
const placed=placeLabels(drawn.map(({marker,at})=>({at,width:ctx.measureText(t(marker.tag)).width+8,pinned:marker.active})),{gap:10,rise:3,bounds:{width,height},obstacles:drawn.map(({marker,at})=>{const r=marker.active?8:6.5;return {x:at.x-r,y:at.y-r,w:r*2,h:r*2};})});
|
|
274
275
|
// Leaders first, so no leader crosses another joint's label.
|
|
275
276
|
drawn.forEach(({marker,at},i)=>{
|
|
276
277
|
const {box,visible,moved}=placed[i]!;if(!visible||!moved)return;
|
|
@@ -279,7 +280,7 @@ export class RigOverlays {
|
|
|
279
280
|
});
|
|
280
281
|
drawn.forEach(({marker},i)=>{
|
|
281
282
|
const {box,visible}=placed[i]!,c=marker.colors;if(!visible)return;
|
|
282
|
-
ctx.fillStyle=c.labelBg;ctx.fillRect(box.x,box.y,box.w,box.h);ctx.fillStyle=c.stroke;ctx.fillText(marker.tag,box.x+4,box.y+11);
|
|
283
|
+
ctx.fillStyle=c.labelBg;ctx.fillRect(box.x,box.y,box.w,box.h);ctx.fillStyle=c.stroke;ctx.fillText(t(marker.tag),box.x+4,box.y+11);
|
|
283
284
|
});
|
|
284
285
|
}
|
|
285
286
|
ctx.globalAlpha=1;
|
|
@@ -95,11 +95,16 @@ function renderControls(controller:ViewportController):void {
|
|
|
95
95
|
const label=controls?.targetLabel?.(target)??(target==='reference'?'Reference':'Rig');
|
|
96
96
|
text(controls?.zoomId??'zoom-value',`${Math.round((target?paneCamera(target).zoom:1)*100)}% · ${label}`);
|
|
97
97
|
button('fit').textContent=host.fitLabel??controls?.fitLabel?.(state.cameraSync)??(state.cameraSync?'Fit views':'Fit active');
|
|
98
|
+
renderCaption();
|
|
99
|
+
}
|
|
100
|
+
/** The footer names the camera mode the sync checkbox shows, on the rig and the raster paths alike. */
|
|
101
|
+
function renderCaption():void {
|
|
102
|
+
const controls=host.cameraControls;
|
|
98
103
|
if(controls?.coordinatesId!==null)text(controls?.coordinatesId??'coordinates',state.cameraSync?'Cameras synchronized · drag to pan · scroll to zoom':'Independent cameras · drag to pan · scroll to zoom');
|
|
99
104
|
}
|
|
100
105
|
return {el,message,get nativeScale(){return host.raster?rasterActive():undefined;},
|
|
101
106
|
render:controller=>rasterActive()?raster!.render(controller):render(controller),
|
|
102
|
-
renderControls:controller=>rasterActive()
|
|
107
|
+
renderControls:controller=>{if(rasterActive()){raster!.renderControls(controller);renderCaption();}else renderControls(controller);},
|
|
103
108
|
...(host.panes?{panes:[...host.panes,{target:'reference' as const,viewport:el('reference-viewport'),pane:el('reference-pane')}]}:{}),
|
|
104
109
|
dimensionVisibility:host.dimensionVisibility,
|
|
105
110
|
fitMargins:host.rigMargins,fitMessage:host.fitMessage,pinch:host.pinch,
|
package/web/stage-comments.ts
CHANGED
|
@@ -30,7 +30,7 @@ interface Host<Row extends CommentRow=Feedback,Pose extends CommentUiPose=Commen
|
|
|
30
30
|
pose:(view:StageComment['viewport'])=>Pose|null;pause:()=>Promise<void>;
|
|
31
31
|
bookmark:()=>unknown;restore:(bookmark:unknown,timeOnly?:boolean)=>Promise<void>;
|
|
32
32
|
feedback:()=>Row[];locked:(id:string)=>boolean;
|
|
33
|
-
add:(feedback:Row,side?:'a'|'b')=>void;changed:()=>void|Promise<void>;error:(message:string)=>void;
|
|
33
|
+
add:(feedback:Row,side?:'a'|'b')=>void;changed:()=>void|Promise<void>;draftChanged?:()=>void;error:(message:string)=>void;
|
|
34
34
|
general?:{create:(summary:string)=>Row;matches:(row:Row)=>boolean;rows?:Row[];available?:()=>boolean;refusal?:()=>string|null};
|
|
35
35
|
refusal?:()=>string|null;blocked:()=>boolean;busy?:()=>boolean;busyError?:(message:string)=>void;shortcutBlocked?:()=>boolean;shortcutActive?:()=>boolean;codec?:CommentCodec<Row,Pose>;
|
|
36
36
|
}
|
|
@@ -67,7 +67,7 @@ async function crop(pose:CommentUiPose,r:MarkRegion):Promise<StageComment['crop'
|
|
|
67
67
|
const bytes=Uint8Array.from(atob(png.split(',')[1]!),c=>c.charCodeAt(0)),sha256=[...new Uint8Array(await crypto.subtle.digest('SHA-256',bytes))].map(n=>n.toString(16).padStart(2,'0')).join('');
|
|
68
68
|
return {path:`comment-crops/${sha256}.png`,sha256,png,width:out.width,height:out.height};
|
|
69
69
|
}
|
|
70
|
-
export function bindStageComments<Row extends CommentRow=Feedback,Pose extends CommentUiPose=CommentPose>(host:Host<Row,Pose>):{refresh:()=>void;dispose:()=>void;active:()=>boolean;draft:()=>boolean}{
|
|
70
|
+
export function bindStageComments<Row extends CommentRow=Feedback,Pose extends CommentUiPose=CommentPose>(host:Host<Row,Pose>):{refresh:()=>void;dispose:()=>void;active:()=>boolean;draft:()=>boolean;hasPendingComment:()=>boolean;commitDraft:()=>Promise<boolean>}{
|
|
71
71
|
const readMark=(row:Row):CommentUiMark|null=>host.codec?host.codec.read(row):markOf(row as unknown as Feedback);
|
|
72
72
|
const toggle=host.toggle??document.getElementById('stage-comment') as HTMLButtonElement;if(!toggle)throw new Error('PARTS_WORKSPACE_NODE_REQUIRED: stage-comment');Object.assign(toggle.style,{whiteSpace:'nowrap',flex:'none'});
|
|
73
73
|
const inline=!!host.listHost;
|
|
@@ -80,13 +80,13 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
80
80
|
const refusalNote=document.createElement('small');refusalNote.id='stage-comment-refusal';refusalNote.setAttribute('role','status');refusalNote.hidden=true;Object.assign(refusalNote.style,{position:'absolute',width:'1px',height:'1px',overflow:'hidden',clipPath:'inset(50%)',whiteSpace:'nowrap'});toggle.after(refusalNote);toggle.setAttribute('aria-describedby',refusalNote.id);toggle.setAttribute('aria-controls',list.id);toggle.setAttribute('aria-expanded',String(inline));const originalTitle=toEn(toggle.title);
|
|
81
81
|
const updateRefusal=()=>{const raw=host.refusal?.()??null,reason=raw?t(raw):null,prev=refusalNote.textContent||'',nextTitle=reason??t(originalTitle);toggle.disabled=!!host.busy?.();toggle.setAttribute('aria-busy',String(toggle.disabled));if(toggle.title!==nextTitle)toggle.title=nextTitle;if(refusalNote.title!==(reason??''))refusalNote.title=reason??'';if(refusalNote.textContent!==(reason??''))refusalNote.textContent=reason??'';refusalNote.hidden=!reason;if(!list.hidden&&(reason??'')!==prev)renderList();return reason;};
|
|
82
82
|
const layers=new Map<StageComment['viewport'],HTMLDivElement>();for(const [key,pane]of Object.entries(host.viewports)){const layer=document.createElement('div');layer.className='stage-comment-layer';pane!.append(layer);layers.set(key as StageComment['viewport'],layer);}
|
|
83
|
-
let enabled=false,disposed=false,pending:{view:StageComment['viewport'];start:MarkPoint;end:MarkPoint;mode:string;id:number;interaction:number;settled:Promise<void>}|null=null,composer:HTMLFormElement|null=null,composerReadOnly=false,composerGeneral=false,syncComposerLang:(()=>void)|null=null,draftMark:{view:StageComment['viewport'];mode:string;screen:MarkRegion}|null=null,busy=false,last='',raf=0,interaction=0;
|
|
83
|
+
let enabled=false,disposed=false,pending:{view:StageComment['viewport'];start:MarkPoint;end:MarkPoint;mode:string;id:number;interaction:number;settled:Promise<void>}|null=null,composer:HTMLFormElement|null=null,composerField:HTMLInputElement|null=null,composerSubmit:(()=>Promise<boolean>)|null=null,composerReadOnly=false,composerGeneral=false,syncComposerLang:(()=>void)|null=null,draftMark:{view:StageComment['viewport'];mode:string;screen:MarkRegion}|null=null,busy=false,last='',raf=0,interaction=0;
|
|
84
84
|
let geometryEdit:{view:StageComment['viewport'];screen:MarkRegion;id?:string;update:(screen:MarkRegion)=>void;changed:boolean;camera:string}|null=null;
|
|
85
85
|
let geometryDrag:{id:number;start:MarkPoint;screen:MarkRegion;handle:string}|null=null;
|
|
86
86
|
let suppressPinClick=false;
|
|
87
87
|
let pinPress:{id:number;view:StageComment['viewport'];start:MarkPoint;pin:HTMLButtonElement}|null=null;
|
|
88
88
|
const setCapture=(value:boolean)=>{value=value&&host.hasPicture?.()!==false;enabled=value;toggle.setAttribute('aria-pressed',String(value||!inline&&!list.hidden));for(const pane of Object.values(host.viewports))pane!.classList.toggle('stage-comment-mode',value);};
|
|
89
|
-
const cancel=()=>{++interaction;const previous=pending??(geometryDrag&&geometryEdit?{view:geometryEdit.view,id:geometryDrag.id}:pinPress);geometryEdit=null;geometryDrag=null;pinPress=null;pending=null;if(previous){const pane=host.viewports[previous.view];if(pane?.hasPointerCapture(previous.id))pane.releasePointerCapture(previous.id);}composer?.remove();composer=null;composerReadOnly=false;composerGeneral=false;syncComposerLang=null;draftMark=null;last='';};
|
|
89
|
+
const cancel=()=>{++interaction;const hadComposer=!!composer,previous=pending??(geometryDrag&&geometryEdit?{view:geometryEdit.view,id:geometryDrag.id}:pinPress);geometryEdit=null;geometryDrag=null;pinPress=null;pending=null;if(previous){const pane=host.viewports[previous.view];if(pane?.hasPointerCapture(previous.id))pane.releasePointerCapture(previous.id);}composer?.remove();composer=null;composerField=null;composerSubmit=null;composerReadOnly=false;composerGeneral=false;syncComposerLang=null;draftMark=null;last='';if(hadComposer)host.draftChanged?.();};
|
|
90
90
|
const assertCapture=()=>{const reason=updateRefusal();if(reason){cancel();setCapture(false);host.error(reason);throw new Error(reason);}if(host.blocked())throw new Error(t('COMMENT_BUSY: wait for inspection'));};
|
|
91
91
|
const generalRefusal=()=>host.general?.refusal?.()??null;
|
|
92
92
|
const assertWritable=(reason:string|null)=>{if(reason){setCapture(false);host.error(reason);throw new Error(reason);}if(host.blocked())throw new Error(t('COMMENT_BUSY: wait for inspection'));};
|
|
@@ -135,7 +135,7 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
135
135
|
const openComment=async(f:Row)=>{const mark=readMark(f);if(!mark){if(host.general?.matches(f))openComposer(null,{x:0,y:0,width:0,height:0},f);return;}if(list.hidden)setOpen(true);if(list.hidden)return;if(await jump(f)){const reason=updateRefusal();setCapture(!reason&&!host.blocked());const pose=host.pose(mark.viewport),screen=host.codec?.geometry&&pose?region(projectMark(mark.world,pose.camera),projectMark({x:mark.world.x+mark.world.width,y:mark.world.y+mark.world.height},pose.camera)):mark.screen;openComposer(mark.viewport,screen,f,pose?.mode??mark.mode);}};
|
|
136
136
|
const renderList=()=>{placeList();list.setAttribute('aria-label',t('Comments'));list.replaceChildren();const title=document.createElement('strong');title.textContent=t('Comments');list.append(title);const rawReason=host.refusal?.()??null,reason=rawReason?t(rawReason):null;if(reason){const note=document.createElement('small');note.className='stage-comment-refusal-note';note.title=reason;note.textContent=reason;Object.assign(note.style,{display:'block',marginTop:'4px',maxWidth:'100%',whiteSpace:inline?'normal':'nowrap',overflow:'hidden',textOverflow:'ellipsis'});list.append(note);}if(host.general&&host.general.available?.()!==false){const add=document.createElement('button');add.type='button';add.textContent=t('Add general comment');add.dataset.commentGeneral='';add.onclick=()=>openComposer(null,{x:0,y:0,width:0,height:0});list.append(add);}const all=host.feedback().filter(f=>readMark(f)||host.general?.matches(f));if(host.general?.rows)all.push(...host.general.rows);toggle.textContent=t(host.busy?.()?'Comment · C ({0}) · Rendering':'Comment · C ({0})').replace('{0}',String(all.length));if(!all.length){const empty=document.createElement('p');empty.textContent=t(inline?'No comments yet.':reason?'Read only · Escape closes':'Mark a point or region, then type. Enter saves · Escape cancels.');list.append(empty);}for(const [i,f]of all.entries()){
|
|
137
137
|
const mark=readMark(f),row=document.createElement('div');row.className='stage-comment-item';row.dataset.commentId=f.id;
|
|
138
|
-
const go=document.createElement('button');go.type='button';go.className='stage-comment-summary';go.textContent=!mark?`${i+1} · ${t('General comment')} · ${f.summary}`:host.codec?`${i+1} · ${host.codec.label(f,mark)}`:`${i+1} · ${mark.mode.toUpperCase()} · ${mark.viewport.toUpperCase()} · ${mark.frame
|
|
138
|
+
const go=document.createElement('button');go.type='button';go.className='stage-comment-summary';go.textContent=!mark?`${i+1} · ${t('General comment')} · ${f.summary}`:host.codec?`${i+1} · ${host.codec.label(f,mark)}`:`${i+1} · ${mark.mode.toUpperCase()} · ${mark.viewport.toUpperCase()} · ${mark.frame?t(`F${mark.frame.index} (${mark.frame.basis})`):t(feedbackTimingLabel(f as unknown as Feedback))} · ${f.summary}`;go.onclick=()=>openComment(f);row.append(go);
|
|
139
139
|
if(host.locked(f.id)){const submitted=document.createElement('span');submitted.textContent=t('Submitted');row.append(submitted);}
|
|
140
140
|
list.append(row);
|
|
141
141
|
}};
|
|
@@ -150,7 +150,7 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
150
150
|
const locked=!!existing&&host.locked(existing.id),initialRefusal=existing?(general?generalRefusal():updateRefusal()):null;
|
|
151
151
|
if(existing&&!initialRefusal&&host.blocked()){host.error(t('COMMENT_BUSY: wait for inspection'));return;}
|
|
152
152
|
geometryEdit=null;composer?.remove();composerReadOnly=locked||!!initialRefusal||!generalAvailable;composerGeneral=general;draftMark=view?{view,mode:placementMode!,screen}:null;const generation=interaction;const pane=view?host.viewports[view]!:list,form=composer=document.createElement('form');form.className='stage-comment-composer stage-comment-ui';form.setAttribute('aria-label',t('Comment composer'));if(general)form.style.position='relative';
|
|
153
|
-
const field=document.createElement('input');field.type='text';field.maxLength=1000;field.setAttribute('aria-label',t('Comment text'));field.placeholder=t('Describe this spot…');field.value=existing?.summary??'';
|
|
153
|
+
const field=composerField=document.createElement('input');field.type='text';field.maxLength=1000;field.setAttribute('aria-label',t('Comment text'));field.placeholder=t('Describe this spot…');field.value=existing?.summary??'';field.oninput=()=>host.draftChanged?.();
|
|
154
154
|
if(composerReadOnly){field.readOnly=true;field.setAttribute('aria-readonly','true');}
|
|
155
155
|
const hint=document.createElement('small');hint.textContent=composerReadOnly?'Read only · Escape closes':'Enter saves · Escape cancels';hint.textContent=t(hint.textContent);const error=document.createElement('p');error.setAttribute('role','alert');form.append(field,hint,error);
|
|
156
156
|
const place=()=>{if(general)return;
|
|
@@ -250,7 +250,7 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
250
250
|
const chosen = new Set(selectedParts);
|
|
251
251
|
if (chosen.has(name)) chosen.delete(name);else chosen.add(name);
|
|
252
252
|
selectedParts = chipNames.filter(part => chosen.has(part));
|
|
253
|
-
syncChips();place();
|
|
253
|
+
syncChips();place();field.focus();
|
|
254
254
|
};
|
|
255
255
|
return chip;
|
|
256
256
|
}));
|
|
@@ -274,20 +274,19 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
274
274
|
prepared=crop(pose,screen);prepared.catch(()=>{});last='';place();
|
|
275
275
|
}};
|
|
276
276
|
}
|
|
277
|
-
|
|
278
|
-
form.onsubmit=async e=>{e.preventDefault();if(busy)return;if(generation!==interaction||view&&host.pose(view)&&host.pose(view!)?.mode!==placementMode){cancel();return;}const summary=field.value.trim();if(!summary){field.focus();return;}try{
|
|
277
|
+
const submitComposer=composerSubmit=async():Promise<boolean>=>{if(busy)return false;if(generation!==interaction||view&&host.pose(view)&&host.pose(view!)?.mode!==placementMode){cancel();return false;}const summary=field.value.trim();if(!summary){field.focus();return false;}try{
|
|
279
278
|
if(selectedParts && !selectedParts.length)throw new Error(t('Select at least one part.'));
|
|
280
279
|
if(existing){
|
|
281
280
|
assertEdit(general);if(host.locked(existing.id))throw new Error(t('COMMENT_SUBMITTED: submitted evidence is immutable'));
|
|
282
281
|
busy=true;field.disabled=true;syncChips();
|
|
283
282
|
if(!general&&host.codec?.update){
|
|
284
283
|
const geometry=geometryEdit?.changed&&pose?{pose,screen:{...screen},crop:(await prepared)!}:undefined;
|
|
285
|
-
if(disposed||generation!==interaction)return;assertEdit(general);
|
|
284
|
+
if(disposed||generation!==interaction)return false;assertEdit(general);
|
|
286
285
|
const replacement=await host.codec.update(copy(existing),summary,selectedParts?.slice(),geometry);
|
|
287
|
-
if(disposed||generation!==interaction)return;
|
|
286
|
+
if(disposed||generation!==interaction)return false;
|
|
288
287
|
assertEdit(general);if(host.locked(existing.id))throw new Error(t('COMMENT_SUBMITTED: submitted evidence is immutable'));
|
|
289
288
|
const all=host.feedback(),index=all.indexOf(existing);
|
|
290
|
-
if(index<0)return;
|
|
289
|
+
if(index<0)return false;
|
|
291
290
|
all.splice(index,1,replacement);
|
|
292
291
|
}else existing.summary=summary;
|
|
293
292
|
}else if(general){
|
|
@@ -296,22 +295,24 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
296
295
|
}else{
|
|
297
296
|
assertCapture();if(!pose||!host.codec&&!pose.frame&&!pose.timeBasis)throw new Error(t(pose?.frameReason??'COMMENT_FRAME_UNAVAILABLE: provide an explicit producer clock or a decoded reference frame index'));
|
|
298
297
|
busy=true;field.disabled=true;syncChips();
|
|
299
|
-
if(host.codec){const pixels=await prepared;if(disposed||generation!==interaction)return;assertCapture();const row=await host.codec.create(pose,view!,screen,pixels!,bookmark,summary,selectedParts?.slice());if(disposed||generation!==interaction)return;assertCapture();if(host.pose(view!)?.mode!==placementMode)return;host.add(row);}
|
|
298
|
+
if(host.codec){const pixels=await prepared;if(disposed||generation!==interaction)return false;assertCapture();const row=await host.codec.create(pose,view!,screen,pixels!,bookmark,summary,selectedParts?.slice());if(disposed||generation!==interaction)return false;assertCapture();if(host.pose(view!)?.mode!==placementMode)return false;host.add(row);}
|
|
300
299
|
else {const rigPose=pose as unknown as CommentPose;
|
|
301
300
|
const world=region(unprojectMark(screen,rigPose.camera),unprojectMark({x:screen.x+screen.width,y:screen.y+screen.height},rigPose.camera));
|
|
302
301
|
const slots=rigPose.posed?drawnSlots(rigPose.posed,world):[];
|
|
303
302
|
const comment:StageComment={schema:'rig-review-comment/1',mode:placementMode as StageComment['mode'],viewport:view!,frame:rigPose.frame,...(rigPose.timeBasis?{timeBasis:rigPose.timeBasis}:{}),time:rigPose.time,animation:rigPose.animation,sourceHash:rigPose.sourceHash,modelHash:rigPose.modelHash,referenceHash:rigPose.referenceHash,referenceId:rigPose.referenceId,camera:copy(rigPose.camera),screen,world,slots,crop:(await prepared)!,bookmark};
|
|
304
303
|
assertCapture();
|
|
305
|
-
if(disposed||generation!==interaction||host.pose(view!)?.mode!==placementMode)return;
|
|
304
|
+
if(disposed||generation!==interaction||host.pose(view!)?.mode!==placementMode)return false;
|
|
306
305
|
const n=rigPose.frame?.index??null;host.add({id:crypto.randomUUID(),frameStart:n,frameEnd:n,target:slots[0]?{kind:'slot',name:slots[0].slot}:{kind:'rig',name:rigPose.rig},category:'defect',summary,context:{animation:rigPose.animation,time:rigPose.time,frame:rigPose.frame?.basis==='producer'?n:null,...(turn?{turn:turn as any}:{}),interval:n===null?null:{frameStart:n,frameEnd:n,inclusive:true},comment:comment as any} } as unknown as Row,rigPose.side);
|
|
307
306
|
}
|
|
308
307
|
}
|
|
309
308
|
busy=true;field.disabled=true;syncChips();
|
|
310
309
|
await host.changed();
|
|
311
|
-
if(disposed||generation!==interaction)return;
|
|
312
|
-
cancel();refresh();revealLatest();
|
|
313
|
-
}catch(e){if(disposed||generation!==interaction)return;const
|
|
314
|
-
|
|
310
|
+
if(disposed||generation!==interaction)return false;
|
|
311
|
+
cancel();refresh();revealLatest();return true;
|
|
312
|
+
}catch(e){if(disposed||generation!==interaction)return false;const rawMsg=e instanceof Error?e.message:String(e),msg=/^PARTS_COMMENT_OUT_OF_BOUNDS:/.test(rawMsg)?'PARTS_COMMENT_OUT_OF_BOUNDS: region exceeds original image':/^JOB_[A-Z_]+$/.test(rawMsg)&&t('job.submit.'+rawMsg)!=='job.submit.'+rawMsg?'job.submit.'+rawMsg:rawMsg;errorSource=toEn(msg);error.textContent=t(errorSource);place();host.error(t(errorSource));field.disabled=false;field.focus();return false;}finally{busy=false;if(composer===form)syncChips();}};
|
|
313
|
+
form.onkeydown=e=>{if(e.key==='Escape'){e.preventDefault();e.stopPropagation();cancel();renderPins();pane.focus();}else if(e.key==='Enter'&&!e.isComposing&&!composerReadOnly){e.preventDefault();e.stopPropagation();void submitComposer();}};
|
|
314
|
+
form.onsubmit=e=>{e.preventDefault();return submitComposer();};
|
|
315
|
+
field.focus();last='';host.draftChanged?.();
|
|
315
316
|
};
|
|
316
317
|
const disposers:(()=>void)[]=[];
|
|
317
318
|
for(const [key,pane]of Object.entries(host.viewports)){
|
|
@@ -349,7 +350,7 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
349
350
|
}
|
|
350
351
|
if(!pending||pending.id!==e.pointerId)return;e.preventDefault();e.stopImmediatePropagation();pending.end=local(e);draftMark={view,mode:pending.mode,screen:region(pending.start,pending.end)};last='';};
|
|
351
352
|
const up=async(e:PointerEvent)=>{
|
|
352
|
-
if(geometryDrag?.id===e.pointerId){e.preventDefault();e.stopImmediatePropagation();geometryDrag=null;if(pane!.hasPointerCapture(e.pointerId))pane!.releasePointerCapture(e.pointerId);return;}
|
|
353
|
+
if(geometryDrag?.id===e.pointerId){e.preventDefault();e.stopImmediatePropagation();geometryDrag=null;if(pane!.hasPointerCapture(e.pointerId))pane!.releasePointerCapture(e.pointerId);if(composer&&!composerReadOnly)composerField?.focus();return;}
|
|
353
354
|
if(pinPress?.id===e.pointerId){e.preventDefault();e.stopImmediatePropagation();const pin=pinPress.pin;pinPress=null;if(pane!.hasPointerCapture(e.pointerId))pane!.releasePointerCapture(e.pointerId);pin.click();return;}
|
|
354
355
|
if(!pending||pending.id!==e.pointerId)return;e.preventDefault();e.stopImmediatePropagation();const p=pending;pending=null;if(pane!.hasPointerCapture(e.pointerId))pane!.releasePointerCapture(e.pointerId);try{await p.settled;assertCapture();if(disposed||interaction!==p.interaction||!enabled)return;const r=Math.hypot(p.end.x-p.start.x,p.end.y-p.start.y)<4?region(p.start,p.start):region(p.start,p.end);openComposer(view,r,undefined,p.mode);}catch(error){host.error(String(error));cancel();}};
|
|
355
356
|
const abort=(e:PointerEvent)=>{if(pending?.view===view&&pending.id===e.pointerId||geometryDrag?.id===e.pointerId||pinPress?.id===e.pointerId)cancel();};
|
|
@@ -358,7 +359,7 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
358
359
|
pane!.addEventListener('pointerdown',down,true);pane!.addEventListener('pointermove',move,true);pane!.addEventListener('pointerup',up,true);pane!.addEventListener('pointercancel',abort,true);pane!.addEventListener('lostpointercapture',abort,true);
|
|
359
360
|
disposers.push(()=>{pane!.removeEventListener('pointerdown',down,true);pane!.removeEventListener('pointermove',move,true);pane!.removeEventListener('pointerup',up,true);pane!.removeEventListener('pointercancel',abort,true);pane!.removeEventListener('lostpointercapture',abort,true);});
|
|
360
361
|
}
|
|
361
|
-
const key=(e:KeyboardEvent)=>{if(host.shortcutActive&&!host.shortcutActive())return;if(e.key==='Escape'&&(pending||composer||pinPress)){e.preventDefault();cancel();renderPins();return;}if(e.defaultPrevented||e.repeat||e.ctrlKey||e.metaKey||e.altKey||textEntryFocused(e.target)||host.shortcutBlocked?.())return;if(e.key.toLowerCase()==='c'){e.preventDefault();setOpen(inline?!enabled:list.hidden);}};
|
|
362
|
+
const key=(e:KeyboardEvent)=>{if(host.shortcutActive&&!host.shortcutActive())return;if(e.key==='Escape'&&(pending||composer||pinPress)){e.preventDefault();cancel();renderPins();return;}if(e.key==='Enter'&&!e.isComposing&&composer&&!composerReadOnly&&!busy&&!textEntryFocused(e.target)){e.preventDefault();void composerSubmit?.();return;}if(e.defaultPrevented||e.repeat||e.ctrlKey||e.metaKey||e.altKey||textEntryFocused(e.target)||host.shortcutBlocked?.())return;if(e.key.toLowerCase()==='c'){e.preventDefault();setOpen(inline?!enabled:list.hidden);}};
|
|
362
363
|
window.addEventListener('blur',cancel);window.addEventListener('resize',placeList);document.addEventListener('keydown',key);toggle.onclick=(e?:MouseEvent)=>{if(e?.detail)toggle.blur?.();setOpen(inline?!enabled:list.hidden);};
|
|
363
364
|
const ro=typeof ResizeObserver==='function'?new ResizeObserver(()=>{if(!disposed&&!list.hidden)placeList();}):null;if(ro){try{ro.observe(host.toolbar);if(workspace)ro.observe(workspace);}catch{}}
|
|
364
365
|
const renderPins=()=>{if(disposed)return;if(enabled&&host.hasPicture?.()===false){cancel();setCapture(false);}if(!list.hidden)placeList();const refusal=updateRefusal();if(refusal&&(enabled||pending||composer&&!composerReadOnly&&!composerGeneral)){cancel();setCapture(false);host.error(refusal);}const all=host.feedback().map(f=>({f,mark:readMark(f)})).filter(x=>x.mark);
|
|
@@ -395,5 +396,5 @@ export function bindStageComments<Row extends CommentRow=Feedback,Pose extends C
|
|
|
395
396
|
}}};
|
|
396
397
|
const paint=()=>{if(disposed)return;renderPins();raf=requestAnimationFrame(paint);};
|
|
397
398
|
const offLang=onLang(()=>{if(disposed)return;updateRefusal();renderList();syncComposerLang?.();last='';renderPins();});
|
|
398
|
-
refresh();paint();return {active:()=>enabled,draft:()=>!!pending||!!composer&&!composerReadOnly,refresh,dispose:()=>{disposed=true;ro?.disconnect();offLang();cancelAnimationFrame(raf);cancel();window.removeEventListener('blur',cancel);window.removeEventListener('resize',placeList);document.removeEventListener('keydown',key);for(const dispose of disposers)dispose();for(const layer of layers.values())layer.remove();toggle.onclick=null;list.remove();refusalNote.remove();}};
|
|
399
|
+
refresh();paint();return {active:()=>enabled,draft:()=>!!pending||!!composer&&!composerReadOnly,hasPendingComment:()=>!!composer&&!composerReadOnly&&!composerGeneral&&!!composerField?.value.trim(),commitDraft:async()=>composer&&!composerReadOnly&&composerSubmit?await composerSubmit():true,refresh,dispose:()=>{disposed=true;ro?.disconnect();offLang();cancelAnimationFrame(raf);cancel();window.removeEventListener('blur',cancel);window.removeEventListener('resize',placeList);document.removeEventListener('keydown',key);for(const dispose of disposers)dispose();for(const layer of layers.values())layer.remove();toggle.onclick=null;list.remove();refusalNote.remove();}};
|
|
399
400
|
}
|
package/web/styles.css
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
/* Density: 4px spacing; 32/24px controls. See DESIGN Style scale for geometry exceptions. */
|
|
2
2
|
/* Theme tokens: site values copied from rig-c.org styles.css (dark); light and --rv-* are review-local derivations. No literal colour outside these blocks. */
|
|
3
|
-
:root{--
|
|
4
|
-
:root[data-theme=light]{--
|
|
3
|
+
:root{--rv-region-a:#ff9f43;--rv-region-a-fill:rgba(255,159,67,.18);--rv-region-b:#4dd6ff;--rv-region-b-fill:rgba(77,214,255,.18);--font-sans:Inter,system-ui,sans-serif;--font-display:Inter,system-ui,sans-serif;--font-mono:"JetBrains Mono",ui-monospace,monospace;--radius:6px;--bg:#070b18;--fg:#c9d4e8;--fg-strong:#f3f6fc;--fg-muted:#7f8ba6;--border:#18213a;--border-strong:#2a3657;--hover-bg:#0f1730;--active-bg:#142042;--link:#7cc8ff;--link-hover:#b3e0ff;--btn-fg:#08101f;--code-bg:#050814;--code-fg:#d6e2f5;--code-border:#18213a;--code-inline-bg:#121a30;--footer-bg:#050813;--pass:#30d158;--warn:#ffcc00;--fail:#ff453a;--rv-bar:#0b1124;--rv-panel:#0d152b;--rv-raised:var(--code-inline-bg);--rv-control:var(--code-inline-bg);--rv-control-hover:var(--active-bg);--rv-field:var(--code-bg);--rv-segmented:var(--code-bg);--rv-pressed-bg:#133733;--rv-pressed-border:#207c44;--rv-pressed-fg:var(--fg-strong);--rv-focus:var(--link-hover);--rv-backdrop:rgba(7,11,24,.82);--rv-pane-lo:#070b18;--rv-pane-label-bg:rgba(7,11,24,.85);--rv-stage-fg:#aebbd4;--rv-grid-dot:rgba(127,139,166,.2);--rv-media-bg:#0b1020;--rv-scrollbar-thumb:#2a3657;--rv-scrollbar-thumb-hover:#3d4c74;--rv-scrollbar-track:transparent;--rv-separator:#1a2747;--rv-separator-hover:#3f7fb8;--rv-tick-inspected:#7cc8ff;--rv-tick-scratch:#ff9f43;--space-1:4px;--space-2:8px;--space-3:12px;--space-4:16px;--space-5:20px;--space-6:24px;--space-8:32px;--control-height:32px;--control-compact:24px;--font-size-meta:11px;--font-size-compact:12px;--font-size-body:13px;--font-size-title:14px;--font-size-headline:16px;--font-size-wordmark:18px;--radius-small:4px;--radius-panel:8px;--space-7:28px;--font-weight-regular:400;--font-weight-medium:500;--font-weight-emphasis:600}
|
|
4
|
+
:root[data-theme=light]{--rv-region-a:#ff9f43;--rv-region-a-fill:rgba(255,159,67,.18);--rv-region-b:#4dd6ff;--rv-region-b-fill:rgba(77,214,255,.18);--bg:#f5f7fb;--fg:#26324a;--fg-strong:#0c1324;--fg-muted:#5d6982;--border:#d5dcea;--border-strong:#b3bed3;--hover-bg:#e8edf6;--active-bg:#dbe3f3;--link:#1a6fc0;--link-hover:#0f528f;--btn-fg:#ffffff;--code-bg:#eef1f7;--code-fg:#1d2940;--code-border:#d5dcea;--code-inline-bg:#e3e8f2;--footer-bg:#eceff6;--pass:#1e8a3c;--warn:#8a6400;--fail:#b3261e;--rv-bar:#edf1f7;--rv-panel:#e9eef6;--rv-raised:var(--code-inline-bg);--rv-control:var(--code-inline-bg);--rv-control-hover:#d5ddec;--rv-field:#ffffff;--rv-segmented:var(--code-inline-bg);--rv-pressed-bg:#c9ded8;--rv-pressed-border:#6fb286;--rv-pressed-fg:var(--fg-strong);--rv-focus:var(--link);--rv-backdrop:rgba(12,19,36,.45);--rv-pane-lo:#070b18;--rv-pane-label-bg:rgba(7,11,24,.85);--rv-stage-fg:#aebbd4;--rv-grid-dot:rgba(127,139,166,.2);--rv-media-bg:#0b1020;--rv-scrollbar-thumb:#b3bed3;--rv-scrollbar-thumb-hover:#8e9bb5;--rv-scrollbar-track:transparent;--rv-separator:#c9d6ec;--rv-separator-hover:#5b93cf;--rv-tick-inspected:#1a6fc0;--rv-tick-scratch:#c25e00;--space-1:4px;--space-2:8px;--space-3:12px;--space-4:16px;--space-5:20px;--space-6:24px;--space-8:32px;--control-height:32px;--control-compact:24px;--font-size-meta:11px;--font-size-compact:12px;--font-size-body:13px;--font-size-title:14px;--font-size-headline:16px;--font-size-wordmark:18px;--radius-small:4px;--radius-panel:8px;--space-7:28px;--font-weight-regular:400;--font-weight-medium:500;--font-weight-emphasis:600}
|
|
5
5
|
:root{font-family:var(--font-sans);color:var(--fg);background:var(--bg);font-size:var(--font-size-body);color-scheme:dark;font-synthesis:none;font-weight:var(--font-weight-regular)}*{box-sizing:border-box}body{margin:0}button,input,select,textarea{font:inherit}button{color:inherit;background:var(--rv-control);border:1px solid var(--border-strong);border-radius:var(--radius);cursor:pointer;padding:0 var(--space-3);line-height:14px;height:var(--control-height)}button:hover{background:var(--rv-control-hover)}button:disabled{opacity:.45;cursor:default}button[aria-pressed=true]{background:var(--rv-pressed-bg);border-color:var(--rv-pressed-border);color:var(--rv-pressed-fg)}button.primary{background:var(--link);border-color:var(--link);color:var(--btn-fg);font-weight:var(--font-weight-emphasis)}button.outline{background:transparent}button.block{width:100%;margin-top:var(--space-3)}a{color:var(--link)}input,select,textarea{color:var(--fg);background:var(--rv-field);border:1px solid var(--border-strong);border-radius:var(--radius);padding:var(--space-2);max-width:100%}select,input[type=text],textarea{width:100%}textarea{resize:vertical;line-height:1.6}input[type=range]{accent-color:var(--link);padding:0;min-width:0}input[type=checkbox],input[type=radio]{accent-color:var(--link)}button:focus-visible,a:focus-visible,input:focus-visible,select:focus-visible,textarea:focus-visible{outline:2px solid var(--rv-focus);outline-offset:3px}[hidden]{display:none!important}.topbar{min-height:72px;display:flex;align-items:center;border-bottom:1px solid var(--border);flex-wrap:wrap;background:var(--rv-bar);padding:var(--space-4) var(--space-6);gap:var(--space-6)}.brand{white-space:nowrap;font-size:var(--font-size-wordmark);font-weight:var(--font-weight-medium);letter-spacing:0}.brand-mark{display:inline-grid;place-items:center;width:24px;height:24px;border:1px solid var(--link);color:var(--link);border-radius:50%;margin-right:var(--space-2);font-size:var(--font-size-title)}.topbar strong{font-weight:var(--font-weight-medium);font-size:var(--font-size-body)}.topbar #revision{margin-left:var(--space-2)}.top-actions{display:flex;align-items:center;gap:var(--space-2);margin-left:auto;flex-wrap:wrap}.subtle,.hint{color:var(--fg-muted);font-size:var(--font-size-meta)}.hint{line-height:1.6}.workspaces{display:flex;gap:var(--space-3);padding:0 var(--space-5);border-bottom:1px solid var(--border);background:var(--rv-bar)}.workspaces button{border:0;border-bottom:2px solid transparent;border-radius:0;background:transparent;font-size:var(--font-size-compact);letter-spacing:0;color:var(--fg);min-height:var(--control-height);height:var(--control-height);padding:0 var(--space-3)}.workspaces button[aria-pressed=true]{border-bottom-color:var(--link);color:var(--fg-strong);background:transparent}.workspaces button span{font-size:var(--font-size-meta);margin-left:var(--space-2);letter-spacing:0;color:var(--fg-muted)}.layout{display:grid;grid-template-columns:190px minmax(250px,1fr) 286px;min-height:calc(100vh - 160px)}aside{background:var(--rv-panel);padding:var(--space-5) var(--space-4)}.left-panel{border-right:1px solid var(--border);padding:var(--space-3)}.right-panel{border-left:1px solid var(--border)}.eyebrow{font-size:var(--font-size-meta);letter-spacing:0;color:var(--fg-muted);margin:0 0 var(--space-3)}.label{display:block;color:var(--fg-muted);font-size:var(--font-size-meta);margin:0 0 var(--space-2)}.space-top{margin-top:var(--space-4)}.left-panel section{margin-top:var(--space-7)}.tool{width:100%;display:flex;justify-content:space-between;align-items:center;text-align:left;gap:var(--space-1);border-color:transparent;background:transparent;padding:var(--space-2) var(--space-2);margin:var(--space-1) 0;height:auto;min-height:var(--control-height)}.tool small{font-size:var(--font-size-meta);color:var(--fg-muted)}.checkpoint{display:block;width:100%;background:transparent;border:1px solid transparent;text-align:left;margin:var(--space-1) 0;padding:var(--space-3) var(--space-2);white-space:normal;line-height:1.5;height:auto;min-height:var(--control-height)}.checkpoint[aria-current=true]{background:var(--rv-pressed-bg);border-color:var(--rv-pressed-border)}.checkpoint small{display:block;font-size:var(--font-size-meta);color:var(--fg-muted);margin-top:var(--space-1)}.source-link{display:block;font-size:var(--font-size-meta);overflow-wrap:anywhere;margin:var(--space-2) 0}main{min-width:0;display:flex;flex-direction:column;background:var(--bg)}.viewbar{display:flex;align-items:center;justify-content:space-between;flex-wrap:wrap;border-bottom:1px solid var(--border);padding:var(--space-2) var(--space-3);gap:var(--space-2)}.zoom-controls{display:flex;gap:var(--space-1);align-items:center}.zoom-controls button{font-size:var(--font-size-compact);height:var(--control-height);padding:0 var(--space-2)}.zoom-controls output{font:var(--font-size-meta) var(--font-mono);font-variant-numeric:tabular-nums;min-width:39px;text-align:center;color:var(--fg-muted)}.stages{display:flex;gap:var(--space-3);padding:var(--space-3) var(--space-3) 0;flex:1;min-height:460px}.stage-pane{position:relative;min-width:0;flex:1;border:1px solid var(--border-strong);border-radius:var(--radius-panel);overflow:hidden;background:var(--rv-pane-lo)}.pane-label{position:absolute;left:10px;top:10px;z-index:2;background:var(--rv-pane-label-bg);border-radius:var(--radius-small);padding:var(--space-1) var(--space-2);color:var(--rv-stage-fg);font-size:var(--font-size-meta);pointer-events:none}.viewport{position:relative;overflow:hidden;width:100%;height:100%;min-height:450px;touch-action:none;background-image:radial-gradient(var(--rv-grid-dot) .7px,transparent .7px);background-size:22px 22px}.empty{position:absolute;inset:65px 22px 30px;display:grid;place-items:center;text-align:center;color:var(--rv-stage-fg);font-size:var(--font-size-compact);line-height:1.8}.reference-content,#rig-root{position:absolute;transform-origin:0 0}.reference-content img,.reference-content video{display:block;max-width:none}.reference-content svg{display:block;max-width:none}.reference-content video{object-fit:contain}.stage-footer{display:flex;align-items:center;justify-content:space-between;gap:var(--space-3);flex-wrap:nowrap;height:30px;min-height:30px;max-height:30px;padding:0 var(--space-4);box-sizing:border-box;flex:none;overflow:hidden;color:var(--fg-muted);font-size:var(--font-size-meta)}.stage-footer>*{min-width:0;white-space:nowrap;overflow:hidden;text-overflow:ellipsis}.stage-footer>span:last-child{flex:none}.transport{display:flex;align-items:center;gap:var(--space-3);padding:var(--space-3);border-top:1px solid var(--border);background:var(--rv-panel)}.transport select{width:auto;max-width:150px;font-size:var(--font-size-meta)}.transport input{flex:1}.transport output{font:var(--font-size-meta) var(--font-mono);font-variant-numeric:tabular-nums;white-space:nowrap;color:var(--fg-muted)}#time-label{min-width:17ch;display:inline-block;text-align:right}.sound-panel,.angle-panel{padding:var(--space-4);border-top:1px solid var(--border);background:var(--rv-panel)}.row{display:flex;align-items:center;gap:var(--space-3);flex-wrap:wrap}.row .eyebrow{margin:0}.sound-panel .row{font-size:var(--font-size-meta);margin-bottom:var(--space-2)}.sound-panel input[type=range]{flex:1;max-width:160px}.cue{display:flex;gap:var(--space-2);align-items:center;justify-content:space-between;border-top:1px solid var(--border);padding:var(--space-2) 0;font-size:var(--font-size-meta);flex-wrap:wrap}.cue button{padding:0 var(--space-2);font-size:var(--font-size-meta);height:var(--control-compact)}.angle-panel{display:flex;gap:var(--space-3);align-items:center;flex-wrap:wrap;font-size:var(--font-size-meta)}.angle-panel select{width:auto;max-width:150px}.angle-panel .hint{width:100%;margin:0}.angle-panel input{flex:1}.divider{height:1px;background:var(--border-strong);margin:var(--space-6) 0}h1{font-size:var(--font-size-title);font-weight:var(--font-weight-medium);line-height:1.6;margin:0 0 var(--space-2)}.outcome{border:0;padding:0;margin:var(--space-5) 0 0;display:flex;gap:var(--space-3);flex-wrap:wrap}.outcome legend{font-size:var(--font-size-meta);color:var(--fg-muted);margin-bottom:var(--space-2);padding:0}.outcome label{display:flex;align-items:center;gap:var(--space-1);font-size:var(--font-size-meta)}.proposal-item{border-top:1px solid var(--border);padding:var(--space-3) 0;margin-top:var(--space-3);font-size:var(--font-size-meta);overflow-wrap:anywhere}.proposal-item strong{display:block;font-weight:var(--font-weight-medium);margin-bottom:var(--space-1)}.proposal-item button{font-size:var(--font-size-meta);padding:0 var(--space-2);margin-top:var(--space-2);height:var(--control-compact)}footer{display:flex;justify-content:space-between;align-items:center;flex-wrap:nowrap;height:40px;box-sizing:border-box;overflow:hidden;border-top:1px solid var(--border);background:var(--footer-bg);font-size:var(--font-size-meta);color:var(--fg);padding:0 var(--space-4);gap:var(--space-2) var(--space-4)}.error{color:var(--fail)!important}.dirty{color:var(--warn)!important}.sr-only{position:absolute;width:1px;height:1px;overflow:hidden;clip-path:inset(50%)}
|
|
6
6
|
@media(min-width:1500px){.layout{grid-template-columns:218px minmax(250px,1fr) 310px}.stages{min-height:600px}}
|
|
7
7
|
@media(max-width:1000px){.layout{grid-template-columns:158px minmax(250px,1fr) 250px}aside{padding:var(--space-4) var(--space-3)}.topbar{gap:var(--space-4)}.topbar #revision{display:block;margin-left:0}.stages{min-height:400px}.viewport{min-height:400px}.workspaces span{display:none}}
|
|
@@ -119,11 +119,12 @@ main{min-height:0;overflow:hidden;display:flex;flex-direction:column}
|
|
|
119
119
|
.workspace-drawer-triggers button{font-size:var(--font-size-meta);min-height:var(--control-compact);height:var(--control-compact);padding:0 var(--space-2)}
|
|
120
120
|
.workspace-drawer{position:fixed;inset:0;width:min(94vw,950px);height:min(92dvh,850px);max-width:94vw;max-height:92dvh;margin:auto;padding:var(--space-2);border:1px solid var(--border-strong);border-radius:var(--radius-panel);background:var(--rv-panel);color:inherit;overflow:hidden;z-index:20}
|
|
121
121
|
.workspace-drawer:not([open]){display:none}.workspace-drawer[open]{display:flex;flex-direction:column;gap:var(--space-2)}
|
|
122
|
+
.workspace-drawer[data-panel=inspectorHeight][open]:not(:modal){inset:auto 0 0;height:min(36dvh,360px);margin:0 auto}
|
|
122
123
|
.workspace-drawer::backdrop{background:var(--rv-backdrop)}
|
|
123
|
-
#job-record-asks
|
|
124
|
-
#job-record-asks
|
|
125
|
-
#job-record-asks
|
|
126
|
-
#job-record-asks
|
|
124
|
+
#job-record-asks{width:min(94vw,760px);height:fit-content;max-height:92dvh;gap:var(--space-1)}
|
|
125
|
+
#job-record-asks fieldset{min-width:0;margin:0;padding:0 var(--space-1) var(--space-1);border:0}
|
|
126
|
+
#job-record-asks fieldset>:first-child{margin-top:0}
|
|
127
|
+
#job-record-asks fieldset>button+button{margin-left:var(--space-2)}
|
|
127
128
|
.workspace-drawer-close{align-self:flex-end;flex:none}
|
|
128
129
|
.workspace-drawer>.left-panel{display:flex!important;flex-direction:column;flex:1;overflow:hidden;min-height:0;padding:0}
|
|
129
130
|
.workspace-drawer>.parts-explorer{display:flex;flex-direction:column;grid-template-columns:none;flex:1;width:auto;min-width:0;min-height:0;height:auto;overflow:hidden}
|
|
@@ -161,6 +162,7 @@ main{min-height:0;overflow:hidden;display:flex;flex-direction:column}
|
|
|
161
162
|
.view-menu>summary::after{content:'\25BE';color:var(--fg-muted)}
|
|
162
163
|
.view-menu>summary:hover{background:var(--rv-control-hover)}
|
|
163
164
|
.view-menu-list{position:absolute;right:0;top:calc(100% + 4px);z-index:12;display:flex;flex-direction:column;gap:var(--space-1);min-width:150px;padding:var(--space-1);background:var(--rv-panel);border:1px solid var(--border-strong);border-radius:var(--radius-panel)}
|
|
165
|
+
body:has(.workspace-drawer[data-panel=inspectorHeight][open]:not(:modal)) .view-menu-list{z-index:21}
|
|
164
166
|
.view-menu-list button{text-align:left;font-size:var(--font-size-meta);padding:0 var(--space-2);border-color:transparent;background:transparent;height:var(--control-compact)}
|
|
165
167
|
.view-menu-list button[aria-pressed=true]{background:var(--rv-pressed-bg);border-color:var(--rv-pressed-border);color:var(--rv-pressed-fg)}
|
|
166
168
|
.transport .idle-repeat{display:inline-flex;align-items:center;gap:var(--space-1);font-size:var(--font-size-meta);white-space:nowrap;flex:none}
|
|
@@ -407,7 +409,7 @@ footer.status-bar{display:grid;max-width:100vw;grid-template-columns:minmax(0,1f
|
|
|
407
409
|
#turn-pad-host>p{margin:0 var(--space-3) var(--space-2)}
|
|
408
410
|
|
|
409
411
|
/* Source-bound stage comments; the layer never intercepts ordinary inspection. */
|
|
410
|
-
main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{white-space:nowrap;flex:none}#stage-comment-refusal{position:absolute;width:1px;height:1px;overflow:hidden;clip-path:inset(50%);white-space:nowrap}.stage-comment-refusal-note{display:block;margin-top:var(--space-1);max-width:100%;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font-size:var(--font-size-meta);color:var(--fg-muted)}.stage-comment-mode{cursor:crosshair}.stage-comment-mode video{pointer-events:none}.stage-comment-layer{position:absolute;inset:0;pointer-events:none;z-index:20;overflow:hidden}.stage-comment-region{position:absolute;border:2px solid var(--link);pointer-events:none}.stage-comment-pin{position:absolute;transform:translate(-50%,-50%);border-radius:50%;background:var(--link);color:var(--btn-fg);pointer-events:auto;height:var(--control-compact);min-width:var(--control-compact);padding:0 var(--space-1);font-family:var(--font-mono);font-variant-numeric:tabular-nums}.stage-comment-composer{position:absolute;z-index:30;width:286px;max-width:calc(100% - 8px);max-height:calc(100% - 8px);overflow:auto;overflow-wrap:anywhere;padding:var(--space-3);background:var(--rv-panel);border:1px solid var(--link);border-radius:var(--radius);box-shadow:0 4px 20px var(--rv-backdrop)}.stage-comment-composer input{width:100%}.stage-comment-composer small{display:block;margin-top:var(--space-2);color:var(--fg-muted)}.stage-comment-composer p{color:var(--fail);margin:var(--space-1) 0}.stage-comment-list{position:absolute;position-anchor:--stage-comment-bar;z-index:40;right:8px;top:calc(anchor(bottom,50px) + 5px);width:310px;max-width:90%;max-height:60%;overflow:auto;background:var(--rv-panel);border:1px solid var(--border-strong);padding:var(--space-3);border-radius:var(--radius)}.stage-comment-item{padding:var(--space-2) 0;border-bottom:1px solid var(--border)}.stage-comment-item>button:first-child{display:block;width:100%;text-align:left;overflow-wrap:anywhere;font-variant-numeric:tabular-nums;height:auto;min-height:var(--control-height)}.stage-comment-item span{display:block;color:var(--fg-muted)}
|
|
412
|
+
main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{white-space:nowrap;flex:none}#stage-comment-refusal{position:absolute;width:1px;height:1px;overflow:hidden;clip-path:inset(50%);white-space:nowrap}.stage-comment-refusal-note{display:block;margin-top:var(--space-1);max-width:100%;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font-size:var(--font-size-meta);color:var(--fg-muted)}.stage-comment-mode{cursor:crosshair}.stage-comment-mode video{pointer-events:none}.stage-comment-layer{position:absolute;inset:0;pointer-events:none;z-index:20;overflow:hidden}.stage-comment-region{position:absolute;border:2px solid var(--link);pointer-events:none}.stage-comment-pin{position:absolute;transform:translate(-50%,-50%);border-radius:50%;background:var(--link);color:var(--btn-fg);pointer-events:auto;height:var(--control-compact);min-width:var(--control-compact);padding:0 var(--space-1);font-family:var(--font-mono);font-variant-numeric:tabular-nums}.stage-comment-pin:hover{background:var(--link)}.stage-comment-composer{position:absolute;z-index:30;width:286px;max-width:calc(100% - 8px);max-height:calc(100% - 8px);overflow:auto;overflow-wrap:anywhere;padding:var(--space-3);background:var(--rv-panel);border:1px solid var(--link);border-radius:var(--radius);box-shadow:0 4px 20px var(--rv-backdrop)}.stage-comment-composer input{width:100%}.stage-comment-composer small{display:block;margin-top:var(--space-2);color:var(--fg-muted)}.stage-comment-composer p{color:var(--fail);margin:var(--space-1) 0}.stage-comment-list{position:absolute;position-anchor:--stage-comment-bar;z-index:40;right:8px;top:calc(anchor(bottom,50px) + 5px);width:310px;max-width:90%;max-height:60%;overflow:auto;background:var(--rv-panel);border:1px solid var(--border-strong);padding:var(--space-3);border-radius:var(--radius)}.stage-comment-item{padding:var(--space-2) 0;border-bottom:1px solid var(--border)}.stage-comment-item>button:first-child{display:block;width:100%;text-align:left;overflow-wrap:anywhere;font-variant-numeric:tabular-nums;line-height:20px;height:auto;min-height:var(--control-height)}.stage-comment-item span{display:block;color:var(--fg-muted)}
|
|
411
413
|
:root:lang(ko){word-break:keep-all;overflow-wrap:break-word}
|
|
412
414
|
|
|
413
415
|
.topbar,.pv-top{flex-wrap:wrap}
|
|
@@ -417,46 +419,28 @@ main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{w
|
|
|
417
419
|
#direction-authored-body{display:none;flex:1;min-height:0;overflow:auto;white-space:pre-wrap;overflow-wrap:anywhere;margin:0;padding:var(--space-2)}
|
|
418
420
|
#direction-panel[open]:not([hidden]):has(#direction-authored-keys[open]:not([hidden])) + #direction-authored-body{display:block}
|
|
419
421
|
#direction-panel[open]:not([hidden]):has(#direction-authored-keys[open]:not([hidden])) + #direction-authored-body ~ #stage-layout{display:none}
|
|
420
|
-
/* Create step 2: the interview modal over the one review screen (#708); the workspace drawer dialog. */
|
|
421
|
-
.interview-modal{width:min(96vw,1400px);height:min(92dvh,900px);max-width:96vw}
|
|
422
|
-
.interview-modal-body{flex:1;min-height:0;overflow:auto;padding:0 var(--space-1) var(--space-2)}
|
|
423
|
-
.interview-modal h2{font-size:var(--font-size-title);font-weight:var(--font-weight-emphasis);margin:0}
|
|
424
|
-
.interview-modal .workspace-drawer-header{display:flex;align-items:center;justify-content:space-between;gap:var(--space-3)}
|
|
425
422
|
.interview-grid{display:grid;grid-template-columns:minmax(10rem,.55fr) minmax(0,1.6fr) minmax(22rem,1.25fr);gap:var(--space-3);align-items:start}
|
|
426
423
|
.interview-grid>*{min-width:0}
|
|
427
|
-
.interview-grid>
|
|
428
|
-
.interview-grid>aside{position:sticky;top:0}
|
|
429
|
-
.interview-view{display:flex;flex-direction:column;gap:var(--space-2);margin-top:var(--space-3)}.interview-view .zoom-controls{flex-wrap:wrap}.interview-viewport{position:relative;overflow:hidden;height:min(66dvh,640px);min-height:320px;touch-action:none;border:1px solid var(--border);border-radius:var(--radius);background:var(--rv-media-bg);background-image:radial-gradient(var(--rv-grid-dot) .7px,transparent .7px);background-size:22px 22px}.interview-view-root{position:absolute;transform-origin:0 0}.interview-view-root canvas{display:block}
|
|
424
|
+
.interview-grid>nav{background:var(--rv-raised);border:1px solid var(--border-strong);border-radius:var(--radius-panel);padding:var(--space-3)}
|
|
430
425
|
.interview-questions>p{margin:0 0 var(--space-2);color:var(--fg-muted);font-size:var(--font-size-meta)}
|
|
431
426
|
.interview-questions ol{list-style:none;margin:0;padding:0;display:grid;gap:var(--space-1)}
|
|
432
427
|
.interview-question{width:100%;text-align:left;white-space:normal;overflow-wrap:anywhere;line-height:1.5;background:transparent;border-color:var(--border);height:auto;min-height:var(--control-height)}
|
|
433
428
|
.interview-question[aria-current=true]{background:var(--rv-pressed-bg);border-color:var(--rv-pressed-border);color:var(--rv-pressed-fg)}
|
|
434
429
|
.interview-question[data-answered]::before{content:"\2713 ";color:var(--pass)}
|
|
435
430
|
.interview-question:disabled{opacity:1;cursor:default}
|
|
436
|
-
.interview-modal fieldset{border:0;padding:0;margin:0;min-width:0}
|
|
437
|
-
.interview-modal fieldset.interview-ask{border-top:1px solid var(--border-strong);padding-top:var(--space-2);margin:var(--space-3) 0}
|
|
438
|
-
.interview-modal legend{font-weight:var(--font-weight-emphasis);padding:0;margin-bottom:var(--space-2)}
|
|
439
|
-
.interview-modal legend,.interview-option span,.interview-option strong{white-space:pre-wrap;overflow-wrap:anywhere}
|
|
440
431
|
.interview-option{display:grid;grid-template-columns:min-content 1fr;background:var(--rv-panel);border:1px solid var(--border);border-radius:var(--radius);cursor:pointer;padding:var(--space-1) var(--space-3);margin:var(--space-1) 0;gap:var(--space-1) var(--space-2)}
|
|
441
432
|
.interview-option:has(input:checked){border-color:var(--rv-pressed-border);background:var(--rv-pressed-bg)}
|
|
442
433
|
.interview-option span,.interview-option b{grid-column:2}
|
|
443
434
|
.interview-option span{color:var(--fg)}
|
|
435
|
+
.interview-option :is(span,strong){white-space:pre-wrap;overflow-wrap:anywhere}
|
|
444
436
|
.interview-option b.interview-recommended{justify-self:start;font-size:var(--font-size-meta);border-radius:var(--radius-small);color:var(--link);background:transparent;border:1px solid var(--border-strong);padding:0 var(--space-1);font-weight:var(--font-weight-medium)}
|
|
445
|
-
.interview-modal textarea:not([hidden]){display:block;width:100%;min-height:4rem;margin:var(--space-2) 0 var(--space-3)}
|
|
446
|
-
.interview-modal label:not(.interview-option){display:block;margin-top:var(--space-2)}
|
|
447
437
|
.interview-pending{color:var(--warn);font-size:var(--font-size-meta)}
|
|
448
|
-
.interview-modal code,.interview-binding{overflow-wrap:anywhere;font:var(--font-size-meta) var(--font-mono);color:var(--fg-muted)}
|
|
449
|
-
.interview-modal form>code{display:block;margin-bottom:var(--space-3)}
|
|
450
|
-
.interview-modal pre{white-space:pre-wrap;overflow-wrap:anywhere}
|
|
451
|
-
.interview-modal details{margin-block:var(--space-3)}
|
|
452
|
-
.interview-modal form button[type=submit]{margin-top:var(--space-3)}
|
|
453
438
|
.interview-app>header{display:flex;flex-wrap:wrap;align-items:center;gap:var(--space-4);padding:var(--space-3) var(--space-5);background:var(--rv-bar);border-bottom:1px solid var(--border)}
|
|
454
439
|
.interview-app>header h1{margin:0}
|
|
455
440
|
.interview-app>header select{width:auto;margin-inline-start:auto}
|
|
456
441
|
.job-forms>[data-job-interview-open]{margin:var(--space-2) 0}
|
|
457
442
|
@media (max-width:65rem){
|
|
458
443
|
.interview-grid{grid-template-columns:minmax(0,1fr)}
|
|
459
|
-
.interview-grid>aside{position:static}
|
|
460
444
|
}
|
|
461
445
|
|
|
462
446
|
/* Persistent job inspection uses the canonical pair and camera controls. */
|
|
@@ -469,8 +453,8 @@ main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{w
|
|
|
469
453
|
.workspace-main-toolbar #play{font-size:var(--font-size-compact);line-height:1;flex:none;width:var(--control-height);height:var(--control-height);padding:0}
|
|
470
454
|
.workspace-secondary-toolbar>label{display:inline-flex;align-items:center;gap:var(--space-2);font-size:var(--font-size-meta);line-height:1.5}
|
|
471
455
|
.workspace-secondary-toolbar>label input[type=checkbox]{margin:0}
|
|
472
|
-
#parts-difference-operand-label{max-width:100
|
|
473
|
-
#parts-difference-operand{width:
|
|
456
|
+
#parts-difference-operand-label{flex:1 1 0;min-width:9.5rem;max-width:100%;gap:var(--space-1)}
|
|
457
|
+
#parts-difference-operand{flex:1 1 0;width:0;min-width:6.5rem;max-width:max-content;padding-inline:var(--space-1);overflow:hidden;text-overflow:ellipsis;white-space:nowrap}
|
|
474
458
|
.workspace-main-toolbar .zoom-controls{padding-right:var(--space-1)}
|
|
475
459
|
.workspace-bottom-tabs{display:flex;align-items:center;gap:var(--space-1);flex-wrap:nowrap}
|
|
476
460
|
.workspace-bottom-tabs [aria-selected=true]{background:var(--rv-pressed-bg);border-color:var(--rv-pressed-border)}
|
|
@@ -522,14 +506,8 @@ main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{w
|
|
|
522
506
|
.parts-explorer li:has([data-pv-visible]){display:flex;align-items:center;gap:var(--space-1)}
|
|
523
507
|
.parts-explorer li:has([data-pv-visible]) button{flex:1;min-width:0}
|
|
524
508
|
|
|
525
|
-
/* Reuse the interview panel's approved question list | image | survey layout. */
|
|
526
509
|
.interview-answer.interview-grid{display:grid;flex:1;min-height:0;grid-template-columns:minmax(9rem,.5fr) minmax(0,1.5fr) minmax(24rem,1.25fr);grid-template-rows:minmax(0,1fr) auto;align-items:stretch;overflow:hidden}
|
|
527
510
|
.interview-answer>.interview-questions{grid-column:1;grid-row:1;overflow:auto}
|
|
528
|
-
.interview-answer>.interview-art{grid-column:2;grid-row:1;display:flex;flex-direction:column;position:static;min-height:0;padding:var(--space-2)}
|
|
529
|
-
.interview-art>.interview-view{display:grid;flex:1;min-height:0;grid-template-rows:auto minmax(100px,1fr) 5px var(--interview-answer-height,120px);gap:0;margin:0}
|
|
530
|
-
.interview-answer .interview-viewport{height:auto;min-height:100px;grid-row:2}
|
|
531
|
-
.interview-answer .zoom-controls{grid-row:1;padding-bottom:var(--space-2)}
|
|
532
|
-
.interview-answer .interview-bottom-resize{grid-row:3}
|
|
533
511
|
.interview-image-context{grid-row:4;overflow:auto;min-height:0;padding:var(--space-2)}
|
|
534
512
|
.interview-answer-fields{grid-column:3;grid-row:1;min-height:0;overflow:auto;border:0;padding:0 var(--space-1)!important}
|
|
535
513
|
.interview-answer-fields>h3{margin:var(--space-1) 0}
|
|
@@ -542,9 +520,8 @@ main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{w
|
|
|
542
520
|
.interview-answer>p[role=status]{grid-column:1 / -1;grid-row:2;margin:var(--space-1)}
|
|
543
521
|
.interview-delegate{justify-self:start;font-size:var(--font-size-meta);color:var(--fg-muted)}
|
|
544
522
|
@media(max-width:65rem){
|
|
545
|
-
.interview-answer.interview-grid{grid-template-columns:minmax(0,1fr);grid-template-rows:auto
|
|
523
|
+
.interview-answer.interview-grid{grid-template-columns:minmax(0,1fr);grid-template-rows:auto auto auto;overflow:auto}
|
|
546
524
|
.interview-answer>.interview-questions{grid-column:1;grid-row:1}
|
|
547
|
-
.interview-answer>.interview-art{grid-column:1;grid-row:2}
|
|
548
525
|
.interview-answer-fields{grid-column:1;grid-row:3;overflow:visible}
|
|
549
526
|
.interview-answer>p[role=status]{grid-column:1;grid-row:4}
|
|
550
527
|
}
|
|
@@ -582,7 +559,7 @@ main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{w
|
|
|
582
559
|
#app:has(>.workspace-act-row)>.status-bar{grid-row:4}
|
|
583
560
|
.workspace-act-row .workspace-act-bar{margin:0;width:100%;min-height:var(--control-height);flex-wrap:nowrap;gap:var(--space-3)}
|
|
584
561
|
.workspace-act-row #workspace-ask-headline{flex:1 1 0;min-width:0;font-size:var(--font-size-headline);font-weight:var(--font-weight-medium);font-variant-numeric:tabular-nums;color:var(--fg-strong);white-space:normal;overflow:visible;text-overflow:clip;overflow-wrap:anywhere}
|
|
585
|
-
.workspace-act-row #workspace-pending-ask{order:2;flex:none}
|
|
562
|
+
.workspace-act-row :is(#workspace-pending-ask,#workspace-pending-record-ask){order:2;flex:none}
|
|
586
563
|
.workspace-act-row .review-dialog-actions{min-width:0;gap:var(--space-2);justify-content:flex-end}
|
|
587
564
|
.workspace-act-row .review-message:not(.error){display:none}
|
|
588
565
|
.workspace-act-row .review-message.error{max-width:none;white-space:normal;overflow:visible;text-overflow:clip;overflow-wrap:anywhere}
|
|
@@ -595,22 +572,17 @@ main{position:relative}.toolbar{anchor-name:--stage-comment-bar}#stage-comment{w
|
|
|
595
572
|
.workspace-act-row .workspace-act-bar:has(.review-draft-state[data-save-state=failed]) #save{grid-column:3;grid-row:1;justify-self:end}
|
|
596
573
|
.workspace-act-row .workspace-act-bar:has(.review-draft-state[data-save-state=failed]) #request-changes{grid-column:4;grid-row:1;justify-self:end}
|
|
597
574
|
|
|
598
|
-
/*
|
|
575
|
+
/* Interview forms share the workspace bottom panel. */
|
|
599
576
|
.workspace-interview-panel{flex:1;min-height:0;overflow:auto;padding:var(--space-3) var(--space-4)}
|
|
600
577
|
.workspace-interview-panel>.interview-answer{grid-template-columns:minmax(9rem,.4fr) minmax(0,1fr);grid-template-rows:auto auto;overflow:visible}
|
|
601
578
|
.workspace-interview-panel .interview-answer-fields{grid-column:2;grid-row:1;overflow:visible}
|
|
602
579
|
.workspace-interview-panel .interview-questions{position:static}
|
|
603
580
|
.workspace-interview-panel .interview-answer>p[role=status]{grid-column:1/-1;grid-row:2}
|
|
604
|
-
|
|
605
|
-
|
|
606
|
-
|
|
607
|
-
|
|
608
|
-
|
|
609
|
-
#job-record-asks:not(:has(.interview-view)) .interview-answer{display:flex;flex-direction:column;gap:var(--space-2);overflow:auto}
|
|
610
|
-
#job-record-asks:not(:has(.interview-view)) .interview-answer>*{flex:none;overflow:visible}
|
|
611
|
-
#job-record-asks:not(:has(.interview-view)) .interview-questions{padding:0 var(--space-1)}
|
|
612
|
-
#job-record-asks:not(:has(.interview-view)) .interview-image-context{border-top:1px solid var(--border-strong);padding:var(--space-2) 0 0;margin-top:var(--space-2)}
|
|
613
|
-
#job-record-asks:not(:has(.interview-view)) .interview-image-context p{margin:var(--space-1) 0}
|
|
581
|
+
.workspace-interview-panel .interview-ask{border:0;border-top:1px solid var(--border-strong);padding-inline:0}
|
|
582
|
+
.workspace-interview-panel .interview-ask>legend{font-weight:var(--font-weight-emphasis);padding:0;margin-bottom:var(--space-2);white-space:pre-wrap;overflow-wrap:anywhere}
|
|
583
|
+
.workspace-interview-panel .interview-image-context{overflow-wrap:anywhere;font-size:var(--font-size-meta);color:var(--fg-muted)}
|
|
584
|
+
.workspace-interview-panel .interview-image-context h2{font-size:var(--font-size-title);font-weight:var(--font-weight-emphasis);margin:0 0 var(--space-2)}
|
|
585
|
+
.workspace-interview-panel .interview-image-context code{font:var(--font-size-meta) var(--font-mono)}
|
|
614
586
|
|
|
615
587
|
|
|
616
588
|
/* Shared density primitives; native toggles and ranges keep their platform geometry. */
|
package/web/workspace-layout.ts
CHANGED
|
@@ -64,14 +64,14 @@ export function bindWorkspaceSeparator(options:WorkspaceSeparatorOptions):{refre
|
|
|
64
64
|
element.style.touchAction='none';element.addEventListener('pointerdown',down);element.addEventListener('pointermove',move);element.addEventListener('pointerup',up);element.addEventListener('pointercancel',cancel);element.addEventListener('lostpointercapture',cancel);element.addEventListener('keydown',key);events?.addEventListener('blur',blur);refresh();
|
|
65
65
|
return {refresh,dispose(){if(disposed)return;release(true);disposed=true;element.removeEventListener('pointerdown',down);element.removeEventListener('pointermove',move);element.removeEventListener('pointerup',up);element.removeEventListener('pointercancel',cancel);element.removeEventListener('lostpointercapture',cancel);element.removeEventListener('keydown',key);events?.removeEventListener('blur',blur);element.style.touchAction=touchAction;element.tabIndex=tabIndex;for(const [key,value]of saved)if(value===null)element.removeAttribute(key);else element.setAttribute(key,value);}};
|
|
66
66
|
}
|
|
67
|
-
/** Use
|
|
67
|
+
/** Use the native drawer, with modal focus containment unless the workspace stays interactive.
|
|
68
68
|
* The trigger remains outside the collapsed panel; closing returns focus to that trigger. */
|
|
69
|
-
export function bindWorkspaceDrawer(options:{trigger:HTMLButtonElement;drawer:HTMLDialogElement;label:string;close?:HTMLButtonElement}):()=>void {
|
|
69
|
+
export function bindWorkspaceDrawer(options:{trigger:HTMLButtonElement;drawer:HTMLDialogElement;label:string;close?:HTMLButtonElement;modal?:()=>boolean}):()=>void {
|
|
70
70
|
const {trigger,drawer}=options;if(!drawer.id||!options.label)throw new Error('WORKSPACE_DRAWER: named dialog and trigger required');let opened=false;
|
|
71
71
|
trigger.setAttribute('aria-haspopup','dialog');trigger.setAttribute('aria-controls',drawer.id);trigger.setAttribute('aria-expanded',String(drawer.open));if(!drawer.getAttribute('aria-label')&&!drawer.getAttribute('aria-labelledby'))drawer.setAttribute('aria-label',options.label);
|
|
72
|
-
const close=()=>{if(drawer.open)drawer.close();closed();};const toggle=()=>{if(drawer.open){close();return;}drawer.showModal();opened=true;trigger.setAttribute('aria-expanded','true');};const closed=()=>{trigger.setAttribute('aria-expanded','false');if(opened){opened=false;trigger.focus({preventScroll:true});}};
|
|
72
|
+
const close=()=>{if(drawer.open)drawer.close();closed();};const toggle=()=>{if(drawer.open){close();return;}if(options.modal?.()===false)drawer.show();else drawer.showModal();opened=true;trigger.setAttribute('aria-expanded','true');};const closed=()=>{if(drawer.open)return;trigger.setAttribute('aria-expanded','false');if(opened){opened=false;trigger.focus({preventScroll:true});}};
|
|
73
73
|
trigger.addEventListener('click',toggle);drawer.addEventListener('close',closed);options.close?.addEventListener('click',close);
|
|
74
|
-
return ()=>{if(opened)close();trigger.removeEventListener('click',toggle);drawer.removeEventListener('close',closed);options.close?.removeEventListener('click',close);};
|
|
74
|
+
return ()=>{if(opened)close();trigger.removeEventListener('click',toggle);for(const attr of ['aria-haspopup','aria-controls','aria-expanded'])trigger.removeAttribute(attr);drawer.removeEventListener('close',closed);options.close?.removeEventListener('click',close);};
|
|
75
75
|
}
|
|
76
76
|
export const inspectorTabs=['view','rig','playback','feedback'] as const;
|
|
77
77
|
export type InspectorTab=typeof inspectorTabs[number];
|