@rig-c/review 4.1.0 → 4.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -140,9 +140,9 @@ export type ViewControlsOptions = {layout:'rigStep1';viewSwitch:ViewSwitchConfig
140
140
  /** One creation site for each common control; hosts retain adjacent tools and camera/event binding. */
141
141
  export function createViewControls(options:ViewControlsOptions) {
142
142
  const rig=options.layout==='rigStep1',compare=options.layout==='legacyCompareStep3';
143
- const zoomIn=actionButton(compare?'+':t(rig?'Zoom in':'job.zoomIn'),null);zoomIn.id='zoom-in';
144
- const zoomOut=actionButton(compare?'−':t(rig?'Zoom out':'job.zoomOut'),null);zoomOut.id='zoom-out';
145
- const fit=actionButton(t(compare?'Fit synchronized views':'Fit'),null);fit.id='fit';
143
+ const zoomIn=actionButton(t(rig||compare?'Zoom in':'job.zoomIn'),null);zoomIn.id='zoom-in';
144
+ const zoomOut=actionButton(t(rig||compare?'Zoom out':'job.zoomOut'),null);zoomOut.id='zoom-out';
145
+ const fit=actionButton(t('Fit'),null);fit.id='fit';
146
146
  const value=panelMake(rig||compare?'output':'span',{id:compare?'zoom-label':'zoom-value',textContent:rig||compare?'100%':''});
147
147
  const sync=panelMake('input',{id:'camera-sync',type:'checkbox'});
148
148
  const syncLabel=labelledControl(t('Sync cameras'),sync,true);
@@ -200,7 +200,7 @@ export function createViewControls(options:ViewControlsOptions) {
200
200
  if(rig){
201
201
  viewSwitch=panelMake('details',{id:'view-menu',className:'view-menu'});configure(options.viewSwitch);
202
202
  zoomGroup!.append(zoomIn,zoomOut,fit,nativeOne!,viewSwitch,value);
203
- }else if(compare)zoomGroup!.append(syncLabel,zoomOut,value,zoomIn,fit);
203
+ }else if(compare)zoomGroup!.append(syncLabel,zoomIn,zoomOut,fit,value);
204
204
  return {zoomButtons,zoomGroup,syncLabel,value,nativeOne,viewSwitch,get viewModeIds(){return [...modes.keys()];},setMode,setDisabled,replaceViewSwitch};
205
205
  }
206
206
 
@@ -1,7 +1,7 @@
1
1
  /** Browser workspace presentation. Source selection, player clocks and review decisions stay with the page. */
2
2
  import {WorkspacePreferenceStore,panelBounds,type WorkspaceLanguage,type WorkspacePanels,type WorkspacePreferences,type WorkspaceTheme} from './workspace-preferences.ts';
3
3
  import {allocateWorkspaceLayout,bindWorkspaceSeparator,bindWorkspaceDrawer,defaultWorkspaceColumns,InspectorScrollMemory,inspectorTabs,workspaceMinimums,type InspectorTab,type WorkspaceColumns,type WorkspacePanel,type SeparatorRange} from './workspace-layout.ts';
4
- import {bindDomI18n,getLinkLanguage,setLanguagePreference,setLinkLanguage,tr,onLanguageChange} from './i18n.ts';
4
+ import {bindDomI18n,getLinkLanguage,resolveLanguage,setLanguagePreference,setLinkLanguage,tr,onLanguageChange} from './i18n.ts';
5
5
  import {panelMake,actionButton,labelledControl} from './view-controls.ts';
6
6
 
7
7
  /** Header availability belongs to the shared shell, independently of the removed step chips. */
@@ -89,11 +89,12 @@ export function mountWorkspaceShell(options:WorkspaceHeaderOptions):WorkspaceHea
89
89
  if(!parts){
90
90
  language=panelMake('select');
91
91
  if(settingsLanguage){language.id='settings-language';language.dataset.appPreference='';}
92
- for(const value of settingsLanguage?['system','en','ko']:['en','ko']){
93
- const text=settingsLanguage?(value==='system'?'System':value==='en'?'English':'한국어'):interview?(value==='en'?'English':'한국어'):'';
92
+ for(const value of ['en','ko']){
93
+ // Owner ruling #873: the top-bar choice is En or Kr, with no System option.
94
+ const text=settingsLanguage?(value==='en'?'En':'Kr'):interview?(value==='en'?'English':'한국어'):'';
94
95
  language.append(panelMake('option',{value,textContent:text}));
95
96
  }
96
- if(settingsLanguage){languageLabel=labelledControl('Language ',language);if(rig)header.append(languageLabel);}
97
+ if(settingsLanguage){if(rig){language.setAttribute('aria-label','Language');header.append(language);}else languageLabel=labelledControl('Language ',language);}
97
98
  else{if(interview)header.append('\n ');header.append(language);if(interview)header.append('\n ');}
98
99
  }
99
100
  if(options.embedded){if(rig||parts)header.hidden=true;else if(interview)language!.hidden=true;}
@@ -153,6 +154,7 @@ export function bindWorkspaceUI(options:{root?:HTMLElement;regions?:WorkspaceReg
153
154
  if(!sharedLanguage.closest('header'))settingsBody.firstElementChild!.after(sharedLanguage.parentElement!);
154
155
  sourceList.append(settings);
155
156
  const theme=require<HTMLSelectElement>('settings-theme'),language=sharedLanguage,sync=require<HTMLInputElement>('settings-sync'),idle=require<HTMLInputElement>('settings-idle'),status=require('settings-state');
157
+ let languageMigrated=false;
156
158
  const store=new WorkspacePreferenceStore({onStatus:value=>{status.textContent=tr(value.detail);}});let desired={...store.get().panels};
157
159
  const stack=document.createElement('div');stack.className='workspace-stage-stack';for(const child of [...main.children])if(child!==inspector)stack.append(child);main.prepend(stack);
158
160
  const triggers=document.createElement('div');triggers.className='workspace-drawer-triggers';triggers.setAttribute('aria-label','Workspace panels');stack.prepend(triggers);
@@ -215,7 +217,11 @@ export function bindWorkspaceUI(options:{root?:HTMLElement;regions?:WorkspaceReg
215
217
  layout.dataset.stageMinimum=String(effective.stageMinimumSatisfied);for(const binding of bindings)binding.refresh();options.changed();restore();
216
218
  }finally{applying=false;}
217
219
  }
218
- const renderSettings=()=>{const value=store.get();setLanguagePreference(value.language);settingsToggle.setAttribute('aria-expanded',String(!value.settingsCollapsed));settingsBody.hidden=value.settingsCollapsed;settings.dataset.collapsed=String(value.settingsCollapsed);theme.value=options.currentTheme?.()??value.theme;language.value=getLinkLanguage()??value.language;sync.checked=value.defaultCameraSync;idle.checked=value.defaultIdleRepeat;status.textContent=tr(store.status().detail);};
220
+ const renderSettings=()=>{const value=store.get();
221
+ // A stored or default 'system' becomes the browser's language once (ko → ko, else en) and is kept (#873).
222
+ const shown=value.language==='system'?resolveLanguage('system'):value.language;
223
+ if(value.language==='system'&&!languageMigrated){languageMigrated=true;store.update({language:shown});}
224
+ setLanguagePreference(shown);settingsToggle.setAttribute('aria-expanded',String(!value.settingsCollapsed));settingsBody.hidden=value.settingsCollapsed;settings.dataset.collapsed=String(value.settingsCollapsed);theme.value=options.currentTheme?.()??value.theme;language.value=getLinkLanguage()??shown;sync.checked=value.defaultCameraSync;idle.checked=value.defaultIdleRepeat;status.textContent=tr(store.status().detail);};
219
225
  const revealInspector=()=>{
220
226
  if(bottom&&collapsed){collapsed=false;try{localStorage.setItem(bottomCollapseKey,'false');}catch{}apply();}
221
227
  if(effective.inspectorMode==='drawer'&&!dialogs.inspectorHeight.open){for(const dialog of Object.values(dialogs))if(dialog.open)dialog.close();buttons.inspectorHeight.click();if(bottom)apply();}