@rig-c/review 0.24.1 → 0.25.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -1
- package/docs/DESIGN.md +1 -1
- package/docs/PANELS.md +20 -5
- package/docs/REVIEW_PACKAGE.md +3 -3
- package/docs/WORKFLOWS.md +1 -1
- package/package.json +1 -1
- package/skills/rig-review/SKILL.md +1 -1
- package/web/animation-inspection.ts +2 -1
- package/web/catalog-en.ts +2956 -0
- package/web/catalog-ko.ts +2956 -0
- package/web/compare-picked-tools.ts +4 -3
- package/web/compare.css +6 -0
- package/web/compare.html +1 -1
- package/web/compare.ts +2 -2
- package/web/i18n.ts +1154 -0
- package/web/index.html +1 -1
- package/web/main.ts +6 -5
- package/web/stage-comments.ts +95 -41
- package/web/styles.css +7 -6
- package/web/workspace-preferences.ts +15 -13
- package/web/workspace-ui.ts +8 -7
package/web/stage-comments.ts
CHANGED
|
@@ -4,6 +4,7 @@ import {paintInspectionViewport,pixelAlignedCrop,type ViewportCapture} from './v
|
|
|
4
4
|
import type {Feedback} from '../src/session.ts';
|
|
5
5
|
import type {ControlNumericCamera} from '../src/control.ts';
|
|
6
6
|
import {drawnSlots,region,projectMark,unprojectMark,parseStageComment,feedbackTimingLabel,type MarkRegion,type MarkPoint,type StageComment} from '../src/stage-comment.ts';
|
|
7
|
+
import {getLanguage as i18nLang,onLanguageChange as i18nOnChange,t as i18nT,tr as i18nTr} from './i18n.ts';
|
|
7
8
|
import {textEntryFocused} from './view-controls.ts';
|
|
8
9
|
export interface CommentPose {
|
|
9
10
|
mode:StageComment['mode'];camera:ControlNumericCamera;frame:StageComment['frame'];timeBasis?:StageComment['timeBasis'];time:number;animation:string|null;
|
|
@@ -20,88 +21,141 @@ interface Host {
|
|
|
20
21
|
}
|
|
21
22
|
const markOf=(f:Feedback):StageComment|null=>{try{const c=f.context as Record<string,unknown>|undefined;return c?.comment?parseStageComment(c.comment):null;}catch{return null;}};
|
|
22
23
|
const copy=<T>(v:T):T=>JSON.parse(JSON.stringify(v));
|
|
24
|
+
const t=(s:string)=>typeof i18nT==='function'?i18nT(s):s;
|
|
25
|
+
const toEn=(s:string)=>typeof i18nTr==='function'?i18nTr(s,'en'):s;
|
|
26
|
+
const onLang=(fn:()=>void)=>typeof i18nOnChange==='function'?i18nOnChange(fn):()=>{};
|
|
27
|
+
const curLang=()=>typeof i18nLang==='function'?i18nLang():'en';
|
|
23
28
|
function rectElement(r:MarkRegion):HTMLDivElement{const node=document.createElement('div');node.className='stage-comment-region';Object.assign(node.style,{left:r.x+'px',top:r.y+'px',width:Math.max(2,r.width)+'px',height:Math.max(2,r.height)+'px'});return node;}
|
|
24
29
|
async function crop(pose:CommentPose,r:MarkRegion):Promise<StageComment['crop']>{
|
|
25
|
-
if(!pose.capture)throw new Error('COMMENT_CROP_UNAVAILABLE: viewport pixel source unavailable');
|
|
30
|
+
if(!pose.capture)throw new Error(t('COMMENT_CROP_UNAVAILABLE: viewport pixel source unavailable'));
|
|
26
31
|
const camera=pose.camera,padding=24,rawLeft=Math.max(0,Math.floor(r.x-padding)),rawTop=Math.max(0,Math.floor(r.y-padding)),pane=pose.capture.pane,bounds=pane.getBoundingClientRect(),ratio=globalThis.devicePixelRatio||1;
|
|
27
32
|
const {x:left,y:top,width,height}=pixelAlignedCrop({x:rawLeft,y:rawTop,width:Math.min(camera.viewport.width-rawLeft,Math.ceil(r.width+2*padding)),height:Math.min(camera.viewport.height-rawTop,Math.ceil(r.height+2*padding))},{x:bounds.left+pane.clientLeft,y:bounds.top+pane.clientTop},ratio);
|
|
28
|
-
if(width<=0||height<=0)throw new Error('COMMENT_CROP_UNAVAILABLE: mark is outside the viewport');
|
|
29
|
-
const
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
+
if(width<=0||height<=0)throw new Error(t('COMMENT_CROP_UNAVAILABLE: mark is outside the viewport'));
|
|
34
|
+
const out=document.createElement('canvas'),stroke=getComputedStyle(document.documentElement).getPropertyValue('--link').trim()||'#3b82f6';
|
|
35
|
+
let scale=Math.min(ratio,768/width,768/height),png='';
|
|
36
|
+
while(true){
|
|
37
|
+
out.width=Math.max(1,Math.round(width*scale));out.height=Math.max(1,Math.round(height*scale));
|
|
38
|
+
const sx=out.width/width,sy=out.height/height,s=Math.min(sx,sy),ctx=out.getContext('2d')!;
|
|
39
|
+
ctx.scale(sx,sy);ctx.translate(-left,-top);
|
|
40
|
+
paintInspectionViewport(ctx,{x:left,y:top,width,height},pose.capture,pose);
|
|
41
|
+
const pad=1/s,mw=Math.min(Math.max(3/s,r.width),Math.max(1/s,width-2*pad)),mh=Math.min(Math.max(3/s,r.height),Math.max(1/s,height-2*pad));
|
|
42
|
+
const mx=Math.max(left+pad,Math.min(r.x,left+width-pad-mw)),my=Math.max(top+pad,Math.min(r.y,top+height-pad-mh));
|
|
43
|
+
ctx.strokeStyle=stroke;ctx.lineWidth=2/s;ctx.strokeRect(mx,my,mw,mh);
|
|
44
|
+
png=out.toDataURL('image/png');
|
|
45
|
+
if(png.length<=200000||out.width===1&&out.height===1)break;
|
|
46
|
+
const next=scale*Math.min(.85,Math.sqrt(185000/png.length));
|
|
47
|
+
scale=Math.max(1,Math.round(width*next))===out.width&&Math.max(1,Math.round(height*next))===out.height?Math.min((out.width-1)/width,(out.height-1)/height):next;
|
|
48
|
+
}
|
|
49
|
+
if(png.length>200000)throw new Error(t('COMMENT_CROP_LIMIT: mark a smaller region (PNG limit 150 KiB)'));
|
|
33
50
|
const bytes=Uint8Array.from(atob(png.split(',')[1]!),c=>c.charCodeAt(0)),sha256=[...new Uint8Array(await crypto.subtle.digest('SHA-256',bytes))].map(n=>n.toString(16).padStart(2,'0')).join('');
|
|
34
51
|
return {path:`comment-crops/${sha256}.png`,sha256,png,width:out.width,height:out.height};
|
|
35
52
|
}
|
|
36
53
|
export function bindStageComments(host:Host):{refresh:()=>void;dispose:()=>void;active:()=>boolean;draft:()=>boolean}{
|
|
37
|
-
const toggle=document.getElementById('stage-comment') as HTMLButtonElement
|
|
38
|
-
const list=document.createElement('section');list.id='stage-comment-list';list.className='stage-comment-list stage-comment-ui';list.setAttribute('aria-label','Stage comments');list.hidden=true;
|
|
54
|
+
const toggle=document.getElementById('stage-comment') as HTMLButtonElement;Object.assign(toggle.style,{whiteSpace:'nowrap',flex:'none'});
|
|
55
|
+
const list=document.createElement('section');list.id='stage-comment-list';list.className='stage-comment-list stage-comment-ui';list.setAttribute('aria-label',t('Stage comments'));list.hidden=true;
|
|
39
56
|
// An absolute overlay is not stage chrome: workspace measures stack children
|
|
40
57
|
// to allocate Inspector height. Keep the list in its positioned main instead.
|
|
41
58
|
const workspace=host.toolbar.closest('main');if(workspace)workspace.append(list);else host.toolbar.after(list);
|
|
42
|
-
const refusalNote=document.createElement('small');refusalNote.id='stage-comment-refusal';refusalNote.setAttribute('role','status');refusalNote.hidden=true;toggle.after(refusalNote);toggle.setAttribute('aria-describedby',refusalNote.id);const originalTitle=toggle.title;
|
|
43
|
-
const updateRefusal=()=>{const
|
|
59
|
+
const refusalNote=document.createElement('small');refusalNote.id='stage-comment-refusal';refusalNote.setAttribute('role','status');refusalNote.hidden=true;Object.assign(refusalNote.style,{position:'absolute',width:'1px',height:'1px',overflow:'hidden',clipPath:'inset(50%)',whiteSpace:'nowrap'});toggle.after(refusalNote);toggle.setAttribute('aria-describedby',refusalNote.id);toggle.setAttribute('aria-controls',list.id);toggle.setAttribute('aria-expanded','false');const originalTitle=toEn(toggle.title);
|
|
60
|
+
const updateRefusal=()=>{const raw=host.refusal?.()??null,reason=raw?t(raw):null,prev=refusalNote.textContent||'',nextTitle=reason??t(originalTitle);toggle.disabled=false;if(toggle.title!==nextTitle)toggle.title=nextTitle;if(refusalNote.title!==(reason??''))refusalNote.title=reason??'';if(refusalNote.textContent!==(reason??''))refusalNote.textContent=reason??'';refusalNote.hidden=!reason;if(!list.hidden&&(reason??'')!==prev)renderList();return reason;};
|
|
44
61
|
const layers=new Map<StageComment['viewport'],HTMLDivElement>();for(const [key,pane]of Object.entries(host.viewports)){const layer=document.createElement('div');layer.className='stage-comment-layer';pane!.append(layer);layers.set(key as StageComment['viewport'],layer);}
|
|
45
|
-
let enabled=false,disposed=false,pending:{view:StageComment['viewport'];start:MarkPoint;end:MarkPoint;mode:StageComment['mode'];id:number;interaction:number;settled:Promise<void>}|null=null,composer:HTMLFormElement|null=null,draftMark:{view:StageComment['viewport'];mode:StageComment['mode'];screen:MarkRegion}|null=null,busy=false,last='',raf=0,interaction=0;
|
|
46
|
-
const
|
|
47
|
-
const cancel=()=>{++interaction;const previous=pending;pending=null;if(previous){const pane=host.viewports[previous.view];if(pane?.hasPointerCapture(previous.id))pane.releasePointerCapture(previous.id);}composer?.remove();composer=null;draftMark=null;last='';};
|
|
48
|
-
const assertCapture=()=>{const reason=updateRefusal();if(reason){cancel();
|
|
49
|
-
const
|
|
50
|
-
const
|
|
62
|
+
let enabled=false,disposed=false,pending:{view:StageComment['viewport'];start:MarkPoint;end:MarkPoint;mode:StageComment['mode'];id:number;interaction:number;settled:Promise<void>}|null=null,composer:HTMLFormElement|null=null,composerReadOnly=false,syncComposerLang:(()=>void)|null=null,draftMark:{view:StageComment['viewport'];mode:StageComment['mode'];screen:MarkRegion}|null=null,busy=false,last='',raf=0,interaction=0;
|
|
63
|
+
const setCapture=(value:boolean)=>{enabled=value;toggle.setAttribute('aria-pressed',String(value||!list.hidden));for(const pane of Object.values(host.viewports))pane!.classList.toggle('stage-comment-mode',value);};
|
|
64
|
+
const cancel=()=>{++interaction;const previous=pending;pending=null;if(previous){const pane=host.viewports[previous.view];if(pane?.hasPointerCapture(previous.id))pane.releasePointerCapture(previous.id);}composer?.remove();composer=null;composerReadOnly=false;syncComposerLang=null;draftMark=null;last='';};
|
|
65
|
+
const assertCapture=()=>{const reason=updateRefusal();if(reason){cancel();setCapture(false);host.error(reason);throw new Error(reason);}if(host.blocked())throw new Error(t('COMMENT_BUSY: wait for inspection'));};
|
|
66
|
+
const assertEdit=()=>{const reason=updateRefusal();if(reason){setCapture(false);host.error(reason);throw new Error(reason);}if(host.blocked())throw new Error(t('COMMENT_BUSY: wait for inspection'));};
|
|
67
|
+
const jump=async(f:Feedback):Promise<boolean>=>{const mark=markOf(f);if(!mark)return false;const panes=Object.values(host.viewports).map(p=>({pane:p!,visibility:p!.style.visibility}));try{cancel();for(const {pane}of panes)pane.style.visibility='hidden';await host.restore(mark.bookmark,mark.frame===null);last='';return true;}catch(error){host.error(String(error));return false;}finally{for(const {pane,visibility}of panes)pane.style.visibility=visibility;}};
|
|
68
|
+
const setOpen=(value:boolean)=>{
|
|
69
|
+
if(!value){cancel();list.hidden=true;toggle.setAttribute('aria-expanded','false');setCapture(false);return;}
|
|
70
|
+
if(host.shortcutBlocked?.()){host.error(t('COMMENT_BUSY: close the active editor or wait for the inspection to settle'));return;}
|
|
71
|
+
const reason=updateRefusal();
|
|
72
|
+
if(!reason&&host.blocked()){host.error(t('COMMENT_BUSY: close the active editor or wait for the inspection to settle'));return;}
|
|
73
|
+
list.hidden=false;toggle.setAttribute('aria-expanded','true');renderList();
|
|
74
|
+
if(reason){setCapture(false);host.error(reason);return;}
|
|
75
|
+
setCapture(true);
|
|
76
|
+
};
|
|
77
|
+
const openComment=async(f:Feedback)=>{const mark=markOf(f);if(!mark)return;if(list.hidden)setOpen(true);if(list.hidden)return;if(await jump(f)){const reason=updateRefusal();setCapture(!reason&&!host.blocked());openComposer(mark.viewport,mark.screen,f,host.pose(mark.viewport)?.mode??mark.mode);}};
|
|
78
|
+
const renderList=()=>{list.setAttribute('aria-label',t('Stage comments'));list.replaceChildren();const title=document.createElement('strong');title.textContent=t('Comments');list.append(title);const rawReason=host.refusal?.()??null,reason=rawReason?t(rawReason):null;if(reason){const note=document.createElement('small');note.className='stage-comment-refusal-note';note.title=reason;note.textContent=reason;Object.assign(note.style,{display:'block',marginTop:'4px',maxWidth:'100%',whiteSpace:'nowrap',overflow:'hidden',textOverflow:'ellipsis'});list.append(note);}const all=host.feedback().filter(f=>markOf(f));toggle.textContent=t(`Comment · C (${all.length})`);if(!all.length){const empty=document.createElement('p');empty.textContent=t(reason?'Read only · Escape closes':'Mark a point or region, then type. Enter saves · Escape cancels.');list.append(empty);}for(const [i,f]of all.entries()){
|
|
51
79
|
const mark=markOf(f)!,row=document.createElement('div');row.className='stage-comment-item';row.dataset.commentId=f.id;
|
|
52
|
-
const go=document.createElement('button');go.type='button';go.textContent=`${i+1} · ${mark.mode.toUpperCase()} · ${mark.viewport.toUpperCase()} · ${mark.frame?`F${mark.frame.index} (${mark.frame.basis})`:feedbackTimingLabel(f)} · ${f.summary}`;go.onclick=()=>
|
|
53
|
-
if(
|
|
80
|
+
const go=document.createElement('button');go.type='button';go.className='stage-comment-summary';go.textContent=`${i+1} · ${mark.mode.toUpperCase()} · ${mark.viewport.toUpperCase()} · ${mark.frame?`F${mark.frame.index} (${mark.frame.basis})`:t(feedbackTimingLabel(f))} · ${f.summary}`;go.onclick=()=>openComment(f);row.append(go);
|
|
81
|
+
if(host.locked(f.id)){const submitted=document.createElement('span');submitted.textContent=t('Submitted');row.append(submitted);}
|
|
82
|
+
list.append(row);
|
|
54
83
|
}};
|
|
55
84
|
const refresh=()=>{last='';renderList();};
|
|
56
85
|
const openComposer=(view:StageComment['viewport'],screen:MarkRegion,existing?:Feedback,placementMode=host.pose(view)?.mode)=>{
|
|
57
|
-
try{assertCapture();}catch{return;}
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
const
|
|
61
|
-
|
|
62
|
-
|
|
86
|
+
if(!existing){try{assertCapture();}catch{return;}}
|
|
87
|
+
const currentMode=host.pose(view)?.mode;
|
|
88
|
+
if(!placementMode||currentMode&¤tMode!==placementMode){cancel();return;}
|
|
89
|
+
const locked=!!existing&&host.locked(existing.id),initialRefusal=existing?updateRefusal():null;
|
|
90
|
+
if(existing&&!initialRefusal&&host.blocked()){host.error(t('COMMENT_BUSY: wait for inspection'));return;}
|
|
91
|
+
composer?.remove();composerReadOnly=locked||!!initialRefusal;draftMark={view,mode:placementMode,screen};const generation=interaction;const pane=host.viewports[view]!,form=composer=document.createElement('form');form.className='stage-comment-composer stage-comment-ui';form.setAttribute('aria-label',t('Comment composer'));
|
|
92
|
+
const field=document.createElement('input');field.type='text';field.maxLength=1000;field.setAttribute('aria-label',t('Comment text'));field.placeholder=t('Describe this spot…');field.value=existing?.summary??'';
|
|
93
|
+
if(locked||initialRefusal){field.readOnly=true;field.setAttribute('aria-readonly','true');}
|
|
94
|
+
const hint=document.createElement('small');hint.textContent=composerReadOnly?'Read only · Escape closes':'Enter saves · Escape cancels';hint.textContent=t(hint.textContent);const error=document.createElement('p');error.setAttribute('role','alert');form.append(field,hint,error);
|
|
95
|
+
const place=()=>{const w=form.offsetWidth||294,h=form.offsetHeight||132;Object.assign(form.style,{left:Math.max(4,Math.min(screen.x+screen.width+8,pane.clientWidth-w-4))+'px',top:Math.max(4,Math.min(screen.y+screen.height+8,pane.clientHeight-h-4))+'px'});};
|
|
96
|
+
let removeBtn:HTMLButtonElement|null=null,errorSource='';
|
|
97
|
+
if(existing&&!locked){
|
|
98
|
+
const remove=removeBtn=document.createElement('button');remove.type='button';remove.className='stage-comment-delete';remove.textContent=t('Delete');
|
|
99
|
+
remove.onclick=()=>{
|
|
100
|
+
if(busy)return;
|
|
101
|
+
try{
|
|
102
|
+
assertEdit();if(host.locked(existing.id))throw new Error(t('COMMENT_SUBMITTED: submitted evidence is immutable'));
|
|
103
|
+
const all=host.feedback(),index=all.findIndex(x=>x.id===existing.id);if(index>=0)all.splice(index,1);
|
|
104
|
+
cancel();host.changed();refresh();
|
|
105
|
+
}catch(e){errorSource=toEn(e instanceof Error?e.message:String(e));error.textContent=t(errorSource);place();}
|
|
106
|
+
};
|
|
107
|
+
form.append(remove);
|
|
108
|
+
}
|
|
63
109
|
// Capture all view context now; camera or dial changes while typing cannot rebind the mark.
|
|
64
110
|
const pose=host.pose(view),bookmark=copy(host.bookmark()),turn=pose?copy(pose.turn):null;
|
|
65
|
-
if(
|
|
111
|
+
if(initialRefusal){errorSource=toEn(host.refusal?.()??initialRefusal);error.textContent=t(errorSource);host.error(t(errorSource));}
|
|
112
|
+
else if(!existing&&pose&&!pose.frame&&!pose.timeBasis){errorSource=toEn(pose.frameReason??'COMMENT_FRAME_UNAVAILABLE: no explicit frame index');error.textContent=t(errorSource);}
|
|
113
|
+
syncComposerLang=()=>{if(composer!==form)return;form.setAttribute('aria-label',t('Comment composer'));field.setAttribute('aria-label',t('Comment text'));field.placeholder=t('Describe this spot…');hint.textContent=t(composerReadOnly?'Read only · Escape closes':'Enter saves · Escape cancels');if(removeBtn)removeBtn.textContent=t('Delete');if(errorSource)error.textContent=t(errorSource);};
|
|
114
|
+
pane.append(form);place();
|
|
66
115
|
const previous=existing?markOf(existing):null;
|
|
67
116
|
const prepared=previous?Promise.resolve(previous.crop):pose?crop(pose,screen):Promise.reject(new Error('COMMENT_VIEW_UNAVAILABLE'));
|
|
68
117
|
prepared.catch(()=>{});
|
|
69
|
-
form.onkeydown=e=>{if(e.key==='Escape'){e.preventDefault();e.stopPropagation();
|
|
70
|
-
form.onsubmit=async e=>{e.preventDefault();if(busy)return;if(generation!==interaction||host.pose(view)?.mode!==placementMode){cancel();return;}const summary=field.value.trim();if(!summary){field.focus();return;}try{
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
118
|
+
form.onkeydown=e=>{if(e.key==='Escape'){e.preventDefault();e.stopPropagation();setOpen(false);pane.focus();}};
|
|
119
|
+
form.onsubmit=async e=>{e.preventDefault();if(busy)return;if(generation!==interaction||host.pose(view)&&host.pose(view)?.mode!==placementMode){cancel();return;}const summary=field.value.trim();if(!summary){field.focus();return;}try{
|
|
120
|
+
if(existing){
|
|
121
|
+
assertEdit();if(host.locked(existing.id))throw new Error(t('COMMENT_SUBMITTED: submitted evidence is immutable'));
|
|
122
|
+
busy=true;field.disabled=true;
|
|
123
|
+
existing.summary=summary;
|
|
124
|
+
}else{
|
|
125
|
+
assertCapture();if(!pose||!pose.frame&&!pose.timeBasis)throw new Error(t(pose?.frameReason??'COMMENT_FRAME_UNAVAILABLE: provide an explicit producer clock or a decoded reference frame index'));
|
|
126
|
+
busy=true;field.disabled=true;
|
|
75
127
|
const world=region(unprojectMark(screen,pose.camera),unprojectMark({x:screen.x+screen.width,y:screen.y+screen.height},pose.camera));
|
|
76
128
|
const slots=pose.posed?drawnSlots(pose.posed,world):[];
|
|
77
129
|
const comment:StageComment={schema:'rig-review-comment/1',mode:placementMode,viewport:view,frame:pose.frame,...(pose.timeBasis?{timeBasis:pose.timeBasis}:{}),time:pose.time,animation:pose.animation,sourceHash:pose.sourceHash,modelHash:pose.modelHash,referenceHash:pose.referenceHash,referenceId:pose.referenceId,camera:copy(pose.camera),screen,world,slots,crop:await prepared,bookmark};
|
|
78
|
-
assertCapture();
|
|
130
|
+
assertCapture();
|
|
79
131
|
if(disposed||generation!==interaction||host.pose(view)?.mode!==placementMode)return;
|
|
80
132
|
const n=pose.frame?.index??null;host.add({id:crypto.randomUUID(),frameStart:n,frameEnd:n,target:slots[0]?{kind:'slot',name:slots[0].slot}:{kind:'rig',name:pose.rig},category:'defect',summary,context:{animation:pose.animation,time:pose.time,frame:pose.frame?.basis==='producer'?n:null,...(turn?{turn:turn as any}:{}),interval:n===null?null:{frameStart:n,frameEnd:n,inclusive:true},comment:comment as any}},pose.side);
|
|
81
133
|
}
|
|
82
134
|
cancel();host.changed();refresh();
|
|
83
|
-
}catch(e){
|
|
135
|
+
}catch(e){const msg=e instanceof Error?e.message:String(e);errorSource=toEn(msg);error.textContent=t(errorSource);place();if(locked)host.error(t(errorSource));field.disabled=false;field.focus();}finally{busy=false;}};
|
|
84
136
|
field.focus();last='';
|
|
85
137
|
};
|
|
86
138
|
const disposers:(()=>void)[]=[];
|
|
87
139
|
for(const [key,pane]of Object.entries(host.viewports)){
|
|
88
140
|
const view=key as StageComment['viewport'],local=(e:PointerEvent)=>{const r=pane!.getBoundingClientRect();return {x:Math.max(0,Math.min(pane!.clientWidth,e.clientX-r.left-pane!.clientLeft)),y:Math.max(0,Math.min(pane!.clientHeight,e.clientY-r.top-pane!.clientTop))};};
|
|
89
|
-
const down=(e:PointerEvent)=>{if(
|
|
141
|
+
const down=(e:PointerEvent)=>{if(e.button!==0||!e.isPrimary||(e.target as Element)?.closest?.('.stage-comment-ui,button,input'))return;if(enabled||!list.hidden){try{assertCapture();}catch{return;}}if(!enabled||host.blocked())return;e.preventDefault();e.stopImmediatePropagation();cancel();const at=local(e),mode=host.pose(view)?.mode;if(!mode)return;const generation=interaction;pending={view,start:at,end:at,mode,id:e.pointerId,interaction:generation,settled:host.pause()};pending.settled.catch(e=>{if(interaction===generation&&!disposed)host.error(String(e));});pane!.setPointerCapture(e.pointerId);};
|
|
90
142
|
const move=(e:PointerEvent)=>{if(!pending||pending.id!==e.pointerId)return;e.preventDefault();e.stopImmediatePropagation();pending.end=local(e);draftMark={view,mode:pending.mode,screen:region(pending.start,pending.end)};last='';};
|
|
91
143
|
const up=async(e:PointerEvent)=>{if(!pending||pending.id!==e.pointerId)return;e.preventDefault();e.stopImmediatePropagation();const p=pending;pending=null;if(pane!.hasPointerCapture(e.pointerId))pane!.releasePointerCapture(e.pointerId);try{await p.settled;assertCapture();if(disposed||interaction!==p.interaction||!enabled)return;const r=Math.hypot(p.end.x-p.start.x,p.end.y-p.start.y)<4?region(p.start,p.start):region(p.start,p.end);openComposer(view,r,undefined,p.mode);}catch(error){host.error(String(error));cancel();}};
|
|
92
144
|
const abort=(e:PointerEvent)=>{if(pending?.view===view&&pending.id===e.pointerId)cancel();};
|
|
93
145
|
pane!.addEventListener('pointerdown',down,true);pane!.addEventListener('pointermove',move,true);pane!.addEventListener('pointerup',up,true);pane!.addEventListener('pointercancel',abort,true);pane!.addEventListener('lostpointercapture',abort,true);
|
|
94
146
|
disposers.push(()=>{pane!.removeEventListener('pointerdown',down,true);pane!.removeEventListener('pointermove',move,true);pane!.removeEventListener('pointerup',up,true);pane!.removeEventListener('pointercancel',abort,true);pane!.removeEventListener('lostpointercapture',abort,true);});
|
|
95
147
|
}
|
|
96
|
-
const key=(e:KeyboardEvent)=>{if(e.key==='Escape'&&(pending||composer||enabled&&!host.shortcutBlocked?.()&&!textEntryFocused(e.target))){e.preventDefault();
|
|
97
|
-
window.addEventListener('blur',cancel);document.addEventListener('keydown',key);toggle.onclick=()=>
|
|
98
|
-
const
|
|
148
|
+
const key=(e:KeyboardEvent)=>{if(e.key==='Escape'&&(pending||composer||(enabled||!list.hidden)&&!host.shortcutBlocked?.()&&!textEntryFocused(e.target))){e.preventDefault();setOpen(false);return;}if(e.defaultPrevented||e.repeat||e.ctrlKey||e.metaKey||e.altKey||textEntryFocused(e.target)||host.shortcutBlocked?.())return;if(e.key.toLowerCase()==='c'){e.preventDefault();setOpen(list.hidden);}};
|
|
149
|
+
window.addEventListener('blur',cancel);document.addEventListener('keydown',key);toggle.onclick=()=>setOpen(list.hidden);
|
|
150
|
+
const renderPins=()=>{if(disposed)return;const refusal=updateRefusal();if(refusal&&(enabled||pending||composer&&!composerReadOnly)){cancel();setCapture(false);host.error(refusal);}const all=host.feedback().map(f=>({f,mark:markOf(f)})).filter(x=>x.mark);
|
|
99
151
|
const poses=new Map([...layers.keys()].map(view=>[view,host.pose(view)]));
|
|
100
152
|
if(draftMark&&poses.get(draftMark.view)?.mode!==draftMark.mode||pending&&poses.get(pending.view)?.mode!==pending.mode)cancel();
|
|
101
|
-
const signature=JSON.stringify([refusal,all.map(({f,mark})=>[f.id,f.summary,mark!.mode,mark!.world]),[...poses].map(([view,p])=>[view,p?.mode,p?.animation,p?.frame,p?.timeBasis,p?.time,p?.turn,p?.camera,p?.referenceId,p?.referenceHash]),draftMark]);
|
|
153
|
+
const signature=JSON.stringify([curLang(),refusal,all.map(({f,mark})=>[f.id,f.summary,mark!.mode,mark!.world]),[...poses].map(([view,p])=>[view,p?.mode,p?.animation,p?.frame,p?.timeBasis,p?.time,p?.turn,p?.camera,p?.referenceId,p?.referenceHash]),draftMark]);
|
|
102
154
|
if(signature!==last){last=signature;for(const layer of layers.values())layer.replaceChildren();for(const [i,{f,mark:m}]of all.entries()){
|
|
103
155
|
const mark=m!,pose=poses.get(mark.viewport),layer=layers.get(mark.viewport);if(refusal||!pose||!layer||pose.mode!==mark.mode||pose.animation!==mark.animation||pose.sourceHash!==mark.sourceHash||pose.modelHash!==mark.modelHash||pose.referenceId!==mark.referenceId||pose.referenceHash!==mark.referenceHash||JSON.stringify(pose.frame)!==JSON.stringify(mark.frame)||JSON.stringify(pose.timeBasis??null)!==JSON.stringify(mark.timeBasis??null)||Math.abs(pose.time-mark.time)>1e-7||JSON.stringify(pose.turn)!==JSON.stringify((f.context as any)?.turn??null))continue;
|
|
104
|
-
const a=projectMark(mark.world,pose.camera),b=projectMark({x:mark.world.x+mark.world.width,y:mark.world.y+mark.world.height},pose.camera),r=region(a,b),box=rectElement(r),pin=document.createElement('button');pin.type='button';pin.className='stage-comment-pin stage-comment-ui';pin.textContent=String(i+1);pin.setAttribute('aria-label'
|
|
105
|
-
}if(draftMark)layers.get(draftMark.view)?.append(rectElement(draftMark.screen));}
|
|
106
|
-
|
|
156
|
+
const a=projectMark(mark.world,pose.camera),b=projectMark({x:mark.world.x+mark.world.width,y:mark.world.y+mark.world.height},pose.camera),r=region(a,b),box=rectElement(r),pin=document.createElement('button');pin.type='button';pin.className='stage-comment-pin stage-comment-ui';pin.textContent=String(i+1);pin.setAttribute('aria-label',`${t('Comment {0}:').replace('{0}',String(i+1))} ${f.summary}`);pin.title=f.summary;Object.assign(pin.style,{left:r.x+'px',top:r.y+'px'});pin.onclick=()=>openComment(f);layer.append(box,pin);
|
|
157
|
+
}if(draftMark)layers.get(draftMark.view)?.append(rectElement(draftMark.screen));}};
|
|
158
|
+
const paint=()=>{if(disposed)return;renderPins();raf=requestAnimationFrame(paint);};
|
|
159
|
+
const offLang=onLang(()=>{if(disposed)return;updateRefusal();renderList();syncComposerLang?.();last='';renderPins();});
|
|
160
|
+
refresh();paint();return {active:()=>enabled,draft:()=>!!pending||!!composer&&!composerReadOnly,refresh,dispose:()=>{disposed=true;offLang();cancelAnimationFrame(raf);cancel();window.removeEventListener('blur',cancel);document.removeEventListener('keydown',key);for(const dispose of disposers)dispose();for(const layer of layers.values())layer.remove();list.remove();refusalNote.remove();}};
|
|
107
161
|
}
|
package/web/styles.css
CHANGED
|
@@ -146,9 +146,9 @@ main{min-height:0;overflow:hidden;display:flex;flex-direction:column}
|
|
|
146
146
|
.layer-toggle:has(input:disabled){opacity:.45;cursor:default}
|
|
147
147
|
.layer-toggle:has(input:focus-visible){outline:2px solid var(--rv-focus);outline-offset:2px}
|
|
148
148
|
.layer-toggle kbd{font:10px var(--font-mono);padding:0 4px;border:1px solid var(--border-strong);border-radius:3px;color:var(--fg-muted)}
|
|
149
|
-
/* View bar
|
|
150
|
-
.viewbar{flex-wrap:
|
|
151
|
-
.viewbar>.layer-toggles{flex:
|
|
149
|
+
/* View bar: layers, camera sync and zoom, then the View menu at the right end; wraps when the stage is narrow. */
|
|
150
|
+
.viewbar{flex-wrap:wrap;justify-content:flex-start;gap:6px 8px;padding:8px 10px;min-width:0}
|
|
151
|
+
.viewbar>.layer-toggles{flex:none}
|
|
152
152
|
.viewbar .zoom-controls{flex:none}
|
|
153
153
|
.view-menu{position:relative;margin-left:auto;flex:none;font-size:11px}
|
|
154
154
|
.view-menu>summary{list-style:none;cursor:pointer;display:inline-flex;align-items:center;gap:5px;padding:5px 9px;border:1px solid var(--border-strong);border-radius:6px;background:var(--rv-control);white-space:nowrap}
|
|
@@ -229,7 +229,7 @@ footer.status-bar{flex-wrap:nowrap}
|
|
|
229
229
|
@media(max-width:540px){.review-dialog-header .hint{display:none}}
|
|
230
230
|
:root{--rv-mesh-region:#ff7ae0;--rv-mesh-region-fill:rgba(255,122,224,.12);--rv-mesh-handle:#ffffff;--rv-bust-r:#00e5ff;--rv-bust-r-fill:rgba(0,229,255,.13);--rv-bust-l:#52ff88;--rv-bust-l-fill:rgba(82,255,136,.13);--rv-bust-overlap:#ff5252;--rv-bust-overlap-fill:rgba(255,82,82,.13);--rv-bust-handle:#ffffff;--rv-bust-ink:#111318;--rv-bust-label-bg:rgba(12,14,18,.82);--rv-bust-flash:#ffcc00;--rv-landmark:#ffd34d;--rv-landmark-fill:#ffd34d;--rv-landmark-ink:#111318}
|
|
231
231
|
:root[data-theme=light]{--rv-mesh-region:#c2189b;--rv-mesh-region-fill:rgba(194,24,155,.12);--rv-mesh-handle:#ffffff;--rv-bust-r:#00e5ff;--rv-bust-r-fill:rgba(0,229,255,.13);--rv-bust-l:#52ff88;--rv-bust-l-fill:rgba(82,255,136,.13);--rv-bust-overlap:#ff5252;--rv-bust-overlap-fill:rgba(255,82,82,.13);--rv-bust-handle:#ffffff;--rv-bust-ink:#111318;--rv-bust-label-bg:rgba(12,14,18,.82);--rv-bust-flash:#ffcc00;--rv-landmark:#ffd34d;--rv-landmark-fill:#ffd34d;--rv-landmark-ink:#111318}
|
|
232
|
-
.view-tools{display:flex;gap:4px;flex:none}.view-tool{padding:5px 9px;font-size:11px;white-space:nowrap}
|
|
232
|
+
.view-tools{display:flex;gap:4px;flex:none}.view-tools:not(:has(:not([hidden]))){display:none}.view-tool{padding:5px 9px;font-size:11px;white-space:nowrap}
|
|
233
233
|
.chest-editor-bar{display:flex;align-items:center;flex-wrap:wrap;gap:6px 12px;padding:6px 10px;border-bottom:1px solid var(--border);background:var(--rv-bar);font-size:11px}.chest-editor-bar[hidden]{display:none}.chest-editor-bar input[type=range]{width:84px}.chest-editor-bar input[type=text]{width:104px;padding:3px 5px;font-size:11px}.chest-editor-bar output{min-width:2.6em;font:10px/1 var(--font-mono);color:var(--fg)}.chest-editor-bar [data-landmark][aria-pressed=true]{outline:2px solid var(--rv-landmark);outline-offset:1px}#lm-derived{flex:1 1 100%;order:9;min-width:0;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font:10px/1.4 var(--font-mono)}#lm-derived.error{color:var(--fail)}.chest-editor-bar .bust-group{display:flex;align-items:center;flex-wrap:wrap;min-width:0;gap:6px;padding-left:10px;border-left:1px solid var(--border)}.chest-editor-bar .bust-group:first-child{padding-left:0;border-left:0}.chest-editor-bar label{display:flex;align-items:center;gap:4px;color:var(--fg-muted)}.chest-editor-bar input[type=number]{width:58px;padding:3px 5px;font-size:11px}.chest-editor-bar button{padding:4px 8px;font-size:11px}.chest-editor-bar button[aria-disabled=true]{opacity:.6}.bust-tag{font-weight:700}.bust-tag-r{color:var(--rv-bust-r)}.bust-tag-l{color:var(--rv-bust-l)}#handoff-line{flex:1 1 100%;order:10;min-width:0;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font:10px/1.4 var(--font-mono)}#chest-editor-status{flex:1 1 220px;min-width:0;white-space:nowrap;overflow:hidden;text-overflow:ellipsis}.chest-editor-bar{position:relative}.rebuild-log{position:absolute;top:100%;left:10px;right:10px;z-index:6;margin:4px 0 0;max-height:7.5em;overflow:auto;padding:5px 8px;font:10px/1.5 var(--font-mono);white-space:pre-wrap;overflow-wrap:anywhere;background:var(--code-bg);color:var(--code-fg);border:1px solid var(--border);border-radius:5px}
|
|
234
234
|
:root{--rv-mesh-veil:rgba(8,10,14,.55);--rv-mesh-edge:#69f1ff;--rv-mesh-hull:#ffb020;--rv-mesh-constraint:#ff4fd8;--rv-mesh-removed:#ff5252;--rv-mesh-vertex:#ffffff;--rv-mesh-ink:#111318;--rv-mesh-selected:#ffe14d;--rv-mesh-added:#52ff88;--rv-mesh-hover:#ffffff;--rv-mesh-box:#ffe14d;--rv-mesh-box-fill:rgba(255,225,77,.12)}
|
|
235
235
|
:root[data-theme=light]{--rv-mesh-veil:rgba(245,247,251,.6);--rv-mesh-edge:#69f1ff;--rv-mesh-hull:#ffb020;--rv-mesh-constraint:#ff4fd8;--rv-mesh-removed:#ff5252;--rv-mesh-vertex:#ffffff;--rv-mesh-ink:#111318;--rv-mesh-selected:#ffe14d;--rv-mesh-added:#52ff88;--rv-mesh-hover:#ffffff;--rv-mesh-box:#ffe14d;--rv-mesh-box-fill:rgba(255,225,77,.12)}
|
|
@@ -266,7 +266,7 @@ footer.status-bar{flex-wrap:nowrap}
|
|
|
266
266
|
.rebuild-drop-notice{color:var(--warn);font-size:11px;white-space:normal;overflow-wrap:anywhere;min-width:0;max-width:100%}.rebuild-drop-notice[hidden]{display:none}
|
|
267
267
|
.density-strip{margin-top:12px;padding-top:10px;border-top:1px solid var(--border)}.density-strip-form label{display:inline-flex;align-items:center;gap:4px}.density-strip-form input[type=number]{width:64px}.density-strip-table{overflow-x:auto;max-width:100%}.density-strip-rows{width:100%;border-collapse:collapse;font:11px var(--font-mono);font-variant-numeric:tabular-nums}.density-strip-rows th,.density-strip-rows td{padding:4px 6px;border-top:1px solid var(--border);text-align:left;vertical-align:top}.density-strip-rows th{color:var(--fg-muted);font-weight:500;white-space:nowrap}.density-strip-rows tr.pending td{background:var(--rv-pressed-bg)}.density-strip-rows tr.refused td{color:var(--fg-muted)}.density-strip-value strong{display:block;color:var(--fg-strong)}.density-strip-label{display:block;margin-top:3px;padding:1px 5px;border:1px solid var(--rv-pressed-border);border-radius:4px;color:var(--fg-strong);white-space:nowrap;font-family:var(--font-sans)}.density-strip-bars div{white-space:nowrap}.density-strip-verdict{min-width:140px;max-width:340px;overflow-wrap:anywhere}.density-strip-verdict.pass{color:var(--pass)}.density-strip-actions{white-space:nowrap}.density-strip-actions button{margin:0 4px 4px 0}
|
|
268
268
|
/* Key inspection and dopesheet editing (#235): tokens only. */
|
|
269
|
-
#stage-comment-refusal{
|
|
269
|
+
#stage-comment{white-space:nowrap;flex:none}#stage-comment-refusal{position:absolute;width:1px;height:1px;overflow:hidden;clip-path:inset(50%);white-space:nowrap}.stage-comment-refusal-note{display:block;margin-top:4px;max-width:100%;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font-size:11px;color:var(--fg-muted)}
|
|
270
270
|
.inspector-body{display:flex;flex-direction:column;min-height:0;overflow:hidden}
|
|
271
271
|
.inspector-body>[data-inspector-panel]{flex:1 1 0;min-height:0}
|
|
272
272
|
.applied-records:not([hidden]){display:flex;align-items:center;gap:8px;padding:1px 10px;height:20px;min-height:20px;max-height:20px;box-sizing:border-box;overflow:hidden;flex:none}
|
|
@@ -388,4 +388,5 @@ footer.status-bar{flex-wrap:nowrap}
|
|
|
388
388
|
#turn-pad-host>p{margin:0 12px 6px}
|
|
389
389
|
|
|
390
390
|
/* Source-bound stage comments; the layer never intercepts ordinary inspection. */
|
|
391
|
-
main{position:relative}.stage-comment-mode{cursor:crosshair}.stage-comment-mode video{pointer-events:none}.stage-comment-layer{position:absolute;inset:0;pointer-events:none;z-index:20;overflow:hidden}.stage-comment-region{position:absolute;border:2px solid var(--link);pointer-events:none}.stage-comment-pin{position:absolute;transform:translate(-50%,-50%);border-radius:50%;min-width:26px;height:26px;padding:2px 5px;background:var(--link);color:var(--btn-fg);pointer-events:auto}.stage-comment-composer{position:absolute;z-index:30;width:286px;padding:10px;background:var(--rv-panel);border:1px solid var(--link);border-radius:6px;box-shadow:0 4px 20px var(--rv-backdrop)}.stage-comment-composer input{width:100%}.stage-comment-composer small{display:block;margin-top:6px;color:var(--fg-muted)}.stage-comment-composer p{color:var(--fail);margin:4px 0}.stage-comment-list{position:absolute;z-index:40;right:8px;top:55px;width:310px;max-width:90%;max-height:60%;overflow:auto;background:var(--rv-panel);border:1px solid var(--border-strong);padding:12px;border-radius:6px}.stage-comment-item{padding:8px 0;border-bottom:1px solid var(--border)}.stage-comment-item>button:first-child{display:block;width:100%;text-align:left;overflow-wrap:anywhere}.stage-comment-item span{display:block;color:var(--fg-muted)}
|
|
391
|
+
main{position:relative}#stage-comment{white-space:nowrap;flex:none}#stage-comment-refusal{position:absolute;width:1px;height:1px;overflow:hidden;clip-path:inset(50%);white-space:nowrap}.stage-comment-refusal-note{display:block;margin-top:4px;max-width:100%;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font-size:11px;color:var(--fg-muted)}.stage-comment-mode{cursor:crosshair}.stage-comment-mode video{pointer-events:none}.stage-comment-layer{position:absolute;inset:0;pointer-events:none;z-index:20;overflow:hidden}.stage-comment-region{position:absolute;border:2px solid var(--link);pointer-events:none}.stage-comment-pin{position:absolute;transform:translate(-50%,-50%);border-radius:50%;min-width:26px;height:26px;padding:2px 5px;background:var(--link);color:var(--btn-fg);pointer-events:auto}.stage-comment-composer{position:absolute;z-index:30;width:286px;max-width:calc(100% - 8px);max-height:calc(100% - 8px);overflow:auto;overflow-wrap:anywhere;padding:10px;background:var(--rv-panel);border:1px solid var(--link);border-radius:6px;box-shadow:0 4px 20px var(--rv-backdrop)}.stage-comment-composer input{width:100%}.stage-comment-composer small{display:block;margin-top:6px;color:var(--fg-muted)}.stage-comment-composer p{color:var(--fail);margin:4px 0}.stage-comment-list{position:absolute;z-index:40;right:8px;top:55px;width:310px;max-width:90%;max-height:60%;overflow:auto;background:var(--rv-panel);border:1px solid var(--border-strong);padding:12px;border-radius:6px}.stage-comment-item{padding:8px 0;border-bottom:1px solid var(--border)}.stage-comment-item>button:first-child{display:block;width:100%;text-align:left;overflow-wrap:anywhere}.stage-comment-item span{display:block;color:var(--fg-muted)}
|
|
392
|
+
:root:lang(ko){word-break:keep-all;overflow-wrap:break-word}
|
|
@@ -2,6 +2,7 @@
|
|
|
2
2
|
export const workspacePreferenceKey='rig-review-preferences/1';
|
|
3
3
|
export const legacyAppearanceKey='rig-review-appearance/1';
|
|
4
4
|
export type WorkspaceTheme='system'|'dark'|'light';
|
|
5
|
+
export type WorkspaceLanguage='system'|'en'|'ko';
|
|
5
6
|
/** Saved field names are part of the stored record and do not move with the panels.
|
|
6
7
|
* `rightWidth` is the parts explorer's width wherever the page shows it (the single review page shows
|
|
7
8
|
* it on the left); `leftWidth` is the compare page's sources column. */
|
|
@@ -10,15 +11,15 @@ export const panelBounds=Object.freeze({leftWidth:Object.freeze({min:120,max:720
|
|
|
10
11
|
export const defaultWorkspacePanels:Readonly<WorkspacePanels>=Object.freeze({leftWidth:170,rightWidth:260,inspectorHeight:350});
|
|
11
12
|
const legacyDefaultInspectorHeight=280;
|
|
12
13
|
type Flag='defaultCameraSync'|'defaultIdleRepeat'|'settingsCollapsed';
|
|
13
|
-
type Field='theme'|Flag|keyof WorkspacePanels;
|
|
14
|
-
const fields:readonly Field[]=['theme','defaultCameraSync','defaultIdleRepeat','settingsCollapsed','leftWidth','rightWidth','inspectorHeight'];
|
|
14
|
+
type Field='theme'|'language'|Flag|keyof WorkspacePanels;
|
|
15
|
+
const fields:readonly Field[]=['theme','language','defaultCameraSync','defaultIdleRepeat','settingsCollapsed','leftWidth','rightWidth','inspectorHeight'];
|
|
15
16
|
const flags:readonly Flag[]=['defaultCameraSync','defaultIdleRepeat','settingsCollapsed'];
|
|
16
17
|
/** Fields added after the record shipped. A stored record that predates one has neither the value nor its
|
|
17
18
|
* stamp: it loads with the default value at revision 0, exactly as if that field had never been edited. */
|
|
18
|
-
const addedFields:ReadonlySet<Field>=new Set(['settingsCollapsed']);
|
|
19
|
+
const addedFields:ReadonlySet<Field>=new Set(['settingsCollapsed','language']);
|
|
19
20
|
interface FieldStamp {revision:number;writer:string}
|
|
20
|
-
export interface WorkspacePreferences {schema:'rig-review-preferences/1';revision:number;theme:WorkspaceTheme;defaultCameraSync:boolean;defaultIdleRepeat:boolean;settingsCollapsed:boolean;panels:WorkspacePanels;stamps:Record<Field,FieldStamp>}
|
|
21
|
-
export interface WorkspacePreferencePatch {theme?:WorkspaceTheme;defaultCameraSync?:boolean;defaultIdleRepeat?:boolean;settingsCollapsed?:boolean;panels?:Partial<WorkspacePanels>}
|
|
21
|
+
export interface WorkspacePreferences {schema:'rig-review-preferences/1';revision:number;theme:WorkspaceTheme;language:WorkspaceLanguage;defaultCameraSync:boolean;defaultIdleRepeat:boolean;settingsCollapsed:boolean;panels:WorkspacePanels;stamps:Record<Field,FieldStamp>}
|
|
22
|
+
export interface WorkspacePreferencePatch {theme?:WorkspaceTheme;language?:WorkspaceLanguage;defaultCameraSync?:boolean;defaultIdleRepeat?:boolean;settingsCollapsed?:boolean;panels?:Partial<WorkspacePanels>}
|
|
22
23
|
export interface PreferenceStorage {getItem(key:string):string|null;setItem(key:string,value:string):void}
|
|
23
24
|
export interface PreferenceStatus {state:'available'|'memory-only'|'corrupt';detail:string}
|
|
24
25
|
export interface PreferenceEventSource {addEventListener(type:string,listener:EventListener):void;removeEventListener(type:string,listener:EventListener):void}
|
|
@@ -26,24 +27,25 @@ export interface WorkspacePreferenceOptions {storage?:PreferenceStorage|null;eve
|
|
|
26
27
|
const object=(v:unknown,label:string):Record<string,unknown>=>{if(!v||typeof v!=='object'||Array.isArray(v))throw new Error(`${label}: expected object`);return v as Record<string,unknown>;};
|
|
27
28
|
const closed=(v:Record<string,unknown>,allowed:readonly string[],label:string)=>{for(const key of Object.keys(v))if(!allowed.includes(key))throw new Error(`${label}.${key}: unknown field`);};
|
|
28
29
|
const theme=(v:unknown):WorkspaceTheme=>{if(v!=='system'&&v!=='dark'&&v!=='light')throw new Error('PREFERENCES_THEME: expected system, dark or light');return v;};
|
|
30
|
+
const language=(v:unknown):WorkspaceLanguage=>{if(v!=='system'&&v!=='en'&&v!=='ko')throw new Error('PREFERENCES_LANGUAGE: expected system, en or ko');return v;};
|
|
29
31
|
const boolean=(v:unknown,label:string):boolean=>{if(typeof v!=='boolean')throw new Error(`${label}: expected boolean`);return v;};
|
|
30
32
|
const panel=(v:unknown,key:keyof WorkspacePanels):number=>{const {min,max}=panelBounds[key];if(typeof v!=='number'||!Number.isFinite(v)||v<min||v>max)throw new Error(`PREFERENCES_PANEL: ${key} requires finite ${min}..${max} CSS pixels`);return v;};
|
|
31
33
|
export function parseWorkspacePanels(value:unknown):WorkspacePanels {const o=object(value,'panels');closed(o,Object.keys(panelBounds),'panels');return {leftWidth:panel(o.leftWidth,'leftWidth'),rightWidth:panel(o.rightWidth,'rightWidth'),inspectorHeight:panel(o.inspectorHeight,'inspectorHeight')};}
|
|
32
|
-
export function defaultWorkspacePreferences():WorkspacePreferences {return {schema:workspacePreferenceKey,revision:0,theme:'system',defaultCameraSync:true,defaultIdleRepeat:true,settingsCollapsed:true,panels:{...defaultWorkspacePanels},stamps:Object.fromEntries(fields.map(field=>[field,{revision:0,writer:''}])) as Record<Field,FieldStamp>};}
|
|
34
|
+
export function defaultWorkspacePreferences():WorkspacePreferences {return {schema:workspacePreferenceKey,revision:0,theme:'system',language:'system',defaultCameraSync:true,defaultIdleRepeat:true,settingsCollapsed:true,panels:{...defaultWorkspacePanels},stamps:Object.fromEntries(fields.map(field=>[field,{revision:0,writer:''}])) as Record<Field,FieldStamp>};}
|
|
33
35
|
const clone=(v:WorkspacePreferences):WorkspacePreferences=>({...v,panels:{...v.panels},stamps:Object.fromEntries(fields.map(field=>[field,{...v.stamps[field]}])) as Record<Field,FieldStamp>});
|
|
34
|
-
function leaf(value:WorkspacePreferences,field:Field):WorkspaceTheme|boolean|number {return field in panelBounds?value.panels[field as keyof WorkspacePanels]:value[field as 'theme'|Flag];}
|
|
35
|
-
function put(value:WorkspacePreferences,field:Field,v:WorkspaceTheme|boolean|number):void {if(field==='theme')value.theme=theme(v);else if(flags.includes(field as Flag))value[field as Flag]=boolean(v,field);else value.panels[field as keyof WorkspacePanels]=panel(v,field as keyof WorkspacePanels);}
|
|
36
|
+
function leaf(value:WorkspacePreferences,field:Field):WorkspaceTheme|WorkspaceLanguage|boolean|number {return field in panelBounds?value.panels[field as keyof WorkspacePanels]:value[field as 'theme'|'language'|Flag];}
|
|
37
|
+
function put(value:WorkspacePreferences,field:Field,v:WorkspaceTheme|WorkspaceLanguage|boolean|number):void {if(field==='theme')value.theme=theme(v);else if(field==='language')value.language=language(v);else if(flags.includes(field as Flag))value[field as Flag]=boolean(v,field);else value.panels[field as keyof WorkspacePanels]=panel(v,field as keyof WorkspacePanels);}
|
|
36
38
|
export function parseWorkspacePreferences(value:unknown):WorkspacePreferences {
|
|
37
|
-
const o=object(value,'preferences');closed(o,['schema','revision','theme','defaultCameraSync','defaultIdleRepeat','settingsCollapsed','panels','stamps'],'preferences');if(o.schema!==workspacePreferenceKey)throw new Error('PREFERENCES_VERSION: unsupported schema');
|
|
38
|
-
const result=defaultWorkspacePreferences();result.theme=theme(o.theme);result.defaultCameraSync=boolean(o.defaultCameraSync,'defaultCameraSync');result.defaultIdleRepeat=boolean(o.defaultIdleRepeat,'defaultIdleRepeat');if('settingsCollapsed'in o)result.settingsCollapsed=boolean(o.settingsCollapsed,'settingsCollapsed');result.panels=parseWorkspacePanels(o.panels);
|
|
39
|
+
const o=object(value,'preferences');closed(o,['schema','revision','theme','language','defaultCameraSync','defaultIdleRepeat','settingsCollapsed','panels','stamps'],'preferences');if(o.schema!==workspacePreferenceKey)throw new Error('PREFERENCES_VERSION: unsupported schema');
|
|
40
|
+
const result=defaultWorkspacePreferences();result.theme=theme(o.theme);if('language'in o)result.language=language(o.language);result.defaultCameraSync=boolean(o.defaultCameraSync,'defaultCameraSync');result.defaultIdleRepeat=boolean(o.defaultIdleRepeat,'defaultIdleRepeat');if('settingsCollapsed'in o)result.settingsCollapsed=boolean(o.settingsCollapsed,'settingsCollapsed');result.panels=parseWorkspacePanels(o.panels);
|
|
39
41
|
const stamps=object(o.stamps,'stamps');closed(stamps,fields,'stamps');
|
|
40
42
|
for(const field of fields){const stamp=stamps[field]===undefined&&addedFields.has(field)?{revision:0,writer:''}:object(stamps[field],`stamps.${field}`);closed(stamp,['revision','writer'],`stamps.${field}`);if(typeof stamp.revision!=='number'||!Number.isSafeInteger(stamp.revision)||stamp.revision<0||typeof stamp.writer!=='string'||!(/^[A-Za-z0-9_-]{1,80}$/.test(stamp.writer)||stamp.revision===0&&stamp.writer===''))throw new Error(`PREFERENCES_STAMP: invalid ${field} revision/writer`);if(field==='inspectorHeight'&&stamp.revision===0&&stamp.writer===''&&result.panels.inspectorHeight===legacyDefaultInspectorHeight)result.panels.inspectorHeight=defaultWorkspacePanels.inspectorHeight;if(stamp.revision===0&&(stamp.writer!==''||leaf(result,field)!==leaf(defaultWorkspacePreferences(),field)))throw new Error(`PREFERENCES_STAMP: unstamped ${field} differs from defaults`);result.stamps[field]={revision:stamp.revision,writer:stamp.writer};}
|
|
41
43
|
const revision=Math.max(...fields.map(field=>result.stamps[field].revision));if(o.revision!==revision)throw new Error('PREFERENCES_REVISION: record revision must equal maximum field revision');result.revision=revision;return result;
|
|
42
44
|
}
|
|
43
45
|
function parseText(raw:string):WorkspacePreferences {if(raw.length>8192)throw new Error('PREFERENCES_SIZE: record exceeds 8192 characters');return parseWorkspacePreferences(JSON.parse(raw));}
|
|
44
|
-
function patches(value:unknown):Map<Field,WorkspaceTheme|boolean|number> {
|
|
45
|
-
const o=object(value,'preference patch');closed(o,['theme',...flags,'panels'],'preference patch');const patch=new Map<Field,WorkspaceTheme|boolean|number>();
|
|
46
|
-
if('theme'in o)patch.set('theme',theme(o.theme));for(const field of flags)if(field in o)patch.set(field,boolean(o[field],field));
|
|
46
|
+
function patches(value:unknown):Map<Field,WorkspaceTheme|WorkspaceLanguage|boolean|number> {
|
|
47
|
+
const o=object(value,'preference patch');closed(o,['theme','language',...flags,'panels'],'preference patch');const patch=new Map<Field,WorkspaceTheme|WorkspaceLanguage|boolean|number>();
|
|
48
|
+
if('theme'in o)patch.set('theme',theme(o.theme));if('language'in o)patch.set('language',language(o.language));for(const field of flags)if(field in o)patch.set(field,boolean(o[field],field));
|
|
47
49
|
if('panels'in o){const p=object(o.panels,'panel patch');closed(p,Object.keys(panelBounds),'panel patch');for(const key of Object.keys(p) as (keyof WorkspacePanels)[])patch.set(key,panel(p[key],key));}return patch;
|
|
48
50
|
}
|
|
49
51
|
/** Per-field Lamport stamps converge even when independent tabs wrote stale whole records.
|
package/web/workspace-ui.ts
CHANGED
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
/** Browser workspace presentation. Source selection, player clocks and review decisions stay with the page. */
|
|
2
|
-
import {WorkspacePreferenceStore,panelBounds,type WorkspacePanels,type WorkspacePreferences,type WorkspaceTheme} from './workspace-preferences.ts';
|
|
2
|
+
import {WorkspacePreferenceStore,panelBounds,type WorkspaceLanguage,type WorkspacePanels,type WorkspacePreferences,type WorkspaceTheme} from './workspace-preferences.ts';
|
|
3
3
|
import {allocateWorkspaceLayout,bindWorkspaceSeparator,bindWorkspaceDrawer,defaultWorkspaceColumns,InspectorScrollMemory,inspectorTabs,workspaceMinimums,type InspectorTab,type WorkspaceColumns,type WorkspacePanel,type SeparatorRange} from './workspace-layout.ts';
|
|
4
|
+
import {bindDomI18n,setLanguagePreference,tr} from './i18n.ts';
|
|
4
5
|
|
|
5
6
|
/** Reachable effective bounds, accounting for the other panel's saved desired size. */
|
|
6
7
|
export function workspaceResizeRange(available:{width:number;height:number},desired:WorkspacePanels,panel:WorkspacePanel,columns:WorkspaceColumns=defaultWorkspaceColumns):SeparatorRange {
|
|
@@ -43,10 +44,10 @@ export function bindWorkspaceUI(options:{changed:()=>void;defaultTheme:(theme:Wo
|
|
|
43
44
|
const settings=document.createElement('section');settings.className='workspace-settings';settings.setAttribute('aria-label','Settings');
|
|
44
45
|
// The header holds the expand/collapse control; the body is hidden while collapsed (a workspace preference, default collapsed).
|
|
45
46
|
const settingsHeader=document.createElement('h2'),settingsToggle=document.createElement('button'),settingsBody=document.createElement('div');settingsHeader.className='sticky-header settings-header';settingsToggle.type='button';settingsToggle.id='settings-toggle';settingsToggle.className='settings-toggle';settingsToggle.textContent='Settings';settingsToggle.setAttribute('aria-controls','settings-body');settingsBody.id='settings-body';settingsBody.className='settings-body';settingsHeader.append(settingsToggle);settings.append(settingsHeader,settingsBody);
|
|
46
|
-
settingsBody.innerHTML='<label>Theme <select id="settings-theme" data-app-preference><option value="system">System</option><option value="dark">Dark</option><option value="light">Light</option></select></label><label><input id="settings-sync" data-app-preference type="checkbox">Sync cameras by default</label><label><input id="settings-idle" data-app-preference type="checkbox">Repeat idle by default</label><button id="settings-reset" type="button">Reset layout</button><p class="hint">Defaults apply to new inspections. Links and source drafts retain their explicit view.</p><p id="settings-state" class="hint" role="status"></p>';
|
|
47
|
+
settingsBody.innerHTML='<label>Theme <select id="settings-theme" data-app-preference><option value="system">System</option><option value="dark">Dark</option><option value="light">Light</option></select></label><label>Language <select id="settings-language" data-app-preference><option value="system">System</option><option value="en">English</option><option value="ko">한국어</option></select></label><label><input id="settings-sync" data-app-preference type="checkbox">Sync cameras by default</label><label><input id="settings-idle" data-app-preference type="checkbox">Repeat idle by default</label><button id="settings-reset" type="button">Reset layout</button><p class="hint">Defaults apply to new inspections. Links and source drafts retain their explicit view.</p><p id="settings-state" class="hint" role="status"></p>';
|
|
47
48
|
sourceList.append(settings);
|
|
48
|
-
const theme=require<HTMLSelectElement>('settings-theme'),sync=require<HTMLInputElement>('settings-sync'),idle=require<HTMLInputElement>('settings-idle'),status=require('settings-state');
|
|
49
|
-
const store=new WorkspacePreferenceStore({onStatus:value=>{status.textContent=value.detail;}});let desired={...store.get().panels};
|
|
49
|
+
const theme=require<HTMLSelectElement>('settings-theme'),language=require<HTMLSelectElement>('settings-language'),sync=require<HTMLInputElement>('settings-sync'),idle=require<HTMLInputElement>('settings-idle'),status=require('settings-state');
|
|
50
|
+
const store=new WorkspacePreferenceStore({onStatus:value=>{status.textContent=tr(value.detail);}});let desired={...store.get().panels};
|
|
50
51
|
const stack=document.createElement('div');stack.className='workspace-stage-stack';for(const child of [...main.children])if(child!==inspector)stack.append(child);main.prepend(stack);
|
|
51
52
|
const triggers=document.createElement('div');triggers.className='workspace-drawer-triggers';triggers.setAttribute('aria-label','Workspace panels');stack.prepend(triggers);
|
|
52
53
|
const panels:Partial<Record<WorkspacePanel,HTMLElement>>=explorerLeft?{rightWidth:left,inspectorHeight:inspector}:{leftWidth:left,rightWidth:explorer,inspectorHeight:inspector};
|
|
@@ -90,9 +91,9 @@ export function bindWorkspaceUI(options:{changed:()=>void;defaultTheme:(theme:Wo
|
|
|
90
91
|
layout.dataset.stageMinimum=String(effective.stageMinimumSatisfied);for(const binding of bindings)binding.refresh();options.changed();restore();
|
|
91
92
|
}finally{applying=false;}
|
|
92
93
|
}
|
|
93
|
-
const renderSettings=()=>{const value=store.get();settingsToggle.setAttribute('aria-expanded',String(!value.settingsCollapsed));settingsBody.hidden=value.settingsCollapsed;settings.dataset.collapsed=String(value.settingsCollapsed);theme.value=options.currentTheme?.()??value.theme;sync.checked=value.defaultCameraSync;idle.checked=value.defaultIdleRepeat;status.textContent=store.status().detail;};
|
|
94
|
-
theme.onchange=()=>{store.update({theme:theme.value as WorkspaceTheme});options.defaultTheme(store.get().theme);};sync.onchange=()=>{store.update({defaultCameraSync:sync.checked});};idle.onchange=()=>{store.update({defaultIdleRepeat:idle.checked});};require<HTMLButtonElement>('settings-reset').onclick=()=>store.resetLayout();settingsToggle.onclick=()=>{store.update({settingsCollapsed:!store.get().settingsCollapsed});};
|
|
95
|
-
const unsubscribe=store.subscribe(value=>{desired={...value.panels};renderSettings();schedule();});renderSettings();
|
|
94
|
+
const renderSettings=()=>{const value=store.get();setLanguagePreference(value.language);settingsToggle.setAttribute('aria-expanded',String(!value.settingsCollapsed));settingsBody.hidden=value.settingsCollapsed;settings.dataset.collapsed=String(value.settingsCollapsed);theme.value=options.currentTheme?.()??value.theme;language.value=value.language;sync.checked=value.defaultCameraSync;idle.checked=value.defaultIdleRepeat;status.textContent=tr(store.status().detail);};
|
|
95
|
+
theme.onchange=()=>{store.update({theme:theme.value as WorkspaceTheme});options.defaultTheme(store.get().theme);};language.onchange=()=>{store.update({language:language.value as WorkspaceLanguage});setLanguagePreference(store.get().language);};sync.onchange=()=>{store.update({defaultCameraSync:sync.checked});};idle.onchange=()=>{store.update({defaultIdleRepeat:idle.checked});};require<HTMLButtonElement>('settings-reset').onclick=()=>store.resetLayout();settingsToggle.onclick=()=>{store.update({settingsCollapsed:!store.get().settingsCollapsed});};
|
|
96
|
+
bindDomI18n(document);const unsubscribe=store.subscribe(value=>{desired={...value.panels};renderSettings();schedule();});renderSettings();
|
|
96
97
|
for(const tab of tabs){
|
|
97
98
|
const panel=panelFor(tab);let timer:ReturnType<typeof setTimeout>|undefined;
|
|
98
99
|
const intent=()=>{userByTab.set(tab,true);if(timer)clearTimeout(timer);timer=setTimeout(()=>{userByTab.set(tab,false);},600);};const scrolled=()=>{
|