@riddledc/riddle-proof 0.8.6 → 0.8.8

package/runtime/tests/recon_verify_smoke.py

@@ -340,14 +340,18 @@ class FakeRiddle:
                     'largeVisibleElements': [{'tag': 'h1', 'text': 'Proof'}],
                 }
                 proof_evidence = {
-                    'before': {'path': '/'},
-                    'action': 'clicked Proof',
-                    'after': {'path': '/proof/'},
-                    'assertions': {
-                        'startedOnHome': True,
-                        'clickedProofNavigation': True,
-                        'terminalPathIsProof': True,
-                        'proofContentVisible': True,
+                    'proofEvidence': {
+                        'version': 'riddle-proof.interaction.v1',
+                        'start': {'href': 'https://riddledc.com/'},
+                        'action': {'type': 'click', 'target': 'Proof'},
+                        'terminal': {'href': 'https://riddledc.com/proof/'},
+                        'afterUrl': 'https://riddledc.com/proof/',
+                        'assertions': {
+                            'startedOnHome': True,
+                            'clickedProofNavigation': True,
+                            'terminalPathIsProof': True,
+                            'proofContentVisible': True,
+                        },
                     },
                 }
                 return {
@@ -1921,6 +1925,63 @@ def run_author_applies_supervisor_packet():
         shutil.rmtree(tempdir, ignore_errors=True)
 
 
+def run_author_keeps_interaction_start_route():
+    tempdir = Path(tempfile.mkdtemp(prefix='riddle-proof-supervisor-interaction-start-'))
+    state_path = tempdir / 'state.json'
+    try:
+        state = base_state(tempdir, reference='before')
+        state.update({
+            'recon_status': 'ready_for_proof_plan',
+            'verification_mode': 'interaction',
+            'server_path': '/',
+            'expected_start_path': '/',
+            'before_cdn': 'https://cdn.example.com/before-home.png',
+            'recon_results': {
+                'baselines': {'before': {'path': '/', 'url': 'https://cdn.example.com/before-home.png'}},
+                'current_plan': {'target_path': '/'},
+            },
+            'author_request': {
+                'current_plan': {'target_path': '/'},
+                'observed_baselines': {'before': {'path': '/', 'url': 'https://cdn.example.com/before-home.png'}},
+            },
+            'supervisor_author_packet': {
+                'proof_plan': 'Start at /, click Proof, and verify the terminal /proof/ route.',
+                'capture_script': "clickedProofNavigation(); await saveScreenshot('after-proof');",
+                'refined_inputs': {
+                    'server_path': '/proof/',
+                    'expected_terminal_path': '/proof/',
+                    'wait_for_selector': '',
+                    'reference': 'before',
+                },
+                'rationale': ['The interaction starts on home and terminates on Proof.'],
+                'confidence': 'high',
+                'summary': 'Supervisor supplied the interaction proof packet.',
+            },
+        })
+        write_state(state_path, state)
+        os.environ['RIDDLE_PROOF_STATE_FILE'] = str(state_path)
+
+        fake = FakeRiddle()
+        load_util_with_fake(fake)
+        load_module('author_supervisor_interaction_start', AUTHOR_PATH)
+        after_author = json.loads(state_path.read_text())
+
+        assert after_author['author_status'] == 'ready'
+        assert after_author['server_path'] == '/'
+        assert after_author['expected_start_path'] == '/'
+        assert after_author['expected_terminal_path'] == '/proof/'
+        assert after_author['author_packet']['refined_inputs']['server_path'] == '/'
+        assert after_author['author_warnings']
+        assert 'terminal interaction route' in after_author['author_warnings'][0]
+        return {
+            'ok': True,
+            'server_path': after_author['server_path'],
+            'expected_terminal_path': after_author['expected_terminal_path'],
+        }
+    finally:
+        shutil.rmtree(tempdir, ignore_errors=True)
+
+
 def run_verify_requests_supervisor_assessment():
     tempdir = Path(tempfile.mkdtemp(prefix='riddle-proof-verify-supervisor-'))
     state_path = tempdir / 'state.json'
@@ -2530,7 +2591,7 @@ def run_verify_interaction_hash_terminal_route_from_proof_evidence():
         shutil.rmtree(tempdir, ignore_errors=True)
 
 
-def run_verify_interaction_authored_query_hash_mismatch_returns_author():
+def run_verify_interaction_authored_query_hash_mismatch_blocks_with_evidence():
     tempdir = Path(tempfile.mkdtemp(prefix='riddle-proof-interaction-query-hash-mismatch-'))
     state_path = tempdir / 'state.json'
     try:
@@ -2569,17 +2630,24 @@ def run_verify_interaction_authored_query_hash_mismatch_returns_author():
         after_verify = json.loads(state_path.read_text())
 
         request = after_verify['verify_decision_request']
-        capture_quality = request['capture_quality']
-        assert after_verify['verify_status'] == 'capture_incomplete'
+        assert after_verify['verify_status'] == 'evidence_captured'
+        assert after_verify['merge_recommendation'] == 'do-not-merge'
         assert after_verify['route_expectation']['expected_query'] == 'rp_probe=1'
         assert after_verify['route_expectation']['expected_hash'] == '#pricing-probe'
-        assert request['recommended_stage'] == 'author'
-        assert request['continue_with_stage'] == 'author'
-        assert capture_quality['recommended_stage'] == 'author'
-        assert capture_quality['mismatch']['expected_path'] == '/pricing?rp_probe=1#pricing-probe'
-        assert capture_quality['mismatch']['observed_after_path'] == '/pricing/'
-        assert 'page.waitForURL: Timeout 15000ms exceeded' in capture_quality['summary']
-        assert any('capture plan should be revised' in reason for reason in capture_quality['reasons'])
+        assert 'capture_quality' not in request
+        assert request['recommended_stage'] is None
+        assert request['continue_with_stage'] is None
+        assert 'failed assertions' in request['summary']
+        assert 'checks.routeMatches' in request['structured_interaction_failure_summary']
+        assert 'page.waitForURL: Timeout 15000ms exceeded' in request['structured_interaction_failure_summary']
+        assessment_request = after_verify['proof_assessment_request']
+        assert 'structured-interaction-failure' in assessment_request['evidence_basis']
+        assert any('checks.routeMatches' in blocker for blocker in assessment_request['hard_blockers'])
+        assert assessment_request['semantic_context']['route']['expected_terminal_query'] == 'rp_probe=1'
+        assert assessment_request['semantic_context']['route']['expected_terminal_hash'] == '#pricing-probe'
+        assert assessment_request['semantic_context']['route']['after_observed_path'] == '/pricing'
+        assert assessment_request['semantic_context']['route']['after_observed_query'] == ''
+        assert assessment_request['semantic_context']['route']['after_observed_hash'] == ''
         supporting = after_verify['verify_results']['after']['supporting_artifacts']
         assert supporting['proof_evidence_present'] is True
         assert supporting['has_structured_payload'] is True
@@ -2594,7 +2662,7 @@ def run_verify_interaction_authored_query_hash_mismatch_returns_author():
         assert 'page.waitForURL: Timeout 15000ms exceeded' in synthetic_evidence['capture_error']
         return {
             'ok': True,
-            'summary': capture_quality['summary'],
+            'summary': request['summary'],
             'recommended_stage': request['recommended_stage'],
         }
     finally:
@@ -3009,6 +3077,7 @@ if __name__ == '__main__':
         'recon_hint_root_preference': run_recon_prefers_hint_root_over_single_route_literal(),
         'capture_hint_rejects_route_specific_mode_only_match': run_capture_hint_rejects_route_specific_mode_only_match(),
         'author_applies_supervisor_packet': run_author_applies_supervisor_packet(),
+        'author_keeps_interaction_start_route': run_author_keeps_interaction_start_route(),
         'verify_requests_supervisor_assessment': run_verify_requests_supervisor_assessment(),
         'verify_routes_unmeasured_visual_delta_to_recovery': run_verify_routes_unmeasured_visual_delta_to_recovery(),
         'verify_structured_evidence_without_screenshot': run_verify_structured_evidence_without_screenshot(),
@@ -3020,7 +3089,7 @@ if __name__ == '__main__':
         'verify_interaction_terminal_route_from_proof_evidence': run_verify_interaction_terminal_route_from_proof_evidence(),
         'verify_interaction_reverse_terminal_route_from_proof_evidence': run_verify_interaction_reverse_terminal_route_from_proof_evidence(),
         'verify_interaction_hash_terminal_route_from_proof_evidence': run_verify_interaction_hash_terminal_route_from_proof_evidence(),
-        'verify_interaction_authored_query_hash_mismatch_returns_author': run_verify_interaction_authored_query_hash_mismatch_returns_author(),
+        'verify_interaction_authored_query_hash_mismatch_blocks_with_evidence': run_verify_interaction_authored_query_hash_mismatch_blocks_with_evidence(),
         'verify_capture_retry_surfaces_script_timeout': run_verify_capture_retry_surfaces_script_timeout(),
         'missing_baseline_guard': run_verify_missing_baseline(),
         'ship_supervisor_gate': run_ship_missing_supervisor_gate(),